On Wed, 21 May 2025 20:05:08 GMT, Hannes Wallnöfer wrote:
>> Please review a change to add the missing license file for
>> [Highlight.js](https://github.com/highlightjs/highlight.js) required for the
>> `--syntax-highlight` option. This also updates the tests for legal files and
>> library ver
On Mon, 9 Dec 2024 21:05:30 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote:
> Please review this PR which contains the open L10n drop changes for RDP1.
>
> I recommend viewing the improved diffs which are built out by Jon's tool
> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the
> correctnes
On Tue, 10 Dec 2024 00:05:45 GMT, Henry Jen wrote:
>> Oh you're right. That's odd though. But the translations aren't wrong then.
>
> `每个 是\n限定的程序包名称.`
> We use here, but the args format is using Chinese translation,`=
> [-]<程序包>(,[-]<程序包>)*`
>
> Should that be consistent?
Regarding `''` - p
On Mon, 18 Nov 2024 06:38:48 GMT, Jan Lahoda wrote:
> A test ensuring the JDK build is reproducible is failing due to the recent
> https://github.com/openjdk/jdk/commit/81342acdae82262815e04e1ade7deb2d0f24094a
> . The reason is the unordered map used when filtering `java.base` o
A test ensuring the JDK build is reproducible is failing due to the recent
https://github.com/openjdk/jdk/commit/81342acdae82262815e04e1ade7deb2d0f24094a
. The reason is the unordered map used when filtering `java.base` out of the
list of dependencies.
This patch is resolving that, by moving th
On Thu, 7 Nov 2024 12:03:18 GMT, Jan Lahoda wrote:
> When https://github.com/openjdk/jdk/pull/21431 is integrated, there will be a
> new preview language feature: `requires transitive java.base;`. It would be
> good to show a warning box in the javadoc about the use of the feature. T
On Fri, 8 Nov 2024 17:32:08 GMT, Hannes Wallnöfer wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Using instead of , as suggested.
>
> src/jdk.javadoc/share/classes/jdk/javadoc
nd the then section,
> keeping the else section + some slight cleanup.
>
> The new javadoc can be seen here:
> https://cr.openjdk.org/~jlahoda/8343752/updated/api/java.se/module-summary.html#preview-requires-transitive-java.base
Jan Lahoda has updated the pull request incrementally with
nd the then section,
> keeping the else section + some slight cleanup.
>
> The new javadoc can be seen here:
> https://cr.openjdk.org/~jlahoda/8343752/updated/api/java.se/module-summary.html#preview-requires-transitive-java.base
Jan Lahoda has updated the pull request incrementally with
nd the then section,
> keeping the else section + some slight cleanup.
>
> The new javadoc can be seen here:
> https://cr.openjdk.org/~jlahoda/8343752/updated/api/java.se/module-summary.html#preview-requires-transitive-java.base
Jan Lahoda has updated the pull request with a n
When https://github.com/openjdk/jdk/pull/21431 is integrated, there will be a
new preview language feature: `requires transitive java.base;`. It would be
good to show a warning box in the javadoc about the use of the feature. This PR
is attempting to add such a warning box.
Given it is likely t
On Fri, 2 Feb 2024 14:02:28 GMT, Jan Lahoda wrote:
> This is an attempt to add Markdown support in documentation comments to
> JShell.
>
> It works by converting the Markdown text to HTML during the process of
> resolving `{@inheritDoc}` tags.
This pull request has now
> This is an attempt to add Markdown support in documentation comments to
> JShell.
>
> It works by converting the Markdown text to HTML during the process of
> resolving `{@inheritDoc}` tags.
Jan Lahoda has updated the pull request incrementally with one additional
commit
> This is an attempt to add Markdown support in documentation comments to
> JShell.
>
> It works by converting the Markdown text to HTML during the process of
> resolving `{@inheritDoc}` tags.
Jan Lahoda has updated the pull request with a new target base due to a merge
or a r
On Fri, 24 May 2024 09:05:20 GMT, Jan Lahoda wrote:
> If the javadoc comment contains a (Markdown) link like:
>
> [java.util.Arrays#asList(Object[])]
>
>
> The transformer that converts this link into the Javadoc link will not find
> the reference, as it is looking
ssing escapes), which is not present in the original text.
>
> This patch tries to fix that by permitting optional escapes for all escapable
> character when searching for the reference, in case the literal search fails.
> This is done using regexp, although could presumably be done u
On Sat, 25 May 2024 11:06:51 GMT, Vicente Romero wrote:
>> If the javadoc comment contains a (Markdown) link like:
>>
>> [java.util.Arrays#asList(Object[])]
>>
>>
>> The transformer that converts this link into the Javadoc link will not find
>> the reference, as it is looking for `java.util.A
> This is an attempt to add Markdown support in documentation comments to
> JShell.
>
> It works by converting the Markdown text to HTML during the process of
> resolving `{@inheritDoc}` tags.
Jan Lahoda has updated the pull request with a new target base due to a merge
or a r
If the javadoc comment contains a (Markdown) link like:
[java.util.Arrays#asList(Object[])]
The transformer that converts this link into the Javadoc link will not find the
reference, as it is looking for `java.util.Arrays#asList(Object[])` (note the
missing escapes), which is not present in th
> This is an attempt to add Markdown support in documentation comments to
> JShell.
>
> It works by converting the Markdown text to HTML during the process of
> resolving `{@inheritDoc}` tags.
Jan Lahoda has updated the pull request with a new target base due to a merge
or a r
> This is an attempt to add Markdown support in documentation comments to
> JShell.
>
> It works by converting the Markdown text to HTML during the process of
> resolving `{@inheritDoc}` tags.
Jan Lahoda has updated the pull request with a new target base due to a merge
or a r
On Fri, 29 Mar 2024 01:17:42 GMT, Vicente Romero wrote:
> Please review this simple fix, basically javadoc is showing the `sealed`
> modifier for methods annotated with the `jdk.internal.javac.Restricted`
> annotation. This is because the `SEALED` and `RESTRICTED` flags share the
> same bit. T
On Fri, 2 Feb 2024 14:02:28 GMT, Jan Lahoda wrote:
> This is an attempt to add Markdown support in documentation comments to
> JShell.
>
> It works by converting the Markdown text to HTML during the process of
> resolving `{@inheritDoc}` tags.
Thanks for the comments! I
This is an attempt to add Markdown support in documentation comments to JShell.
It works by converting the Markdown text to HTML during the process of
resolving `{@inheritDoc}` tags.
-
Depends on: https://git.openjdk.org/jdk/pull/16388
Commit messages:
- Cleanup.
- Preventing a N
On Tue, 6 Feb 2024 01:36:58 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module `jd
On Mon, 8 Jan 2024 13:23:02 GMT, Thomas Schatzl wrote:
> Hi all,
>
> please review this small fix to increase max heap size for the test to let
> it pass with GenZGC and Parallel GC as well.
>
> The test has at least 660m of live data, so the default 768m provided by
> testng is too small f
On Tue, 12 Dec 2023 12:42:41 GMT, Hannes Wallnöfer wrote:
>> Please review a simple fix in `JavacTrees` to only look up member references
>> in the enclosing type if the reference does not contain an explicit type
>> name. For example, `@see #method()` in a a doc comment of class
>> `Outer.Inn
On Wed, 29 Nov 2023 14:30:50 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - S
On Thu, 23 Nov 2023 10:17:39 GMT, Pavel Rappo wrote:
> jdk.javadoc.internal.doclint.Checker should favour the official
> javax.lang.model.util.Elements.getOrigin API over implementation-specific
> source tree positioning, to detect the default constructor.
Looks good to me.
-
Mar
On Fri, 3 Nov 2023 12:40:48 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - Si
On Thu, 2 Nov 2023 11:55:50 GMT, Jim Laskey wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java line 249:
>>
>>> 247: STRING_TEMPLATES(JDK21, Fragments.FeatureStringTemplates,
>>> DiagKind.PLURAL),
>>> 248: UNNAMED_CLASSES(JDK21, Fragments.FeatureUnname
On Thu, 2 Nov 2023 14:52:46 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 76:
>>
>>> 74: UNNAMED_CLASSES,
>>> 75: @JEP(number=999, title="Implicit Classes and Instance Main
>>> Methods")
>>> 76: IMPLICIT_CLASSES,
>>
>>
On Thu, 2 Nov 2023 16:19:07 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - Si
efs; d.nonEmpty(); d = d.tail) {
> +if (d.head.hasTag(MODULEDEF))
> +return (JCModuleDecl) d.head;
> }
> return null;
> }
>
>
> However, Jan Lahoda (@lahodaj) told me that `JCCompilationUnit` already
> provides thi
On Fri, 6 Oct 2023 23:39:27 GMT, Jonathan Gibbons wrote:
> Please review a simple cleanup to eliminate an unused parameter and rename
> the enclosing method.
>
> No new tests; bug is primarily `noreg-cleanup`. Two tests were affected by
> the change, but are not in themselves tests for the cha
On Wed, 11 Jan 2023 07:17:09 GMT, Jan Lahoda wrote:
> Adding support for MarkDown javadoc in the JShell
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/11936
> Adding support for MarkDown javadoc in the JShell
Jan Lahoda has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains eight additional commits since
the l
Adding support for MarkDown javadoc in the JShell
-
Depends on: https://git.openjdk.org/jdk/pull/11701
Commit messages:
- Cleanup.
- Post-merge updates.
- Merge branch '8298405.doclet-markdown' into markdown-in-jshell
- Improving handling of new trees.
- Prototype of MarkDown ja
39 matches
Mail list logo
