On Tue, 13 Feb 2024 06:23:03 GMT, psoujany wrote:
> The scrollable element `` with non-interactive content is not tabbable.
> Grid columns in the javadoc stylesheet has overflow: auto, which is failing
> Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690
This pull request has
On Mon, 26 Aug 2024 12:01:42 GMT, Nizar Benalla wrote:
>> Could I please get a review for this small clenup? I updated the `--help`
>> command output to match that of `man javadoc`.
>>
>> I also noticed that `--help-extended` was renamed to `--help-extra` at some
>> point but doc-comment was
On Mon, 13 May 2024 23:08:51 GMT, Jonathan Gibbons wrote:
> Please review a relatively simple update to the generated Help page, as part
> of the ongoing campaign to improve the documentation around the overall use
> of `@since` tags.
This pull request has been closed without being integrated.
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change, the relative link to the
> stylesheet isn't needed as it wasn't used anyway in the generated HTML. The
> correct link to the stylesheet is already in the generated HTML.
>
> This is the di
On Mon, 11 Mar 2024 13:57:23 GMT, Chen Liang wrote:
>> Please review this patch that fixes the issue where type annotations on
>> primitive types are not linked.
>>
>> Tested with file
>> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>>
>> import java.lang.annotation.*;
>>
>
On Fri, 23 Feb 2024 05:44:08 GMT, Chen Liang wrote:
>> Currently in the javadoc tool, the generated class use page does not track
>> the occurrences of a class in the type arguments of the extends or
>> implements list, where they can appear. (See more details on the JBS issue)
>> For example:
On Tue, 12 Mar 2024 22:06:35 GMT, Chen Liang wrote:
>> Please review this patch that fixes placement of type annotations on array
>> types in Javadoc output. This oversight seems to have existed since JDK 8
>> but was never noticed or reported.
>
> Chen Liang has updated the pull request with a
On Sun, 12 May 2024 08:36:44 GMT, Chen Liang wrote:
> Some tests are not migrated to the ClassFile API in previous migrations.
>
> - Some are simple oversights that didn't remove usages of
> com.sun.tools.classfile;
> - The CallerSensitive ones used an old utility, replaced by CF API-based ne
On Wed, 3 Jul 2024 14:17:14 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change? It removes some lines that
> are no longer necessary and sets the ARIA role as global.
> Thanks in advance.
@nizarbenalla
Your change (at version 94c1ca8429fee2da0a9b2da1ce208bed371c2e0d) i
On Fri, 14 Jul 2023 15:57:03 GMT, Jim Laskey wrote:
> Update javadoc man page to indicate unnamed classes are supported.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/14891
On Tue, 30 May 2023 14:07:05 GMT, Pavel Rappo wrote:
> Please review this change.
>
> It turns out that JavaDoc's model for overriding and inheritance for methods
> is simplistic. As a result, it fails to accommodate upcoming changes in the
> "method comments algorithm" and the new feature cal
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote:
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
>
On Tue, 11 Apr 2023 18:13:14 GMT, Jonathan Gibbons wrote:
> Please review a cleanup in DocCommentParser to merge blockContent and
> inlineContent into a single method to parse "rich content" in a doc comment.
>
> **Note:** This is dependent on PR #13362, to convert `DocCommentParser` to
> use
On Fri, 2 Dec 2022 16:36:22 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
> surprisingly) ac
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Thu, 30 Jun 2022 15:14:40 GMT, Hannes Wallnöfer wrote:
> Please review an enhancement to the preview page to add a list of preview
> features and allow users to explore the preview APIs by feature.
>
> While the changes for the enhancement itself are not overly complex, the work
> entailed
16 matches
Mail list logo
