Re: [7u4] Request for approval for CR 7115524 - Regression: keytool -printcert -sslserver failure

2011-12-01 Thread Edvard Wendelin
Approved. Cheers, Edvard On Dec 2, 2011, at 3:30 AM, Weijun Wang wrote: > Hi, > > This is a request to backport a JDK 8 fix into JDK 7u4: > >7115524: Regression: keytool -printcert -sslserver failure >http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7115524 > > The fix for JDK 8 is:

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread Henri Gomez
>> Where is the Mercurial URL for jdk7u-osx ? > > > Same place as all the other repos :) > > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/ Nice, I'll try to build this one also :) Cheers

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread David Holmes
On 2/12/2011 4:56 PM, Henri Gomez wrote: Where is the Mercurial URL for jdk7u-osx ? Same place as all the other repos :) http://hg.openjdk.java.net/jdk7u/jdk7u-osx/ David 2011/12/2 David Holmes: On 2/12/2011 11:30 AM, Paul Hohensee wrote: I agree. Be a good idea to ask for review from

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread Henri Gomez
Where is the Mercurial URL for jdk7u-osx ? 2011/12/2 David Holmes : > > > > On 2/12/2011 11:30 AM, Paul Hohensee wrote: >> >> I agree. Be a good idea to ask for review from all the affected teams. >> I _think_ core libs is the only one we missed, though. > > > My concern is that there are a numbe

Re: [7u4] Request for approval for 7113349 - Initial changeset for Macosx port to jdk7u (jdk7u-osx)

2011-12-01 Thread Michael McMahon
Max, I re-synched with jdk7u-dev before generating the webrev. - Michael. On 02/12/11 02:23, Weijun Wang wrote: I tried to apply the patches to my jdk7u-osx repo, but found two conflicts: make/java/java/Makefile src/solaris/native/java/util/TimeZone_md.c Thanks Max On 12/02/2011 07:16 AM,

Re: [7u4] Request for approval for 7113349 - Initial changeset for Macosx port to jdk7u (jdk7u-osx)

2011-12-01 Thread Weijun Wang
One more. 7116189: Export JVM_SetNativeThreadName from Hotspot http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/242b4e0e6f73 should be included in the hotspot repo. -Max On 12/02/2011 12:03 PM, Weijun Wang wrote: Another thing. I'm trying to build on my Mac and it failed saying Canno

Re: [7u4] Request for approval for 7113349 - Initial changeset for Macosx port to jdk7u (jdk7u-osx)

2011-12-01 Thread Weijun Wang
Another thing. I'm trying to build on my Mac and it failed saying Cannot run program "./run-and-write-if-okay": error=13, Permission denied There is no Entering/Leaving words so I don't know at which stage the build failed. Anyway, the file is inside jdk/src/macosx/native/jobjc. I gues

[7u4] Request for approval for CR 7115524 - Regression: keytool -printcert -sslserver failure

2011-12-01 Thread Weijun Wang
Hi, This is a request to backport a JDK 8 fix into JDK 7u4: 7115524: Regression: keytool -printcert -sslserver failure http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7115524 The fix for JDK 8 is: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1928ae4e0a2 Due to a recent refactori

Re: [7u4] Request for approval for 7113349 - Initial changeset for Macosx port to jdk7u (jdk7u-osx)

2011-12-01 Thread Weijun Wang
I tried to apply the patches to my jdk7u-osx repo, but found two conflicts: make/java/java/Makefile src/solaris/native/java/util/TimeZone_md.c Thanks Max On 12/02/2011 07:16 AM, Michael McMahon wrote: Hi, This is a request to push the Macosx port of jdk into the jdk7u-osx forest, for 7u4. W

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread David Holmes
On 2/12/2011 11:30 AM, Paul Hohensee wrote: I agree. Be a good idea to ask for review from all the affected teams. I _think_ core libs is the only one we missed, though. My concern is that there are a number of platform specific changes being made to java.* and javax.* classes (there are cha

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread Paul Hohensee
I agree. Be a good idea to ask for review from all the affected teams. I _think_ core libs is the only one we missed, though. Paul On 12/1/11 8:07 PM, David Holmes wrote: On 2/12/2011 7:38 AM, Dalibor Topic wrote: On 12/1/11 6:12 PM, Michael McMahon wrote: Kelly, Yes, that is correct. This p

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread David Holmes
On 2/12/2011 7:38 AM, Dalibor Topic wrote: On 12/1/11 6:12 PM, Michael McMahon wrote: Kelly, Yes, that is correct. This push is initially just for jdk7u-osx, which is a development forest. I'm not sure exactly what the procedure will be yet for the push into jdk7u-dev. There is no special pro

[7u4] Request for approval for 7113349 - Initial changeset for Macosx port to jdk7u (jdk7u-osx)

2011-12-01 Thread Michael McMahon
Hi, This is a request to push the Macosx port of jdk into the jdk7u-osx forest, for 7u4. Webrevs are located at: (jdk modified files) http://cr.openjdk.java.net/~michaelm/7113349/4/jdk7u-osx/modified/ (jdk new files) http://cr.openjdk.java.net/~michaelm/7113349/4/jdk7u-osx/new/ (corba new a

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread Dalibor Topic
On 12/1/11 6:12 PM, Michael McMahon wrote: > Kelly, > > Yes, that is correct. This push is initially just for jdk7u-osx, which > is a development forest. I'm not sure exactly what the procedure will be yet > for the push into jdk7u-dev. There is no special procedure for pushing into jdk7u-osx tha

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread Dalibor Topic
On 12/1/11 5:07 PM, Kelly O'Hair wrote: > I haven't been watching the rules closely, but doesn't someone have to get > some kind of jdk7 update > approval before pushing anything into jdk7u-dev? > And if so, would someone be doing some kind of one big approval for a massive > integration from > j