Re: Need reviewer - jdk7u-osx Mac sanity check fixes

2011-12-19 Thread Henri Gomez
> The JDK should be buildable under both llvm-gcc (which it currently uses) and > clang, which is the future, since llvm-gcc is now in maintenance mode. > > If you are restricting your builders to Mac OS X 10.7 now, you can actually > cut over to using clang soon, since it has no known bugs compi

Re: Need reviewer - jdk7u-osx Mac sanity check fixes

2011-12-19 Thread Kelly O'Hair
On Dec 19, 2011, at 5:46 PM, Mike Swingler wrote: > It would be worth filing a bug into JDK8 to start compiling the Mac OS X port > with clang from the start, so you'll be able to use a supported compiler > baseline for the projected timeframe when JDK8 will be productized. I'll file an RFE, c

Re: Need reviewer - jdk7u-osx Mac sanity check fixes

2011-12-19 Thread Mike Swingler
On Dec 19, 2011, at 4:38 PM, Kelly O'Hair wrote: > On Dec 19, 2011, at 4:11 PM, Mike Swingler wrote: > >> On Dec 19, 2011, at 3:33 PM, Kelly O'Hair wrote: >> >>> >>> Need reviewer for some sanity check fixes for jdk7u-osx (Mac) >>> >>> 7123022: Fixing some Mac sanity checks >>> http://cr.openj

Re: Need reviewer - jdk7u-osx Mac sanity check fixes

2011-12-19 Thread Kelly O'Hair
On Dec 19, 2011, at 4:11 PM, Mike Swingler wrote: > On Dec 19, 2011, at 3:33 PM, Kelly O'Hair wrote: > >> >> Need reviewer for some sanity check fixes for jdk7u-osx (Mac) >> >> 7123022: Fixing some Mac sanity checks >> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7u-osx-jdk-sanity/webrev/ >

Re: Need reviewer - jdk7u-osx Mac sanity check fixes

2011-12-19 Thread Mike Swingler
On Dec 19, 2011, at 3:33 PM, Kelly O'Hair wrote: > > Need reviewer for some sanity check fixes for jdk7u-osx (Mac) > > 7123022: Fixing some Mac sanity checks > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7u-osx-jdk-sanity/webrev/ Looks good to me, except: + REQUIRED_COMPILER_NAME = GCC4

Need reviewer - jdk7u-osx Mac sanity check fixes

2011-12-19 Thread Kelly O'Hair
Need reviewer for some sanity check fixes for jdk7u-osx (Mac) 7123022: Fixing some Mac sanity checks http://cr.openjdk.java.net/~ohair/openjdk7/jdk7u-osx-jdk-sanity/webrev/ -kto

Re: JDK7 Mac OS X Port integration into 7 updates

2011-12-19 Thread Artem Ananiev
Here are some updates: 1. The macosx-port workspace is frozen (read-only). 2. Alexander Zuev (OpenJKD user name: kizune) is preparing the final patch to make 7u-osx up-to-date with what we have in macosx-port. The patch will be sent for technical review to the macosx-port-dev alias. 3. Late

Re: Request for approval : CR# 7078816 - /test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failure

2011-12-19 Thread Edvard Wendelin
Approved. On 12/19/2011 04:50 AM, Mala Bankal wrote: HI , Request approval for CR# 7078816 - /test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failure for 7u4 b01. Webrev includes changes to test SecretKeysBasic.sh which has been failing at QE end. Changes include removing hardcoded Ja