Re: [7u-dev] Request for Approval and Review: 8056156: [TEST_BUG] Test javax/swing/JFileChooser/8046391/bug8046391.java fails in Windows

2014-08-28 Thread Anthony Petrov
Hi Alexey, The fix looks fine. -- best regards, Anthony On 8/28/2014 11:29 AM, Alexey Ivanov wrote: Hello, Could you please approve the fix of the test in jdk7u-dev? Could you please review the fix? webrev: http://cr.openjdk.java.net/~aivanov/8056156/jdk7/webrev.00/ JBS: https://bugs.

Re: [7u-dev] Request for approval for JDK-8043610: Sorting columns in JFileChooser fails with AppContext NPE

2014-08-20 Thread Anthony Petrov
Looks fine. +1 -- best regards, Anthony On 8/20/2014 5:35 PM, Alexey Ivanov wrote: Hello, Please approve the backport of the fix to jdk7u-dev. I replaced lambda expressions and method reference with anonymous classes: webrev: http://cr.openjdk.java.net/~aivanov/8043610/jdk7/webrev.00/

Re: CFV: New JDK7u Committer: Anton Nashatyrev

2014-08-05 Thread Anthony Petrov
Vote: YES -- best regards, Anthony On 8/5/2014 6:06 PM, Alexander Potochkin wrote: I hereby nominate Anton Nashatyrev to jdk7u Committer. Anton is a member of the Java SE sustaining team. He has spent most of that time working on the GUI and deployment issues. He has contributed 16 changes to

Re: CFV: New JDK7u Committer: Mikhail Cherkasov

2014-07-15 Thread Anthony Petrov
Vote: YES -- best regards, Anthony On 7/15/2014 8:11 PM, Alexander Potochkin wrote: I hereby nominate Mikhail Cherkasov to jdk7u Committer. Mikhail has been a member of the Java SE sustaining team for more than two years now and already made enough contributions to get the committer status for

Re: CFV: New JDK7u Committer: Dmitry Markov

2014-04-01 Thread Anthony Petrov
Vote: YES -- best regards, Anthony On 4/1/2014 7:11 PM, Alexander Potochkin wrote: I hereby nominate Dmitry Markov to jdk7u Committer. Dmitry is a member of the Java SE sustaining team. He has spent most of that time working on the GUI and deployment issues. He has contributed 10 changes to j

Re: CFV: New JDK7u Committer: Petr Pchelko

2013-11-14 Thread Anthony Petrov
Vote: YES -- best regards, Anthony On 11/14/2013 02:33 PM, Artem Ananiev wrote: I hereby nominate Petr Pchelko (OpenJDK user name: pchelko) to JDK7u Committer. Petr has a Committer role in JDK8 and OpenJFX projects. Many of his fixes are backported to JDK7u as well, here is the incomplete lis

Re: CFV: New JDK7u Committer: Mikhail Cherkasov

2013-10-10 Thread Anthony Petrov
Vote: YES -- best regards, Anthony On 10/10/2013 08:20 PM, Alexander Potochkin wrote: I hereby nominate Mikhail Cherkasov to jdk7u Committer. Mikhail has been a member of the Java SE sustaining team for more than a year now and already made enough contributions to get the committer status for

Re: CFV: New JDK7u Committer: Mikhail Cherkasov

2013-09-16 Thread Anthony Petrov
Vote: YES -- best regards, Anthony On 09/13/13 21:02, Alexander Potochkin wrote: I hereby nominate Mikhail Cherkasov to jdk7u Committer. Mikhail has been a member of the Java SE sustaining team for more than a year now and already made enough contributions to get the committer status for the J

Re: CFV: New JDK7u Committer: Petr Pchelko

2013-08-12 Thread Anthony Petrov
Vote: YES -- best regards, Anthony On 08/06/2013 06:13 PM, Artem Ananiev wrote: I hereby nominate Petr Pchelko (OpenJDK user name: pchelko) to JDK7u Committer. Petr is a JDK8 Committer and an active contributor to AWT, Swing, and OpenJFX. Here is the list of his changesets in 7u: http://hg.o

Re: CFV: New JDK7u Committer: Anton Litvinov

2013-07-17 Thread Anthony Petrov
Vote: YES -- best regards, Anthony On 07/17/2013 05:58 PM, Alexander Potochkin wrote: I hereby nominate Anton Litvinov to jdk7u Committer. Anton has been a member of the Java SE sustaining team for more then a year. He has spent most of that time working on client issues. He has contributed s

hg: jdk7u/jdk7u-dev/jdk: 7181710: [macosx] jawt_md.h shipped with jdk is outdated

2013-06-07 Thread anthony . petrov
Changeset: fa856e37c8ef Author:ddehaven Date: 2013-06-07 14:56 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/fa856e37c8ef 7181710: [macosx] jawt_md.h shipped with jdk is outdated Reviewed-by: anthony, art ! make/common/Defs.gmk ! make/sun/jawt/Makefile + src/macosx/

Re: RFR: JDK-7181710: [macosx] jawt_md.h shipped with jdk is outdated

2013-06-06 Thread Anthony Petrov
Mac, since we're going to remove XAWT support on that platform in JDK8 anyway. Thanks, Artem On 6/6/2013 4:40 PM, Anthony Petrov wrote: I've already reviewed this fix, and it looks fine to me. We still need another reviewer. Adding awt-dev@. Anyone please? -- best regards, Anthony O

Re: RFR: JDK-7181710: [macosx] jawt_md.h shipped with jdk is outdated

2013-06-06 Thread Anthony Petrov
hanged several #include statements to use the JDK headers instead of the deprecated JavaVM framework headers. Since I'm not a jdk7u-dev committer, Anthony Petrov has graciously agreed to sponsor this patch. I will be kicking off a JPRT run when I can steal another couple minutes, and figure out th

hg: jdk7u/jdk7u-dev/jdk: 8015303: [macosx] Application launched via custom URL Scheme does not receive URL

2013-06-03 Thread anthony . petrov
Changeset: 75119057b941 Author:anthony Date: 2013-06-03 16:53 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/75119057b941 8015303: [macosx] Application launched via custom URL Scheme does not receive URL Summary: Make copies of event parameters Reviewed-by: anthony,

Re: [7u] Review Request for JDK-8006634 Unify LWCToolkit.invokeAndWait() and sun.awt.datatransfer.ToolkitThreadBlockedHandler

2013-05-06 Thread Anthony Petrov
thrown with locked handler.(SunDropTargetContextPeer.postDropTargetEvent()). - The same approach is used on windows too. (WToolkitThreadBlockedHandler.enter()) - It would be good to have straightforward backports, when possible. On 30.04.2013 17:02, Anthony Petrov wrote: Hi Petr, src/macosx/classes

Re: [7u] Review Request for JDK-8006634 Unify LWCToolkit.invokeAndWait() and sun.awt.datatransfer.ToolkitThreadBlockedHandler

2013-04-30 Thread Anthony Petrov
Hi Petr, src/macosx/classes/sun/lwawt/macosx/CToolkitThreadBlockedHandler.java 45 unlock(); 46 LWCToolkit.doAWTRunLoop(awtRunLoopMediator, processEvents); 47 lock(); I suggest to use the try/finally pattern for the unlock()/lock() calls here to ensure the method

Re: CFV: New JDK7u Committer: Vladislav Karnaukhov

2013-04-01 Thread Anthony Petrov
Vote: YES -- best regards, Anthony On 3/29/2013 20:44, Alexander potochkin wrote: I hereby nominate Vladislav Karnaukhov to jdk7u Committer. Vlad has been a member of the Java SE sustaining team for five years. He has spent most of that time working on customer escalations. He has contribut

Re: CFV: New JDK7u Committer: Konstantin Shefov

2013-03-27 Thread Anthony Petrov
Vote: YES -- best regards, Anthony On 3/27/2013 14:30, Artem Ananiev wrote: I hereby nominate Konstantin Shefov to JDK7u Committer. Konstantin is currently JDK8 Committer, and many of his fixes are backported to JDK7u as well: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/log?rev=kshefov

hg: jdk7u/jdk7u-dev/jdk: 8005465: [macosx] Evaluate if checking for the -XstartOnFirstThread is still needed in awt.m

2013-01-18 Thread anthony . petrov
Changeset: 38fa2ac0dec9 Author:anthony Date: 2013-01-18 14:53 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/38fa2ac0dec9 8005465: [macosx] Evaluate if checking for the -XstartOnFirstThread is still needed in awt.m Summary: Allow one to start AWT on the main thread w

[7u14] Request for approval for CR 8005465: [macosx] Evaluate if checking for the -XstartOnFirstThread is still needed in awt.m

2013-01-18 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=8005465 Webrev: http://cr.openjdk.java.net/~anthony/8-53-startOnFirstThreadCheck-minimal-8005465.0/ Review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2013-January/004088.html Reviewers: Artem Ananiev, Sergey Bylokhov JDK8 changeset: h

hg: jdk7u/jdk7u-dev/jdk: 6789984: JPasswordField can not receive keyboard input

2012-11-27 Thread anthony . petrov
Changeset: 580e399d49a5 Author:alitvinov Date: 2012-11-27 16:11 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/580e399d49a5 6789984: JPasswordField can not receive keyboard input Reviewed-by: naoto, anthony ! src/share/classes/sun/awt/im/InputContext.java ! src/share

Re: New to forum - how do I track code changes

2012-11-07 Thread Anthony Petrov
You can clone a repository and issue $ hg log -k where is the bug number (e.g. 7193966). You can also try using your favorite search engine and enter a query like this: site:hg.openjdk.java.net This should provide you with a list of changesets that mention the . -- best regards, Anthony

Re: Cannot build jdk7u-dev

2012-11-07 Thread Anthony Petrov
Romanov wrote: Would be k if I just push missing file without sending a review? I forgot to do "hg add" on it when committing the fix into my local repo. On Nov 7, 2012, at 5:43 PM, Anthony Petrov wrote: I just filed 8002362. Leonid, please take a look asap. -- best regards, Antho

Re: Cannot build jdk7u-dev

2012-11-07 Thread Anthony Petrov
a review? I forgot to do "hg add" on it when committing the fix into my local repo. On Nov 7, 2012, at 5:43 PM, Anthony Petrov wrote: I just filed 8002362. Leonid, please take a look asap. -- best regards, Anthony On 11/7/2012 4:44 PM, Seán Coffey wrote: This is related to the 7

Re: Cannot build jdk7u-dev

2012-11-07 Thread Anthony Petrov
fix asap ? All code changes need to be build and tested before pushing. Regards, Sean. On 07/11/2012 12:07, Anthony Petrov wrote: (bcc'ing core-libs-dev@) Looks like this is related to 6981400. I'm CC'ing Anton to take a look at it. -- best regards, Anthony On 11/7/2012

hg: jdk7u/jdk7u-dev/jdk: 7200762: [macosx] Stuck in sun.java2d.opengl.CGLGraphicsConfig.getMaxTextureSize(Native Method)

2012-10-05 Thread anthony . petrov
Changeset: 8fab77c17bfb Author:anthony Date: 2012-10-05 14:58 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/8fab77c17bfb 7200762: [macosx] Stuck in sun.java2d.opengl.CGLGraphicsConfig.getMaxTextureSize(Native Method) Summary: Cache the GL max texture size to avoid c

[7u12] Request for approval for CR 7200762: [macosx] Stuck in sun.java2d.opengl.CGLGraphicsConfig.getMaxTextureSize(Native Method)

2012-10-05 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7200762 Webrev: http://cr.openjdk.java.net/~anthony/7u10-1-getMaxTextureSizeDeadlock-7200762.0/ Review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2012-September/003601.html Reviewers: Artem Ananiev, Andrew Brygin This is a new fix for

Re: OpenJDK 7u and Fedora 17

2012-08-29 Thread Anthony Petrov
++-static.i686 : Static libraries for the GNU standard C++ library libstdc++-static.x86_64 : Static libraries for the GNU standard C++ library I'll try with libstdc++-static Stay tuned 2012/8/29 Anthony Petrov : Make sure you have the static version of stdc++ installed. E.g. on my Mandriva I'

Re: OpenJDK 7u and Fedora 17

2012-08-29 Thread Anthony Petrov
Make sure you have the static version of stdc++ installed. E.g. on my Mandriva I've got the following packages installed: $ rpm -qa | grep stdc libstdc++-static-devel-4.4.3-2mnb2 libstdc++6-4.4.3-2mnb2 libstdc++-devel-4.4.3-2mnb2 libstdc++5-3.3.6-4mdv2009.0 It is the "static-devel" package that

hg: jdk7u/jdk7u-dev/jdk: 7160609: [macosx] JDK crash in libjvm.dylib ( C [GeForceGLDriver+0x675a] gldAttachDrawable+0x941)

2012-08-24 Thread anthony . petrov
Changeset: 3898abcc7c28 Author:anthony Date: 2012-08-24 16:40 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3898abcc7c28 7160609: [macosx] JDK crash in libjvm.dylib ( C [GeForceGLDriver+0x675a] gldAttachDrawable+0x941) Summary: Constrain window dimensions with scree

[7u8] Request for approval for CR 7160609: [macosx] JDK crash in libjvm.dylib ( C [GeForceGLDriver+0x675a] gldAttachDrawable+0x941)

2012-08-24 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7160609 Webrev: http://cr.openjdk.java.net/~anthony/7u8-2-hugeWindowCrash-7160609.0/ Review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2012-August/003320.html Reviewers: Sergey Bylokhov, Artem Ananiev JDK 8 changeset: http://hg.openjdk.ja

hg: jdk7u/jdk7u-dev/jdk: 7189350: Fix failed for CR 7162144

2012-08-22 Thread anthony . petrov
Changeset: 6c5484839ef6 Author:anthony Date: 2012-08-22 15:07 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/6c5484839ef6 7189350: Fix failed for CR 7162144 Summary: Handle EDT interruption differently Reviewed-by: art, bagiras, serb ! src/share/classes/java/awt/Even

[7u8] Request for approval for CR 7189350: Fix failed for CR 7162144

2012-08-21 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7189350 Webrev: http://cr.openjdk.java.net/~anthony/7u8-1-missingAWTThread-7189350.0/ Review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2012-August/003309.html Reviewers: Sergey Bylokhov, Oleg Pekhovskiy, Artem Ananiev Note: we may cons

hg: jdk7u/jdk7u6-dev/jdk: 7162144: Missing AWT thread in headless mode in 7u4 b06

2012-07-12 Thread anthony . petrov
Changeset: a51e0bc5a081 Author:anthony Date: 2012-07-12 20:00 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u6-dev/jdk/rev/a51e0bc5a081 7162144: Missing AWT thread in headless mode in 7u4 b06 Summary: invokeAndWait() will throw InterruptedException when the EDT.interrupt() is cal

[7u6] Request for approval for CR 7162144: Missing AWT thread in headless mode in 7u4 b20

2012-07-12 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7162144 Webrev: http://cr.openjdk.java.net/~anthony/7u6-16-missingAWTThread-7162144.0/ Review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2012-July/003097.html Reviewers: Sergey Bylokhov, Oleg Pekhovskiy -- best regards, Anthony

hg: jdk7u/jdk7u6-dev/jdk: 7177173: [macosx] JFrame.setExtendedState(JFrame.MAXIMIZED_BOTH) not working as expected in JDK 7

2012-07-11 Thread anthony . petrov
Changeset: 5b74dcc8191d Author:anthony Date: 2012-07-11 13:46 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u6-dev/jdk/rev/5b74dcc8191d 7177173: [macosx] JFrame.setExtendedState(JFrame.MAXIMIZED_BOTH) not working as expected in JDK 7 Summary: Apply the extended state only when ne

[7u6] Request for approval for CR 7177173: [macosx] JFrame.setExtendedState(JFrame.MAXIMIZED_BOTH) not working as expected in JDK 7

2012-07-10 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7177173 Webrev: http://cr.openjdk.java.net/~anthony/7u6-17-MaximizedBoth-7177173.0/ Review threads: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-July/004596.html http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-July/004585.h

hg: jdk7u/jdk7u-dev/jdk: 7124326: [macosx] An issue similar to autoshutdown one in two AppContexts situation.

2012-06-26 Thread anthony . petrov
Changeset: d69bfcf16e6d Author:anthony Date: 2012-06-26 19:48 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/d69bfcf16e6d 7124326: [macosx] An issue similar to autoshutdown one in two AppContexts situation. Summary: Don't add SystemTrayPeer to the peers map Reviewed-

[7u6] Request for approval for CR 7124326: [macosx] An issue similar to autoshutdown one in two AppContexts situation.

2012-06-26 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7124326 Webrev: http://cr.openjdk.java.net/~anthony/7u6-15-AppContextAutoshutdown-7124326.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-June/004529.html Reviewers: Artem Ananiev, Leonid Romanov Note: this is a 100% dir

hg: jdk7u/jdk7u-dev/jdk: 7174718: [macosx] Regression in 7u6 b12: PopupFactory leaks DefaultFrames.

2012-06-26 Thread anthony . petrov
Changeset: 9de9cbe25f0b Author:anthony Date: 2012-06-26 16:29 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/9de9cbe25f0b 7174718: [macosx] Regression in 7u6 b12: PopupFactory leaks DefaultFrames. Summary: Fix memory management Reviewed-by: art, serb ! src/macosx/cla

[7u6] Request for approval for CR 7174718: [macosx] Regression in 7u6 b12: PopupFactory leaks DefaultFrames.

2012-06-26 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7174718 Webrev: http://cr.openjdk.java.net/~anthony/7u6-14-AWTWindowLeak-7174718.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-June/004510.html Reviewers: Artem Ananiev, Sergey Bylokhov Note: this is a 100% direct back-

hg: jdk7u/jdk7u-dev/jdk: 7170716: JVM crash when opening an AWT app from a registered file.

2012-06-25 Thread anthony . petrov
Changeset: 77fb9dcd6e1c Author:anthony Date: 2012-06-25 18:28 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/77fb9dcd6e1c 7170716: JVM crash when opening an AWT app from a registered file. Summary: Fix memory management for queued events. Reviewed-by: art, leonidr Con

[7u6] Request for approval for CR 7170716: JVM crash when opening an AWT app from a registered file.

2012-06-25 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7170716 Webrev: http://cr.openjdk.java.net/~anthony/7u6-13-crashInSetApplicationDelegate-7170716.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-June/004482.html Reviewers: Artem Ananiev, Leonid Romanov Note: this is a 1

Re: [7u6] Request for approval for CR 7174704: [macosx] New issue in 7u6 b12: HeadlessPrintingTest failure

2012-06-22 Thread Anthony Petrov
Will do. Thanks for the approval, Seán. -- best regards, Anthony On 6/22/2012 1:31 AM, Seán Coffey wrote: Approved. Please address the JDK 8 issue asap. regards, Sean. On 21/06/2012 13:48, Anthony Petrov wrote: Bug: http://bugs.sun.com/view_bug.do?bug_id=7174704 Webrev: http

hg: jdk7u/jdk7u-dev/jdk: 7174704: [macosx] New issue in 7u6 b12: HeadlessPrintingTest failure

2012-06-22 Thread anthony . petrov
Changeset: 002ca3d97d19 Author:anthony Date: 2012-06-22 15:20 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/002ca3d97d19 7174704: [macosx] New issue in 7u6 b12: HeadlessPrintingTest failure Summary: Revert a fix for 7144542, and don't install run loop observers in h

[7u6] Request for approval for CR 7174704: [macosx] New issue in 7u6 b12: HeadlessPrintingTest failure

2012-06-21 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7174704 Webrev: http://cr.openjdk.java.net/~anthony/7u6-12-headlessPrinting-7174704.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-June/004452.html Reviewers: Artem Ananiev, Leonid Romanov Note: we may want to fix this

hg: jdk7u/jdk7u-dev/jdk: 7043963: AWT workaround missing for Mutter.

2012-06-13 Thread anthony . petrov
Changeset: 3d7847385e94 Author:anthony Date: 2012-06-13 18:42 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3d7847385e94 7043963: AWT workaround missing for Mutter. Summary: Support Mutter window manager Reviewed-by: art, omajid Contributed-by: Omair Majid ! src/so

Re: [7u6] Request for approval for CR 7043963: AWT workaround missing for Mutter.

2012-06-13 Thread Anthony Petrov
Could I get an approval for this back-ported fix please? -- best regards, Anthony On 6/7/2012 5:20 PM, Anthony Petrov wrote: Bug: http://bugs.sun.com/view_bug.do?bug_id=7043963 Webrev: http://cr.openjdk.java.net/~anthony/7u6-10-Mutter-7043963.0/ Review thread: http://mail.openjdk.java.net

[7u6] Request for approval for CR 7043963: AWT workaround missing for Mutter.

2012-06-07 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7043963 Webrev: http://cr.openjdk.java.net/~anthony/7u6-10-Mutter-7043963.0/ Review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2012-June/002923.html Reviewers: Artem Ananiev, Omair Majid -- best regards, Anthony

hg: jdk7u/jdk7u-dev/jdk: 7172722: Latest jdk7u from OSX broke universal build

2012-06-06 Thread anthony . petrov
Changeset: 0065e89d5e18 Author:anthony Date: 2012-06-06 19:45 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0065e89d5e18 7172722: Latest jdk7u from OSX broke universal build Summary: Add a data member for a property Reviewed-by: art, serb ! src/macosx/native/sun/awt

[7u6] Request for approval for CR 7172722: Latest jdk7u from OSX broke universal build

2012-06-06 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7172722 Webrev: http://cr.openjdk.java.net/~anthony/7u6-11-MacUniversalBuild-7172722.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-June/004356.html Reviewers: Artem Ananiev, Sergey Bylokhov. -- best regards, Anthony

Re: Bug reporting for jdk7u

2012-05-30 Thread Anthony Petrov
Hi Henri, On 5/30/2012 2:03 PM, Henri Gomez wrote: I see a problem with latest jdk7u who broke OSX universal build. I have a patch available to fix it, should I use : https://bugs.openjdk.java.net/ Nobody uses it. or http://bugreport.sun.com/bugreport/ This one is the correct place. Ple

hg: jdk7u/jdk7u-dev/jdk: 7144542: [macosx] Crash in liblwawt.dylib setBusy() when exiting an FX app

2012-05-21 Thread anthony . petrov
Changeset: d75496a7c71b Author:anthony Date: 2012-05-21 18:35 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/d75496a7c71b 7144542: [macosx] Crash in liblwawt.dylib setBusy() when exiting an FX app Summary: Use XToolkit instead of CToolkit in headless mode Reviewed-by:

Re: [7u6] Request for approval for CR 7144542: [macosx] Crash in liblwawt.dylib setBusy() when exiting an FX app run with j2d pipeline

2012-05-21 Thread Anthony Petrov
Thanks for the approval. There's no a fix for JDK 8 (the SubCR is closed as Not an Issue). -- best regards, Anthony On 05/18/12 21:01, Edvard Wendelin wrote: Approved. Please push to JDK 8 first, if you haven't done so already. /Edvard On May 18, 2012, at 4:16 PM, Anthony Pe

[7u6] Request for approval for CR 7144542: [macosx] Crash in liblwawt.dylib setBusy() when exiting an FX app run with j2d pipeline

2012-05-18 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7144542 Webrev: http://cr.openjdk.java.net/~anthony/7u6-6-crashInSetBusy-7144542.1/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004192.html Reviewers: Artem Ananiev -- best regards, Anthony

hg: jdk7u/jdk7u-dev/jdk: 7149062: [macosx] dock menu don't show available frames

2012-05-15 Thread anthony . petrov
Changeset: b5b68b7b6aa6 Author:anthony Date: 2012-05-15 17:29 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b5b68b7b6aa6 7149062: [macosx] dock menu don't show available frames Summary: Use either NSWindow or NSPanel as an ancestor for Java windows. NSWindow-based w

[7u6] Request for approval for CR 7149062: [macosx] dock menu don't show available frames

2012-05-15 Thread Anthony Petrov
This is a back port of the same fix from JDK 8. Bug: http://bugs.sun.com/view_bug.do?bug_id=7149062 Webrev: http://cr.openjdk.java.net/~anthony/7u6-9-windowListInDockMenu-7149062.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004140.html Reviewers: Mike Swing

hg: jdk7u/jdk7u-dev/jdk: 7166437: [macosx] Support for Window.Type.UTILITY on the Mac

2012-05-15 Thread anthony . petrov
Changeset: fa84dc221972 Author:anthony Date: 2012-05-15 15:24 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/fa84dc221972 7166437: [macosx] Support for Window.Type.UTILITY on the Mac Summary: Apply the native UTILITY style to Java UTILITY windows Reviewed-by: kizune,

[7u6] Request for approval for CR 7166437: [macosx] Support for Window.Type.UTILITY on the Mac

2012-05-12 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7166437 Webrev: http://cr.openjdk.java.net/~anthony/7u6-8-UTILITY-7166437.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004135.html Reviewers: Sergey Bylokhov, Alexander Zuev -- best regards, Anthony

Re: java.awt event processing performance degradation on JRE7 - linux

2012-04-24 Thread Anthony Petrov
es the following CPU usages: 14%, 13%, 13%. Please let me know if I can be of further help. Cheers, Nicolas On 04/18/2012 05:08 AM, Anthony Petrov wrote: Hi Nicolas, Frederico's patch is needed - with that patch we avoid string concatenation operations in XAWT code if logging has been d

Re: java.awt event processing performance degradation on JRE7 - linux

2012-04-18 Thread Anthony Petrov
Hi Nicolas, Frederico's patch is needed - with that patch we avoid string concatenation operations in XAWT code if logging has been disabled. These operations caused heavy memory usage, and eliminating them resolved the issue reported by Frederico. We don't want to revert that patch. In fact,

Re: java.awt event processing performance degradation on JRE7 - linux

2012-04-17 Thread Anthony Petrov
Here's the relevant thread: http://mail.openjdk.java.net/pipermail/awt-dev/2011-October/001952.html It was concerning building strings that are supposed to be logged while the logging itself wasn't actually enabled. The problem reported by Nicolas seems to be about logger initialization, so

hg: jdk7u/jdk7u-dev/jdk: 7131021: [macosx] Consider using system properties to pass arguments from the launcher to AWT/SplashScreen

2012-04-16 Thread anthony . petrov
Changeset: 81300fbbd705 Author:anthony Date: 2012-04-16 17:46 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/81300fbbd705 7131021: [macosx] Consider using system properties to pass arguments from the launcher to AWT/SplashScreen Summary: Add comments to the source co

[7u6] Request for approval for CR 7131021: [macosx] Consider using system properties to pass arguments from the launcher to AWT/SplashScreen

2012-04-13 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7131021 Webrev: http://cr.openjdk.java.net/~anthony/7u6-2-keepEnvVars-7131021.1/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-April/003862.html Reviewer: Kumar Srinivasan, Mike Swingler, Artem Ananiev -- best regards, Ant

hg: jdk7u/jdk7u4-dev/jdk: 7159266: [macosx] ApplicationDelegate should not be set in the headless mode

2012-04-09 Thread anthony . petrov
Changeset: 24a9125a2c96 Author:anthony Date: 2012-04-09 16:21 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/24a9125a2c96 7159266: [macosx] ApplicationDelegate should not be set in the headless mode Summary: Don't install an application delegate in headless mode Revi

hg: jdk7u/jdk7u4-dev/jdk: 7149085: [macosx] Quit with QuitStrategy CLOSE_ALL_WINDOWS does terminate application

2012-03-21 Thread anthony . petrov
Changeset: fdd008c3ef5a Author:anthony Date: 2012-03-21 20:22 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/fdd008c3ef5a 7149085: [macosx] Quit with QuitStrategy CLOSE_ALL_WINDOWS does terminate application Summary: Don't terminate the event loop. System.exit() wil

hg: jdk7u/jdk7u4-dev/jdk: 7124428: [macosx] Frame.setExtendedState() doesn't work for undecorated windows

2012-03-21 Thread anthony . petrov
Changeset: 0b7acd016f8c Author:anthony Date: 2012-03-21 20:17 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/0b7acd016f8c 7124428: [macosx] Frame.setExtendedState() doesn't work for undecorated windows Summary: Emulate -zoom request for undecorated windows Reviewed-b

hg: jdk7u/jdk7u4-dev/jdk: 7154177: [macosx] An invisible owner frame becomes visible upon clicking a child window

2012-03-21 Thread anthony . petrov
Changeset: 28cf821cd6a1 Author:anthony Date: 2012-03-21 20:10 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/28cf821cd6a1 7154177: [macosx] An invisible owner frame becomes visible upon clicking a child window Summary: Only visible frames must participate in the par

[7u4] Request for phase 2 approval for CR 7154177: [macosx] An invisible owner frame becomes visible upon clicking a child window

2012-03-20 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7154177 Webrev: http://cr.openjdk.java.net/~anthony/7u4-5-invisibleOwner-7154177.1/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003628.html Reviewer: Sergey Bylokhov (serb) Rationale for inclusion in 7u4: Impact

[7u4] Request for phase 2 approval for CR 7149085: [macosx] Quit with QuitStrategy CLOSE_ALL_WINDOWS does terminate application

2012-03-20 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7149085 Webrev: http://cr.openjdk.java.net/~anthony/7u4-8-CloseAllWindows-7149085.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003654.html Reviewer: Alexander Zuev (kizune) Rationale for inclusion in 7u4: deferra

[7u4] Request for phase 2 approval for CR 7124428: [macosx] Frame.setExtendedState() doesn't work for undecorated windows

2012-03-20 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7124428 Webrev: http://cr.openjdk.java.net/~anthony/7u4-7-setExtendedStateUndecorated-7124428.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003630.html Reviewer: Mike Swingler (swingler) Rationale for inclusion i

hg: jdk7u/jdk7u4-dev/jdk: 7148275: [macosx] setIconImages() not working correctly (distorted icon when minimized)

2012-03-13 Thread anthony . petrov
Changeset: 93eda4253911 Author:anthony Date: 2012-03-14 07:03 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/93eda4253911 7148275: [macosx] setIconImages() not working correctly (distorted icon when minimized) Summary: Choose the largest icon from a list of icons pr

Re: CFV: New JDK7u Committer: Mike Swingler

2012-03-12 Thread Anthony Petrov
Vote: YES. -- best regards, Anthony On 3/12/2012 9:52 PM, Artem Ananiev wrote: I hereby nominate Mike Swingler (OpenJDK user name: swingler) to JDK7u Committer. I don't think any more information about Mike should be provided here, we all know Mike's contribution to Java. Votes are due b

[7u4] Request for phase 2 approval for CR 7148275 - [macosx] setIconImages() not working correctly (distorted icon when minimized)

2012-03-12 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7148275 Webrev: http://cr.openjdk.java.net/~anthony/x-23-lowResIcon.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003531.html Reviewer: Mike Swingler (swingler) Rationale for inclusion in 7u4: the fix resolves a n

hg: jdk7u/jdk7u4-dev/jdk: 7150516: [macosx] appletviewer shouldn't link against libX11 on the Mac

2012-03-05 Thread anthony . petrov
Changeset: 2b9fbd5a6ec0 Author:anthony Date: 2012-03-05 18:58 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/2b9fbd5a6ec0 7150516: [macosx] appletviewer shouldn't link against libX11 on the Mac Summary: Don't link against libX11 on the Mac Reviewed-by: swingler ! ma

Re: CFV: New JDK7u Committer: Scott Kovatch

2012-03-05 Thread Anthony Petrov
Vote: YES. -- best regards, Anthony On 3/2/2012 11:41 PM, Artem Ananiev wrote: I hereby nominate Scott Kovatch (OpenJDK user name: skovatch) to JDK7u Committer. Many of us know Scott as a former member of Apple JDK team, and many pieces of Mac OS X Port code were actually written by Scott

[7u4] Request for phase 2 approval for CR 7150516 - [macosx] appletviewer shouldn't link against libX11 on the Mac

2012-03-02 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7150516 Webrev: http://cr.openjdk.java.net/~anthony/x-22-appletviewerLibX11-7150516.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003457.html Reviewer: Mike Swingler (swingler) Rationale for inclusion in 7u4: X11

Re: CFV: New JDK7u Committer: Leonid Romanov

2012-03-01 Thread Anthony Petrov
Vote: YES. -- best regards, Anthony On 03/01/12 03:09, Artem Ananiev wrote: I hereby nominate Leonid Romanov (OpenJDK user name: leonidr) to JDK7u Committer. Leonid is a member of AWT Group and is an active contributor to Mac OS X Port and JDK7u projects with about 20 fixes already in the wor

Re: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11

2012-02-29 Thread Anthony Petrov
ops_md.c:431 is already in the workspace... Other comments: 1. HeadlessGraphicsEnvironment is in the sun.java2d package, not sun.awt 2. Changes to awt_LoadLibrary.c look fine as all the defaults are set in java_props.c 3. GraphicsEnvironment.java also looks fine. Thanks, Artem On 2/27/2012 6:30

Re: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11

2012-02-28 Thread Anthony Petrov
hicsEnvironment.java also looks fine. Thanks, Artem On 2/27/2012 6:30 AM, Anthony Petrov wrote: Hello, Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ This bug is a regression of

Re: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11

2012-02-28 Thread Anthony Petrov
re set in java_props.c 3. GraphicsEnvironment.java also looks fine. Thanks, Artem On 2/27/2012 6:30 AM, Anthony Petrov wrote: Hello, Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ This bug is a re

hg: jdk7u/jdk7u4-dev/jdk: 7132692: [macosx] Class com.apple.eawt not functioning

2012-02-28 Thread anthony . petrov
Changeset: 05e342dd44de Author:anthony Date: 2012-02-28 16:39 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/05e342dd44de 7132692: [macosx] Class com.apple.eawt not functioning Summary: Postpone setting an application delegate until an app is fully initialized Revie

Re: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11

2012-02-28 Thread Anthony Petrov
hanks, Artem On 2/27/2012 6:30 AM, Anthony Petrov wrote: Hello, Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ This bug is a regression of 7124511 fixed for the JDK Mac Port [1]. With tha

[7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11

2012-02-27 Thread Anthony Petrov
Hello, Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ This bug is a regression of 7124511 fixed for the JDK Mac Port [1]. With that fix the code setting the awt.toolkit and java.aw

[7u4] Request for phase 2 approval for CR 7132692 - [macosx] Class com.apple.eawt not functioning

2012-02-21 Thread Anthony Petrov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7132692 Webrev: http://cr.openjdk.java.net/~anthony/x-16-eawt-7132692.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-February/002992.html Reviewer: Artem Ananiev (art) Rationale for inclusion in 7u4: NetBeans requires th

hg: jdk7u/jdk7u-dev/jdk: 7124553: [macosx] Need minimum size for titled Frames and JFrames

2012-02-15 Thread anthony . petrov
Changeset: 9bae15c55008 Author:anthony Date: 2012-02-15 19:25 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/9bae15c55008 7124553: [macosx] Need minimum size for titled Frames and JFrames Summary: Constrain the size for setBounds() and setMinMaxSize() to include wind

[7u4] Request for approval for 7124553: [macosx] Need minimum size for titled Frames and JFrames

2012-02-15 Thread Anthony Petrov
This is a request to push the following fix to jdk7u-dev: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124553 Webrev: http://cr.openjdk.java.net/~anthony/x-15-frameMinSize-7124553.2/ Technical review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-February/003101.

hg: jdk7u/jdk7u-dev/jdk: 7142120: [macosx] Some JCK tests for SplashScreen fail on Mac OS X due to incorrect positioning of the splash

2012-02-07 Thread anthony . petrov
Changeset: 0d6cacf5e210 Author:anthony Date: 2012-02-07 19:08 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0d6cacf5e210 7142120: [macosx] Some JCK tests for SplashScreen fail on Mac OS X due to incorrect positioning of the splash Summary: Use NSScreen -frame instea

[7u4] Request for approval for 7142120: [macosx] Some JCK tests for SplashScreen fail on Mac OS X due to incorrect positioning of the splash

2012-02-07 Thread Anthony Petrov
This is a request to push the following fix to jdk7u-dev: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142120 http://cr.openjdk.java.net/~anthony/x-14-splashScreen-7142120.1/ Technical review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-February/002808.html

[7u-osx] Request for approval for 7122250: [macosx] mouseMoved Events test do not respond in JCK-runtime-7 interactive

2012-01-31 Thread Anthony Petrov
This is a request to push the following fix to jdk7u-osx: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7122250 http://cr.openjdk.java.net/~anthony/x-13-mouseEnterExit-7122250.0/ Technical review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-January/002671.html

[7u-osx] Request for approval for 7132809: [macosx] MAXIMIZED_BOTH set before setVisible(true) hides Frame

2012-01-31 Thread Anthony Petrov
This is a request to push the following fix to jdk7u-osx: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7132809 http://cr.openjdk.java.net/~anthony/x-11-MaximizedBoth-7132809.1/ Technical review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-January/002500.html --

[7u-osx] Request for approval for 7132809: [macosx] MAXIMIZED_BOTH set before setVisible(true) hides Frame

2012-01-30 Thread Anthony Petrov
This is a request to push the following fix to jdk7u-osx: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7132809 http://cr.openjdk.java.net/~anthony/x-11-MaximizedBoth-7132809.0/ Technical review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-January/002500.html

[7u-osx] Request for approval for 7129420: [macosx] SplashScreen.getSplashScreen() returns null

2012-01-26 Thread Anthony Petrov
This is a request to push the following fix to jdk7u-osx: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129420 http://cr.openjdk.java.net/~anthony/x-8-getSplashScreenNull.2/ Technical review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-January/002456.html --

[7u-osx] Request for approval for 7124554: [macosx] JWindow does ignore setAlwaysOnTop property

2012-01-26 Thread Anthony Petrov
This is a request to push the following fix to jdk7u-osx: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124554 Webrev: http://cr.openjdk.java.net/~anthony/x-6-alwaysOnTop.4/ Technical review and approval: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-January/002482.html

[7u-osx] Request for approval for 7131038: [macosx] Document usage of -XstartOnFirstThread and -Xdock:*

2012-01-24 Thread Anthony Petrov
Hello, This is a request to push the following fix to jdk7u-osx: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7131038 Webrev: http://cr.openjdk.java.net/~anthony/x-10-Xflags-7131038.0/ The changes to the specification are approved by CCC. -- best regards, Anthony

Re: [7u4-osx] Please review: 7124089: launcher refactoring v1.0

2012-01-20 Thread Anthony Petrov
Hi Kumar, The fix looks fine to me. -- best regards, Anthony On 1/20/2012 8:24 PM, Kumar Srinivasan wrote: Hi All, Based on all the comments from Anthony, Joe and David, here is the modified version: Highlights: 1. re-factored code in solaris directory to be shared with macosx, reducin

Re: [7ux-osx] Please review: 7124089: launcher refactoring

2012-01-18 Thread Anthony Petrov
On 1/18/2012 4:03 AM, Joseph Darcy wrote: If a flag is generally sensible, I'd prefer to see the flag supported across platforms. Neither of the flags make sense on platforms other than the Mac at the moment. -- best regards, Anthony

Re: [7ux-osx] Please review: 7124089: launcher refactoring

2012-01-18 Thread Anthony Petrov
On 1/18/2012 4:33 AM, Kumar Srinivasan wrote: Was a specification (ccc) filed for these flags ? Will this be documented in the help section ? though X flags are unsupported, in the past we have documented them, both in the man pages as well as "java -X", if these will be left undocumented shoul

Re: [7ux-osx] Please review: 7124089: launcher refactoring

2012-01-17 Thread Anthony Petrov
On 1/17/2012 8:35 PM, Kumar Srinivasan wrote: src/share/bin/java.c 987 } else if (IsMacOSX() && JLI_StrCmp(arg, "-XstartOnFirstThread") == 0) { 988 ProcessSpecialArg(arg); 989 } else if (IsMacOSX() && JLI_StrCCmp(arg, "-Xdock:") == 0) { 990 ProcessS

Re: [7ux-osx] Please review: 7124089: launcher refactoring

2012-01-17 Thread Anthony Petrov
Hi Kumar, src/share/bin/java.c 987 } else if (IsMacOSX() && JLI_StrCmp(arg, "-XstartOnFirstThread") == 0) { 988 ProcessSpecialArg(arg); 989 } else if (IsMacOSX() && JLI_StrCCmp(arg, "-Xdock:") == 0) { 990 ProcessSpecialArg(arg); 1595 if (IsMacO

  1   2   >