Re: CFV: New JDK 7 Updates Project Committer: Edvard Wendelin

2013-02-22 Thread Jim Holmlund
Vote: yes On 2/22/2013 6:35 AM, Dalibor Topic wrote: I hereby nominate Edvard Wendelin to JDK 7 Updates Project Committer. As one of this Project's Maintainers, Edvard has been active in this Project since its creation. He has gradually accumulated the necessary commits by contributing across m

Request for approval for 7185778 to be fixed in jdk7u-dev/langtools

2012-09-06 Thread Jim Holmlund
- bugs.sun.com: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7185778 - The patch is the same as that in jdk 8: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3673c811be1c - testing: - built the jdk forest on windows - ran all the langtools/regression tests on windows T

Re: [7u8] Request for review and approval/backport: 7146424: Wildcard expansion for single entry classpath

2012-08-15 Thread Jim Holmlund
- http://cr.openjdk.java.net/~ksrini/7146424/webrev.0/src/share/bin/wildcard.c.frames.html This line was deleted in the jdk8 version but not in the jdk 7 version: 149 WIN32_FIND_DATA find_data; - http://cr.openjdk.java.net/~ksrini/7146424/webrev.0/test/tools/launcher/Arrrghs.java.frame

Re: [7u8] Request for review and approval: 7189944: (launcher) test/tools/launcher/Arrrrghs.java needs a couple of minor fixes

2012-08-15 Thread Jim Holmlund
Approved - jjh On 8/14/2012 1:26 PM, Kumar Srinivasan wrote: Hi, Please review and approve webrev: http://cr.openjdk.java.net/~ksrini/7189944/webrev.0/ http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7189944 http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a44671e0b6d7 http://mail.openjdk.java.n

Request for approval for 7159016 to be fixed in jdk7u-dev/langtools

2012-06-01 Thread Jim Holmlund
- bugs.sun.com: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159016 - The patch is a simple one line fix that is the same as that in jdk 8: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/844478076c25 It was reviewed by Jon Gibbons. The patch has been in the tl forest o

Re: CFV: New JDK7u Committer: Mike Swingler

2012-03-14 Thread Jim Holmlund
Vote: yes

hg: jdk7u/jdk7u-dev/langtools: 7142086: performance problem in Check.checkOverrideClashes(...)

2012-02-15 Thread jim . holmlund
Changeset: 0e72ee1bd8ff Author:jjh Date: 2012-02-15 13:43 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/0e72ee1bd8ff 7142086: performance problem in Check.checkOverrideClashes(...) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test

[7u4] Request for approval for CR: 7142086 performance problem in Check.checkOverrideClashes(...)

2012-02-15 Thread Jim Holmlund
Request for Backport of a JDK 8 fix into 7u4. Bug description : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142086 The fix is the same as in JDK 8: JDK 8 changeset : http://hg.openjdk.java.net/jdk8/tl/langtools/rev/84b61130cbed The fix has passed the JDK 8 nightly build a

hg: jdk7u/jdk7u-dev/langtools: 7142667: Problems with the value passed to the 'classes' param of JavaCompiler.CompilationTask.getTask(...)

2012-02-14 Thread jim . holmlund
Changeset: 7c69f5833241 Author:jjh Date: 2012-02-14 12:39 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/7c69f5833241 7142667: Problems with the value passed to the 'classes' param of JavaCompiler.CompilationTask.getTask(...) Reviewed-by: jjg ! src/share/class

[7u4] Request for approval for CR: 7142667: Problems with the value passed to the 'classes' param of JavaCompiler.CompilationTask.getTask(...)

2012-02-14 Thread Jim Holmlund
Request for Backport of a JDK 8 fix into 7u4. Bug description : http://monaco.us.oracle.com/detail.jsf?cr=7142667/7u4 The fix is the same as in JDK 8: JDK 8 changeset : http://hg.openjdk.java.net/jdk8/tl/langtools/rev/237198ef45f5 It is basically a one line fix that avoids an asse

hg: jdk7u/jdk7u-dev/langtools: 7144979: incorrect path separator in make/build.xml for Windows when running jtreg tests

2012-02-14 Thread jim . holmlund
Changeset: ec158c8e0a6b Author:jjh Date: 2012-02-14 10:02 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/ec158c8e0a6b 7144979: incorrect path separator in make/build.xml for Windows when running jtreg tests Reviewed-by: jjg ! make/build.xml

[7u4] Request for approval for CR : 2221126: incorrect path separator in make/build.xml for Windows when running jtreg tests

2012-02-13 Thread Jim Holmlund
Request for Backport of a JDK 8 fix into 7u4. This fixes a problem in the langtools/make/build.xml file that causes a problem for the jtreg targets on windows. Bug description http://monaco.us.oracle.com/detail.jsf?cr=2221126 The fix is a one line change that is the same as in JDK 8: JDK 8

Re: Mac OS X port - update

2012-02-06 Thread Jim Holmlund
On 2/6/2012 8:38 AM, Artem Ananiev wrote: On 2/3/2012 11:11 PM, Jim Holmlund wrote: On 2/3/2012 7:40 AM, Kumar Srinivasan wrote: On 2/3/2012 7:36 AM, Alan Bateman wrote: On 03/02/2012 15:28, Kumar Srinivasan wrote: On 2/3/2012 3:23 AM, Alan Bateman wrote: On 03/02/2012 02:10, David

Re: Mac OS X port - update

2012-02-03 Thread Jim Holmlund
On 2/3/2012 7:40 AM, Kumar Srinivasan wrote: On 2/3/2012 7:36 AM, Alan Bateman wrote: On 03/02/2012 15:28, Kumar Srinivasan wrote: On 2/3/2012 3:23 AM, Alan Bateman wrote: On 03/02/2012 02:10, David Holmes wrote: I am concerned. There was some discussion when various changes went into 7u-o

hg: jdk7u/jdk7u-dev/langtools: 7126832: com.sun.tools.javac.api.ClientCodeWrapper$WrappedJavaFileManager cannot be cast

2012-01-25 Thread jim . holmlund
Changeset: 7ca6d8cb4cc7 Author:jjh Date: 2012-01-25 17:33 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/7ca6d8cb4cc7 7126832: com.sun.tools.javac.api.ClientCodeWrapper$WrappedJavaFileManager cannot be cast Reviewed-by: jjg ! src/share/classes/com/sun/tools/ja

Re: [jdk7u-dev] Please review the fix for 7126832

2012-01-25 Thread Jim Holmlund
- jjh cheers, dalibor topic On 1/25/12 10:29 AM, Jim Holmlund wrote: Here is the bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7126832 Here is the webrev http://cr.openjdk.java.net/~jjh/7126832/ The fix is the same as the fix in jdk8 with one exception: - in JDK 8, the compile

hg: jdk7u/jdk7u-dev/langtools: 7129225: javac fails to run annotation processors when star import of package of gensrc

2012-01-25 Thread jim . holmlund
Changeset: 83d5084beaa1 Author:jjh Date: 2012-01-25 17:26 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/83d5084beaa1 7129225: javac fails to run annotation processors when star import of package of gensrc Reviewed-by: jjg ! src/share/classes/com/sun/tools/jav

[jdk7u-dev] Request approval for 7129225 - javac fails to run annotation processors when star import of package of gensrc

2012-01-25 Thread Jim Holmlund
<> Here is the bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129225 Here is the webrev http://cr.openjdk.java.net/~jjh/7129225.7u The jdk8 fix for 7129225 failed when run with jtreg -samevm. The fix for 7133314 fixes this problem. The bad fix for 7129225 was not pushed to j

[jdk7u-dev] Request approval for 7126832 - com.sun.tools.javac.api.ClientCodeWrapper$WrappedJavaFileManager cannot be cast

2012-01-25 Thread Jim Holmlund
<> Here is the bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7126832 Here is the webrev http://cr.openjdk.java.net/~jjh/7126832/ The fix is the same as the fix in jdk8 with one exception: - in JDK 8, the compile(...) methods in Main.java return Result whereas in JDK 7 they re

[jdk7u-dev] Please review the fix for 7129225

2012-01-25 Thread Jim Holmlund
Here is the bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129225 Here is the webrev http://cr.openjdk.java.net/~jjh/7129225.7u The jdk8 fix for 7129225 failed when run with jtreg -samevm. The fix for 7133314 fixes this problem. The bad fix for 7129225 was not pushed to jdk7u. So th

[jdk7u-dev] Please review the fix for 7126832

2012-01-25 Thread Jim Holmlund
Here is the bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7126832 Here is the webrev http://cr.openjdk.java.net/~jjh/7126832/ The fix is the same as the fix in jdk8 with one exception: - in JDK 8, the compile(...) methods in Main.java return Result whereas in JDK 7 they return int - t

[jdk7u-osx] Request for approval for 7130704: (macosx) Few of the jtreg tests need to be ported for mac builds

2012-01-24 Thread Jim Holmlund
This is a request to push the following fix to jdk7u-osx: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7130704 Webrev: http://cr.openjdk.java.net/~jjh/7130704/ Sent for review to : macosx-port-...@openjdk.java.net Testing:langtools repo built and regression tests

Request for phase 2 approval for CR 7102515 - javac running very very long and not returning

2011-10-20 Thread Jim Holmlund
eference+Set]&mixReference=false&flags=Show+Passed%2C+Show+Pass+Rate%2C+Show+Known%2C+Show+Unknown&significance=empty&hideDataConfiguration=true&calculateSummary=true&showComplementAttributes=false&compactTables=true&viewStyle=chessboard&filter= Author: Mauriz

Request for phase 2 approval for CR 7068451 - Regression: javac compiles fixed sources against previous, not current, version of generated sources

2011-10-17 Thread Jim Holmlund
Reviewed by: Maurizio Cimadamore , Jim Holmlund