Re: Request for review : FreeType embedded in OSX packages

2012-10-16 Thread Scott Kovatch
report.sun.com/bugreport/> describing what you want to change, and then attach a new patch. Mike's review plus one other will be enough to get it into JDK 8. JDK 7u will need two reviewers, since I think the Java2D team owns this part of the code. (I cc'd Phil Race). -- Scott K. Scott Kovatch scott.kova...@oracle.com Santa Clara/Pleasanton, CA

hg: jdk7u/jdk7u-dev/jdk: 7187834: [macosx] Usage of private API in macosx 2d implementation causes Apple Store rejection

2012-09-07 Thread scott . kovatch
Changeset: 0fa8d5080fd8 Author:skovatch Date: 2012-09-07 08:22 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0fa8d5080fd8 7187834: [macosx] Usage of private API in macosx 2d implementation causes Apple Store rejection Reviewed-by: prr, igor, swingler ! src/macosx/n

Request for approval: 7187834 - private API causes OS X store rejection

2012-09-06 Thread Scott Kovatch
7187834: [macosx] Usage of private API in macosx 2D implementation causes Apple Store rejection This is a direct back port of the fix in JDK 8. Bug: http://bugs.sun.com/view_bug.do?bug_id=7187834 Webrev: http://cr.openjdk.java.net/~skovatch/7187834/webrev.01/ JDK 8 changeset: http://hg.openjdk.j

Re: cacerts and OSX

2012-05-31 Thread Scott Kovatch
istributor or licensee is responsible for obtaining their own root certificates, and in Apple's case, they are already distributed via the OS, so the JDK was covered by those licenses. -- Scott K. Scott Kovatch scott.kova...@oracle.com Santa Clara/Pleasanton, CA

Re: Review OSX universal mode patch

2012-05-10 Thread Scott Kovatch
On May 10, 2012, at 11:19 AM, Michael McMahon wrote: > On 10/05/12 18:35, Scott Kovatch wrote: >> On May 10, 2012, at 8:51 AM, Dalibor Topic wrote: >> >>> On 5/10/12 5:21 PM, Mike Swingler wrote: >>>> The OpenJDK product should be build-able for 32 or 32/64

Re: Review OSX universal mode patch

2012-05-10 Thread Scott Kovatch
ts I'm missing here? Henri, does your patch satisfy all of these requirements? I think it does, based on the conversation I saw between you and David Holmes, but I'm not clear on the make targets. -- Scott K. Scott Kovatch scott.kova...@oracle.com Santa Clara/Pleasanton, CA

Re: [7u4] Request to check in 7162440

2012-04-27 Thread Scott Kovatch
r 19, 2012, at 10:00 PM, Scott Kovatch wrote: > >> Hello, >> >> This is a request to check in a fix for >> http://bugs.sun.com/view_bug.do?bug_id=7162440 >> >> This diff is very small, and just fixes a typo in Release-macosx.gmk >> >> --- old/ma

Re: OSX 32/64 bits support for JDK7 patch for review

2012-04-25 Thread Scott Kovatch
only, with either a -D flag or other external switch? -- Scott K. -------- Scott Kovatch scott.kova...@oracle.com Santa Clara/Pleasanton, CA

Re: [7u4] Request to check in 7162440

2012-04-23 Thread Scott Kovatch
eed an OpenJDK reviewer approval as well. > > Looks fine to me. > > cheers, > dalibor topic > >> >> Cheers, >> Edvard >> >> >> On 04/19/2012 10:00 PM, Scott Kovatch wrote: >>> Hello, >>> >>> This is a request to ch

hg: jdk7u/jdk7u4-dev/jdk: 7162440: Fix typo in BUNDLE_ID variable so it can be overridden

2012-04-19 Thread scott . kovatch
Changeset: 71f3de57c188 Author:skovatch Date: 2012-04-19 18:44 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/71f3de57c188 7162440: Fix typo in BUNDLE_ID variable so it can be overridden Reviewed-by: lana ! make/common/Release-macosx.gmk

hg: jdk7u/jdk7u-dev/jdk: 3 new changesets

2012-04-19 Thread scott . kovatch
Changeset: 15c00ee70f48 Author:skovatch Date: 2012-04-19 14:54 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/15c00ee70f48 7162440: Fix typo in macro so BUNDLE_ID can be overridden Reviewed-by: lana ! make/common/Release-macosx.gmk Changeset: e31a20c0c658 Author:

[7u4] Request to check in 7162440

2012-04-19 Thread Scott Kovatch
$(JDK_MINOR_VERSION) BUNDLE_NAME_JRE ?= $(BUNDLE_NAME) This is needed to properly build an Oracle-branded JDK 7 with a unique bundle ID. The fix will need to propagate to 7u6 and 8. http://cr.openjdk.java.net/~skovatch/7162440-open/webrev/ -- Scott K. Scott Kovatch

Re: [7u4] RFR: 7134701 [macosx] Support legacy native library names

2012-04-02 Thread Scott Kovatch
. I mistakenly forwarded the original > email instead of the updated one.. > > This is the correct webrev: > > > > Thanks, > Michael. > > > On 02/04/12 17:20, Scott Kovatch wrote: >> >> On Apr 2, 2012, at 9:35 AM, Michael McMahon wrote: >> >

Re: [7u4] RFR: 7134701 [macosx] Support legacy native library names

2012-04-02 Thread Scott Kovatch
loader. I enthusiastically approve this change. :-) -- Scott K. -------- Scott Kovatch scott.kova...@oracle.com Santa Clara/Pleasanton, CA

Re: Result: New JDK7u Committer: Scott Kovatch

2012-03-19 Thread Scott Kovatch
Woohoo! Thank you, everyone! -- Scott K. Scott Kovatch scott.kova...@oracle.com Santa Clara/Pleasanton, CA On Mar 19, 2012, at 6:39 AM, Artem Ananiev wrote: > > Voting for Scott Kovatch [1] is now closed. > > Yes: 12 > Veto:

Re: [7u4] Request for phase 2 approval for CR 7132692 - [macosx] Class com.apple.eawt not functioning

2012-03-12 Thread Scott Kovatch
Looks like it was just pushed to jdk7u4 today at 3:15 p.m. or so Pacific time. It's tagged for the b16 build. I'm not sure when it will make its way back to the main jdk7u forest. -- Scott K. On Mar 12, 2012, at 5:30 PM, niagarasoft20-macosxport...@yahoo.com wrote: > Has this been pushed to so

Re: OS X preview only installs on Lion?

2012-02-25 Thread Scott Kovatch
Go to https://developer.apple.com/downloads/index.action and you can find Xcode 4.2 for Snow Leopard. Unfortunately I think you have to be a paid Mac or iOS developer to get it. 3.2.6 is available, though. -- Scott K. On Feb 25, 2012, at 10:57 AM, Henri Gomez wrote: > Stephen > > Did you bu

Re: Review request for CR 7147456

2012-02-23 Thread Scott Kovatch
p://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-February/003239.html > > Webrev: > http://cr.openjdk.java.net/~gkbrown/7147456/webrev.00/ Scott Kovatch scott.kova...@oracle.com Santa Clara/Pleasanton, CA

Re: Branches

2012-02-20 Thread Scott Kovatch
happens, both will be copying the final output into j2sdk-bundle and j2re-bundle. This was done because the current scheme prevented you from doing a self-hosted build because some of the tool binaries were getting moved out from underneath the bootdir during the build, causing it to fail.

Re: Please review patch for 7124306

2012-01-17 Thread Scott Kovatch
This looks good to me. It was a simple typo/error in the process of converting from apple.awt to sun.lwawt.macosx. -- Scott On Jan 17, 2012, at 8:15 PM, Pete Brunet wrote: > Regarding 628 == 7124306 > http://java.net/jira/browse/MACOSX_PORT-628 > http://monaco.us.oracle.com/detail.jsf?cr=7124

Re: Can't log onto wiki

2012-01-11 Thread Scott Kovatch
I just logged in with my Oracle ID. Today was also the first day I didn't get a complaint about the site certificate having a different domain than the one I was connecting to, so I guess there was another server update recently. Maybe you need to re-register? When I click on 'swingler' I get a

Review request: 7129152 -- multiple calls to System.setProperties(null) crash VM

2012-01-11 Thread Scott Kovatch
Hello, I finally put together a proper review package for 7129152, originally MACOSX_PORT-515. Please see: http://cr.openjdk.java.net/~skovatch/7129152/webrev.00/ We need to NULL out the proxy property storage so the next call won't attempt to free a bad pointer. Thanks, Scott K.

Re: Filing bugs

2012-01-10 Thread Scott Kovatch
On Jan 10, 2012, at 12:50 AM, Alan Bateman wrote: > On 09/01/2012 23:35, Roger Lewis wrote: >> >> >> It would be useful bugs being being submitted to bugs.sun.com related to >> this project team to have a term at the beginning of the synopsis that would >> help identify it as a bug related to

Re: Filing bugs

2012-01-10 Thread Scott Kovatch
-- Scott K. -------- Scott Kovatch scott.kova...@oracle.com Santa Clara/Pleasanton, CA On Jan 9, 2012, at 3:35 PM, Roger Lewis wrote: > Mike, > > The page at bugs.sun.com is in the process of being updated to accept bugs > against Mac. The workaround would be t