hg: jdk7u/jdk7u-dev/jdk: 8022997: [macosx] Remaining duplicated key events

2013-08-20 Thread leonid . romanov
Changeset: df8dd2c6a7ca Author:leonidr Date: 2013-08-20 18:56 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/df8dd2c6a7ca 8022997: [macosx] Remaining duplicated key events Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/CMenuItem.m ! test/javax/swing/JMenuIte

[7u] Request for approval for 8022997: [macosx] Remaining duplicated key events

2013-08-20 Thread Leonid Romanov
Hello, Requesting an approval to push the fix for 8022997 into jdk7u-dev. The fix has already been pushed into JDK 8. Bug: http://bugs.sun.com/view_bug.do?bug_id=8022997 webrev: http://cr.openjdk.java.net/~leonidr/8022997/webrev.00/ JDK 8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/393

Re: RFR: 8022734: [macosx] Rebuilding jdk 7u on mac almost always fails

2013-08-09 Thread Leonid Romanov
This bug been driving me crazy. Thanks for fixing it! On Aug 10, 2013, at 12:14 AM, David DeHaven wrote: > > This issue has been annoying me for some time, I finally got frustrated > enough to fix it. > > Synopsis: > Running make when a build has already completed will fail when it tries to

hg: jdk7u/jdk7u-dev/jdk: 8021815: Add regression test for JDK-8007267

2013-08-08 Thread leonid . romanov
Changeset: f9f84ce5f53a Author:leonidr Date: 2013-08-09 01:39 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/f9f84ce5f53a 8021815: Add regression test for JDK-8007267 Reviewed-by: serb + test/com/apple/eawt/DefaultMenuBar/DefaultMenuBarTest.java

[7u] Request for approval for 8021815: Add regression test for JDK-8007267

2013-08-08 Thread Leonid Romanov
Hello, Requesting an approval to push the fix for 8021815 into jdk7u-dev. The fix has already been pushed into JDK 8. bug: http://bugs.sun.com/view_bug.do?bug_id=8021815 webrev: http://cr.openjdk.java.net/~leonidr/8021815/webrev.01/ JDK 8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/645

hg: jdk7u/jdk7u-dev/jdk: 8007267: [macosx] com.apple.eawt.Application.setDefaultMenuBar is not working

2013-08-08 Thread leonid . romanov
Changeset: b4b8463e9927 Author:leonidr Date: 2013-08-09 00:45 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b4b8463e9927 8007267: [macosx] com.apple.eawt.Application.setDefaultMenuBar is not working Reviewed-by: anthony, serb ! src/macosx/classes/com/apple/eawt/_App

hg: jdk7u/jdk7u40-dev/jdk: 8021381: JavaFX scene included in Swing JDialog not starting from Web Start

2013-08-06 Thread leonid . romanov
Changeset: 9f6cbd5a5c62 Author:leonidr Date: 2013-08-06 16:54 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/9f6cbd5a5c62 8021381: JavaFX scene included in Swing JDialog not starting from Web Start Reviewed-by: art, dcherepanov ! src/share/classes/sun/awt/AppContex

[7u40] Request for phase 2 approval for 8021381: JavaFX scene included in Swing JDialog not starting from Web Start

2013-08-06 Thread Leonid Romanov
Hello, This is a request to push the fix for 8021381 into 7u40. The fix has already been pushed into JDK 8. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8021381 Webrev: http://cr.openjdk.java.net/~leonidr/8021381/webrev.00/

[7u] Request for approval for 8007267: [macosx] com.apple.eawt.Application.setDefaultMenuBar is not working

2013-07-29 Thread Leonid Romanov
Hello, Requesting approval to push the fix for 8007267: [macosx] com.apple.eawt.Application.setDefaultMenuBar is not working into 7u-dev. The fix has already been pushed into 8. Bug: http://bugs.sun.com/view_bug.do?bug_id=8007267 Webrev: http://cr.openjdk.java.net/~leonidr/8007267/webrev.01/ Rev

hg: jdk7u/jdk7u40-dev/jdk: 8020038: [macosx] Incorrect usage of invokeLater() and likes in callbacks called via JNI from AppKit thread

2013-07-16 Thread leonid . romanov
Changeset: de37f0b34e9c Author:leonidr Date: 2013-07-16 16:12 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/de37f0b34e9c 8020038: [macosx] Incorrect usage of invokeLater() and likes in callbacks called via JNI from AppKit thread Reviewed-by: art, anthony ! src/ma

[7u40] Request for phase 2 approval for 8020038: [macosx] Incorrect usage of invokeLater() and likes in callbacks called via JNI from AppKit thread

2013-07-15 Thread Leonid Romanov
Hello, This is a request to push the fix for 8020038 into 7u40. The fix has already been pushed into JDK 8. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8020038 Webrev: http://cr.openjdk.java.net/~leonidr/8020038/webrev.01/

hg: jdk7u/jdk7u40-dev/jdk: 8019265: [macosx] apple.laf.useScreenMenuBar regression comparing with jdk6

2013-07-11 Thread leonid . romanov
Changeset: 311956930113 Author:leonidr Date: 2013-07-11 12:41 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/311956930113 8019265: [macosx] apple.laf.useScreenMenuBar regression comparing with jdk6 Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/CMenuItem.m

[7u40] Request for phase 2 approval for 8019265: [macosx] apple.laf.useScreenMenuBar regression comparing with jdk6

2013-07-10 Thread Leonid Romanov
Hello, This is a request to push the fix for 8019265 into 7u40. The fix has already been pushed into JDK 8. Bug: http://bugs.sun.com/view_bug.do?bug_id=8019265 Webrev: http://cr.openjdk.java.net/~leonidr/8019265/webrev.00/ JDK 8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b7cbad879d63

hg: jdk7u/jdk7u40-dev/jdk: 8014264: The applet pathguy_TimeDead throws java.lang.NullPointerException in java console once click drop-down check box.

2013-07-04 Thread leonid . romanov
Changeset: a5e342a0b9fd Author:leonidr Date: 2013-07-04 18:57 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/a5e342a0b9fd 8014264: The applet pathguy_TimeDead throws java.lang.NullPointerException in java console once click drop-down check box. Reviewed-by: art, an

[7u40] Request for phase 2 approval for 8014264: The applet pathguy_TimeDead throws java.lang.NullPointerException in java console once click drop-down check box.

2013-07-03 Thread Leonid Romanov
Hello, Requesting an approval to push the fix for 8014264 into 7u40. The fix has already been pushed into JDK 8. Bug: http://bugs.sun.com/view_bug.do?bug_id=8014264 Webrev: http://cr.openjdk.java.net/~leonidr/8014264/webrev.01/ Review

hg: jdk7u/jdk7u40-dev/jdk: 8014821: Regression: Focus issues with Oracle WebCenter Capture applet

2013-06-25 Thread leonid . romanov
Changeset: 282d82bfdde7 Author:leonidr Date: 2013-06-26 05:57 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/282d82bfdde7 8014821: Regression: Focus issues with Oracle WebCenter Capture applet Reviewed-by: anthony, leonidr Contributed-by: anton.tara...@oracle.com !

[7u-dev] Request for approval for 8014264: The applet pathguy_TimeDead throws java.lang.NullPointerException in java console once click drop-down check box.

2013-06-20 Thread Leonid Romanov
Hi, This is a request to push the fix for 8014264 into JDK 7u-dev. The fix has already been pushed into JDK 8. There is no difference between JDK 8 and 7u-dev version of the fix. Bug: http://bugs.sun.com/view_bug.do?bug_id=8014264 Webrev: http://cr.openjdk.java.net/~leonidr/8014264/webrev.01/ R

Re: [7u40] Request for phase 2 approval for CR 8014821 - Regression: Focus issues with Oracle WebCenter Capture applet

2013-06-19 Thread Leonid Romanov
The reviewers are: me and Anthony Petrov. On 6/19/2013 12:03, Seán Coffey wrote: Leonid, Phase 2 requires two reviewers. Can you specify who has reviewed ? regards, Sean. On 17/06/2013 16:39, Leonid Romanov wrote: Hello, This is a request for phase 2 approval to push the fix for 8014821

[7u40] Request for phase 2 approval for CR 8014821 - Regression: Focus issues with Oracle WebCenter Capture applet

2013-06-17 Thread Leonid Romanov
Hello, This is a request for phase 2 approval to push the fix for 8014821 into the 7u40 repo. The fix has already been pushed into the JDK 8 repo. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014821 webrev: http://cr.openjdk.java.net/~ant/JDK-8014821.7u40/webrev.0 review: http://ma

Re: [7u40] Request for approval for JDK-8014821: Regression: Focus issues with Oracle WebCenter Capture applet

2013-06-17 Thread Leonid Romanov
est[1]. Please log one. I know, it's been a while :) regards, Sean. [1] http://openjdk.java.net/projects/jdk7u/phase2/phase2-approval-template.html On 17/06/13 14:17, Leonid Romanov wrote: Hello, This is a request to push the fix for 8014821 into the 7u40 repo. The fix has already been p

[7u40] Request for approval for JDK-8014821: Regression: Focus issues with Oracle WebCenter Capture applet

2013-06-17 Thread Leonid Romanov
Hello, This is a request to push the fix for 8014821 into the 7u40 repo. The fix has already been pushed into the JDK 8 repo by Anton Tarasov, who is the author of the fix. Since he is on vacation atm, I'm handling the push into the 7u-40 on his behalf. Bug: http://bugs.sun.com/bugdatabase/v

Re: Review request for 8014724: Broken 7u-dev build

2013-05-16 Thread Leonid Romanov
nid. I didn't see an approval > request go out for this but consider it approved. > > regards, > Sean. > > On 16/05/2013 11:38, Leonid Romanov wrote: >> Hi, >> Could you please review the fix for the broken build: >> >> webrev: http://cr.openjdk.java

hg: jdk7u/jdk7u-dev/jdk: 8014724: Broken 7u-dev build

2013-05-16 Thread leonid . romanov
Changeset: e4c0c70ce3bd Author:leonidr Date: 2013-05-16 17:01 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/e4c0c70ce3bd 8014724: Broken 7u-dev build Reviewed-by: serb ! src/macosx/classes/sun/lwawt/macosx/CViewEmbeddedFrame.java

Review request for 8014724: Broken 7u-dev build

2013-05-16 Thread Leonid Romanov
Hi, Could you please review the fix for the broken build: webrev: http://cr.openjdk.java.net/~leonidr/8014724/webrev/ bug: https://jbs.oracle.com/bugs/browse/JDK-8014724 Thanks, Leonid.

hg: jdk7u/jdk7u-dev/jdk: 2223192: [macosx] "opposite" seems always null in focus events

2013-05-15 Thread leonid . romanov
Changeset: b9336793e998 Author:leonidr Date: 2013-05-15 15:29 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b9336793e998 2223192: [macosx] "opposite" seems always null in focus events Reviewed-by: anthony ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx

Request for approval for 7124310: [macosx] "opposite" seems always null in focus

2013-05-14 Thread Leonid Romanov
Hi, This is a request to push the backport of 7124310 into jdk7u-dev. The fix was pushed into JDK 8 long time ago. Bug: https://jbs.oracle.com/bugs/browse/JDK-7124310 Webrev: http://cr.openjdk.java.net/~leonidr/7124310/webrev.01/ JDK 8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/094c96

hg: jdk7u/jdk7u-dev/jdk: 8008366: [macosx] ActionListener called twice for JMenuItem using ScreenMenuBar

2013-05-14 Thread leonid . romanov
Changeset: e55e4808077a Author:leonidr Date: 2013-05-14 21:04 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/e55e4808077a 8008366: [macosx] ActionListener called twice for JMenuItem using ScreenMenuBar Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/AWTEvent.h

Request for approval: 8008366: [macosx] ActionListener called twice for JMenuItem using ScreenMenuBar

2013-05-14 Thread Leonid Romanov
Hi, This is a request to backport the fix for JDK-8008366 to jdk7u-dev. The fix has already been pushed into JDK8. Bug: https://jbs.oracle.com/bugs/browse/JDK-8008366 Webrev: http://cr.openjdk.java.net/~leonidr/8008366/webrev.01/ JDK 8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/578f

hg: jdk7u/jdk7u-dev/jdk: 8007006: [macosx] Closing subwindow loses main window menus

2013-02-15 Thread leonid . romanov
Changeset: dc53b95a5db7 Author:leonidr Date: 2013-02-16 02:39 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/dc53b95a5db7 8007006: [macosx] Closing subwindow loses main window menus Reviewed-by: art, serb ! src/macosx/native/sun/awt/AWTWindow.m

[7u] Approval request for 8007006: [macosx] Closing subwindow loses main window menus

2013-02-15 Thread Leonid Romanov
Hi, This is a request to push the fix for 8007006: [macosx] Closing subwindow loses main window menus into 7u-dev. This fix is exactly the same as the fix pushed into the jdk8 repo. It has been reviewed by Anthony Petrov and Sergey Bylokhov. Bug: http://bugs.sun.com/view_bug.do?bug_id=8007006

hg: jdk7u/jdk7u-dev/jdk: 8008235: Fix for 8002114 is missing in jdk7u-dev

2013-02-14 Thread leonid . romanov
Changeset: 81e936460bc9 Author:leonidr Date: 2013-02-14 22:49 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/81e936460bc9 8008235: Fix for 8002114 is missing in jdk7u-dev Reviewed-by: serb, anthony ! src/macosx/native/sun/awt/CMenuItem.m

Re: [7u] Approval request for 8008235: Fix for 8002114 is missing in jdk7u-dev

2013-02-14 Thread Leonid Romanov
All credit goes to Tomas Hurka. On Feb 14, 2013, at 10:30 PM, Seán Coffey wrote: > Thanks for catching this one Leonid. This was the result of a bad merge from > my end at 7u10 GA time. > > Approved. > > regards, > Sean. > > On 14/02/2013 17:58, Leonid Romanov

[7u] Approval request for 8008235: Fix for 8002114 is missing in jdk7u-dev

2013-02-14 Thread Leonid Romanov
Hi, This is a request to push the fix for 8008235: "Fix for 8002114 is missing in jdk7u-dev" into 7u-dev. The fix is identical with the fix for 8002114, so no additional review is necessary. Bug: Bug: http://bugs.sun.com/view_bug.do?bug_id=8008235 webrev: http://cr.openjdk.java.net/~leonidr/8008

hg: jdk7u/jdk7u-dev/jdk: 2223196: [macosx] Situation when KeyEventDispatcher doesn't work on AWT but does on Swing

2013-01-15 Thread leonid . romanov
Changeset: c9fb7c0e371f Author:leonidr Date: 2013-01-16 04:34 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/c9fb7c0e371f 2223196: [macosx] Situation when KeyEventDispatcher doesn't work on AWT but does on Swing Reviewed-by: art, ant ! src/macosx/classes/sun/lwawt/L

[7u12] Request for approval for 2223196 : [macosx] Situation when KeyEventDispatcher doesn't work on AWT but does on Swing

2013-01-15 Thread Leonid Romanov
Hi, This is a request for approval for 2223196 : [macosx] Situation when KeyEventDispatcher doesn't work on AWT but does on Swing. In JDK 8 this bug was fixed by the Anton Tarasov fix for 6981400. This fix is a OS X specific subset of the Anton's fix. It has been reviewed by Anton Tarasov and Ar

hg: jdk7u/jdk7u-dev/jdk: 8002362: Build fails after integration of 7185280 to jdk7u-dev

2012-11-07 Thread leonid . romanov
Changeset: 2b43b06caea9 Author:leonidr Date: 2012-11-07 19:44 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/2b43b06caea9 8002362: Build fails after integration of 7185280 to jdk7u-dev Reviewed-by: anthony + src/share/classes/sun/awt/TimedWindowEvent.java

Re: Cannot build jdk7u-dev

2012-11-07 Thread Leonid Romanov
at jdk7u-dev will build > & test ok with this change. > > Your push is approved for jdk7u-dev but subject to awt review and build > results. > > I see Anthony has just reviewed. > > Regards, > Sean. > > On 07/11/2012 15:05, Leonid Romanov wrote: >&g

Re: Cannot build jdk7u-dev

2012-11-07 Thread Leonid Romanov
Would be k if I just push missing file without sending a review? I forgot to do "hg add" on it when committing the fix into my local repo. On Nov 7, 2012, at 5:43 PM, Anthony Petrov wrote: > I just filed 8002362. Leonid, please take a look asap. > > -- > best regards, > Anthony > > On 11/7/2

hg: jdk7u/jdk7u-dev/jdk: 7185280: Jre7cert: focusgained does not get called for all focus req when do alt + tab

2012-11-06 Thread leonid . romanov
Changeset: 6f4e5e8f178d Author:leonidr Date: 2012-11-06 17:08 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/6f4e5e8f178d 7185280: Jre7cert: focusgained does not get called for all focus req when do alt + tab Reviewed-by: art, ant ! src/share/classes/com/sun/java/sw

[7u12] Request for approval for 7185280: Jre7cert: focusgained does not get called for all focus req when do alt + tab

2012-10-31 Thread Leonid Romanov
Hi, Resending a request for the approval to commit the fix for 7185280 into 7u12. The same fix has already been pushed into 7u10 and 8. The fix has been reviewed by Artem Ananiev and Anton Tarasov. Bug: https://jbs.oracle.com/bugs/browse/JDK-7185280 Webrev: http://cr.openjdk.java.net/~leonidr/7

RE: [7u12] Request for approval for 7185280: Jre7cert: focusgained does not get called for all focus req when do alt + tab

2012-10-05 Thread Leonid Romanov
We discussed this issue yesterday. Indeed, let's push it to JDK 8 first. > -Original Message- > From: Seán Coffey [mailto:sean.cof...@oracle.com] > Sent: Friday, October 05, 2012 3:17 PM > To: Leonid Romanov > Cc: jdk7u-dev@openjdk.java.net > Subject: Re: [7u12] R

Re: [7u12] Request for approval for 7185280: Jre7cert: focusgained does not get called for all focus req when do alt + tab

2012-10-03 Thread Leonid Romanov
t 6:49 PM, Seán Coffey wrote: > Leonid, > > can I ask for your thoughts around pushing this to jdk8 first ? > > regards, > Sean. > > On 03/10/12 13:56, Leonid Romanov wrote: >> Hi, >> Requesting approval to commit the fix for 7185280 into 7u12. The same fix >

[7u12] Request for approval for 7185280: Jre7cert: focusgained does not get called for all focus req when do alt + tab

2012-10-03 Thread Leonid Romanov
Hi, Requesting approval to commit the fix for 7185280 into 7u12. The same fix has already been pushed into 7u10. The fix has been reviewed by Artem Ananiev and Anton Tarasov. Bug: https://jbs.oracle.com/bugs/browse/JDK-7185280 Webrev: http://cr.openjdk.java.net/~leonidr/7185280/webrev.01/ Than

hg: jdk7u/jdk7u-dev/jdk: 7160951: ActionListener called twice for JMenuItem using ScreenMenuBar

2012-09-12 Thread leonid . romanov
Changeset: 33cc14b77bef Author:leonidr Date: 2012-09-12 19:34 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/33cc14b77bef 7160951: ActionListener called twice for JMenuItem using ScreenMenuBar Reviewed-by: anthony, serb Contributed-by: Marco Dinacci ! src/macosx/nat

hg: jdk7u/jdk7u-dev/jdk: 7124375: [macosx] Focus isn't transfered as expected between components

2012-09-12 Thread leonid . romanov
Changeset: f81513df8281 Author:leonidr Date: 2012-09-12 17:07 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/f81513df8281 7124375: [macosx] Focus isn't transfered as expected between components Reviewed-by: art, ant ! src/macosx/classes/sun/lwawt/LWComponentPeer.java

[7u10] Request for approval for 7160951: [macosx] ActionListener called twice for JMenuItem using ScreenMenuBar

2012-09-12 Thread Leonid Romanov
Hi, Requesting approval to commit the fix for 7160951 into 7u10. The fix is yet to be pushed into 8 (I don't have push rights yet), however, it has been successfully reviewed for inclusion into 8 . For 7u10, the fix has been reviewed by Anthony Petrov and Sergey Bylokhov. Bug: http://bugs.sun.c

[7u10] Request for approval for 7124375: [macosx] Focus isn't transfered as expected between components

2012-09-12 Thread Leonid Romanov
Hi, Requesting approval to commit fix for 7124375 into 7u10. The fix has already been pushed to jdk8. For 7u10, the fix has been reviewed by Artem Ananiev and Anton Tarasov. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124375 Webrev: http://cr.openjdk.java.net/~leonidr/7124375/webrev

hg: jdk7u/jdk7u6-dev/jdk: 7181027: [macosx] Unable to use headless mode

2012-07-16 Thread leonid . romanov
Changeset: ba7fae92732e Author:leonidr Date: 2012-07-17 01:59 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u6-dev/jdk/rev/ba7fae92732e 7181027: [macosx] Unable to use headless mode Reviewed-by: anthony ! src/share/classes/java/awt/GraphicsEnvironment.java ! src/solaris/native/ja

[7u6] Request for phase 2 approval for CR 7181027: [macosx] Unable to use headless mode

2012-07-16 Thread Leonid Romanov
Hi, Bug: http://bugs.sun.com/view_bug.do?bug_id=7181027 Webrev: http://cr.openjdk.java.net/~leonidr/7181027/webrev.00/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-July/004604.html Reviewer: anthony Rationale for inclusion in 7u4: a low risk fix that makes headless

hg: jdk7u/jdk7u-dev/jdk: 7179349: [macosx] Java processes on Mac should not use default Apple icon

2012-06-26 Thread leonid . romanov
Changeset: 23f237259967 Author:leonidr Date: 2012-06-26 16:39 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/23f237259967 7179349: [macosx] Java processes on Mac should not use default Apple icon Reviewed-by: anthony, art ! make/sun/osxapp/Makefile + make/sun/osxapp/

[7u6] Request for approval: 7179349: [macosx] Java processes on Mac should not use default Apple icon

2012-06-26 Thread Leonid Romanov
Hi, Requesting approval to push the fix for CR 7179349. This fix has been reviewed by Anthony Petrov and Artem Ananiev. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7179349 Webrev: http://cr.openjdk.java.net/~leonidr/7179349/webrev.01/ Thanks, Leonid.

hg: jdk7u/jdk7u-dev/jdk: 7159381: [macosx] Dock Icon defaults to Generic Java Application Category

2012-06-22 Thread leonid . romanov
Changeset: 8f37aad76b5b Author:leonidr Date: 2012-06-22 15:22 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/8f37aad76b5b 7159381: [macosx] Dock Icon defaults to Generic Java Application Category Reviewed-by: skovatch, art ! src/macosx/native/sun/osxapp/NSApplication

hg: jdk7u/jdk7u-dev/jdk: 7124239: [macosx] sun.awt.SunToolkit.InfiniteLoop exception in realSync called from SwingTestHelper

2012-06-22 Thread leonid . romanov
Changeset: b521e3a5b843 Author:leonidr Date: 2012-06-22 14:06 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b521e3a5b843 7124239: [macosx] sun.awt.SunToolkit.InfiniteLoop exception in realSync called from SwingTestHelper Reviewed-by: anthony, art ! src/macosx/nativ

Re: [7u6] Request for approval: 7124239: [macosx] sun.awt.SunToolkit.InfiniteLoop exception in realSync called from SwingTestHelper

2012-06-21 Thread Leonid Romanov
9381 > > Is it possible for you to push to jdk 8 first as per ground rules ? > regards, > Sean. > > http://openjdk.java.net/projects/jdk7u/groundrules.html > > On 21/06/2012 13:27, Leonid Romanov wrote: >> Hi, >> Requesting approval to push the fix for CR

[7u6] Request for approval: 7159381: [macosx] Dock Icon defaults to Generic Java Application Category

2012-06-21 Thread Leonid Romanov
Hi, Requesting approval to push the fix for CR 7159381. This fix has been reviewed by Scott Kovatch and Artem Ananiev. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159381 Webrev: http://cr.openjdk.java.net/~leonidr/7159381/webrev.00/ Thanks, Leonid.

[7u6] Request for approval: 7124239: [macosx] sun.awt.SunToolkit.InfiniteLoop exception in realSync called from SwingTestHelper

2012-06-21 Thread Leonid Romanov
Hi, Requesting approval to push the fix for CR 7124239. This fix has been reviewed by Anthony Petrov. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124239 Webrev: http://cr.openjdk.java.net/~leonidr/7124239/webrev.02/ Thanks, Leonid.

hg: jdk7u/jdk7u-dev/jdk: 7124411: [macosx] There's no KEY_TYPED for VK_ESCAPE

2012-05-28 Thread leonid . romanov
Changeset: 7e2de40cb062 Author:leonidr Date: 2012-05-28 19:06 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/7e2de40cb062 7124411: [macosx] There's no KEY_TYPED for VK_ESCAPE Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTEvent.m

[7u6] Request for approval: 7124411: [macosx] There's no KEY_TYPED for VK_ESCAPE

2012-05-24 Thread Leonid Romanov
Hi, Requesting approval to push the fix for CR 712441. This fix has already been pushed to JDK 8. For 7u6 it has been reviewed by Anthony Petrov. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=712441 Webrev: http://cr.openjdk.java.net/~leonidr/7124411/webrev.00/ JDK 8 changeset: http:

hg: jdk7u/jdk7u-dev/jdk: 7124376: [macosx] Modal dialog lost focus

2012-05-05 Thread leonid . romanov
Changeset: 6bf2990ade5d Author:leonidr Date: 2012-05-05 14:17 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/6bf2990ade5d 7124376: [macosx] Modal dialog lost focus Reviewed-by: kizune ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/Pla

[7u6] Request for approval: 7124376: [macosx] Modal dialog lost focus

2012-05-03 Thread Leonid Romanov
Hi, Requesting approval to push the fix for CR 7124376. This fix has already been pushed to JDK 8. For 7u6 it has been reviewed by Alexander Zuev. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124376 Webrev: http://cr.openjdk.java.net/~leonidr/7124376/webrev.02/ Review: http://mail

hg: jdk7u/jdk7u4-dev/jdk: 7154480: [macosx] Not all popup menu items are visible

2012-03-28 Thread leonid . romanov
Changeset: 2e90db16f9af Author:leonidr Date: 2012-03-28 19:08 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/2e90db16f9af 7154480: [macosx] Not all popup menu items are visible Reviewed-by: swingler, anthony ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! sr

hg: jdk7u/jdk7u4-dev/jdk: 7150089: [macosx] Default for a custom cursor created from non-existent image is not transparent

2012-03-28 Thread leonid . romanov
Changeset: 1dff65eca846 Author:leonidr Date: 2012-03-28 19:04 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/1dff65eca846 7150089: [macosx] Default for a custom cursor created from non-existent image is not transparent Reviewed-by: swingler ! src/macosx/classes/sun

hg: jdk7u/jdk7u4-dev/jdk: 7124286: [macosx] Option modifier should work like AltGr as in Apple jdk 6

2012-03-21 Thread leonid . romanov
Changeset: 6572dc1873ab Author:leonidr Date: 2012-03-21 20:46 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/6572dc1873ab 7124286: [macosx] Option modifier should work like AltGr as in Apple jdk 6 Summary: Refactored printable character check out of the performAction

[7u4] Request for phase 2 approval for CR 7124286: [macosx] Option modifier should work like AltGr as in Apple jdk 6

2012-03-21 Thread Leonid Romanov
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124286 Webrev: http://cr.openjdk.java.net/~leonidr/7124286/webrev.00/ Reviewer: swingler, alexp Rationale for inclusion in 7u4: the ability to enter characters from the extended characters set via option+letter combo is a basic functionali

[7u4] Request for phase 2 approval for CR 7150089: [macosx] Default for a custom cursor created from non-existent image is not transparent

2012-03-20 Thread Leonid Romanov
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7150089 Webrev: http://cr.openjdk.java.net/~leonidr/7150089/webrev.00/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003637.html Reviewer: swingler Rationale for inclusion in 7u4: Since 1.3 release, there

[7u4] Request for phase 2 approval for CR 7124321: [macosx] TrayIcon MouseListener is never triggered

2012-03-13 Thread Leonid Romanov
Bug: http://bugs.sun.com/view_bug.do?bug_id=7124321 Webrev: http://cr.openjdk.java.net/~leonidr/7124321/webrev.01/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003520.html Reviewer: Anthony Petrov (anthony) Rationale for inclusion in 7u4: it's a regression fro

[7u4] Request for approval for CR 7124272: [macosx] VK_DELETE does produce an extraneous character in a TextArea or TextField

2012-02-13 Thread Leonid Romanov
Hi, This is a request to push the following changes to jdk7u-dev: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124272 webrev: http://cr.openjdk.java.net/~leonidr/MACOSX_PORT-675/webrev.01/ The fix has been reviewed on macosx-port-dev mailing list by Mike Swingler Thanks, Leonid.

[7u4] Request for approval for CR 7124382: [macosx] Property sun.awt.enableExtraMouseButtons is always 'false'

2012-02-02 Thread Leonid Romanov
Hi, This is a request to push the following changes to jdk7u-dev: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124382 webrev: http://cr.openjdk.java.net/~leonidr/7124382/webrev.02/ The fix has been reviewed on macosx-port-dev mailing list by Artem Ananiev Thanks, Leonid.

[7u-osx] Request for approval for MACOSX_PORT-568: KeyEvent difference between Apple 1.6 and openjdk 1.7

2012-01-27 Thread Leonid Romanov
Hi, This a request to push the following changes to jdk7u-osx. CR: http://java.net/jira/browse/MACOSX_PORT-568 Webrev: http://cr.openjdk.java.net/~leonidr/MACOSX_PORT-568/webrev.00/ The fix has been reviewed on macosx-port-dev mailing list by Anthony Petrov and Alexander Potochkin. Thanks, Leo

[7u4-osx] Request for approval for CR 7124364: [macosx] Robot screen capturing functionality doesn't work

2012-01-23 Thread Leonid Romanov
Hi, This a request to push the following changes to jdk7u-osx. CR: http://monaco.us.oracle.com/detail.jsf?cr=7124364 Webrev: http://cr.openjdk.java.net/~leonidr/7124364/webrev.00/ The fix removes a bunch of code that was only useful when Robot used OpenGL for taking a screenshot. The removed co

[7u-osx] Request for approval for CR 7130751: [macosx] EventTest0020 test fails in JCK-runtime-7 interactive

2012-01-19 Thread Leonid Romanov
Hi, This a request to push the following changes to jdk7u-osx. CR: http://monaco.us.oracle.com/detail.jsf?cr=7130751 Webrev: http://cr.openjdk.java.net/~leonidr/7130751/webrev.00 The fix has been reviewed on macosx-port-dev mailing list by Dmitry Cherepanov. Thanks, Leonid.

[7u4] Request for approval for CR 7124368: UnsupportedOperationException is thown on getLockingKeyState()

2012-01-12 Thread Leonid Romanov
Hi, This a request to push the following changes to jdk7u-osx. CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124368 Webrev: http://cr.openjdk.java.net/~leonidr/7124368/webrev.01/ The fix has been reviewed on macosx-port-dev mailing list by Anthony Petrov. Thanks, Leonid.

[7u4] Request for approval for CR 7124289: Modal behavior difference with and without Robot interaction

2011-12-30 Thread Leonid Romanov
Hi, This a request to push the following changes to jdk7u-osx. CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124289 Webrev: http://cr.openjdk.java.net/~leonidr/7124289/webrev.00/ The fix has been reviewed on macosx-port-dev mailing list by Anthony Petrov. Thanks, Leonid.

[7u4] Request for approval for CR 7125267: TrayIcon removal test invariably crashes on System.exit after successful completion

2011-12-28 Thread Leonid Romanov
Hi, This a request to push the following changes to jdk7u-osx. CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7125267 Webrev: http://cr.openjdk.java.net/~leonidr/7125267/webrev.00/ The fix has been reviewed on macosx-port-dev mailing list by Anthony Petrov. Thanks, Leonid.

[7u4] Request for approval for CR 7124354: PopipMenuTest is not functional in JCK-runtime-7 interactive

2011-12-27 Thread Leonid Romanov
Hi, This is a request to push the following changes to jdk7u-osx. CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124354 Webrev: http://cr.openjdk.java.net/~leonidr/7124354/webrev.00/ The fix has been reviewed on macosx-port-dev mailing list by Anthony Petrov. Thanks, Leonid.