Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-02 Thread Dalibor Topic
On 12/2/11 10:53 AM, Alan Bateman wrote: > On 01/12/2011 21:38, Dalibor Topic wrote: >> : >> There is no special procedure for pushing into jdk7u-osx that's different >> from >> the one for jdk7u-dev. You need to submit a bulk change request for approval >> first, >> someone (i.e. either me or Ed

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-02 Thread Michael McMahon
On 02/12/11 10:21, Alan Bateman wrote: On 02/12/2011 10:13, Weijun Wang wrote: Yes, I think jdk7u-osx is only a temporary playground. There is no need for approval to push anything there. In fact, it's even not as formal as jdk8/tl, where code reviews must be done seriously, jcheck rules must

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-02 Thread Alan Bateman
On 02/12/2011 10:13, Weijun Wang wrote: Yes, I think jdk7u-osx is only a temporary playground. There is no need for approval to push anything there. In fact, it's even not as formal as jdk8/tl, where code reviews must be done seriously, jcheck rules must be obeyed, and all changesets will be

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-02 Thread Weijun Wang
Yes, I think jdk7u-osx is only a temporary playground. There is no need for approval to push anything there. In fact, it's even not as formal as jdk8/tl, where code reviews must be done seriously, jcheck rules must be obeyed, and all changesets will be pushed to the main repo with no change. T

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-02 Thread Alan Bateman
On 01/12/2011 21:38, Dalibor Topic wrote: : There is no special procedure for pushing into jdk7u-osx that's different from the one for jdk7u-dev. You need to submit a bulk change request for approval first, someone (i.e. either me or Edvard) needs to approve it, then the push can happen - regard

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-02 Thread Alan Bateman
On 02/12/2011 02:03, David Holmes wrote: : My concern is that there are a number of platform specific changes being made to java.* and javax.* classes (there are changes to sun.* as well but that is less of a concern). http://cr.openjdk.java.net/~michaelm/7113349/4/jdk7u-osx/modified/ I woul

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread Henri Gomez
>> Where is the Mercurial URL for jdk7u-osx ? > > > Same place as all the other repos :) > > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/ Nice, I'll try to build this one also :) Cheers

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread David Holmes
On 2/12/2011 4:56 PM, Henri Gomez wrote: Where is the Mercurial URL for jdk7u-osx ? Same place as all the other repos :) http://hg.openjdk.java.net/jdk7u/jdk7u-osx/ David 2011/12/2 David Holmes: On 2/12/2011 11:30 AM, Paul Hohensee wrote: I agree. Be a good idea to ask for review from

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread Henri Gomez
Where is the Mercurial URL for jdk7u-osx ? 2011/12/2 David Holmes : > > > > On 2/12/2011 11:30 AM, Paul Hohensee wrote: >> >> I agree. Be a good idea to ask for review from all the affected teams. >> I _think_ core libs is the only one we missed, though. > > > My concern is that there are a numbe

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread David Holmes
On 2/12/2011 11:30 AM, Paul Hohensee wrote: I agree. Be a good idea to ask for review from all the affected teams. I _think_ core libs is the only one we missed, though. My concern is that there are a number of platform specific changes being made to java.* and javax.* classes (there are cha

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread Paul Hohensee
I agree. Be a good idea to ask for review from all the affected teams. I _think_ core libs is the only one we missed, though. Paul On 12/1/11 8:07 PM, David Holmes wrote: On 2/12/2011 7:38 AM, Dalibor Topic wrote: On 12/1/11 6:12 PM, Michael McMahon wrote: Kelly, Yes, that is correct. This p

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread David Holmes
On 2/12/2011 7:38 AM, Dalibor Topic wrote: On 12/1/11 6:12 PM, Michael McMahon wrote: Kelly, Yes, that is correct. This push is initially just for jdk7u-osx, which is a development forest. I'm not sure exactly what the procedure will be yet for the push into jdk7u-dev. There is no special pro

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread Dalibor Topic
On 12/1/11 6:12 PM, Michael McMahon wrote: > Kelly, > > Yes, that is correct. This push is initially just for jdk7u-osx, which > is a development forest. I'm not sure exactly what the procedure will be yet > for the push into jdk7u-dev. There is no special procedure for pushing into jdk7u-osx tha

Re: webrevs.2 for macosx changes to jdk7u-osx

2011-12-01 Thread Dalibor Topic
On 12/1/11 5:07 PM, Kelly O'Hair wrote: > I haven't been watching the rules closely, but doesn't someone have to get > some kind of jdk7 update > approval before pushing anything into jdk7u-dev? > And if so, would someone be doing some kind of one big approval for a massive > integration from > j