[jira] Commented: (JDO-522) Draft proposal for CopyOnAttach property

2007-09-19 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528975 ] Andy Jefferson commented on JDO-522: Craig, you can check in your patch when ready - JPOX should be fine. Draft

Re: Who is responsible for JDOCentral.com?

2007-09-18 Thread Andy Jefferson
Is the JDO vendor community still serious about JDO? If so, I think they should fund to keep JDOCentral alive... I'd like to see the same. So I can understand your requirements better I ask the question JDOCentral was what exactly ? To me it was a central point for discussion of a

[jira] Commented: (JDO-522) Draft proposal for CopyOnAttach property

2007-09-18 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528440 ] Andy Jefferson commented on JDO-522: No particular comment on the draft, just to note that JPOX CVS now provides

[jira] Commented: (JDO-517) NPE on enhancement of classes with persistent properties

2007-09-18 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528453 ] Andy Jefferson commented on JDO-517: Thx Michelle. Subsequent issue comes via PCDSDepartment.java public void

[jira] Commented: (JDO-517) NPE on enhancement of classes with persistent properties

2007-09-17 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528007 ] Andy Jefferson commented on JDO-517: The test companyAnnotatedAllRelationshipsPCConcrete.conf for datastore

[jira] Created: (JDO-528) JDOHelper.getObjectState() : convenience method to return the state of an object

2007-09-16 Thread Andy Jefferson (JIRA)
Issue Type: New Feature Components: api2 Reporter: Andy Jefferson Priority: Minor Fix For: JDO 2 maintenance release 1 As discussed on the jdo-dev mailing list cerca 5th August 2007, it would be desirable for JDOHelper to have a method to return

[jira] Updated: (JDO-528) JDOHelper.getObjectState() : convenience method to return the state of an object

2007-09-16 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-528: --- Attachment: ObjectState.patch JDOHelper.patch Patches for JDOHelper, and new

[jira] Updated: (JDO-528) JDOHelper.getObjectState() : convenience method to return the state of an object

2007-09-16 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-528: --- Attachment: (was: JDOHelper.patch) JDOHelper.getObjectState() : convenience method to return

[jira] Updated: (JDO-528) JDOHelper.getObjectState() : convenience method to return the state of an object

2007-09-16 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-528: --- Attachment: JDOHelper.patch Updated JDOHelper for P_NONTRANS/P_NONTRANS_DIRTY bug

[jira] Updated: (JDO-528) JDOHelper.getObjectState() : convenience method to return the state of an object

2007-09-16 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-528: --- Attachment: (was: ObjectState.patch) JDOHelper.getObjectState() : convenience method to return

[jira] Updated: (JDO-528) JDOHelper.getObjectState() : convenience method to return the state of an object

2007-09-16 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-528: --- Attachment: (was: JDOHelper.patch) JDOHelper.getObjectState() : convenience method to return

[jira] Updated: (JDO-528) JDOHelper.getObjectState() : convenience method to return the state of an object

2007-09-16 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-528: --- Attachment: ObjectState.patch JDOHelper.patch Updated patches to 1. provide user

[jira] Assigned: (JDO-517) NPE on enhancement of classes with persistent properties

2007-09-16 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson reassigned JDO-517: -- Assignee: Michelle Caisse (was: Andy Jefferson) The enhancement of these tests seems to have

[jira] Commented: (JDO-528) JDOHelper.getObjectState() : convenience method to return the state of an object

2007-09-16 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527870 ] Andy Jefferson commented on JDO-528: No reason other than I had that in a cut-paste of something else

[jira] Updated: (JDO-528) JDOHelper.getObjectState() : convenience method to return the state of an object

2007-09-16 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-528: --- Attachment: (was: ObjectState.patch) JDOHelper.getObjectState() : convenience method to return

[jira] Updated: (JDO-528) JDOHelper.getObjectState() : convenience method to return the state of an object

2007-09-16 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-528: --- Attachment: (was: JDOHelper.patch) JDOHelper.getObjectState() : convenience method to return

Re: Explanation of notation in the spec draft?

2007-09-15 Thread Andy Jefferson
what does A12.5.7-6A [...] actually mean? An assert, for use by the TCK. Something to check on. And why is something labeled 12.5.7 within the 12.6.7 section? No idea :-) -- Andy  (Java Persistent Objects - http://www.jpox.org)

TCK2 : src/java/org/apache/jdo/tck/mapping/RelationshipManyToManyNoRelationships.java

2007-09-11 Thread Andy Jefferson
Hi, this test seems to have an error. Line 154 has emp1 = (Employee)pm.getObjectById(emp1Oid); yet it should be emp4 = (Employee)pm.getObjectById(emp4Oid); since emp4 is the Employee that is being compared just after (emp1 is never used). -- Andy  (Java Persistent Objects -

[jira] Resolved: (JDO-525) Department.getEmployees().contains() returns wrong answer

2007-09-10 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson resolved JDO-525. Resolution: Fixed Fix Version/s: JDO 2 maintenance release 1 Fixed in CVS HEAD

[jira] Resolved: (JDO-526) Implementation fails to set other side of relationship on flush()

2007-09-09 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson resolved JDO-526. Resolution: Fixed Fix Version/s: JDO 2 maintenance release 1 I see no issues on 1-1 relations

[jira] Commented: (JDO-521) Create tests for relationship mapping (spec section 15.3)

2007-09-09 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525981 ] Andy Jefferson commented on JDO-521: The negative 1-1 relation tests raise a question. Let's take the first one

[jira] Commented: (JDO-521) Create tests for relationship mapping (spec section 15.3)

2007-09-09 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526000 ] Andy Jefferson commented on JDO-521: The negative test I was expecting to find was where you set up something like

[jira] Created: (JDO-527) NullPointerException in JDO_Test.isTestToBePerformed()

2007-09-08 Thread Andy Jefferson (JIRA)
NullPointerException in JDO_Test.isTestToBePerformed() -- Key: JDO-527 URL: https://issues.apache.org/jira/browse/JDO-527 Project: JDO Issue Type: Bug Reporter: Andy Jefferson

TCK2 : src/java/org/apache/jdo/tck/pc/companyAnnotatedPI/PIAppProject.java

2007-09-07 Thread Andy Jefferson
seems to have :- @Element(types=org.apache.jdo.tck.pc.companyAnnotatedFC.FCAppEmployee.class, column=REVIEWER, foreignKey=PR_REV_FK) Set getReviewers(); @Element(types=org.apache.jdo.tck.pc.companyAnnotatedFC.FCAppEmployee.class, column=MEMBER,

[jira] Commented: (JDO-517) NPE on enhancement of classes with persistent properties

2007-08-17 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520503 ] Andy Jefferson commented on JDO-517: PCDSPerson seems to have 2 methods setLastname. One of them sets the personId

[jira] Commented: (JDO-517) NPE on enhancement of classes with persistent properties

2007-08-15 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519893 ] Andy Jefferson commented on JDO-517: If a class is persistence-capable, by default fields of a particular type

Re: All annotations issues...

2007-08-15 Thread Andy Jefferson
On 15 August 2007, Craig L Russell wrote: that I can find are resolved with the patch to https:// issues.apache.org/jira/browse/JDO-515. If I've missed any, please let me know. Hi Craig, Persistent property property has to have field-name specified. When specifying this with @Persistent

[jira] Commented: (JDO-517) NPE on enhancement of classes with persistent properties

2007-08-14 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519748 ] Andy Jefferson commented on JDO-517: Why are classes annotated with @NotPersistent on fields and @Persistent

Re: Minutes: JDO TCK Conference Call Friday, Aug 10, 9 am PDT

2007-08-13 Thread Andy Jefferson
2. Annotations: discuss custom settings for enum-valued elements. We need better javadoc for UNKNOWN, and in fact we might change UNKNOWN to UNSPECIFIED so it's more clear from the name itself. AI Matthew raise this issue on the alias. It also seems like adding a new value of CUSTOM is

[jira] Created: (JDO-515) Allow custom settings for some annotation enum values

2007-08-13 Thread Andy Jefferson (JIRA)
Reporter: Andy Jefferson Fix For: JDO 2 maintenance release 1 JDO2.1 annotations utilise some enums defining the acceptable values for various strategies. The following need changing to allow implementations to provide custom values. @Persistence valueStrategy

Re: Implicitly setting @Column's defaultValue parameter

2007-08-10 Thread Andy Jefferson
In the case of a PC class with a field declared as @Column(name = foo_bar, allowsNull = false) int fooBar = 0; It would be nice if the implementation would implicitly set the default value for the column, as if the user had typed @Column(name = foo_bar, allowsNull =

Re: 2.1 Spec: detached-dirty parameters to makePersistent() when DetachAllOnCommit=true

2007-08-09 Thread Andy Jefferson
Hi, So if we introduce a flag that uses the same instance on attach, we might want to have the flag called CopyOnMakePersistent and have true be the current specified behavior and false be the new behavior we've been discussing. Sounds great to me. There's some fine print here, though:

Re: 2.1 Spec: detached-dirty parameters to makePersistent() when DetachAllOnCommit=true

2007-08-07 Thread Andy Jefferson
With this restriction in place, however, would I be able to do the following? // fetch a detched object Query q = pm.newQuery(Foo.class); q.setUnique(true); Foo foo = (Foo) q.execute(); detachAllOnCommit will transition instances to detached *at commit*. You have no commit here (using

Re: 2.1 Spec: detached-dirty parameters to makePersistent() when DetachAllOnCommit=true

2007-08-07 Thread Andy Jefferson
// and attach it a second time foo : detached-dirty - persistent-clean I'm with you until this last one... It would transition from persistent-clean to detached-clean upon committing the transaction, right? If so, then we're aligned... Yes. It's the same operation as earlier, so it

Re: JDO 2.1 specification draft can be reviewed...

2007-08-04 Thread Andy Jefferson
Hi, I'd like to see others' reaction to this proposal as well. String getObjectState(Object pc) I clearly think it's a good idea since that's why JPOX has it ;-) Anything that adds more information to the user domain and more clearly defines the object states is a good thing. I agree

Re: Abstract Class Persistence

2007-08-02 Thread Andy Jefferson
Hi Craig, I've added your comments at http://www.jpox.org/servlet/wiki/en/Persistent_Abstract_Class_Design -- Andy  (Java Persistent Objects - http://www.jpox.org)

Re: Abstract Class Persistence

2007-07-31 Thread Andy Jefferson
Hi Craig, Is there a getting started building JPOX from source? I downloaded Core, Enhancer, and Plugins but the maven goals don't seem to work. In general follow http://www.jpox.org/docs/project/building_maven1.html You'll probably need the top level too (because I seem to remember

Re: Abstract Class Persistence

2007-07-31 Thread Andy Jefferson
Hi Craig, There is a small bit of design work to do. Should I post something to the JPOX wiki? Good idea -- Andy  (Java Persistent Objects - http://www.jpox.org)

[jira] Updated: (JDO-503) Create tests for JDO 2.1 annotations

2007-07-30 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-503: --- Attachment: (was: company_annotatedpi.patch) Create tests for JDO 2.1 annotations

[jira] Updated: (JDO-503) Create tests for JDO 2.1 annotations

2007-07-30 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-503: --- Attachment: company_annotatedpi.patch Further updates for schema mapping Create tests for JDO 2.1

[jira] Updated: (JDO-503) Create tests for JDO 2.1 annotations

2007-07-30 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-503: --- Attachment: datastoreidentity_sql.patch applicationidentity_sql.patch Schema mapping

Re: Embedding fields of non-persistent types even when field-type is used

2007-07-30 Thread Andy Jefferson
Hi Craig, I agree that we're getting a bit far from reality with the framework that we set up for deepEquality testing. It appears that a reflection- based approach might work if we are unsuccessful in getting JPOX to work with this artificial setup. Michelle and I have already prototyped a

Re: Abstract Class Persistence

2007-07-30 Thread Andy Jefferson
Hi Craig, The difference between Persistent Interface and Persistent Abstract Class is: 1. interface PIXXX vs. abstract class PACXXX 2. PIXXXImpl implements PIXXX vs. PACXXXImpl extends PACXXX 3. All methods in PIXXX must be properties (corresponding get/set methods) vs. all abstract

Re: @Implements uses String[]

2007-07-30 Thread Andy Jefferson
Is there a reason for @Implements to take String[] instead of Class[]? No -- Andy  (Java Persistent Objects - http://www.jpox.org)

[jira] Updated: (JDO-503) Create tests for JDO 2.1 annotations

2007-07-29 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-503: --- Attachment: datastoreidentity_company_package_jdo.patch Add missing definition

[jira] Updated: (JDO-503) Create tests for JDO 2.1 annotations

2007-07-29 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-503: --- Attachment: datastoreidentity_company_pidsemployee.patch Missing @Persistent and types for PIDSEmployee

[jira] Updated: (JDO-503) Create tests for JDO 2.1 annotations

2007-07-29 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-503: --- Attachment: applicationidentity_company_pidsemployee.patch Missing @Persistent and types

[jira] Commented: (JDO-503) Create tests for JDO 2.1 annotations

2007-07-29 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516203 ] Andy Jefferson commented on JDO-503: src/java/org/apache/jdo/tck/pc/companyAnnotatedPI/PIDSPerson.java refers

[jira] Updated: (JDO-503) Create tests for JDO 2.1 annotations

2007-07-29 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-503: --- Attachment: applicationidentity_company_package_jdo.patch Updates to persistent-interface definitions

[jira] Assigned: (JDO-509) Enhancement failure on persistent interface that extends non-persistent interface

2007-07-29 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson reassigned JDO-509: -- Assignee: Michelle Caisse (was: Andy Jefferson) Latest JPOX CVS HEAD passes companyPMInterface

[jira] Updated: (JDO-503) Create tests for JDO 2.1 annotations

2007-07-29 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-503: --- Attachment: (was: applicationidentity_company_pidsemployee.patch) Create tests for JDO 2.1

[jira] Updated: (JDO-503) Create tests for JDO 2.1 annotations

2007-07-29 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-503: --- Attachment: (was: datastoreidentity_company_pidsemployee.patch) Create tests for JDO 2.1

[jira] Updated: (JDO-503) Create tests for JDO 2.1 annotations

2007-07-29 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-503: --- Attachment: company_annotatedpi.patch Patch for whole of org.apache.jdo.tck.pc.companyAnnotatedPI

[jira] Commented: (JDO-503) Create tests for JDO 2.1 annotations

2007-07-29 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516280 ] Andy Jefferson commented on JDO-503: There is also a problem with companyAnnotatedPI and the schema that it uses

[jira] Commented: (JDO-487) Pm.newInstance() fails when the parameter is an abstract class

2007-07-28 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516151 ] Andy Jefferson commented on JDO-487: This was raised in JPOX JIRA 1yr+ ago to add support for newInstance

[jira] Commented: (JDO-511) Add extensions element to @Join, @Element, @Key, @Value, @DatastoreIdentity, ...

2007-07-28 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516152 ] Andy Jefferson commented on JDO-511: Please add it to @Query too. Forgot that in my first list. Add extensions

[jira] Updated: (JDO-509) Enhancement failure on persistent interface that extends non-persistent interface

2007-07-28 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-509: --- Attachment: (was: company_ds_jdo.patch) Enhancement failure on persistent interface that extends

[jira] Updated: (JDO-509) Enhancement failure on persistent interface that extends non-persistent interface

2007-07-28 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-509: --- Attachment: company_ds_jdo.patch Updated patch for datastoreidentity pc/company/package.jdo to fix

Company model : concrete classes and use of field-type

2007-07-27 Thread Andy Jefferson
Hi, I just looked through the company model and noted that the concrete classes now have some fields marked with field-type in the XML (e.g Company.address). Why? The field has its own type so there is no need to specify that. It is typically for use where a field is an interface and so to

src/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCDSProject.java

2007-07-27 Thread Andy Jefferson
This file seems to be missing @Persistent(table=project_reviewer) against the field reviewers. Hopefully some kind person will add it ;-) -- Andy  (Java Persistent Objects - http://www.jpox.org)

Re: Company model : concrete classes and use of field-type

2007-07-27 Thread Andy Jefferson
Hi Craig, Looking briefly, it looks like the only cases are for the embedded Address field. Is this what you are referring to? That's the one I spotted and didn't look further. PS. api2 seems to be missing a couple of files being checked in for a working build

Re: JDO TCK Conference Call Friday, July 27, 9 am PDT

2007-07-27 Thread Andy Jefferson
[From Craig, by email]: The tck with annotations isn't working yet, although it does get past the enhancement step. There are issues with relationships and embedded null values. Hi all, I ran the TCK today (with latest JPOX CVS) and all annotations tests pass except for the

Re: Embedding fields of non-persistent types even when field-type is used

2007-07-27 Thread Andy Jefferson
Hi Craig, Michelle, The problem is that if you declare the PI* address property in PICompany as PIAddress getAddress() void setAddress(PIAddress) then it doesn't implement ICompany any more, since you also need these from the ICompany interface: IAddress getAddress() void

[jira] Created: (JDO-511) Add extensions element to @Join, @Element, @Key, @Value, @DatastoreIdentity, ...

2007-07-26 Thread Andy Jefferson (JIRA)
Issue Type: Improvement Components: api2 Reporter: Andy Jefferson Fix For: JDO 2 maintenance release 1 Vendors have their own extensions to various XML metadata elements and it is desirable for these to be usable with annotations. @PersistenceCapable

Re: [VOTE] remove @Field and @Property; add @Persistent

2007-07-25 Thread Andy Jefferson
Recently we updated the change list: Add Persistent[] members() default {} to @PersistenceCapable Added back PersistenceModifier persistenceModifier() to @Persistent If others agree, please vote. +1 -- Andy

Re: [jira] Commented: (JDO-510) Remove @Field and @Property and replace them with @Persistent

2007-07-25 Thread Andy Jefferson
Hi Craig, Given that we had fieldType and fieldTypes in @Field and @Property, and type and types in @Element, @Key, and @Value, I made them consistent by changing types to boundTypes in @Element, @Key, and @Value. Is this what we want? Or should we change boundTypes back to types for all

Re: Annotations for embedded Key, Value, and Element

2007-07-25 Thread Andy Jefferson
Hi Craig, I disagree on that placement of the other flags, back on to @Field/@Property. They relate specifically to the element, key, value so keep them on the associated annotation would be my vote. So then it really comes down to namings of the global flag, and the mapping details 1.

[jira] Commented: (JDO-509) Enhancement failure on persistent interface that extends non-persistent interface

2007-07-23 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514695 ] Andy Jefferson commented on JDO-509: Hi Michelle, I don't understand the current situation. Have you checked

[jira] Commented: (JDO-509) Enhancement failure on persistent interface that extends non-persistent interface

2007-07-23 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514720 ] Andy Jefferson commented on JDO-509: Wish I hadn't done that svn update now. src/conf/configurations.list refers

[jira] Commented: (JDO-509) Enhancement failure on persistent interface that extends non-persistent interface

2007-07-23 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514738 ] Andy Jefferson commented on JDO-509: Thx. Taking the actual issue a little further, you're overriding the field

Re: JDO TCK Conference Call Friday, July 20, 9 am PDT

2007-07-21 Thread Andy Jefferson
The only reason to have PersistenceModifier at all is to make it possible to say @Persistent (persistenceModifier=PersistenceModifier.NONE) or @Persistent (persistenceModifier=PersistenceModifier.TRANSACTIONAL). It can be removed without loss of functionality. It *cannot* be removed with no

Re: JDO TCK Conference Call Friday, July 20, 9 am PDT

2007-07-21 Thread Andy Jefferson
Hi Craig, This brings up a question. In JPOX, if you enhance a class with a field that is NotPersistent, can you then in an embedded use case mark the same field as Persistent? The only situation I'd currently thought of (but never tried) would be of not persisting a field that had been

Re: Annotations for embedded Key, Value, and Element

2007-07-19 Thread Andy Jefferson
On 19 July 2007, Craig L Russell wrote: Hi Andy, On Jul 18, 2007, at 10:09 PM, Andy Jefferson wrote: Hi Craig, The only thing needed is the Embedded[] embedded() default {} element of @Key, @Value, and @Element, replacing the String embedded() that I think has no use here

Re: DISCUSS remove @Field and @Property; add @Persistent

2007-07-19 Thread Andy Jefferson
Have I ever told you how much I *hate* using @Transient to describe @NotPersistent? Transient is a serialization concept and I have no trouble with a field that is both transient and persistent. That is, not serialized but stored in the database. So calling something @Transient is a big ugly

Re: Annotations for embedded Key, Value, and Element

2007-07-18 Thread Andy Jefferson
The only thing needed is the Embedded[] embedded() default {} element of @Key, @Value, and @Element, replacing the String embedded() that I think has no use here. @Element embedded (String) has the same use as collection embedded-element=... -- Andy  (Java Persistent Objects -

Re: DISCUSS remove @Field and @Property; add @Persistent

2007-07-18 Thread Andy Jefferson
Hi Craig, It might be a good time (as we're almost done with this) to replace @Field and @Property with @Persistent. That would make it easier to describe that either a field or property is being described. While I agree totally with merging @Field and @Property, the use of @Persistent is

Re: DISCUSS remove @Field and @Property; add @Persistent

2007-07-18 Thread Andy Jefferson
Hi Craig, @PersistenceCapable public class MyClass { @Persistent(persistenceModifier=FieldPersistenceModifier.NONE) } Doesn't bother me as much as duplicating Field/Property all over. Me neither, but have to play devils advocate ;-) This is another anomaly:

Re: Minor: change String[ ] fields( ) to Field[ ] fields( ) in @Index and @Unique

2007-07-18 Thread Andy Jefferson
Hi Craig, And fields() has type String[ ]. Now that we have the ability to put a name into Property and Field, should we change String[ ] fields() default { } When specifying an index/unique with fields (or properties) would anyone specify more than just the field names? The field itself is

Re: Annotations for embedded Key, Value, and Element

2007-07-18 Thread Andy Jefferson
Hi Craig, The only thing needed is the Embedded[] embedded() default {} element of @Key, @Value, and @Element, replacing the String embedded() that I think has no use here. @Element embedded (String) has the same use as collection embedded-element=... Yes, this is part of the

Re: DISCUSS remove @Field and @Property; add @Persistent

2007-07-18 Thread Andy Jefferson
Overriding inherited fields :- One other area if you really want to provide annotations with the full capability that XML has. In XML you can override (inherited) fields persistence specifications in subclasses. With Annotations this currently isn't possible. This could be remedied by

[jira] Commented: (JDO-481) Enhancement of a PC abstract class fails

2007-07-17 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513202 ] Andy Jefferson commented on JDO-481: To reproduce, run the following and check the enhancer logs. Yes I did

[jira] Commented: (JDO-509) Enhancement failure on persistent interface that extends non-persistent interface

2007-07-17 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513203 ] Andy Jefferson commented on JDO-509: And how do I reproduce this ? Enhancement failure on persistent interface

Re: JDO Spec clarifications for mapping metadata

2007-07-16 Thread Andy Jefferson
3. Provide a way to specify the foreign key name for a Field and Property annotation, e.g. String foreignKey(). Or @ForeignKey(name=MY_FK) on the field/property. 4. Provide a way to specify the unique key constraint name for Field and Property annotation, e.g. String uniqueKey(). This

[jira] Commented: (JDO-496) Add just name property to PMF, in addition to persistenceUnitName

2007-07-10 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511496 ] Andy Jefferson commented on JDO-496: Are we ready for this? JPOX is ready and has been for a while. Does anyone

[jira] Updated: (JDO-508) Typo: Constants.PMF_ATTRIBUTE_ServerTimeZoneID should be Constants.PMF_ATTRIBUTE_SERVER_TIME_ZONE_ID

2007-07-05 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-508: --- Attachment: servertimezone.patch No idea if that patch was applied or not but all I know after checking

[jira] Commented: (JDO-403) JDO2 Annotations

2007-07-04 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510075 ] Andy Jefferson commented on JDO-403: We are missing the references to ForeignKey, Index, and Unique

[jira] Updated: (JDO-403) JDO2 Annotations

2007-07-04 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-403: --- Attachment: (was: tck2a.patch) JDO2 Annotations Key: JDO-403

[jira] Updated: (JDO-403) JDO2 Annotations

2007-07-04 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-403: --- Attachment: (was: tck2b.patch) JDO2 Annotations Key: JDO-403

[jira] Updated: (JDO-403) JDO2 Annotations

2007-07-04 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-403: --- Attachment: api2_property_table.patch Patch to add table attribute to @Property JDO2 Annotations

[jira] Updated: (JDO-403) JDO2 Annotations

2007-07-04 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-403: --- Attachment: tck2b.patch tck2a.patch Updated patches for tck2 project for migration

[jira] Resolved: (JDO-504) Completeness test with 1-many relationships fails with annotations

2007-07-04 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson resolved JDO-504. Resolution: Fixed Fix Version/s: JDO 2 maintenance release 1 Passes with the patches in JDO

[jira] Resolved: (JDO-506) Completeness test with all relationships fails with annotations

2007-07-04 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson resolved JDO-506. Resolution: Fixed Fix Version/s: JDO 2 maintenance release 1 Passes with the patches in JDO

[jira] Updated: (JDO-403) JDO2 Annotations

2007-07-04 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-403: --- Attachment: (was: tck2a.patch) JDO2 Annotations Key: JDO-403

[jira] Updated: (JDO-403) JDO2 Annotations

2007-07-04 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Jefferson updated JDO-403: --- Attachment: tck2a.patch Updated app-id annotations schema table names JDO2 Annotations

[jira] Commented: (JDO-507) Completeness test for persistent interface fails with annotations

2007-07-04 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510227 ] Andy Jefferson commented on JDO-507: In the PI* classes under src/java/org/apache/jdo/tck/pc/companyAnnotatedDS

[jira] Commented: (JDO-403) JDO2 Annotations

2007-07-03 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509756 ] Andy Jefferson commented on JDO-403: I thought I had already explained why @Table, @SecondaryTable, @JoinTable

[jira] Commented: (JDO-504) Completeness test with 1-many relationships fails with annotations

2007-07-03 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509757 ] Andy Jefferson commented on JDO-504: Well before you get to that test, how exactly do they get enhanced ? since

[jira] Commented: (JDO-507) Completeness test for persistent interface fails with annotations

2007-07-03 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509759 ] Andy Jefferson commented on JDO-507: I closed that JPOX JIRA a few days ago. @PersistentInterface, @Property

[jira] Commented: (JDO-504) Completeness test with 1-many relationships fails with annotations

2007-07-03 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509908 ] Andy Jefferson commented on JDO-504: The enhancement definitely happens Really? Invoking maven -o

[jira] Commented: (JDO-504) Completeness test with 1-many relationships fails with annotations

2007-07-03 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509933 ] Andy Jefferson commented on JDO-504: Thx, enhances now. Completeness test with 1-many relationships fails

<    4   5   6   7   8   9   10   11   12   13   >