Re: Issue with enhancement of annotations

2017-07-21 Thread Craig Russell
Hi Andy, > On Jul 21, 2017, at 8:05 AM, Andy Jefferson wrote: > >> I updated the pom.xml to 5.1.1-SNAPSHOT and the enhancer step worked but >> many tck tests fail. [1] > > I'd suggest that is down to whatever is different in your TCK from the SVN > trunk TCK ... Clearly this is the case. The

Re: Issue with enhancement of annotations

2017-07-21 Thread Andy Jefferson
> I updated the pom.xml to 5.1.1-SNAPSHOT and the enhancer step worked but > many tck tests fail. [1] I'd suggest that is down to whatever is different in your TCK from the SVN trunk TCK ... because SVN trunk works fine with current DN code, and the only change in my fix is ignoring classes that

Re: Issue with enhancement of annotations

2017-07-21 Thread Craig Russell
Hi Andy, > On Jul 20, 2017, at 11:40 PM, Andy Jefferson wrote: > > Hi Craig, > >> It looks like the DN enhancer recognizes the annotation as a >> persistence-capable class because it is annotated with PersistenceCapable >> but doesn't recognize it as an annotation that should not be enhanced. >

Re: Issue with enhancement of annotations

2017-07-21 Thread Andy Jefferson
Hi Craig, > It looks like the DN enhancer recognizes the annotation as a > persistence-capable class because it is annotated with PersistenceCapable > but doesn't recognize it as an annotation that should not be enhanced. Quite probably. I've only been enhancing through a persistence.xml file re

Re: Issue with enhancement of annotations

2017-07-20 Thread Craig Russell
I experimented with putting the annotations into a different directory that has nothing but annotations. Even though the annotations are only referenced by their use in persistent classes, the DataNucleus enhancer still wants to enhance them. [ERROR] Failed to execute goal org.apache.jdo:jdo-ex

Re: Issue with enhancement of annotations

2017-07-20 Thread Craig Russell
Hi Andy, It looks like the DN enhancer recognizes the annotation as a persistence-capable class because it is annotated with PersistenceCapable but doesn't recognize it as an annotation that should not be enhanced. I looked at the code and think that perhaps a patch like this would fix it. org.

Issue with enhancement of annotations

2017-07-19 Thread Craig Russell
Hi, I'm trying to run the tck including this composite annotation: @Target(ElementType.TYPE) @Retention(RetentionPolicy.RUNTIME) @javax.jdo.annotations.PersistenceCapable(detachable="true", identityType=IdentityType.DATASTORE) @javax.jdo.annotations.DatastoreIdentity(strategy=IdGeneratorStrategy