Re: Commit loss status update

2013-11-12 Thread Luca Milanesio
Hi Kohsuke, that's really good news ! I would like once again to publicly apologise with all the Jenkins Developers Community for the inconvenience caused by my forced push on the 10th of November. The problem was caused by the unfortunate combination of fatal mistakes on my side: not the tool'

control of community-contributed localization

2013-11-12 Thread Роман Каган
Hi, I've upgraded to 1.539 and discovered that russian localization is seriously spoiled. Some labels contain offensive words (!), some don't match the original, some are plain garbage. They were introduced by commit 7828dcb46d9a18f88cc8e71046edc9ee91ed95e6 Author: Kohsuke Kawaguchi Date:

Re: Commit loss status update

2013-11-12 Thread Kohsuke Kawaguchi
I merged the three repositories and pushed new master. > puppet-jenkins view-job-filters-plugin xvnc-plugin This concludes the data recovery. All the commits have been restored, all the branches have been updated, and there's no action needed by anyone. That said, it'd be great if people c

Re: Commit loss status update

2013-11-12 Thread Kohsuke Kawaguchi
On 11/12/2013 05:51 PM, Kohsuke Kawaguchi wrote: The following repositories did not take the fast-forwarding: error: failed to push some refs to 'g...@github.com:jenkinsci/conditional-buildstep-plugin.git' error: failed to push some refs to 'g...@github.com:jenkinsci/copyartifact-plugin.git'

Commit loss status update

2013-11-12 Thread Kohsuke Kawaguchi
Luca and I took the conversation to IRC. Based on the list I created we are reasonably confident that we recovered all the lost commits at this point. The following two repositories has the correct 'recovery' branch pointing to the commit just prior to "git push -f". The original list fro

Re: maven-plugin tests not running or..?

2013-11-12 Thread Marcelo
Marco, Recently I noticed that after the build 29the maven-plugin depends on org.jenkins-ci.plugins:plugin:1.538 instead of version 1.532. This version change modify some behaviors of test executions, in particular the parallelism

Re: Commits and refs affected by "git push -f"

2013-11-12 Thread Luca Milanesio
Hi Kohsuke, see below my feedback. On 12 Nov 2013, at 23:38, Kohsuke Kawaguchi wrote: > On 11/12/2013 03:13 PM, Luca Milanesio wrote: >> d) The repos with not enough history or depth >> >> None of those repositories were in the list of the 186 ones mentioned: can't >> find any of them on my lo

Re: Commits and refs affected by "git push -f"

2013-11-12 Thread Kohsuke Kawaguchi
Can you come over to the IRC channel so that we can talk in real time? See http://jenkins-ci.org/content/chat for instructions. On 11/12/2013 03:43 PM, lucamilanesio wrote: Hi Kohsuke, I agree with your conclusions ... that was my impression as well when I was analysing the 54 repos with pre =

Re: Commits and refs affected by "git push -f"

2013-11-12 Thread lucamilanesio
Good news: I managed to create a branch based on a generic SHA1 directly from the GitHub GUI. This allows us to set labels to the pre-push SHA1 for fetching and recovering them. @Kohsuke: do you want me to create those labels on the mentioned projects ? humbug-plugin => *OLD* (pointing the post

Re: Commits and refs affected by "git push -f"

2013-11-12 Thread lucamilanesio
Hi Kohsuke, I agree with your conclusions ... that was my impression as well when I was analysing the 54 repos with pre = post: possibly Nathan thought that no other pushes were made after my forced push on Sunday. One more detail about the 4 discrepancies on the pre-push SHA1: comparing the pre

Re: Commits and refs affected by "git push -f"

2013-11-12 Thread Kohsuke Kawaguchi
On 11/12/2013 03:13 PM, Luca Milanesio wrote: d) The repos with not enough history or depth None of those repositories were in the list of the 186 ones mentioned: can't find any of them on my logs. This means that in the event time window captured by GitHub there wasn't any activity related to

WEB-INF/lib location

2013-11-12 Thread Greg Peters
Is there a way to get runtime access to the WEB-INF/lib folder of Jenkins. Something similar to Servlet.getRealPath()... I'm trying to load third party jar libraries at runtime and validate that are loaded. Any ideas? -- You received this message because you are subscribed to the Google Group

Re: Commits and refs affected by "git push -f"

2013-11-12 Thread Kohsuke Kawaguchi
On 11/12/2013 02:34 PM, Luca Milanesio wrote: I will cross-check with the list provided by GitHub. (was doing a similar exercise on the suspect 54 repos anyway) Yes, please cross check to validate my sanity. I've compared this list with the CSV file from GitHub that you posted earlier. The pr

Re: Commits and refs affected by "git push -f"

2013-11-12 Thread Luca Milanesio
Cross-checking the two lists I have noticed: a) The list from GitHub has lots of apparently incorrect post-push SHA-1 according to Kohsuke's list (88 repos) b) With regards to the pre-push SHA-1, the two lists are almost identical with the following 4 exceptions: git-client-plugin => pre-push

Re: Commits and refs affected by "git push -f"

2013-11-12 Thread Luca Milanesio
I will cross-check with the list provided by GitHub. (was doing a similar exercise on the suspect 54 repos anyway) Luca. On 12 Nov 2013, at 21:27, Kohsuke Kawaguchi wrote: > > As I suggested in the e-mail thread, I've written a little program that looks > at the GitHub events API to figure ou

Commits and refs affected by "git push -f"

2013-11-12 Thread Kohsuke Kawaguchi
As I suggested in the e-mail thread, I've written a little program that looks at the GitHub events API to figure out the push activities from Luca, and assembled a list of refs and affected commits. The result is in [1]. The exact code is at [2], and I invite others to check my sanity. The

Re: Recovery step #2:

2013-11-12 Thread Kohsuke Kawaguchi
Since this CSV file and the 'recovery' branch created by GitHub support doesn't appear to be complete, I'm putting this on hold for now. On 11/11/2013 06:13 PM, Kohsuke Kawaguchi wrote: Any more sanity checks on this course of action before I actually run them? I've only heard from Arnaud.

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Kohsuke Kawaguchi
Indeed, looking at https://api.github.com/repos/jenkinsci/scoring-load-balancer-plugin/events, I see that Luca's push had changed master from 0ca553b933521ba82746a491b3c29d8c6cc2ae89 to 634609e0e7ffe754f1ec3fed8871a89f7403508b. So there's something wrong with the list provided by GitHub...

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Kohsuke Kawaguchi
Hi, Hugo, From what I can tell, those repositories are in the CSV file provided by GitHub, and their commits do seem to be in the 'recovery' branch. So those are already accounted for. Right now we are focusing on either repositories that are not in the CSV file, or the commits that are not

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Hugo Arès
The build-pipeline-plugin is missing the last 2 commits: commit 220610b7683b7ca40b6b470bc0b33191c140841a Merge: 64db20c d9a6545 Author: geoffbullen <...> Date: Mon Nov 4 14:25:50 2013 -0800 Merge pull request #18 from jglick/lower-core-dep Drop core dependency to 1.509 (LTS line).

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Hugo Arès
The git-plugin is missing at least one commit: commit 1e894cd9ce564c2ed8e1283b091b1105512efcdd Author: Stephen Connolly <...> Date: Fri Nov 8 15:51:49 2013 + switch to c:select to support in-place addition of credentials On Tuesday, November 12, 2013 3:27:33 PM UTC-5, lucamilanesio wro

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Luca Milanesio
I'm just checking using the GitHub GUI, will not push anything :-) I am trying the get the final list of repos that would need further fixing. Then would leave to the plugin maintainer to judge which is the latest, as it was not detected by the GitHub support team. Luca - Sent from my

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Slide
Please don't run any more scripts :-). The email-ext-plugin is just fine, please take it off your list for needing recovery. On Tue, Nov 12, 2013 at 12:35 PM, Luca Milanesio wrote: > I've checked as well and tfs-plugin was in the list of recovered repos but > I can't find the recovery branch eit

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Luca Milanesio
Ah ok :-) that is clarified then ! I'm looking now the list of 54 repos to see if they have been already fixed by their maintainers Will provide further updates later. Luca - Sent from my iPhone Luca Milanesio Skype: lucamilanesio On 12 Nov 2013, at 19:44, Kohsuke Kawaguchi wrot

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Kohsuke Kawaguchi
The tfs-plugin repository that I obtained yesterday does contain the recovery branch pointing at f61f3fc4a395c40196fd51838bd4dc07b87bd139, which is the tip of the master before luca's commit according to https://api.github.com/repos/jenkinsci/tfs-plugin/events git ls-remote that I just run a

How to get push access to jenkinsci (core) -if I may

2013-11-12 Thread Marco Miller
Hi! I submitted this pull request 8 days ago and it is not merged (or reviewed) yet: https://github.com/jenkinsci/jenkins/pull/999 Hence my question: -how can I get push access to jenkinsci (core), so I can merge myself, say, after a week of pull-requesting? Big thx, Marco =) -- You received t

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Luca Milanesio
I've checked as well and tfs-plugin was in the list of recovered repos but I can't find the recovery branch either: https://api.github.com/repos/jenkinsci/tfs-plugin/branches/recovery Will run a quick script for assess the situation with the others. In the meantime I've extracted the lists of re

[no subject]

2013-11-12 Thread Peter Liljenberg
I've written a simple Jenkins plugin to fail builds when code quality decreases (test coverage, static analysis), not sure if this exists already? If not I would like to make it available to the community, the code is hosted on GitHub under my name ( https://github.com/pliljenberg/build-regression

Re: Commit loss prevention

2013-11-12 Thread Slide
+1 On Nov 12, 2013 9:48 AM, "Stephen Connolly" wrote: > I am less keen on Gerrit. If anything this recent experience has me > feeling that I don;t want Gerrit anywhere near my workflow > > > On 12 November 2013 15:43, Kevin Fleming (BLOOMBERG/ 731 LEXIN) < > kpflem...@bloomberg.net> wrote: > >> W

Re: Commit loss prevention

2013-11-12 Thread Stephen Connolly
I am less keen on Gerrit. If anything this recent experience has me feeling that I don;t want Gerrit anywhere near my workflow On 12 November 2013 15:43, Kevin Fleming (BLOOMBERG/ 731 LEXIN) < kpflem...@bloomberg.net> wrote: > Well, that would mean that merging a pull request on GitHub (especial

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Kohsuke Kawaguchi
GitHub has the event API that shows activities in a given repository and organization. The documentation page says only up to 300 can be retrieved, and so the events in the org no longer seems to contain the push from luca. But when I look at the repository, I can still see those pushes. For exam

Re: Get file path to Jelly file for a plugin.

2013-11-12 Thread Thomas Åkerlund
I solved it! I used: The ${instance.action} returns the instance of the sub-plugin class that extended my plugin class. Thanks for all the help! Den tisdagen den 12:e november 2013 kl. 15:33:13 UTC+1 skrev Thomas Åkerlund: > > Hi, > > Im not sure, I tried that example and I get the error: > >

Re: Get file path to Jelly file for a plugin.

2013-11-12 Thread Thomas Åkerlund
I solved it! :D worked! Thanks for all the responses! Den tisdagen den 12:e november 2013 kl. 15:33:13 UTC+1 skrev Thomas Åkerlund: > > Hi, > > Im not sure, I tried that example and I get the error: > > No page found 'action.jelly' for class > hudson.model.FreeStyleProject > The tag looks l

Re: Commit loss prevention

2013-11-12 Thread Kevin Fleming (BLOOMBERG/ 731 LEXIN)
Well, that would mean that merging a pull request on GitHub (especially the quick way, using the web UI) wouldn't update the canonical repository; the repo maintainer would need to push that change to the canonical repository, potentially dealing with a second round of merge conflicts if that re

Re: Can't Push To Git

2013-11-12 Thread Ulli Hafner
No. Since the repository name was missing in the other post you were only granted access to existing repositories. Now a new github repository has been created at https://github.com/jenkinsci/websphere-deployer-plugin Welcome aboard! Ulli Am 12.11.2013 um 15:47 schrieb Greg Peters : > I'm try

Re: Commit loss prevention

2013-11-12 Thread Stephen Connolly
On 12 November 2013 14:40, Kevin Fleming (BLOOMBERG/ 731 LEXIN) < kpflem...@bloomberg.net> wrote: > When you say 'canonical' in this proposal, do you mean the repositories > used for making releases > I mean that they are the "official" repositories and all others are just mirrors... this is the

Re: Requesting GIT Commit Access

2013-11-12 Thread Greg Peters
I have not published or committed yet because a repo hasn't been created yet. The plugin repo should be 'websphere-deployer.git'. A new thread has been started about my connectivity issues to Git because of the missing repo. Please disregard this thread an use the newer more recent post. On Mo

Can't Push To Git

2013-11-12 Thread Greg Peters
I'm trying to push a new plugin to Git but the repository doesn't exist. I executed: *git remote add origin g...@github.com:jenkinsci/websphere-deployer.git* Was the repository not created under jenkins-ci? Please advise. -- You received this message because you are subscribed to the Google G

Re: Commit loss prevention

2013-11-12 Thread Kevin Fleming (BLOOMBERG/ 731 LEXIN)
When you say 'canonical' in this proposal, do you mean the repositories used for making releases, or the repositories where development (and especially, pull requests) would be handled? If it's the former, I could see that being worthwhile, especially if *nobody* has permissions to push to the

Re: Get file path to Jelly file for a plugin.

2013-11-12 Thread Thomas Åkerlund
Hi, Im not sure, I tried that example and I get the error: No page found 'action.jelly' for class hudson.model.FreeStyleProject The tag looks like: I wonder if it has something to do with the class that I return from ${it.action}. The class that I return is the class defined in the other plu

Re: Get file path to Jelly file for a plugin.

2013-11-12 Thread Vivekanand S V
does thishelp you ? On Tue, Nov 12, 2013 at 7:34 PM, Thomas Åkerlund wrote: > For some reason the call to getActions() does'nt even happen. Is there any > concrete examples which are not just

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Andrew Melo
On Tue, Nov 12, 2013 at 2:04 AM, Wes Turner wrote: > There are fine-grained "File and branch conditions" in mercurial-server > that can prevent these sorts of pushes from succeeding. [1] > > [1] http://dev.lshift.net/paul/mercurial-server/docbook.html#id160 The same functionality exists in

Re: Get file path to Jelly file for a plugin.

2013-11-12 Thread Thomas Åkerlund
For some reason the call to getActions() does'nt even happen. Is there any concrete examples which are not just an abstract class but an actual implementation of the "load jelly file from another plugin"? Den tisdagen den 12:e november 2013 kl. 14:42:44 UTC+1 skrev slide: > > Try turning optiona

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Olivier Dagenais
Hi, I learned of this situation last night. I'm the [current] maintainer of the tfs-plugin and I don't see commits since I released version 2.0, nor do I see a 'recovery' branch at https://github.com/jenkinsci/tfs-plugin The machine I last made release 3.0.1 from has a clone with the 24 missin

Re: Get file path to Jelly file for a plugin.

2013-11-12 Thread Slide
Try turning optional to false and seeing what error is generated, it can help determine what you are missing. On Tue, Nov 12, 2013 at 6:34 AM, Thomas Åkerlund wrote: > I cant seem to get it to work. > The extension I have, have implemented Action. All overrided methods from > the Action implemen

Re: Get file path to Jelly file for a plugin.

2013-11-12 Thread Thomas Åkerlund
I cant seem to get it to work. The extension I have, have implemented Action. All overrided methods from the Action implementation returns null but the sub-plugin that implements my extention has a jelly file named action.jelly. According to https://wiki.jenkins-ci.org/display/JENKINS/Action+and

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Luca Milanesio
Looking again at the list right now: there are a few in the same situation :-( Luca - Sent from my iPhone Luca Milanesio Skype: lucamilanesio On 12 Nov 2013, at 12:16, Ikedam wrote: > Unfortunately, there may be something wrong with this list... > > scoring-load-balancer-plugin have s

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Ikedam
Unfortunately, there may be something wrong with this list... scoring-load-balancer-plugin have same orig_master and forced_master, 634609e. And the version in its pom.xml is 1.0.1-SNAPSHOT. But I have released scoring-load-balancer-1.0.1 last week. The latest commit should be: https://github.c

Re: Commit loss prevention

2013-11-12 Thread Dariusz Łuksza
In CollabNet we already implemented so called History Protection. We already put some thoughts on this topic and come up with solution for unintended force pushes and branch deletion. Maybe you can reuse some of our approaches. Here is short description of this feature. History Protection it is

Re: Commit loss prevention

2013-11-12 Thread Stephen Connolly
I think part of the issue is that our canonical repositories are on github... I would favour jenkins-ci.org being masters of its own destiny... hence I would recommend hosting canonical repos on project owned hardware and using GIT as a mirror of those canonical repositories... much like the way A

Re: Commit loss prevention

2013-11-12 Thread Christopher Orr
On 12/11/13 07:25, Kohsuke Kawaguchi wrote: I still feel strongly that we maintain the open commit access policy. This is how we've been operating for the longest time, and it's also because otherwise adding/removing developers to repositories would be prohibitively tedious. I agree that the po

Re: Get file path to Jelly file for a plugin.

2013-11-12 Thread Daniel Beck
There are numerous examples of this in the Jenkins source code. One is in AbstractBuild's index.jelly, including actions' summary.jelly to the main page of the build: https://github.com/jenkinsci/jenkins/blob/stable/core/src/main/resources/hudson/model/AbstractBuild

Re: Get file path to Jelly file for a plugin.

2013-11-12 Thread Vincent Latombe
Have a look at [1] [1] http://stapler.kohsuke.org/jelly-taglib-ref.html#jelly:include Vincent 2013/11/12 Thomas Åkerlund > Hi! > > I have written a plugin that extends Builder. I have then created an > extention point for other plugins to use. I want to reference those > sub-plugins specific

Get file path to Jelly file for a plugin.

2013-11-12 Thread Thomas Åkerlund
Hi! I have written a plugin that extends Builder. I have then created an extention point for other plugins to use. I want to reference those sub-plugins specific jelly file from the "main-plugins" jelly file. I know how to do a forEach and get the data etc. What I don't know is how to get the

Re: AW - *PLEASE READ* Re: strange pushes on GitHub

2013-11-12 Thread Wes Turner
> I can't imagine GitHub have much incentive to > implement the type of fine-grained force-push permissions we would need There are fine-grained "File and branch conditions" in mercurial-server that can prevent these sorts of pushes from succeeding. [1] [1] http://dev.lshift.net/paul/mercurial-