Re: Implementing a new Step for 'Pipeline Artifact Promotion' Plugin

2019-06-12 Thread prastik Gyawali
yes 'Void' should be returned. Thank You! On Wednesday, June 12, 2019 at 8:38:24 PM UTC+5:45, Jesse Glick wrote: > > On Tue, Jun 11, 2019 at 6:09 PM prastik Gyawali > > wrote: > > 1) What should be the implementation/use of the Execution class > here?(Its return type- a badge?) > > If it is to

Re: Request for copy-editor permissions for github.com/jenkins-infra/jenkins.io

2019-06-12 Thread Tracy Miranda
Thanks for the votes of confidence all. This has now been resolved and I will use my new powers wisely. On Wed, 12 Jun 2019, 11:40 Parker Ennis, wrote: > +1 for sure! > > On Thu, Jun 6, 2019 at 9:38 PM Liam Newman wrote: > >> Absolutely +1. Surprised you don't already have it. >> >> On Thu, Ju

Re: Request to be made a maintainer - cucumber-slack-notifier-plugin

2019-06-12 Thread slide
We're almost a month on from my update request...anyone in contact with Gareth? Does he want to continue to maintain the plugin? On Tuesday, May 14, 2019 at 7:44:23 AM UTC-7, slide wrote: > > Any updates on this? > > On Fri, Apr 26, 2019 at 3:01 AM James Nord wrote: > >> I've contacted Gareth -

Re: FilePath.act question

2019-06-12 Thread varun vikas
Thanks RobertI have missed generics on FileCallable...it fixed the error. On Wed, 12 Jun 2019, 19:02 Robert Sandell, wrote: > Probably missed the generics on FileCallable > > implements FileCallable> { > > though you should probably use MasterToSlaveFileCallable instead of the > base one.

Re: Creating an env variable via API

2019-06-12 Thread Parichay Barpanda
Just recorrecting myself here. I misconfused global properties with environment variables. Joseph Peterson clarified to me later. So I guess the previous method is not how it works with JCasC. Thanks. On Wednesday, June 12, 2019 at 6:50:46 AM UTC+5:30, Parichay Barpanda wrote: > > I found this

Re: Request for copy-editor permissions for github.com/jenkins-infra/jenkins.io

2019-06-12 Thread Parker Ennis
+1 for sure! On Thu, Jun 6, 2019 at 9:38 PM Liam Newman wrote: > Absolutely +1. Surprised you don't already have it. > > On Thu, Jun 6, 2019 at 5:23 PM Rick wrote: > >> +1 from me >> >> On Fri, Jun 7, 2019 at 7:25 AM Alyssa Tong wrote: >> >>> +1 from me as well. Tracy's help will help to move

Re: Accessing PR head commit sha from a pipeline using branch source plugin

2019-06-12 Thread Jesse Glick
On Wed, Jun 12, 2019 at 3:56 AM Julien HENRY wrote: > Would you be ok to accept a contribution from SonarSource where we would add > a new env variable (like CHANGE_COMMIT) to expose the PR head commit sha to > the pipeline? We are interested to support both GitHub and Bitbucket, so we > would

Re: Implementing a new Step for 'Pipeline Artifact Promotion' Plugin

2019-06-12 Thread Jesse Glick
On Tue, Jun 11, 2019 at 6:09 PM prastik Gyawali wrote: > 1) What should be the implementation/use of the Execution class here?(Its > return type- a badge?) If it is to be used from Declarative, normally the return type will be `Void`, since only a Scripted Pipeline could assign a return value to

Re: FilePath.act question

2019-06-12 Thread Robert Sandell
Probably missed the generics on FileCallable implements FileCallable> { though you should probably use MasterToSlaveFileCallable instead of the base one. /B Den ons 12 juni 2019 kl 11:22 skrev varun vikas : > @old hooky >> > what should be return type of > > public List invoke(File ws, Virtua

Re: Maintainer for Log Parser Plugin

2019-06-12 Thread Martin Reinhardt
looking forward to friday ;) Am Mittwoch, 12. Juni 2019 09:28:57 UTC+2 schrieb Jon Brohauge: > > Hi Martin > > Thank you for stepping up to be a maintainer of this plugin. Can't wait > for the PR's to roll onto master ;-) > > regards > Jon > > On Sunday, June 2, 2019 at 7:33:45 PM UTC+2, Martin R

Re: FilePath.act question

2019-06-12 Thread varun vikas
> > @old hooky > what should be return type of public List invoke(File ws, VirtualChannel channel) function. Here it is throwing error , attempting to use incompatible return type. I have defined a inner class private static final class AttachmentLister implements FileCallable{ @override publi

Re: Publishing plugin use a bad url

2019-06-12 Thread Thomas POUIT
Hello, Thank you slide, you're right: I was missing the whole scm section in my pom! Now it's working. It's my first release... Thank you also Jesse: I see from your link that I can use a netbeans plugin for developing Jenkins plugins. I will test it. Thank you both :-) -- You received this m

Re: Accessing PR head commit sha from a pipeline using branch source plugin

2019-06-12 Thread Julien HENRY
Hi Jesse, Our users are strongly asking for a better support of PR status update by SonarQube/SonarCloud when build is triggered by Jenkins. We don't like the try-fail strategy (trying to annotate current commit, then fallback on parent). Would you be ok to accept a contribution from SonarSourc

Re: Maintainer for Log Parser Plugin

2019-06-12 Thread Jon Brohauge
Hi Martin Thank you for stepping up to be a maintainer of this plugin. Can't wait for the PR's to roll onto master ;-) regards Jon On Sunday, June 2, 2019 at 7:33:45 PM UTC+2, Martin Reinhardt wrote: > > Hi Mike, > > thanks for assisting here. > > My GitHub username is hypery2k > > And me Jenki