Re: [PROPOSAL] Extract `hudson.node_monitors` in a new dedicated plugin

2016-01-23 Thread Baptiste Mathus
Hi, followup and questions 2016-01-15 17:56 GMT+01:00 Jesse Glick : > On Fri, Jan 15, 2016 at 9:16 AM, Baptiste Mathus wrote: > > there are many dependencies in the core classes to those > (AbstractProject, > > Computer, ComputerSet. Node...). > > The `AbstractProject` usage is pretty trivial, c

Re: [PROPOSAL] Extract `hudson.node_monitors` in a new dedicated plugin

2016-01-22 Thread Jesse Glick
On Fri, Jan 22, 2016 at 5:25 AM, Daniel Beck wrote: >> • Keep the extension points in the core => Anybody can use the stuff > > Why? They'll have an implied dependency on the detached plugin anyway. Right, this makes no sense. The viable options are: · Keep the extension points and invoca

Re: [PROPOSAL] Extract `hudson.node_monitors` in a new dedicated plugin

2016-01-22 Thread Daniel Beck
On 22.01.2016, at 09:47, Oleg Nenashev wrote: > • Keep the extension points in the core => Anybody can use the stuff Why? They'll have an implied dependency on the detached plugin anyway. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers"

Re: [PROPOSAL] Extract `hudson.node_monitors` in a new dedicated plugin

2016-01-22 Thread Oleg Nenashev
> > So, at least at first, my *current* thought would be to keep only in the > core the following classes (from the node_monitors package) > >- AbstractNodeMonitorDescriptor.java >- MonitorMarkedNodeOffline.java >- NodeMonitor.java >- NodeMonitorUpdater.java > > I'm totally fine w

Re: [PROPOSAL] Extract `hudson.node_monitors` in a new dedicated plugin

2016-01-15 Thread Baptiste Mathus
2016-01-15 17:56 GMT+01:00 Jesse Glick : > On Fri, Jan 15, 2016 at 9:16 AM, Baptiste Mathus wrote: > > there are many dependencies in the core classes to those > (AbstractProject, > > Computer, ComputerSet. Node...). > > The `AbstractProject` usage is pretty trivial, could be deleted IMO. > So b

Re: [PROPOSAL] Extract `hudson.node_monitors` in a new dedicated plugin

2016-01-15 Thread Jesse Glick
On Fri, Jan 15, 2016 at 9:16 AM, Baptiste Mathus wrote: > there are many dependencies in the core classes to those (AbstractProject, > Computer, ComputerSet. Node...). The `AbstractProject` usage is pretty trivial, could be deleted IMO. Looking at `ComputerSet`, it is mostly about node monitors,

Re: [PROPOSAL] Extract `hudson.node_monitors` in a new dedicated plugin

2016-01-15 Thread Baptiste Mathus
Hi Oleg, Yeah, I didn't really ignore your question on purpose. Just forgot about it, sorry about that. Also my main goal in this thread was mainly to validate the idea of the extraction, and I thought we would then discuss more precisely those things as we go. Anyway, in the meantime, as I've st

Re: [PROPOSAL] Extract `hudson.node_monitors` in a new dedicated plugin

2016-01-15 Thread Oleg Nenashev
Hi Baptiste, There was a question regarding the decoupling approach. What are we going too do with monitoring periodic works and NodeMonitor > APIs? > >- We can leave them in the Core >- We can move them into the plugin as well > > I think it still deserves some discussion среда, 13 ян

Re: [PROPOSAL] Extract `hudson.node_monitors` in a new dedicated plugin

2016-01-13 Thread Baptiste Mathus
Done https://wiki.jenkins-ci.org/display/JENKINS/Split+plugin+from+core copied and reformatted a bit Jesse's email. 2016-01-13 21:24 GMT+01:00 Stephen Connolly : > You should put this procedure on the wiki > > > On Wednesday, 13 January 2016, Jesse Glick wrote: > >> On Tue, Jan 12, 2016 at 3:33

Re: [PROPOSAL] Extract `hudson.node_monitors` in a new dedicated plugin

2016-01-13 Thread Stephen Connolly
You should put this procedure on the wiki On Wednesday, 13 January 2016, Jesse Glick wrote: > On Tue, Jan 12, 2016 at 3:33 PM, Baptiste Mathus > wrote: > > the proposal is basically to remove the hudson.node_monitors package > > from the core, and make that a new plugin > > https://issues.jenki

Re: [PROPOSAL] Extract `hudson.node_monitors` in a new dedicated plugin

2016-01-13 Thread Baptiste Mathus
2016-01-13 19:21 GMT+01:00 Jesse Glick : > On Tue, Jan 12, 2016 at 3:33 PM, Baptiste Mathus wrote: > > the proposal is basically to remove the hudson.node_monitors package > > from the core, and make that a new plugin > > https://issues.jenkins-ci.org/browse/JENKINS-26466 you mean? > Absolutely.

Re: [PROPOSAL] Extract `hudson.node_monitors` in a new dedicated plugin

2016-01-13 Thread Jesse Glick
On Tue, Jan 12, 2016 at 3:33 PM, Baptiste Mathus wrote: > the proposal is basically to remove the hudson.node_monitors package > from the core, and make that a new plugin https://issues.jenkins-ci.org/browse/JENKINS-26466 you mean? > I'm willing to work on that one Great, anyone willing to take

Re: [PROPOSAL] Extract `hudson.node_monitors` in a new dedicated plugin

2016-01-12 Thread Oleg Nenashev
Definitely +1 if we keep it as a bundled plugin. What are we going too do with monitoring periodic works and NodeMonitor APIs? - We can leave them in the Core - We can move them into the plugin as well The second approach looks to be more generic since we suffer from performance impac

[PROPOSAL] Extract `hudson.node_monitors` in a new dedicated plugin

2016-01-12 Thread Baptiste Mathus
Hi everyone, Some context: - In the past few days, I've been working on JENKINS-24278 to add inodes usage monitoring to Jenkins. That initially resulted in the creation of a new dedicated plugin