On Mon, Jun 30, 2014 at 3:27 PM, Kohsuke Kawaguchi wrote:
> it's bit painful to require such a cutting edge version. But it's tolerable.
>
> I wonder if it's possible to do that as an optional feature
Is it really worth jumping through hoops, and making the code more
complicated, just to avoid de
Oops the pr is
https://github.com/jenkinsci/github-oauth-plugin/pull/26
On Monday, June 30, 2014 2:27:59 PM UTC-5, Kohsuke Kawaguchi wrote:
>
> Hmm, tough call. IIUC, multiple other plugins depend on
> github-oauth-plugin, so it's bit painful to require such a cutting edge
> version. But it's
>It's bit hackish, but if you copy SecurityListener class definition
verbatim into github-oauth-plugin in the "jenkins.security" package and put
@Extension(optional=true) to your implementation, then it'd work. >When
running in >=1.569 SecurityListener from the core will hide your private
copy,
Hmm, tough call. IIUC, multiple other plugins depend on
github-oauth-plugin, so it's bit painful to require such a cutting edge
version. But it's tolerable.
I wonder if it's possible to do that as an optional feature --- that if you
run on >=1.569 you get that functionality, but it still degrades
