Refactoring some Subversion code into core

2012-12-06 Thread Dean Yu
Hi folks, specifically rpetti and kutzi, I'd like to do some work to provide a post-commit hook for the Perforce plugin[1]. Looking through that code base, it's looks like it started life modeled on the Subversion plugin, but it has diverged significantly. I'm not going to attempt to rationali

Re: Refactoring some Subversion code into core

2012-12-06 Thread Christoph Kutzinski
Sounds like this makes sense. I guess this code should be generic enough, so that any SCM plugin could profit from it. I've something similar in the Git-plugin - which probably also originated from the svn-plugin, but has since then diverged. Another alternative would be to offer a shared 'abs

Re: Refactoring some Subversion code into core

2012-12-06 Thread Dean Yu
I'm not a big fan of the shared plugin model. As a user, I've gotten bitten way to many times by compatibility problems this causes. -- Dean On 12/6/12 2:16 PM, "Christoph Kutzinski" wrote: >Sounds like this makes sense. >I guess this code should be generic enough, so that any SCM plugin coul

Re: Refactoring some Subversion code into core

2012-12-06 Thread Jesse Glick
On 12/06/2012 08:03 PM, Dean Yu wrote: I'm not a big fan of the shared plugin model. As a user, I've gotten bitten way to many times by compatibility problems this causes. Then report those problems and drive them to get fixed please! We should be moving in the direction of more modularization

Re: Refactoring some Subversion code into core

2012-12-07 Thread Dean Yu
On 12/6/12 6:31 PM, "Jesse Glick" wrote: >On 12/06/2012 08:03 PM, Dean Yu wrote: >> I'm not a big fan of the shared plugin model. As a user, I've gotten >> bitten way to many times by compatibility problems this causes. > >Then report those problems and drive them to get fixed please! We should >

Re: Refactoring some Subversion code into core

2012-12-07 Thread Jesse Glick
On 12/07/2012 03:06 PM, Dean Yu wrote: As a user, I may not be aware of the interrelationships between plugins. Nor should you need to be. I could upgrade a leaf plugin, which requires a newer version of a base plugin I hope in this case the Jenkins plugin manager will force you to upgrade