Re: InternalError on Class.getPackage()

2015-10-19 Thread Mandy Chung
> On Oct 19, 2015, at 6:04 PM, Alan Bateman wrote: > > On 19/10/2015 22:58, Mandy Chung wrote: >> Hi Chris, >> >> Thanks for reporting this (this is not a known issue). >> >> java.lang.InternalError: unnamed package in named module java.base >> >> The case with the unnamed package defined by

hg: jigsaw/jake/jdk: Improve error message in Class.getPackage to help troubeshooting

2015-10-19 Thread mandy . chung
Changeset: d7adac71ce63 Author:mchung Date: 2015-10-19 18:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d7adac71ce63 Improve error message in Class.getPackage to help troubeshooting ! src/java.base/share/classes/jdk/internal/misc/BuiltinClassLoader.java

Re: InternalError on Class.getPackage()

2015-10-19 Thread Alan Bateman
On 19/10/2015 22:58, Mandy Chung wrote: Hi Chris, Thanks for reporting this (this is not a known issue). java.lang.InternalError: unnamed package in named module java.base The case with the unnamed package defined by the boot loader is the types from -Xbootclasspath/a. Is -Xbootclasspath/a b

Re: jmx-dev RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-19 Thread Mandy Chung
> On Oct 16, 2015, at 5:04 AM, Jaroslav Bachorik > wrote: > > On 15.10.2015 21:32, Alan Bateman wrote: >> >> On 15/10/2015 16:55, Jaroslav Bachorik wrote: >>> >>> Any objections to changing the annotation name to @ConstructorMapping >>> to make it better distinguishable from >>> @java.beans.C

Re: jmx-dev RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-19 Thread Alan Bateman
On 16/10/2015 13:04, Jaroslav Bachorik wrote: : I have decided for @ConstructorParameters - it is rather close to the original @ConstructorProperties and corresponds to the annotation purpose. I tried to address all the comments gathered in this review. The updated webrev is http://cr.openj

Re: non-API classes displayed by jrt filesystem

2015-10-19 Thread Alan Bateman
On 19/10/2015 18:41, Uwe Schindler wrote: Hi, As a tool developer (in my case it's the "forbidden-apis" tool [*], used to disallow certain API signatures in compiled code), it would also be good to allow differentiating between real JDK runtime modules (those that are public and part of the J

Re: InternalError on Class.getPackage()

2015-10-19 Thread Mandy Chung
Hi Chris, Thanks for reporting this (this is not a known issue). java.lang.InternalError: unnamed package in named module java.base The case with the unnamed package defined by the boot loader is the types from -Xbootclasspath/a. Is -Xbootclasspath/a being used? Mandy On 10/19/2015 02:50 P

InternalError on Class.getPackage()

2015-10-19 Thread Chris Newland
Hi, Reported initially to Quality Outreach via https://groups.google.com/forum/#!topic/jitwatch/gh3Ybdd4A84 Failed to instantiate [ch.qos.logback.classic.LoggerContext] Reported exception: java.lang.InternalError: unnamed package in named module java.base at jdk.internal.misc.BuiltinClass

hg: jigsaw/jake/hotspot: Fix for 8081403. Problem caused by JVM not properly handling module jdk.proxy1's version string of length zero.

2015-10-19 Thread harold . seigel
Changeset: 9d03e40fb80d Author:hseigel Date: 2015-10-19 14:22 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/9d03e40fb80d Fix for 8081403. Problem caused by JVM not properly handling module jdk.proxy1's version string of length zero. ! src/share/vm/classfile/module

RE: non-API classes displayed by jrt filesystem

2015-10-19 Thread Uwe Schindler
Hi, As a tool developer (in my case it's the "forbidden-apis" tool [*], used to disallow certain API signatures in compiled code), it would also be good to allow differentiating between real JDK runtime modules (those that are public and part of the JDK) from those which are 3rd party plugins m

Re: non-API classes displayed by jrt filesystem

2015-10-19 Thread Jonathan Gibbons
On 10/19/2015 06:57 AM, Alan Bateman wrote: On 19/10/2015 13:12, Philippe Marschall wrote: Hi I'm toying around with the jrt filesystem [1]. I noted that non-API classes are shown for java modules (see attachment). I assume this is because jrt currently reports all classes in a module, not

Re: Review request for 8139508 Debug option does not work in appletviewer

2015-10-19 Thread Alan Bateman
On 19/10/2015 14:33, Alexander Scherbatiy wrote: I do not have the full answer for this. At least the appletviewer uses the same debugger as jdb and it could be removed together with jdb once it becomes obsolete. I'm not aware of any specific plans to drop jdb. On appletviewer -debug th

hg: jigsaw/jake/jdk: 3 new changesets

2015-10-19 Thread alan . bateman
Changeset: b9faea9a4ea2 Author:alanb Date: 2015-10-19 15:20 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b9faea9a4ea2 No need to keep copy of packages when adding packages for dyanmic proxies Contributed: claes.redes...@oracle.com, alan.bate...@oracle.com ! src/java.ba

hg: jigsaw/jake/langtools: 15 new changesets

2015-10-19 Thread chris . hegarty
Changeset: 6fdfa77ddeed Author:aeremeev Date: 2015-09-28 13:23 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/6fdfa77ddeed 8081472: Add a mode to the tests for class-file attributes which dumps in-memory sources to disk Reviewed-by: ksrini ! test/tools/javac/class

Re: non-API classes displayed by jrt filesystem

2015-10-19 Thread Alan Bateman
On 19/10/2015 13:12, Philippe Marschall wrote: Hi I'm toying around with the jrt filesystem [1]. I noted that non-API classes are shown for java modules (see attachment). I assume this is because jrt currently reports all classes in a module, not just the exported ones (and these classes are

hg: jigsaw/jake/hotspot: 20 new changesets

2015-10-19 Thread chris . hegarty
Changeset: 2acd6706667f Author:jwilhelm Date: 2015-09-15 15:49 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/2acd6706667f Merge Changeset: 42f7bd6a45c4 Author:kbarrett Date: 2015-09-16 16:25 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/r

hg: jigsaw/jake/jdk: 64 new changesets

2015-10-19 Thread chris . hegarty
Changeset: 6532ebf82a57 Author:erikj Date: 2015-09-28 09:52 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/6532ebf82a57 8137088: Drop building of interim_java.corba Reviewed-by: alanb, ihse ! make/rmic/RmicCommon.gmk Changeset: dd3b7365c85e Author:erikj Date: 2

hg: jigsaw/jake/nashorn: 18 new changesets

2015-10-19 Thread chris . hegarty
Changeset: f436923c391f Author:attila Date: 2015-09-28 08:40 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/f436923c391f 8134502: introduce abstraction for basic NodeVisitor usage Reviewed-by: lagergren, sundar ! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/ap

hg: jigsaw/jake/jaxws: 5 new changesets

2015-10-19 Thread chris . hegarty
Changeset: 7774118e162b Author:mkos Date: 2015-10-02 14:36 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/7774118e162b 8061466: RELAX NG API visible but not accessible Reviewed-by: alanb ! src/jdk.xml.bind/share/classes/com/sun/tools/internal/xjc/Language.java ! src/j

hg: jigsaw/jake: 20 new changesets

2015-10-19 Thread chris . hegarty
Changeset: adc5d60c2f5c Author:erikj Date: 2015-09-28 09:52 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/adc5d60c2f5c 8137088: Drop building of interim_java.corba Reviewed-by: alanb, ihse ! common/autoconf/spec.gmk.in ! make/Main.gmk ! make/common/RMICompilation.gmk Chang

hg: jigsaw/jake/corba: 6 new changesets

2015-10-19 Thread chris . hegarty
Changeset: 0002c1d8220f Author:erikj Date: 2015-09-28 09:52 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/0002c1d8220f 8137088: Drop building of interim_java.corba Reviewed-by: alanb, ihse - make/CompileInterim.gmk Changeset: 1ee087da34d5 Author:chegar Date:

hg: jigsaw/jake/jaxp: 4 new changesets

2015-10-19 Thread chris . hegarty
Changeset: 1d9850c1b35c Author:joehw Date: 2015-10-06 10:59 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/1d9850c1b35c 8138721: ElementTraversal: javadoc warning; also, hasFeature shall return true Reviewed-by: lancea, dfuchs ! src/java.xml/share/classes/com/sun/org/a

Re: Review request for 8139508 Debug option does not work in appletviewer

2015-10-19 Thread Alexander Scherbatiy
On 10/13/2015 5:00 PM, Alan Bateman wrote: On 13/10/2015 14:33, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8139508 webrev: http://cr.openjdk.java.net/~alexsch/8139508/webrev.00 This is the fix for the appletviewer which ca

Re: non-API classes displayed by jrt filesystem

2015-10-19 Thread Sundararajan Athijegannathan
Hi, The situation is not different from, say, zip/jar file system - that file system too exposes *all* underlying resources via file system. All .class resources - package private classes, anonymous inner classes etc. are exposed. Language notions like public/package-private/anonymous etc. ha

non-API classes displayed by jrt filesystem

2015-10-19 Thread Philippe Marschall
Hi I'm toying around with the jrt filesystem [1]. I noted that non-API classes are shown for java modules (see attachment). I assume this is because jrt currently reports all classes in a module, not just the exported ones (and these classes are not exported). Assuming this is the intended be