Re: RFR: 8130054: javax/naming/module/basic.sh needs to be headless

2016-01-26 Thread Alan Bateman
Vinnie - would you have cycles to look at this for John? Changing it to anything serializable that allows the test to run on a headless machine should be fine. Also he will need to remove it from the exclude list (ProblemList.jake.txt) before it will run. -Alan On 27/01/2016 04:58, John Ji

RFR: 8130054: javax/naming/module/basic.sh needs to be headless

2016-01-26 Thread John Jiang
Hi, Please review the fix for JDK-8130054. The test is using java.awt.event.ActionEvent instead of java.awt.Button. Issue: https://bugs.openjdk.java.net/browse/JDK-8130054 Webrev: http://cr.openjdk.java.net/~jjiang/8130054/webrev.00/ Best regards, John Jiang

hg: jigsaw/jake/jdk: Fix PackageInfoTest.java test to use -Xpatch

2016-01-26 Thread mandy . chung
Changeset: f96ec238e684 Author:mchung Date: 2016-01-26 14:53 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f96ec238e684 Fix PackageInfoTest.java test to use -Xpatch ! test/java/lang/Package/annotation/PackageInfoTest.java + test/java/lang/Package/annotation/jdk.xml.dom/

hg: jigsaw/jake/jdk: More micro-optimization

2016-01-26 Thread mandy . chung
Changeset: 521b1e2b3ffb Author:redestad Date: 2016-01-26 10:16 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/521b1e2b3ffb More micro-optimization ! src/java.base/share/classes/java/lang/module/ModuleDescriptor.java

hg: jigsaw/jake/jdk: Further micro-optimization

2016-01-26 Thread alan . bateman
Changeset: ef69a6691c10 Author:redestad Date: 2016-01-26 17:43 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ef69a6691c10 Further micro-optimization ! src/java.base/share/classes/java/lang/module/Configuration.java ! src/java.base/share/classes/java/lang/module/ModuleRe

Re: RFR: 8068938: Test deploying a XML parser as a module

2016-01-26 Thread huizhe wang
Hi Felix, I would feel sorry for Frank since at the time we wanted all tests to be hosted in the JAXP repo. I understand the intention to consolidate repos as Alan suggested. However, if the JAXP repo is not hampering JDK development, I'd prefer an independent JAXP repo as is since it made JA

Re: Round #4: RFR: 8049365 - Update JDI and JDWP for modules

2016-01-26 Thread serguei.spit...@oracle.com
Thank you for reviews and comments, Lois! Serguei On 1/26/16 04:47, Lois Foltan wrote: On 1/26/2016 6:48 AM, serguei.spit...@oracle.com wrote: Please, review this initial fix for the M4 Jigsaw task: https://bugs.openjdk.java.net/browse/JDK-8049365 Jdk webrev: http://cr.openjdk.java.net/~ssp

Re: Round #4: RFR: 8049365 - Update JDI and JDWP for modules

2016-01-26 Thread serguei.spit...@oracle.com
Thanks, Alan! I'm Ok with the tweaks you suggest before the push. Thanks, Serguei On 1/26/16 04:45, Alan Bateman wrote: On 26/01/2016 11:48, serguei.spit...@oracle.com wrote: Please, review this initial fix for the M4 Jigsaw task: https://bugs.openjdk.java.net/browse/JDK-8049365 Jdk webre

hg: jigsaw/jake/hotspot: 8132924: [TESTBUG] hotspot jtreg test test/runtime/BadObjectClass/BootstrapRedefine.java fails with NPE in javac (in Jake)

2016-01-26 Thread christian . tornqvist
Changeset: f5d3c0433447 Author:ctornqvi Date: 2016-01-26 08:41 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/f5d3c0433447 8132924: [TESTBUG] hotspot jtreg test test/runtime/BadObjectClass/BootstrapRedefine.java fails with NPE in javac (in Jake) ! test/runtime/BadO

hg: jigsaw/jake/hotspot: Add @ignore tags to failing compiler tests

2016-01-26 Thread christian . tornqvist
Changeset: f66eed1eec93 Author:ctornqvi Date: 2016-01-26 08:11 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/f66eed1eec93 Add @ignore tags to failing compiler tests ! test/compiler/intrinsics/unsafe/TestUnsafeUnalignedMismatchedAccesses.java ! test/compiler/jvmci/er

hg: jigsaw/jake/jdk: Initial debugger support for modules

2016-01-26 Thread alan . bateman
Changeset: 83af44f6b786 Author:alanb Date: 2016-01-26 13:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/83af44f6b786 Initial debugger support for modules Contributed-by: serguei.spit...@oracle.com ! make/data/jdwp/jdwp.spec + make/src/classes/build/tools/jdwpgen/Modul

hg: jigsaw/jake/hotspot: Initial debugger support for modules

2016-01-26 Thread alan . bateman
Changeset: 7c6b363ca926 Author:alanb Date: 2016-01-26 13:05 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/7c6b363ca926 Initial debugger support for modules Contributed-by: serguei.spit...@oracle.com ! src/share/vm/prims/jvmti.xml ! src/share/vm/prims/jvmtiEnv.cpp !

Re: Round #4: RFR: 8049365 - Update JDI and JDWP for modules

2016-01-26 Thread Lois Foltan
On 1/26/2016 6:48 AM, serguei.spit...@oracle.com wrote: Please, review this initial fix for the M4 Jigsaw task: https://bugs.openjdk.java.net/browse/JDK-8049365 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8049365-Jigsaw-jdk.4/ Hotspot webrev: http://cr.openjdk.java.net/~

Re: Round #4: RFR: 8049365 - Update JDI and JDWP for modules

2016-01-26 Thread Alan Bateman
On 26/01/2016 11:48, serguei.spit...@oracle.com wrote: Please, review this initial fix for the M4 Jigsaw task: https://bugs.openjdk.java.net/browse/JDK-8049365 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8049365-Jigsaw-jdk.4/ Hotspot webrev: http://cr.openjdk.java.net/~s

Round #4: RFR: 8049365 - Update JDI and JDWP for modules

2016-01-26 Thread serguei.spit...@oracle.com
Please, review this initial fix for the M4 Jigsaw task: https://bugs.openjdk.java.net/browse/JDK-8049365 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8049365-Jigsaw-jdk.4/ Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8049365-Jigsaw-hs.4/ Summa

Re: Round #3: RFR: 8049365 - Update JDI and JDWP for modules

2016-01-26 Thread serguei.spit...@oracle.com
Hi Alan, On 1/23/16 02:35, Alan Bateman wrote: On 22/01/2016 22:16, serguei.spit...@oracle.com wrote: : Jdk webrev: cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8049365-Jigsaw-jdk.3/ Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8049365-Jigsaw-hs.3/ Good to see