Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-17 Thread Mandy Chung
> On Feb 17, 2016, at 8:04 PM, Wang Weijun wrote: > >> >> On Feb 18, 2016, at 9:21 AM, Mandy Chung wrote: >> >>> >>> On Feb 17, 2016, at 4:46 PM, Wang Weijun wrote: >>> >>> On Feb 18, 2016, at 5:15 AM, Mandy Chung wrote: Can I say -providerClass -providerArg is equivale

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-17 Thread Wang Weijun
> On Feb 18, 2016, at 9:21 AM, Mandy Chung wrote: > >> >> On Feb 17, 2016, at 4:46 PM, Wang Weijun wrote: >> >> >>> On Feb 18, 2016, at 5:15 AM, Mandy Chung wrote: >>> >>> Can I say -providerClass -providerArg is equivalent to >>> extending java.security to add “security.provider.N=NAME

Re: [9] RFR 8134487:updated sun/security/ssl/StatusStapling/* to work with modules

2016-02-17 Thread Tim Du
On 2/17/2016 11:40 PM, Alan Bateman wrote: On 17/02/2016 09:57, Tim Du wrote: Sure. I am aslo updated java.base/sun/security/testlibrary to test/java/security/testlibrary/ , so that keep the testlibrary files could be reused by other tests. Re-generate the latest webrev is http://cr.openjdk.j

hg: jigsaw/jake/jdk: Enable jlink & jimages tests to run on JPRT and installed JDK bundle

2016-02-17 Thread mandy . chung
Changeset: 001cae2e19ce Author:mchung Date: 2016-02-17 17:30 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/001cae2e19ce Enable jlink & jimages tests to run on JPRT and installed JDK bundle ! test/jdk/jigsaw/tools/jlink/asmplugin/AsmPluginTestBase.java ! test/jdk/jigsaw/

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-17 Thread Mandy Chung
> On Feb 17, 2016, at 4:46 PM, Wang Weijun wrote: > > >> On Feb 18, 2016, at 5:15 AM, Mandy Chung wrote: >> >> Can I say -providerClass -providerArg is equivalent to >> extending java.security to add “security.provider.N=NAME ARG”? > > Yes. > >> >> I suggest to keep -providerClass and -

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-17 Thread Wang Weijun
> On Feb 18, 2016, at 5:15 AM, Mandy Chung wrote: > > Can I say -providerClass -providerArg is equivalent to extending > java.security to add “security.provider.N=NAME ARG”? Yes. > > I suggest to keep -providerClass and -providerArg only for legacy security > provider (i.e. not a service

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-17 Thread Mandy Chung
> On Feb 16, 2016, at 5:20 PM, Weijun Wang wrote: > > > > On 2/16/2016 22:54, Alan Bateman wrote: >> >> On 16/02/2016 14:44, Weijun Wang wrote: >>> Please review the code change at >>> >>> http://cr.openjdk.java.net/~weijun/8130302/webrev.00/ >>> >>> I didn't abandon -providerClass and go

hg: jigsaw/jake/jdk: 8150092: Named modules should not be able to access types from classpath. (adjusting jdk tests)

2016-02-17 Thread jan . lahoda
Changeset: bb550b381d37 Author:jlahoda Date: 2016-02-17 21:37 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/bb550b381d37 8150092: Named modules should not be able to access types from classpath. (adjusting jdk tests) ! test/jdk/jigsaw/launcher/addreads/AddReadsTest.jav

hg: jigsaw/jake/langtools: 8150092: Named modules should not be able to access types from classpath.

2016-02-17 Thread jan . lahoda
Changeset: 1da86e0c5315 Author:jlahoda Date: 2016-02-17 21:36 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/1da86e0c5315 8150092: Named modules should not be able to access types from classpath. ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/ModuleFinde

hg: jigsaw/jake/jdk: 2 new changesets

2016-02-17 Thread alan . bateman
Changeset: d8b4666c6abe Author:alanb Date: 2016-02-17 18:34 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d8b4666c6abe Add ModuleDescriptor::isSynthetic ! src/java.base/share/classes/java/lang/module/ModuleDescriptor.java ! src/java.base/share/classes/java/lang/module/M

hg: jigsaw/jake/hotspot: Missing exports to java.rmi for RMI to serialize its types

2016-02-17 Thread mandy . chung
Changeset: c466cbb53ee8 Author:mchung Date: 2016-02-17 08:49 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/c466cbb53ee8 Missing exports to java.rmi for RMI to serialize its types ! src/jdk.hotspot.agent/share/classes/module-info.java

Re: [9] RFR 8134487:updated sun/security/ssl/StatusStapling/* to work with modules

2016-02-17 Thread Alan Bateman
On 17/02/2016 09:57, Tim Du wrote: Sure. I am aslo updated java.base/sun/security/testlibrary to test/java/security/testlibrary/ , so that keep the testlibrary files could be reused by other tests. Re-generate the latest webrev is http://cr.openjdk.java.net/~tidu/8134487/webrev.03/ , Thanks.

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-17 Thread Weijun Wang
On 2/17/2016 18:33, Alan Bateman wrote: On 17/02/2016 01:20, Weijun Wang wrote: : Technically they are independent. With -providerClass/-providerArg, the provider is added into system and getInstance() calls (of keyStore, KeyPairGenerator, etc) can use it. On the other hand, -providerName c

hg: jigsaw/jake/jdk: Removed jlink -o option, added -G option for string debug information

2016-02-17 Thread sundararajan . athijegannathan
Changeset: 83fb2d1195da Author:sundar Date: 2016-02-17 17:12 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/83fb2d1195da Removed jlink -o option, added -G option for string debug information ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java ! src/jdk

hg: jigsaw/jake/langtools: Adding bug numbers to some excluded tests, enabling ProfileOptionTest

2016-02-17 Thread jan . lahoda
Changeset: 8e441ecbc324 Author:jlahoda Date: 2016-02-17 11:48 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8e441ecbc324 Adding bug numbers to some excluded tests, enabling ProfileOptionTest ! test/ProblemList.jake.txt

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-17 Thread Alan Bateman
On 17/02/2016 01:20, Weijun Wang wrote: : Technically they are independent. With -providerClass/-providerArg, the provider is added into system and getInstance() calls (of keyStore, KeyPairGenerator, etc) can use it. On the other hand, -providerName can be used to specifically tell KeyPairG

Re: [9] RFR 8134487:updated sun/security/ssl/StatusStapling/* to work with modules

2016-02-17 Thread Alan Bateman
On 17/02/2016 09:57, Tim Du wrote: Sure. I am aslo updated java.base/sun/security/testlibrary to test/java/security/testlibrary/ , so that keep the testlibrary files could be reused by other tests. Re-generate the latest webrev is http://cr.openjdk.java.net/~tidu/8134487/webrev.03/ , Thanks

Re: [9] RFR 8134487:updated sun/security/ssl/StatusStapling/* to work with modules

2016-02-17 Thread Tim Du
On 2/17/2016 4:23 PM, Alan Bateman wrote: On 17/02/2016 08:19, Tim Du wrote: Follow you suggestion, I updated the code as below: 1.Create java.base/sun/security/ssl under test/sun/security/ssl/StatusStapling/, move all test files and dependency class into java.base/sun/security/ssl ,removed

Re: [9] RFR 8134487:updated sun/security/ssl/StatusStapling/* to work with modules

2016-02-17 Thread Alan Bateman
On 17/02/2016 08:19, Tim Du wrote: Follow you suggestion, I updated the code as below: 1.Create java.base/sun/security/ssl under test/sun/security/ssl/StatusStapling/, move all test files and dependency class into java.base/sun/security/ssl ,removed the jtreg label from test java files. 2.Cr

Re: [9] RFR 8134487:updated sun/security/ssl/StatusStapling/* to work with modules

2016-02-17 Thread Tim Du
Hi Alan: On 2/16/2016 7:25 PM, Alan Bateman wrote: On 16/02/2016 11:05, Tim Du wrote: Hi Alan: I tried @compile/module to fix this issue before, but it does not work ,Use CertStatusReqExtensionTests.java as example, the process as below: 1. Create java.base/sun/security/ssl folder in test