Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-22 Thread Mandy Chung
> On Feb 22, 2016, at 7:28 PM, Wang Weijun wrote: > > Webrev updated at http://cr.openjdk.java.net/~weijun/8130302/webrev.03/. > > -provider and loadProviderByName() are useless for jdk9/dev, and > loadProviderByClass() only uses reflection. > I reviewed the provider loading part and looks g

RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-02-22 Thread Felix Yang
Please review the following new test. Webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8141609 jdk 9 bundled a "jrt-fs.jar" file which expose the jrt filesystem support. It is critical that a tool on JDK 8 can use the jrt file system

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-22 Thread Wang Weijun
Webrev updated at http://cr.openjdk.java.net/~weijun/8130302/webrev.03/. -provider and loadProviderByName() are useless for jdk9/dev, and loadProviderByClass() only uses reflection. The SunPKCS11 compatibility line will be add in a sub-patch for jake. --Max > On Feb 23, 2016, at 10:25 AM, Wan

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-22 Thread Wang Weijun
>> >> You mean not supporting all pre-loaded providers in modules, but only one or >> two popular ones? >> > > I meant not support -providerClass for arbitrary providers loaded via service > loader. The only exception is SunPKCS11. In other words, -providerClass can > only be used to load l

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-22 Thread Mandy Chung
> On Feb 22, 2016, at 5:55 PM, Wang Weijun wrote: > 303 // A provider in module can also be use class name 304 if (p.getClass().getName().equals(provClass)) { ProviderConfig::getProvider doesn’t compare the classname. I thought we agree to

hg: jigsaw/jake/langtools: allow unset/0 entries in TargetPlatform attribute

2016-02-22 Thread jonathan . gibbons
Changeset: 4dbbaf7a0699 Author:jjg Date: 2016-02-22 18:00 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4dbbaf7a0699 allow unset/0 entries in TargetPlatform attribute ! src/jdk.jdeps/share/classes/com/sun/tools/javap/AttributeWriter.java

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-22 Thread Wang Weijun
>>> >>> 303 // A provider in module can also be use class name >>> 304 if (p.getClass().getName().equals(provClass)) { >>> >>> ProviderConfig::getProvider doesn’t compare the classname. I thought we >>> agree to discourage the use of -providerClass to load a provider and

hg: jigsaw/jake/langtools: add support for new-style -XaddExports -XaddReads in javac

2016-02-22 Thread jonathan . gibbons
Changeset: fc4c2f3a8b21 Author:jjg Date: 2016-02-22 17:42 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/fc4c2f3a8b21 add support for new-style -XaddExports -XaddReads in javac ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java ! src/jdk.compile

Re: modulepath and classpath mixture

2016-02-22 Thread Jonathan Gibbons
On 02/22/2016 12:44 PM, Robert Scholte wrote: Hi, first of all I'd like to say that I'm very pleased with the new -mp options, these matches better with the way Apache Maven would like to work with jars and class-folders. Here's my use case: I noticed that if I add a module-info to src/ma

Re: modulepath and classpath mixture

2016-02-22 Thread Alex Buckley
Hi Robert, On 2/22/2016 12:44 PM, Robert Scholte wrote: Here's my use case: I noticed that if I add a module-info to src/main/java and put all compile-scoped dependencies to the module path, all compiles fines. Sounds good. I assume that developers are less interested in adding a module-info

modulepath and classpath mixture

2016-02-22 Thread Robert Scholte
Hi, first of all I'd like to say that I'm very pleased with the new -mp options, these matches better with the way Apache Maven would like to work with jars and class-folders. Here's my use case: I noticed that if I add a module-info to src/main/java and put all compile-scoped dependencie

hg: jigsaw/jake/jdk: 2 new changesets

2016-02-22 Thread mandy . chung
Changeset: 5b6e50872248 Author:naoto Date: 2016-02-19 09:55 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/5b6e50872248 8148346: Reduce number of packages in jdk.localedata module Reviewed-by: okutsu, alanb ! make/src/classes/build/tools/cldrconverter/CLDRConverter.java

hg: jigsaw/jake: Fixing JDK-8150293: open+closed jake fails on JPRT when deploy repo is not present

2016-02-22 Thread erik . joelsson
Changeset: eb5ef0636943 Author:erikj Date: 2016-02-22 22:45 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/eb5ef0636943 Fixing JDK-8150293: open+closed jake fails on JPRT when deploy repo is not present ! common/autoconf/generated-configure.sh ! common/autoconf/source-dirs.

hg: jigsaw/jake/hotspot: A module's java.lang.reflect.Module is stored in its respective class loader's ClassLoaderData's handles area, release handles area even if no classes have been defined to tha

2016-02-22 Thread lois . foltan
Changeset: 2818165971bc Author:lfoltan Date: 2016-02-22 12:04 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/2818165971bc A module's java.lang.reflect.Module is stored in its respective class loader's ClassLoaderData's handles area, release handles area even if no cl

hg: jigsaw/jake/jdk: Add JNI_AddModuleReads() and JNICanReadModule() entry points

2016-02-22 Thread harold . seigel
Changeset: 85dcecc06a9c Author:hseigel Date: 2016-02-22 11:33 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/85dcecc06a9c Add JNI_AddModuleReads() and JNICanReadModule() entry points ! src/java.base/share/native/include/jni.h

hg: jigsaw/jake/hotspot: Add JNI_AddModuleReads() and JNICanReadModule() entry points

2016-02-22 Thread harold . seigel
Changeset: 9e6121540f5a Author:hseigel Date: 2016-02-22 11:31 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/9e6121540f5a Add JNI_AddModuleReads() and JNICanReadModule() entry points ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/p

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-02-22 Thread Mandy Chung
> On Feb 21, 2016, at 1:45 AM, Wang Weijun wrote: > > >> On Feb 20, 2016, at 4:01 AM, Mandy Chung wrote: >> >> >>> On Feb 19, 2016, at 2:47 AM, Wang Weijun wrote: >>> >>> Updated at the same URL >>> >>> http://cr.openjdk.java.net/~weijun/8130302/webrev.01 >>> >>> The help looks like this

hg: jigsaw/jake/jdk: 4 new changesets

2016-02-22 Thread alan . bateman
Changeset: e82cfa3de0a3 Author:redestad Date: 2016-02-22 11:15 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e82cfa3de0a3 Change isSameClassPackage to use getPackageName ! src/java.base/share/classes/sun/reflect/Reflection.java Changeset: 230e64a81ff7 Author:alanb