On 01/04/2016 06:27, Sundararajan Athijegannathan wrote:
That is true of shell scripts too. i.e., existing code generates shell
scripts on Windows too (although those shell scripts seem to run fine
under Cygwin).
Do you think we should filter out? Cross-platform image generation scenario?
As
I think we should generate .bat on windows and shell scripts on other
platforms. Generating two scripts are confusing.
Mandy
> On Mar 31, 2016, at 10:27 PM, Sundararajan Athijegannathan
> wrote:
>
> That is true of shell scripts too. i.e., existing code generates shell
> scripts on Windows t
That is true of shell scripts too. i.e., existing code generates shell
scripts on Windows too (although those shell scripts seem to run fine
under Cygwin).
Do you think we should filter out? Cross-platform image generation scenario?
-Sundar
On 4/1/2016 10:54 AM, Mandy Chung wrote:
>> On Mar 31,
> On Mar 31, 2016, at 9:20 PM, Sundararajan Athijegannathan
> wrote:
>
> Please review the updated webrev @
> http://cr.openjdk.java.net/~sundar/8136645/webrev.02/
This version still generates .bat for all platforms as opposed to generate it
for windows only.
Mandy
Please review the updated webrev @
http://cr.openjdk.java.net/~sundar/8136645/webrev.02/
* Changed "\n" to "\r\n"
* Removed POSIX/bits change code
Thanks,
-Sundar
On 4/1/2016 8:22 AM, Sundararajan Athijegannathan wrote:
> Hi,
>
> Comments below..
>
> On 4/1/2016 3:03 AM, Dmitry Samersoff wrote:
Hi,
Comments below..
On 4/1/2016 3:03 AM, Dmitry Samersoff wrote:
> Sundararajan,
>
> Occasionally put my nose in. Just $0.2 ...
>
> 1. Do we really need separate .append("\n")? Also Windows convention is
> "\r\n"
I think so. Perhaps System.getProperty("line.separator") could be used.
I'll fix i
Changeset: 20ec0c69d3e2
Author:mchung
Date: 2016-03-31 11:49 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/20ec0c69d3e2
8153125: rmic from bootcycle build should launch with -m
jdk.rmic/sun.rmi.rmic.Main
Reviewed-by: alanb, erikj
! make/rmic/RmicCommon.gmk
Changeset:
Changeset: fb3b49e0593e
Author:mchung
Date: 2016-03-31 18:15 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/rev/fb3b49e0593e
Use jtreg 4.2 nightly
! common/conf/jib-profiles.js
Changeset: 97b420bd2845
Author:mchung
Date: 2016-03-31 14:11 -0700
URL: http://hg.open
Changeset: 38fb8799f2c1
Author:mchung
Date: 2016-03-31 11:50 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/38fb8799f2c1
8153211: Convert build tool to use the new -XaddExports syntax in bootcycle
build
Reviewed-by: alanb
! make/BuildNashorn.gmk
> On Mar 31, 2016, at 4:10 PM, Mandy Chung wrote:
>
>
>> On Mar 30, 2016, at 9:17 AM, Claes Redestad
>> wrote:
>>
>> Hi Peter,
>>
>> something like this, then:
>>
>> http://cr.openjdk.java.net/~redestad/8152641/webrev.05/
>>
>
> BoundMethodHandle::generateConcreteBMHClassBytes
> It onl
> On Mar 30, 2016, at 9:17 AM, Claes Redestad wrote:
>
> Hi Peter,
>
> something like this, then:
>
> http://cr.openjdk.java.net/~redestad/8152641/webrev.05/
>
BoundMethodHandle::generateConcreteBMHClassBytes
It only allows “LIJFD” characters. But the default species types include
digit
> On Mar 29, 2016, at 4:03 PM, Claes Redestad wrote:
>
> Mandy: I've not found any test (under jdk/test/tools/jlink or elsewhere) which
> has to be updated when adding a plugin like this.
jdk/test/tools/jlink/JLinkTest.java
This is the one I recalled. This is in the core_tools or tier2 test g
Sundararajan,
Occasionally put my nose in. Just $0.2 ...
1. Do we really need separate .append("\n")? Also Windows convention is
"\r\n"
2. Is it possible to name a module using other languages (e.g. Russian
or Japanese). Is StandardCharsets.ISO_8859_1 appropriate in this case?
3. Is PosixFileAt
On 31/03/2016 19:31, Sundararajan Athijegannathan wrote:
Please review updated webrev @
http://cr.openjdk.java.net/~sundar/8136645/webrev.01/
PS. Fixed "/" with "\" in "java" path. The generated batch file worked
in either case - but changing for consistency.
Does this generate the .bat on a
Please review updated webrev @
http://cr.openjdk.java.net/~sundar/8136645/webrev.01/
PS. Fixed "/" with "\" in "java" path. The generated batch file worked
in either case - but changing for consistency.
Thanks,
-Sundar
On 3/31/2016 11:08 PM, Sundararajan Athijegannathan wrote:
> Please review ht
Please review http://cr.openjdk.java.net/~sundar/8136645/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8136645
Thanks,
-Sundar
> On Mar 31, 2016, at 10:06 AM, Alan Bateman wrote:
>
>
> On 31/03/2016 17:56, Mandy Chung wrote:
>> A few build tools are using the old -XaddExports syntax that should switch
>> to the new syntax:
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8153211/webrev.00/
>>
>> Mandy
> This look
On 31/03/2016 17:56, Mandy Chung wrote:
A few build tools are using the old -XaddExports syntax that should switch to
the new syntax:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8153211/webrev.00/
Mandy
This looks okay, are you planning to push these to jake or jdk9/dev?
-Alan
A few build tools are using the old -XaddExports syntax that should switch to
the new syntax:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8153211/webrev.00/
Mandy
Georgiy,
Please file this as an issue against javac, and we'll take it from
there. The case of the final class has previously been considered and
considered "silly but not wrong", but the other two have not been
explicitly considered.
Alex has previously said in this forum that 'uses' and
Changeset: 4d4f3f5b215a
Author:erikj
Date: 2016-03-14 12:03 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/4d4f3f5b215a
8151619: genSocketOptionRegistry.exe always relinked on Windows
Reviewed-by: tbell
! make/lib/Lib-jdk.hotspot.agent.gmk
Changeset: 2eca85c32025
Au
Changeset: 15d52fdd9168
Author:attila
Date: 2016-03-15 16:02 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/15d52fdd9168
8150218: Autoconversion SAM adapters sometimes don't get privileges
Reviewed-by: mhaupt, sundar
! src/jdk.dynalink/share/classes/jdk/dynalink/Call
Changeset: 005df9abb92e
Author:darcy
Date: 2016-03-11 15:30 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/005df9abb92e
8151750: Mark ChangingInterests.java as intermittently failing
Reviewed-by: lancea
! test/java/nio/channels/Selector/ChangingInterests.java
Changeset:
Changeset: 4e6a73cb55da
Author:ksrini
Date: 2016-03-14 15:04 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4e6a73cb55da
8071982: Update tests for revamped Doclet API
8071984: Update test cases for repeating and type annotations output in javadoc
Reviewed-by: ksrini
Changeset: e980062475c1
Author:lana
Date: 2016-03-31 01:13 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/e980062475c1
Added tag jdk-9+112 for changeset 21274e7937ba
! .hgtags
Changeset: 2e61d618c68c
Author:alanb
Date: 2016-03-31 13:43 +0100
URL: http:/
Changeset: cc30faa2da49
Author:lana
Date: 2016-03-31 01:13 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/cc30faa2da49
Added tag jdk-9+112 for changeset 780d0620add3
! .hgtags
Changeset: de3dfa940914
Author:alanb
Date: 2016-03-31 13:44 +0100
URL: http:/
Changeset: 36326537f929
Author:joehw
Date: 2016-03-24 15:34 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/36326537f929
8151154: IllegalArgumentException not thrown when wrong syntax value is set for
javax.xml.catalog.files
Reviewed-by: lancea
! src/java.xml/share/clas
Changeset: 5d868c42d888
Author:erikj
Date: 2016-03-14 12:00 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/rev/5d868c42d888
8151619: genSocketOptionRegistry.exe always relinked on Windows
Reviewed-by: tbell
! common/autoconf/flags.m4
! common/autoconf/generated-configure.sh
! ma
Hi Paul,
No, it does not make sense, if you are writing unit tests. Unit tests often
access classes and methods that general uses of the module should not. On the
other hand, it could make perfect sense to run the code as a module in a
functional test. Functional/integration/acceptance tests sh
On 31/03/2016 11:20, Sanne Grinovero wrote:
Thanks Alex,
that clarifies a lot, I was just about to try with a different dependency.
So this is not a reflection bug, but I'm just realising now that has
quite significant impact on JavaEE:
the Synchronization type is defined as public API of the sp
Thanks Alex,
that clarifies a lot, I was just about to try with a different dependency.
So this is not a reflection bug, but I'm just realising now that has
quite significant impact on JavaEE:
the Synchronization type is defined as public API of the specification [1].
Changing the JavaEE API isn'
Hi Alan, Joe, and All
I have produced a new webrev
http://cr.openjdk.java.net/~fyuan/8078820/webrev.01/ based on your comments,
there are 2 tests:
1. BasicModularXMLParserTest.java, which is same as the previous one, tests the
customized xml provider modules in boot layer
2. LayerModularXMLPars
32 matches
Mail list logo
