On 01/05/2016 17:02, Chris Hegarty wrote:
On 1 May 2016, at 14:50, Andrej Golovnin wrote:
Hi Alan,
If you would like to improve the performance a little bit more,
you can make additional changes (see the patch) to JmodTask
and maybe Claes can rerun his tests to see if it helps.
These look go
On 02/05/2016 06:52, Andrej Golovnin wrote:
:
I don't know how often the method #deriveModuleDescriptor(JarFile)
is executed. But compiling regular expressions over and over doesn't really
helps from the performance standpoint of view:
400 Matcher matcher = Pattern.compile("-(\\d+(\\.
Changeset: 294fcc1ae09f
Author:alanb
Date: 2016-05-02 08:34 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/294fcc1ae09f
More clean-up
Contributed-by: peter.lev...@gmail.com
! src/java.base/share/classes/java/lang/module/ModulePath.java
! src/java.base/share/classes/java/
On 05/02/2016 08:24 AM, Alan Bateman wrote:
ModuleReader:
- the default method read(String name) should close the InputStream
after reading from it, shouldn't it?
Yes it should, just hasn't been noticed because each of the
implementations implement this method. I don't know if you mean to pu
> On 29 Apr 2016, at 13:38, Alan Bateman wrote:
>
> The webrevs, all repos are here:
> http://cr.openjdk.java.net/~alanb/8154956/1/
The updated changes look good to me.
-Chris.
Hello everybody,
after I gave feedback a while ago I recently revisited how to port code
generation libraries to Java 9 and unfortunately, this still does not seem
possible with the current implementation. I am speaking based on experience
with Javassist and Byte Buddy which are both broadly used
On 02/05/2016 13:51, Rafael Winterhalter wrote:
:
I am aware that the idea of project Jigsaw is encapsulation but for
scenarios like the above, it is often required to break module bondaries.
In general, I think that project Jigsaw solved this problem elegantly but
changing this single method's
On 05/02/2016 12:06 AM, Alan Bateman wrote:
On 01/05/2016 17:02, Chris Hegarty wrote:
On 1 May 2016, at 14:50, Andrej Golovnin
wrote:
Hi Alan,
If you would like to improve the performance a little bit more,
you can make additional changes (see the patch) to JmodTask
and maybe Claes can rerun
I can only agree with this.
We rely heavily on both ASM and Javassist, and resource lookup/loading
in general. While, as an agent, we can usually patch the bytecode to
poke holes where needed, having a supported way to read resource
bytes, similar to how getResourceAsStream works in jdk8, followin
Changeset: ad9a8e291a81
Author:jjg
Date: 2016-05-02 11:43 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ad9a8e291a81
tiny whitespace fix
! make/tools/crules/MutableFieldsAnalyzer.java
Hi,
Can you please take a look on:
http://cr.openjdk.java.net/~shurailine/8151914/webrev.01/
?
Thank you
Shura
> On May 2, 2016, at 1:03 PM, Alexandre (Shura) Iline
> wrote:
>
> Hi,
>
> Can you please take a look on:
> http://cr.openjdk.java.net/~shurailine/8151914/webrev.01/
> ?
Looks okay to me.
Mandy
12 matches
Mail list logo