Re: Review request: 8157068 ExceptionInInitializerError if images build patched to use exploded version of java.lang.module.SystemModules

> On May 19, 2016, at 9:19 AM, Alan Bateman wrote: > > > On 19/05/2016 15:48, Mandy Chung wrote: >> Updated webrev: >> >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8157068/webrev.01/index.html >> >> Mandy >> > This looks okay except the naming of the

Re: Review request: 8157068 ExceptionInInitializerError if images build patched to use exploded version of java.lang.module.SystemModules

On 19/05/2016 15:48, Mandy Chung wrote: Updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8157068/webrev.01/index.html Mandy This looks okay except the naming of the sub-directories (basic and SystemModules) is inconsistent. Maybe it needs to be

Re: Review request: 8157068 ExceptionInInitializerError if images build patched to use exploded version of java.lang.module.SystemModules

Updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8157068/webrev.01/index.html Mandy

Re: Fwd: Re: Modules with packages duplication

Attempt to attach zip failed. Attaching the same content as a patch files.diff. It can be "extracted" by invoking: hg init hg import files.diff -m comments On 18.05.2016 18:16, Jonathan Gibbons wrote: Without yet looking at your zip file, it is possible to compile classes that will not

Re: RFR: JDK-8156602 - javac crashes again on Windows 32-bit with ClosedChannelException

This does work for the test provided. The interrupted thread fails on the closed channel, but other theads continue to run on reopened channel. The problem with the non-interruptible I/O is the jdk8 backport issue. There is no way to use the non-interruptible read without loading new classes

Re: RFR: JDK-8156602 - javac crashes again on Windows 32-bit with ClosedChannelException

On 19/05/2016 14:03, Jim Laskey (Oracle) wrote: On 32 bit, a shared jimage channel closed by an interrupted thread (ClosedChannelException) disrupts other threads sharing jimage. Fix is to reopen channel on not interrupted thread. http://cr.openjdk.java.net/~jlaskey/8156602/webrev/index.html

Re: Review request: 8157068 ExceptionInInitializerError if images build patched to use exploded version of java.lang.module.SystemModules

> On May 18, 2016, at 11:27 PM, Alan Bateman wrote: > > On 19/05/2016 02:41, Mandy Chung wrote: >> Webrev at: >> >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8157068/webrev.00/index.html >> >> This is to allow to patch java.base with an exploded image for JDK

Re: Fwd: Re: Modules with packages duplication

I've attached zip file with test.sh renamed to test_sh, hope this will help. On 18.05.2016 18:16, Jonathan Gibbons wrote: Without yet looking at your zip file, it is possible to compile classes that will not load in the application class loader, because of the restrictions defined for the boot

RFR: JDK-8156602 - javac crashes again on Windows 32-bit with ClosedChannelException

On 32 bit, a shared jimage channel closed by an interrupted thread (ClosedChannelException) disrupts other threads sharing jimage. Fix is to reopen channel on not interrupted thread. http://cr.openjdk.java.net/~jlaskey/8156602/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8156602

RE: Compact profiles broken?

Hi, that clearly explains what we are seeing. Elasticsearch and Apache Lucene/Solr are compiled with "-source 1.8 -target 1.8" and use the compact profile settings (Lucene Core with compact1, the rest with compact3, same for Elasticsearch). This works everywhere, except for the javax crypto

Re: 8148834: Update module-info reader/writer to 53.0

On 19 May 2016, at 12:49, Alan Bateman wrote: > javac has been switched to generate v53.0 class files. ASM, pack200 and > several other areas have been updated too. We have two places in the > module-info reader/writing that needs to be updated so I need a Reviewer to

Re: 8157290: jdk/modules/scenarios/overlappingpackages/OverlappingPackagesTest.java failing

On 19 May 2016, at 11:26, Alan Bateman wrote: > > The jdk9/client -> jdk9/dev integration yesterday included the fix for > JDK-8154539 which breaks a test that has been assuming sun.misc is in > java.base. I suspect this test was missed in previous rounds that laid

Re: 8148834: Update module-info reader/writer to 53.0

+1 On 5/19/2016 5:19 PM, Alan Bateman wrote: > javac has been switched to generate v53.0 class files. ASM, pack200 > and several other areas have been updated too. We have two places in > the module-info reader/writing that needs to be updated so I need a > Reviewer to get this into jdk9/dev. >

8148834: Update module-info reader/writer to 53.0

javac has been switched to generate v53.0 class files. ASM, pack200 and several other areas have been updated too. We have two places in the module-info reader/writing that needs to be updated so I need a Reviewer to get this into jdk9/dev. -Alan diff --git

RE: Compact profiles broken?

Hi Alan, Interestingly, compiling large amounts of code with the Java SE8 option for "compact1" or "compact3" works successfully. It is just this class/package failing. How can that be? The issue is not visible to the outside (requires login). Uwe - Uwe Schindler uschind...@apache.org

Re: Compact profiles broken?

On 19/05/2016 06:49, Alan Bateman wrote: : In the mean-time then this should work: java -release 8 -profile compact3 ... or specify -limitmods, as in: java -limitmods java.compact3 ... Oops, I meant `javac` here of course (not `java`). -Alan

Re: Review request: 8157068 ExceptionInInitializerError if images build patched to use exploded version of java.lang.module.SystemModules

On 19/05/2016 02:41, Mandy Chung wrote: Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8157068/webrev.00/index.html This is to allow to patch java.base with an exploded image for JDK development purpose like this: $ images/jdk/bin/java -Xpatch:java.base=jdk/modules/java.base