Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-27 Thread Mandy Chung
> On May 27, 2016, at 1:30 AM, Tom Schindl wrote: > > Do you have an example how to construct such a Layer? // path is the path to javafx-swt.jar ModuleFinder finder = ModuleFinder.of(path); Configuration cf = Layer.boot() .configuration() .resolveRequires(finder, ModuleFinder.of(), Se

Re: RFR: 8156209 - Add argument checks to BasicImageReader calls

2016-05-27 Thread Seán Coffey
why are people slow to put context into exception messages ? Is this temporary code ? example : src/java.base/share/classes/jdk/internal/jimage/ImageStringsReader.java +if (offset < 0 || offset >= bytes.length) { +throw new IndexOutOfBoundsException("offset"); +} + +

Re: RFR: 8156209 - Add argument checks to BasicImageReader calls

2016-05-27 Thread Alan Bateman
On 27/05/2016 16:12, Jim Laskey (Oracle) wrote: http://cr.openjdk.java.net/~jlaskey/8156209/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8156209 You might want to double check the range check in ImageStringsReader.hashCode as it looks like it allows count < 0. I assume what you

Re: RFR: 8156209 - Add argument checks to BasicImageReader calls

2016-05-27 Thread Sundararajan Athijegannathan
Looks good -Sundar On 5/27/2016 8:42 PM, Jim Laskey (Oracle) wrote: > http://cr.openjdk.java.net/~jlaskey/8156209/webrev/index.html > https://bugs.openjdk.java.net/browse/JDK-8156209

RFR: 8156209 - Add argument checks to BasicImageReader calls

2016-05-27 Thread Jim Laskey (Oracle)
http://cr.openjdk.java.net/~jlaskey/8156209/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8156209

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-27 Thread Kevin Rushforth
Thanks for confirming. So it sounds like we have a workable plan. -- Kevin Alan Bateman wrote: On 27/05/2016 13:47, Kevin Rushforth wrote: The qualified exports are done using reflection to the calling module that contains the javafx.embed.swt.FXCanvas class, irrespective of the name of

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-27 Thread Alan Bateman
On 27/05/2016 13:47, Kevin Rushforth wrote: The qualified exports are done using reflection to the calling module that contains the javafx.embed.swt.FXCanvas class, irrespective of the name of the module (so it works even when the javafx.embed.swt package is in the unnamed module). I plan t

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-27 Thread Kevin Rushforth
Alan Bateman wrote: On 26/05/2016 16:38, Kevin Rushforth wrote: Yes, I've tested it in both modes (with a simple HelloFXCanvas program) -- as an automatic jar file and as just an ordinary jar on the classpath. Just curious, if there are qualified exports to javafx.swt then how it does when o

Re: Implied readability: calling toString()

2016-05-27 Thread Jochen Theodorou
On 27.05.2016 13:39, Sander Mak wrote: I'm running into the following compilation error (build 9-ea+116-2016-04-28-175027.javare.4913.nc): $ javac -modulesourcepath src -d out $(find . -name '*.java') .src/test/client/Client.java:13: error: toString() in Object is defined in an inaccessible cl

Implied readability: calling toString()

2016-05-27 Thread Sander Mak
I'm running into the following compilation error (build 9-ea+116-2016-04-28-175027.javare.4913.nc): $ javac -modulesourcepath src -d out $(find . -name '*.java') .src/test/client/Client.java:13: error: toString() in Object is defined in an inaccessible class or interface repository.findTex

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-27 Thread Alan Bateman
On 26/05/2016 16:38, Kevin Rushforth wrote: Yes, I've tested it in both modes (with a simple HelloFXCanvas program) -- as an automatic jar file and as just an ordinary jar on the classpath. Just curious, if there are qualified exports to javafx.swt then how it does when on the class path? -

Re: Ping - Re: RFR 8078812, Test RMI with client and servers as modules

2016-05-27 Thread Felix Yang
HI Stuart, On 2016/5/27 5:57, Stuart Marks wrote: * * * In summary, I think there is only the Client.java cleanup, and (optionally) the String=>Path conversion. Did you need me to push this for you? This will go into jdk9/dev, right? I don't think it needs to go into jake. Please sponsor

Re: Paths in Mutli Release Jar

2016-05-27 Thread Alan Bateman
On 27/05/2016 09:06, Robert Scholte wrote: I noticed that the path is still META-INF/*versions*/ even though the JEP has been renamed from Multi Version jar to Multi Release jar. Is that intended or should/will that be changed as well? I'm not aware of any proposal to rename this. Steve Drach (c

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-27 Thread Tom Schindl
Do you have an example how to construct such a Layer? Tom Von meinem iPhone gesendet > Am 26.05.2016 um 17:47 schrieb Mandy Chung : > > >> On May 26, 2016, at 8:38 AM, Kevin Rushforth >> wrote: >> >> Yes, I've tested it in both modes (with a simple HelloFXCanvas program) -- >> as an automa

Re: creating proxies for interfaces with default methods

2016-05-27 Thread Alan Bateman
On 27/05/2016 06:28, Jochen Theodorou wrote: : MethodHandles.Lookup.class.getDeclaredConstructor(Class.class, int.class). newInstance(interfaceClass, MethodHandles.Lookup.PRIVATE). unreflectSpecial(method, interfaceClass). bindTo(receiver); but that is not working anymore.

Paths in Mutli Release Jar

2016-05-27 Thread Robert Scholte
I noticed that the path is still META-INF/*versions*/ even though the JEP has been renamed from Multi Version jar to Multi Release jar. Is that intended or should/will that be changed as well? thanks, Robert

Re: creating proxies for interfaces with default methods

2016-05-27 Thread Jochen Theodorou
On 27.05.2016 08:58, fo...@univ-mlv.fr wrote: - Mail original - De: "Jochen Theodorou" À: "Remi Forax" Cc: "jigsaw-dev" Envoyé: Vendredi 27 Mai 2016 07:28:58 Objet: Re: creating proxies for interfaces with default methods On 26.05.2016 14:00, Remi Forax wrote: Not if you use Looku