Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

2016-06-09 Thread Alan Bateman
On 08/06/2016 20:45, Jim Laskey (Oracle) wrote: Consistent use of PathPatterns for jlink, jimage and jmod options. —optionName=(regex:|glob:|) ?? where => glob: http://cr.openjdk.java.net/~jlaskey/8158402/webrev/index.html http

Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

2016-06-09 Thread Jim Laskey (Oracle)
> On Jun 9, 2016, at 7:16 AM, Alan Bateman wrote: > > On 08/06/2016 20:45, Jim Laskey (Oracle) wrote: > >> Consistent use of PathPatterns for jlink, jimage and jmod options. >> >> —optionName=(regex:|glob:|) ?? where => >> glob: >> >> http://cr.openjdk.java.net/~jlaskey/8158402/webrev/index

Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

2016-06-09 Thread Chris Hegarty
> On 9 Jun 2016, at 11:16, Alan Bateman wrote: > > On 08/06/2016 20:45, Jim Laskey (Oracle) wrote: > >> Consistent use of PathPatterns for jlink, jimage and jmod options. >> >> —optionName=(regex:|glob:|) ?? where => >> glob: >> >> http://cr.openjdk.java.net/~jlaskey/8158402/webrev/index.ht

Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

2016-06-09 Thread Jim Laskey (Oracle)
> On Jun 9, 2016, at 8:52 AM, Chris Hegarty wrote: > >> >> On 9 Jun 2016, at 11:16, Alan Bateman wrote: >> >> On 08/06/2016 20:45, Jim Laskey (Oracle) wrote: >> >>> Consistent use of PathPatterns for jlink, jimage and jmod options. >>> >>> —optionName=(regex:|glob:|) ?? where => >>> glob:

Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

2016-06-09 Thread Chris Hegarty
> On 9 Jun 2016, at 12:57, Jim Laskey (Oracle) wrote: > > >> On Jun 9, 2016, at 8:52 AM, Chris Hegarty wrote: >> >>> >>> On 9 Jun 2016, at 11:16, Alan Bateman wrote: >>> >>> On 08/06/2016 20:45, Jim Laskey (Oracle) wrote: >>> Consistent use of PathPatterns for jlink, jimage and jmod

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

2016-06-09 Thread Dmitry Dmitriev
Hello Mandy, As I understand all these options are tested by following tests: jdk/test/tools/launcher/modules. I.e. no additional tests are required for moving these options to the VM(except 2 new tests)? You only adds 2 additional tests: RuntimeArguments.java - to check that these options ar

Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

2016-06-09 Thread Alan Bateman
On 09/06/2016 12:52, Chris Hegarty wrote: : As things currently stand --hash-modules accepts a regex, and --exclude accepts a glob. So this change does not affect default behaviour. It makes sense for --exclude to take a glob ( and optionally a regex ). I don’t think it makes sense for --hash-m

Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

2016-06-09 Thread Alan Bateman
On 09/06/2016 12:00, Jim Laskey (Oracle) wrote: : I have changes for the make files as well. diff -r 6a78ef1d1e58 make/Images.gmk --- a/make/Images.gmk Mon May 30 16:17:11 2016 +0200 +++ b/make/Images.gmk Wed Jun 08 15:24:53 2016 -0300 @@ -115,16 +115,16 @@ # Use this file inside the imag

Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

2016-06-09 Thread Jim Laskey (Oracle)
I’ll followup shortly. > On Jun 9, 2016, at 11:51 AM, Alan Bateman wrote: > > > On 09/06/2016 12:00, Jim Laskey (Oracle) wrote: >> : >> I have changes for the make files as well. >> >> diff -r 6a78ef1d1e58 make/Images.gmk >> --- a/make/Images.gmkMon May 30 16:17:11 2016 +0200 >> +++ b