Re: RFR JDK-8159206 - All jlink tests failing

I reviewed http://cr.openjdk.java.net/~jlaskey/8159206/webrev Looks much cleaner. Thanks for the update 342 StringSharingPlugin(String[] patterns) throws IOException { 343 this(ResourceFilter.includeFilter(Arrays.asList(patterns))); 344 } Looks like it’s not used except the n

Re: RFR 8158855: Fix remaining module dependences in java/lang

> On Jun 14, 2016, at 3:53 PM, Alexandre (Shura) Iline > wrote: > > Hi. > > After some offline conversations it was decided to leave the tests which > depend on absence of “-limitmods” in VM options for later. I have created a > separate bug ti track that: > https://bugs.openjdk.java.net/bro

Re: RFR 8158855: Fix remaining module dependences in java/lang

Hi. After some offline conversations it was decided to leave the tests which depend on absence of “-limitmods” in VM options for later. I have created a separate bug ti track that: https://bugs.openjdk.java.net/browse/JDK-8159523 What left for this review is this, then: http://cr.openjdk.java.n

Re: RFR JDK-8159206 - All jlink tests failing

> On Jun 11, 2016, at 9:03 PM, Mandy Chung wrote: > > >> On Jun 10, 2016, at 12:20 PM, Jim Laskey (Oracle) >> wrote: >> >> http://cr.openjdk.java.net/~jlaskey/8159206/webrev/index.html >> https://bugs.openjdk.java.net/browse/JDK

Re: Oops javac throw a NPE

Hi all, I have attached the jigsaw.zip file provided by Remi to the bug entry and assigned the bug to myself, Thanks, Vicente On 06/14/2016 06:36 AM, Alan Bateman wrote: On 14/06/2016 11:29, fo...@univ-mlv.fr wrote: : I use "java/lang/Object" as super class instead of null (0 as constant

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

Hi Alan, On 14.6.2016 12:57, Alan Bateman wrote: On 13/06/2016 17:12, Jan Lahoda wrote: Hello, There is: https://bugs.openjdk.java.net/browse/JDK-8153362 which is about a new warning that should be produced by javac when exported API refers to types not exported/accessible to the API clients

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

Hi Phil, Thanks for the comments. I was preferring @SuppressWarnings over -Xlint:-unexportedinapi because it allows to disable the check only on selected elements (as opposed to disabling it for a whole module, where a newly added API might inadvertently still cause a new warning); and also b

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

On 13/06/2016 17:12, Jan Lahoda wrote: Hello, There is: https://bugs.openjdk.java.net/browse/JDK-8153362 which is about a new warning that should be produced by javac when exported API refers to types not exported/accessible to the API clients. I've put my current javac change here: http://

Re: Oops javac throw a NPE

On 14/06/2016 11:29, fo...@univ-mlv.fr wrote: : I use "java/lang/Object" as super class instead of null (0 as constant pool index) as the spec says. I've created JDK-8159439 to track the javac issue. -Alan

Re: Oops javac throw a NPE

Thanks Alan, You found the bug ! java.lang.module.ResolutionException: Error reading module: mlib/asm-util-6.0.jar at java.lang.module.Resolver.findAll(java.base@9-ea/Resolver.java:768) at java.lang.module.Resolver.resolveUses(java.base@9-ea/Resolver.java:174) at java.la

Re: Oops javac throw a NPE

On 13/06/2016 18:03, Remi Forax wrote: Hi Jon, i've got an exception trying to reference in a module-info.java some modular jars generated by ASM, i suppose there is a bug in the module-info generated by ASM but i'm not able to find it (javap is ok with the code ?) Given that this exception i