Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

2016-08-09 Thread Steve Drach
> On Aug 8, 2016, at 12:46 PM, Alan Bateman wrote: >> > I think we can do this in phases, starting out with jlink picking up the > runtime version and using that to select the resources from the modular JAR > would be a good start. At some point we will have an update module path > implementa

Re: Review request 8136930: Simplify use of module-system options by custom launchers

2016-08-09 Thread Jonathan Gibbons
On 08/09/2016 06:12 AM, Jan Lahoda wrote: I took a pass through langtools changes. Overall seems OK to me. Some minor comments: -src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java: commented-out code in hasArg(). (Some more in Option.ArgKind, but that seems mostly OK.) -src/jdk

Re: Review request 8136930: Simplify use of module-system options by custom launchers

2016-08-09 Thread Kumar Srinivasan
On 8/9/2016 6:12 AM, Jan Lahoda wrote: I took a pass through langtools changes. Overall seems OK to me. Some minor comments: -src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java: commented-out code in hasArg(). (Some more in Option.ArgKind, but that seems mostly OK.) -src/jdk.j

Re: Review request 8136930: Simplify use of module-system options by custom launchers

2016-08-09 Thread Jan Lahoda
I took a pass through langtools changes. Overall seems OK to me. Some minor comments: -src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java: commented-out code in hasArg(). (Some more in Option.ArgKind, but that seems mostly OK.) -src/jdk.javadoc/share/classes/com/sun/tools/javado