Re: Review Request: JDK-8162401 Support multiple --add-exports and --add-reads with the same module/package

2016-10-06 Thread Sundararajan Athijegannathan
+1 -Sundar On 10/7/2016 3:47 AM, Mandy Chung wrote: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8162401/webrev.00/ > > Currently, `--add-exports` and `--add-reads` options do not accept duplicated > module/package and it is an error to attempt to export the same package more > than once

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

2016-10-06 Thread Denis Kononenko
> > > > Could someone please review these new tests for jimage utility. > > > > There're 5 new files containing tests to cover use cases for 'info', > > > 'list', 'extract' and other options. No new tests for 'verify'. > > > > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240 > > WEBREV: h

hg: jigsaw/jake/langtools: 2 new changesets

2016-10-06 Thread mandy . chung
Changeset: 8e9e1a2373a4 Author:lana Date: 2016-10-06 20:56 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8e9e1a2373a4 Added tag jdk-9+139 for changeset 17a82cb0e4b4 ! .hgtags Changeset: e886b0aaa09f Author:mchung Date: 2016-10-06 15:48 -0700 URL: h

hg: jigsaw/jake/jaxws: 2 new changesets

2016-10-06 Thread mandy . chung
Changeset: 6b704401a214 Author:lana Date: 2016-10-06 20:56 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/6b704401a214 Added tag jdk-9+139 for changeset 7a7aadf3c450 ! .hgtags Changeset: 9af9124a6bfe Author:mchung Date: 2016-10-06 15:48 -0700 URL: http:

hg: jigsaw/jake/nashorn: 2 new changesets

2016-10-06 Thread mandy . chung
Changeset: 430dee99064d Author:lana Date: 2016-10-06 20:56 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/430dee99064d Added tag jdk-9+139 for changeset e3b11296395b ! .hgtags Changeset: 034810f8d9cb Author:mchung Date: 2016-10-06 15:48 -0700 URL: htt

hg: jigsaw/jake/jdk: 2 new changesets

2016-10-06 Thread mandy . chung
Changeset: 2bf254421854 Author:lana Date: 2016-10-06 20:56 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/2bf254421854 Added tag jdk-9+139 for changeset 5518ac2f2ead ! .hgtags Changeset: d31ab14d938f Author:mchung Date: 2016-10-06 15:48 -0700 URL: http://

hg: jigsaw/jake: 2 new changesets

2016-10-06 Thread mandy . chung
Changeset: f73344fddabe Author:lana Date: 2016-10-06 20:56 + URL: http://hg.openjdk.java.net/jigsaw/jake/rev/f73344fddabe Added tag jdk-9+139 for changeset 7dcf453eacae ! .hgtags Changeset: 2f8eb7df5d8b Author:mchung Date: 2016-10-06 15:48 -0700 URL: http://hg.o

hg: jigsaw/jake/hotspot: 2 new changesets

2016-10-06 Thread mandy . chung
Changeset: 0384427f59fa Author:lana Date: 2016-10-06 20:56 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/0384427f59fa Added tag jdk-9+139 for changeset 08492e67bf32 ! .hgtags Changeset: ced1a5e167ae Author:mchung Date: 2016-10-06 15:48 -0700 URL: htt

hg: jigsaw/jake/corba: 2 new changesets

2016-10-06 Thread mandy . chung
Changeset: e7cc0efa4972 Author:lana Date: 2016-10-06 20:56 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/e7cc0efa4972 Added tag jdk-9+139 for changeset 8c9da7fc5b07 ! .hgtags Changeset: 3a29b8924e4d Author:mchung Date: 2016-10-06 15:48 -0700 URL: http:

hg: jigsaw/jake/jaxp: 2 new changesets

2016-10-06 Thread mandy . chung
Changeset: fd47b31f4cca Author:lana Date: 2016-10-06 20:56 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/fd47b31f4cca Added tag jdk-9+139 for changeset 8991d71c5316 ! .hgtags Changeset: 615d09630235 Author:mchung Date: 2016-10-06 15:48 -0700 URL: http:/

hg: jigsaw/jake/nashorn: 4 new changesets

2016-10-06 Thread mandy . chung
Changeset: ab0b7e471cb6 Author:hannesw Date: 2016-09-30 19:40 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/ab0b7e471cb6 8166902: Nested object literal property maps not reset in optimistic recompilation Reviewed-by: lagergren, attila ! src/jdk.scripting.nashorn/s

hg: jigsaw/jake/jdk: 39 new changesets

2016-10-06 Thread mandy . chung
Changeset: 12e616e0a018 Author:asmotrak Date: 2016-09-27 11:34 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/12e616e0a018 8164591: sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java failed with SSLHandshakeException Reviewed-by: xuelei + test/javax/net/ssl/

hg: jigsaw/jake/langtools: 10 new changesets

2016-10-06 Thread mandy . chung
Changeset: abfa6353574c Author:sadayapalam Date: 2016-09-28 09:05 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/abfa6353574c 8166363: Method with reordered type parameter bounds compiles with @Override annotation but does not actually override superclass method. R

Re: Review Request: JDK-8162401 Support multiple --add-exports and --add-reads with the same module/package

2016-10-06 Thread Claes Redestad
Hi Mandy, On 2016-10-07 00:17, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8162401/webrev.00/ looks ok to me. /Claes Currently, `--add-exports` and `--add-reads` options do not accept duplicated module/package and it is an error to attempt to export the same package

hg: jigsaw/jake/hotspot: 21 new changesets

2016-10-06 Thread mandy . chung
Changeset: c8b3f8e5423b Author:dsamersoff Date: 2016-09-15 10:19 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/c8b3f8e5423b 8027920: SA: Add default methods to InstanceKlass Summary: Add default methods to InstanceKlass to enable SA to inspect default methods Review

hg: jigsaw/jake: 4 new changesets

2016-10-06 Thread mandy . chung
Changeset: 13a8f3836051 Author:erikj Date: 2016-09-30 09:05 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/13a8f3836051 8160630: libjimage.so and others should link statically to libgcc Reviewed-by: ihse, tbell ! common/autoconf/buildjdk-spec.gmk.in ! common/autoconf/generat

hg: jigsaw/jake/corba: 2 new changesets

2016-10-06 Thread mandy . chung
Changeset: 8c9da7fc5b07 Author:erikj Date: 2016-10-04 13:41 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/8c9da7fc5b07 8166965: Some small java build tools are still running with big JVM configuration Reviewed-by: ihse ! make/gensrc/Gensrc-java.corba.gmk Changeset:

Review Request: JDK-8162401 Support multiple --add-exports and --add-reads with the same module/package

2016-10-06 Thread Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8162401/webrev.00/ Currently, `--add-exports` and `--add-reads` options do not accept duplicated module/package and it is an error to attempt to export the same package more than once on the command-line. There are cases where allow augmenting the

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

2016-10-06 Thread Alan Bateman
On 06/10/2016 17:37, Denis Kononenko wrote: Hi, Could someone please review these new tests for jimage utility. There're 5 new files containing tests to cover use cases for 'info', 'list', 'extract' and other options. No new tests for 'verify'. BUGURL: https://bugs.openjdk.java.net/browse/J

hg: jigsaw/jake/jdk: Workaround jdk.jconsole to add exports private

2016-10-06 Thread mandy . chung
Changeset: f493db6e68cc Author:mchung Date: 2016-10-06 12:22 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f493db6e68cc Workaround jdk.jconsole to add exports private ! make/launcher/Launcher-jdk.jconsole.gmk

Re: Adding boot and platform module flags to ResolvedModule

2016-10-06 Thread Scott Stark
In the prototype that allows the vm to boot with modules on the module path that have packages with the same name, I have modified the ModuleBootstrap to use an alternate Function mapping that creates a jdk.internal.loader.Loader for the modules that are not in the set of boot/platform modules

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

2016-10-06 Thread Alexandre (Shura) Iline
Hi, Denis, By an agreement, @modules should go before any action tag. You use it after @build. Shura > On Oct 6, 2016, at 9:37 AM, Denis Kononenko > wrote: > > Hi, > > Could someone please review these new tests for jimage utility. > > There're 5 new files containing tests to cover use cas

Re: RFR 8167181: Exported elements referring to inaccessible types in jdk.security.jgss

2016-10-06 Thread Mandy Chung
> On Oct 6, 2016, at 9:55 AM, Wang Weijun wrote: > > Please review the code change for jdk9/dev/jdk repo at > > http://cr.openjdk.java.net/~weijun/8167181/webrev.00 This looks good to me. Thanks Mandy

RFR 8167181: Exported elements referring to inaccessible types in jdk.security.jgss

2016-10-06 Thread Wang Weijun
Please review the code change for jdk9/dev/jdk repo at http://cr.openjdk.java.net/~weijun/8167181/webrev.00 and for jdk9/dev which is simply diff --git a/make/CompileJavaModules.gmk b/make/CompileJavaModules.gmk --- a/make/CompileJavaModules.gmk +++ b/make/CompileJavaModules.gmk @@ -452,10 +

[9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

2016-10-06 Thread Denis Kononenko
Hi, Could someone please review these new tests for jimage utility. There're 5 new files containing tests to cover use cases for 'info', 'list', 'extract' and other options. No new tests for 'verify'. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240 WEBREV: http://cr.openjdk.java.net/

Re: Adding boot and platform module flags to ResolvedModule

2016-10-06 Thread Alan Bateman
On 06/10/2016 17:15, Scott Stark wrote: Hello, I'm currently prototyping an alternate bootstrap implementation that will allow packages with the same name to exist across modules, and one thing I have run across is the need to know what the boot and platform modules are since there are restr

Adding boot and platform module flags to ResolvedModule

2016-10-06 Thread Scott Stark
Hello, I'm currently prototyping an alternate bootstrap implementation that will allow packages with the same name to exist across modules, and one thing I have run across is the need to know what the boot and platform modules are since there are restrictions on what type of ClassLoader can be