Re: RFR: 8171373: Reduce copying during initialization of ModuleHashes

+1 Mandy > On Dec 16, 2016, at 4:45 PM, Claes Redestad wrote: > > Chris, Mandy, > > thanks for reviewing! > > I've made nameToHash final and added a comment, updated in place. > > I'll push this tomorrow unless I hear any objections. > > /Claes > > On 2016-12-16

Re: RFR: 8171373: Reduce copying during initialization of ModuleHashes

Chris, Mandy, thanks for reviewing! I've made nameToHash final and added a comment, updated in place. I'll push this tomorrow unless I hear any objections. /Claes On 2016-12-16 18:52, Mandy Chung wrote: On Dec 16, 2016, at 8:00 AM, Claes Redestad wrote: Hi,

RE: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

Hi Chris, thanks, works perfectly. I compiled a JDK with this commit and Lucene's unmapping works. Thanks. https://github.com/apache/lucene-solr/compare/LUCENE-6989-v2 Uwe - Uwe Schindler uschind...@apache.org ASF Member, Apache Lucene PMC / Committer Bremen, Germany

Re: RFR 8170289: Re-examine entry point support in jlink

> On Dec 16, 2016, at 8:36 AM, Sundararajan Athijegannathan > wrote: > > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8170289/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8170289 273 Optional mainClass =

hg: jigsaw/jake/jdk: 8171374: GenGraphs should filter the rank grouping if the group is empty

Changeset: 4c3ba34b0749 Author:mchung Date: 2016-12-16 09:42 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4c3ba34b0749 8171374: GenGraphs should filter the rank grouping if the group is empty Reviewed-by: alanb, psandoz !

Re: RFR: 8171373: Reduce copying during initialization of ModuleHashes

> On Dec 16, 2016, at 8:00 AM, Claes Redestad wrote: > > Hi, > > recent changes to split out ModuleHashes from ModuleDescriptor caused a > small/tiny increase in HashMap creation, resize and copying: > > Webrev:

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

Pushed to jdk9/dev. Should make b150. https://bugs.openjdk.java.net/browse/JDK-8171377 -Chris. > On 14 Dec 2016, at 11:58, Chris Hegarty wrote: > > Webrev updated in-place. > http://cr.openjdk.java.net/~chegar/Unsafe_invokeCleaner/ > > -Chris. > > On 13/12/16

Re: RFR: 8171373: Reduce copying during initialization of ModuleHashes

> On 16 Dec 2016, at 16:00, Claes Redestad wrote: > > Hi, > > recent changes to split out ModuleHashes from ModuleDescriptor caused a > small/tiny increase in HashMap creation, resize and copying: > > Webrev: http://cr.openjdk.java.net/~redestad/8171373/webrev.01/

Re: per-module module-source-path for javac

Thank you for noting the additional use case of CLASS_OUTPUT. -- Jon On 12/16/16 8:57 AM, Nikolay Chashnikov wrote: Hi Jonathan, thank you, glad to hear it. Regarding API design: we already have JavaFileManager#getLocationForModule which takes Location and moduleName, so it looks logical

Re: per-module module-source-path for javac

Hi Jonathan, thank you, glad to hear it. Regarding API design: we already have JavaFileManager#getLocationForModule which takes Location and moduleName, so it looks logical to add setLocationForModule which takes location, moduleName and list of paths, as you suggested. It would be useful not

Re: Review Request JDK-8171323: generate dot file for java.se and java.se.ee with only API dependences

On 16/12/2016 16:22, Mandy Chung wrote: A small fix to the GenGraphs tool: diff --git a/make/src/classes/build/tools/jigsaw/GenGraphs.java b/make/src/classes/build/tools/jigsaw/GenGraphs.java --- a/make/src/classes/build/tools/jigsaw/GenGraphs.java +++

RFR 8170289: Re-examine entry point support in jlink

Hi, Please review http://cr.openjdk.java.net/~sundar/8170289/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8170289 Thanks, -Sundar

Re: Review Request JDK-8171323: generate dot file for java.se and java.se.ee with only API dependences

A small fix to the GenGraphs tool: diff --git a/make/src/classes/build/tools/jigsaw/GenGraphs.java b/make/src/classes/build/tools/jigsaw/GenGraphs.java --- a/make/src/classes/build/tools/jigsaw/GenGraphs.java +++ b/make/src/classes/build/tools/jigsaw/GenGraphs.java @@ -214,13 +214,13 @@

RFR: 8171373: Reduce copying during initialization of ModuleHashes

Hi, recent changes to split out ModuleHashes from ModuleDescriptor caused a small/tiny increase in HashMap creation, resize and copying: Webrev: http://cr.openjdk.java.net/~redestad/8171373/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8171373 This decreases #bytecode executed

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

Hi, I strongly hope Paul and Cedric will be able to start the release process next week, if not we will have to do it the old way I think. what would help us a lot would be you testing the GROOVY_2_4_X branch with your build system to see if it really does solve your problem. Even if it is

Re: per-module module-source-path for javac

Any comments? On Mon, Dec 12, 2016 at 8:29 PM, Nikolay Chashnikov < nikolay.chashni...@jetbrains.com> wrote: > Hello, > > we're actively working on support for Jigsaw in IntelliJ IDEA. Some time > ago we asked (see this post >

Re: 8170987: Module system implementation refresh (12/2016)

Langtools changes look good. —Andrey > On 15 Dec 2016, at 00:46, Alan Bateman wrote: > > Folks on jigsaw-dev will be aware that we are on yet another mission to bring > the changes accumulated in the jake forest to jdk9/dev. The plan this time is > to bring the

RE: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

Hi Jochen, thank you for the information! Is there any plan about a release? I also found no JIRA issue about this issue to link it against our JIRA: https://issues.apache.org/jira/browse/LUCENE-7596 The problem makes our build system unusable, so it would be very important to have a fix

hg: jigsaw/jake/jdk: 39 new changesets

Changeset: b6d62dc38c36 Author:mli Date: 2016-12-12 17:29 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b6d62dc38c36 8166763: java/rmi/* tests fail intermittently with "Port already in use" in RMID.start() Reviewed-by: chegar !

hg: jigsaw/jake/hotspot: 92 new changesets

Changeset: accf1676e416 Author:bchristi Date: 2016-12-13 12:36 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/accf1676e416 8169389: Use a bitmap to control StackTraceElement::toString format and save footprint Reviewed-by: dfuchs, mchung !

hg: jigsaw/jake/jaxp: 7 new changesets

Changeset: 6756e8fc6795 Author:mchung Date: 2016-12-12 18:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/6756e8fc6795 8169925: Organize licenses by module in source, JMOD file, and run-time image Reviewed-by: alanb, erikj, ihse, naoto, prr Contributed-by:

hg: jigsaw/jake: 15 new changesets

Changeset: 27810b5e38a4 Author:mchung Date: 2016-12-12 18:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/27810b5e38a4 8169925: Organize licenses by module in source, JMOD file, and run-time image Reviewed-by: alanb, erikj, ihse, naoto, prr Contributed-by:

hg: jigsaw/jake/langtools: 12 new changesets

Changeset: 44b6ae94e1d5 Author:mchung Date: 2016-12-12 18:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/44b6ae94e1d5 8169925: Organize licenses by module in source, JMOD file, and run-time image Reviewed-by: alanb, erikj, ihse, naoto, prr Contributed-by:

hg: jigsaw/jake/nashorn: 8 new changesets

Changeset: 6d1c784a77fc Author:mchung Date: 2016-12-12 18:57 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/6d1c784a77fc 8169925: Organize licenses by module in source, JMOD file, and run-time image Reviewed-by: alanb, erikj, ihse, naoto, prr Contributed-by:

Re: NCDFE on jdk.internal.reflect.SerializationConstructorAccessorImpl

For the stack trace at hand, doesn't that simply boil down to, that the OSGi framework used doesn't know that jdk.internal.reflect should be boot delegated, meaning it never calls the parent classloader when trying to load the class? /Michael On 16 December 2016 at 00:10, David Holmes