Re: NCDFE on jdk.internal.reflect.SerializationConstructorAccessorImpl

2016-12-16 Thread Michael Rasmussen
For the stack trace at hand, doesn't that simply boil down to, that the OSGi framework used doesn't know that jdk.internal.reflect should be boot delegated, meaning it never calls the parent classloader when trying to load the class? /Michael On 16 December 2016 at 00:10, David Holmes wrote: >

hg: jigsaw/jake/jaxws: 3 new changesets

2016-12-16 Thread alan . bateman
Changeset: a0596db9113f Author:mchung Date: 2016-12-12 18:57 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/a0596db9113f 8169925: Organize licenses by module in source, JMOD file, and run-time image Reviewed-by: alanb, erikj, ihse, naoto, prr Contributed-by: mandy.ch...

hg: jigsaw/jake/nashorn: 8 new changesets

2016-12-16 Thread alan . bateman
Changeset: 6d1c784a77fc Author:mchung Date: 2016-12-12 18:57 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/6d1c784a77fc 8169925: Organize licenses by module in source, JMOD file, and run-time image Reviewed-by: alanb, erikj, ihse, naoto, prr Contributed-by: mandy.ch.

hg: jigsaw/jake/langtools: 12 new changesets

2016-12-16 Thread alan . bateman
Changeset: 44b6ae94e1d5 Author:mchung Date: 2016-12-12 18:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/44b6ae94e1d5 8169925: Organize licenses by module in source, JMOD file, and run-time image Reviewed-by: alanb, erikj, ihse, naoto, prr Contributed-by: mandy.c

hg: jigsaw/jake/jaxp: 7 new changesets

2016-12-16 Thread alan . bateman
Changeset: 6756e8fc6795 Author:mchung Date: 2016-12-12 18:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/6756e8fc6795 8169925: Organize licenses by module in source, JMOD file, and run-time image Reviewed-by: alanb, erikj, ihse, naoto, prr Contributed-by: mandy.ch...@

hg: jigsaw/jake: 15 new changesets

2016-12-16 Thread alan . bateman
Changeset: 27810b5e38a4 Author:mchung Date: 2016-12-12 18:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/27810b5e38a4 8169925: Organize licenses by module in source, JMOD file, and run-time image Reviewed-by: alanb, erikj, ihse, naoto, prr Contributed-by: mandy.ch...@oracl

hg: jigsaw/jake/hotspot: 92 new changesets

2016-12-16 Thread alan . bateman
Changeset: accf1676e416 Author:bchristi Date: 2016-12-13 12:36 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/accf1676e416 8169389: Use a bitmap to control StackTraceElement::toString format and save footprint Reviewed-by: dfuchs, mchung ! src/share/vm/classfile/jav

hg: jigsaw/jake/jdk: 39 new changesets

2016-12-16 Thread alan . bateman
Changeset: b6d62dc38c36 Author:mli Date: 2016-12-12 17:29 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b6d62dc38c36 8166763: java/rmi/* tests fail intermittently with "Port already in use" in RMID.start() Reviewed-by: chegar ! test/java/rmi/activation/ActivationGroup

RE: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-16 Thread Uwe Schindler
Hi Jochen, thank you for the information! Is there any plan about a release? I also found no JIRA issue about this issue to link it against our JIRA: https://issues.apache.org/jira/browse/LUCENE-7596 The problem makes our build system unusable, so it would be very important to have a fix quite

Re: 8170987: Module system implementation refresh (12/2016)

2016-12-16 Thread Andrey Nazarov
Langtools changes look good. —Andrey > On 15 Dec 2016, at 00:46, Alan Bateman wrote: > > Folks on jigsaw-dev will be aware that we are on yet another mission to bring > the changes accumulated in the jake forest to jdk9/dev. The plan this time is > to bring the changes to jdk9/dev to make jdk-

Re: per-module module-source-path for javac

2016-12-16 Thread Nikolay Chashnikov
Any comments? On Mon, Dec 12, 2016 at 8:29 PM, Nikolay Chashnikov < nikolay.chashni...@jetbrains.com> wrote: > Hello, > > we're actively working on support for Jigsaw in IntelliJ IDEA. Some time > ago we asked (see this post >

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-16 Thread Jochen Theodorou
Hi, I strongly hope Paul and Cedric will be able to start the release process next week, if not we will have to do it the old way I think. what would help us a lot would be you testing the GROOVY_2_4_X branch with your build system to see if it really does solve your problem. Even if it is o

Re: per-module module-source-path for javac

2016-12-16 Thread Jonathan Gibbons
Nikolay, We are looking at this. One aspect of the problem we have to take into account is that currently, the JavaFileManager API does not special case the module source path (yes, I know the *implementation* special cases it, even at the handleOption level) and so we need to come up with a

RFR: 8171373: Reduce copying during initialization of ModuleHashes

2016-12-16 Thread Claes Redestad
Hi, recent changes to split out ModuleHashes from ModuleDescriptor caused a small/tiny increase in HashMap creation, resize and copying: Webrev: http://cr.openjdk.java.net/~redestad/8171373/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8171373 This decreases #bytecode executed duri

Re: Review Request JDK-8171323: generate dot file for java.se and java.se.ee with only API dependences

2016-12-16 Thread Mandy Chung
A small fix to the GenGraphs tool: diff --git a/make/src/classes/build/tools/jigsaw/GenGraphs.java b/make/src/classes/build/tools/jigsaw/GenGraphs.java --- a/make/src/classes/build/tools/jigsaw/GenGraphs.java +++ b/make/src/classes/build/tools/jigsaw/GenGraphs.java @@ -214,13 +214,13 @@

RFR 8170289: Re-examine entry point support in jlink

2016-12-16 Thread Sundararajan Athijegannathan
Hi, Please review http://cr.openjdk.java.net/~sundar/8170289/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8170289 Thanks, -Sundar

Re: Review Request JDK-8171323: generate dot file for java.se and java.se.ee with only API dependences

2016-12-16 Thread Paul Sandoz
+1 (Took me a few takes on the patch to see you are substituting the embedded stream op in forEach into a map so you can filter on empty strings.) Paul. > On 16 Dec 2016, at 08:22, Mandy Chung wrote: > > A small fix to the GenGraphs tool: > > diff --git a/make/src/classes/build/tools/jigsaw

Re: Review Request JDK-8171323: generate dot file for java.se and java.se.ee with only API dependences

2016-12-16 Thread Alan Bateman
On 16/12/2016 16:22, Mandy Chung wrote: A small fix to the GenGraphs tool: diff --git a/make/src/classes/build/tools/jigsaw/GenGraphs.java b/make/src/classes/build/tools/jigsaw/GenGraphs.java --- a/make/src/classes/build/tools/jigsaw/GenGraphs.java +++ b/make/src/classes/build/tools/jigsaw/Gen

Re: per-module module-source-path for javac

2016-12-16 Thread Nikolay Chashnikov
Hi Jonathan, thank you, glad to hear it. Regarding API design: we already have JavaFileManager#getLocationForModule which takes Location and moduleName, so it looks logical to add setLocationForModule which takes location, moduleName and list of paths, as you suggested. It would be useful not onl

Re: per-module module-source-path for javac

2016-12-16 Thread Jonathan Gibbons
Thank you for noting the additional use case of CLASS_OUTPUT. -- Jon On 12/16/16 8:57 AM, Nikolay Chashnikov wrote: Hi Jonathan, thank you, glad to hear it. Regarding API design: we already have JavaFileManager#getLocationForModule which takes Location and moduleName, so it looks logical t

Re: RFR: 8171373: Reduce copying during initialization of ModuleHashes

2016-12-16 Thread Chris Hegarty
> On 16 Dec 2016, at 16:00, Claes Redestad wrote: > > Hi, > > recent changes to split out ModuleHashes from ModuleDescriptor caused a > small/tiny increase in HashMap creation, resize and copying: > > Webrev: http://cr.openjdk.java.net/~redestad/8171373/webrev.01/ > Bug: https://bugs.openjdk.

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-16 Thread Chris Hegarty
Pushed to jdk9/dev. Should make b150. https://bugs.openjdk.java.net/browse/JDK-8171377 -Chris. > On 14 Dec 2016, at 11:58, Chris Hegarty wrote: > > Webrev updated in-place. > http://cr.openjdk.java.net/~chegar/Unsafe_invokeCleaner/ > > -Chris. > > On 13/12/16 21:18, Peter Levart wrote: >>

Re: RFR: 8171373: Reduce copying during initialization of ModuleHashes

2016-12-16 Thread Mandy Chung
> On Dec 16, 2016, at 8:00 AM, Claes Redestad wrote: > > Hi, > > recent changes to split out ModuleHashes from ModuleDescriptor caused a > small/tiny increase in HashMap creation, resize and copying: > > Webrev: http://cr.openjdk.java.net/~redestad/8171373/webrev.01/ > Bug: https://bugs.openj

hg: jigsaw/jake/jdk: 8171374: GenGraphs should filter the rank grouping if the group is empty

2016-12-16 Thread mandy . chung
Changeset: 4c3ba34b0749 Author:mchung Date: 2016-12-16 09:42 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4c3ba34b0749 8171374: GenGraphs should filter the rank grouping if the group is empty Reviewed-by: alanb, psandoz ! make/src/classes/build/tools/jigsaw/GenGraphs.j

Re: RFR 8170289: Re-examine entry point support in jlink

2016-12-16 Thread Mandy Chung
> On Dec 16, 2016, at 8:36 AM, Sundararajan Athijegannathan > wrote: > > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8170289/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8170289 273 Optional mainClass = ModuleDescriptor.read(stream).mainClass(); 274

RE: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-16 Thread Uwe Schindler
Hi Chris, thanks, works perfectly. I compiled a JDK with this commit and Lucene's unmapping works. Thanks. https://github.com/apache/lucene-solr/compare/LUCENE-6989-v2 Uwe - Uwe Schindler uschind...@apache.org ASF Member, Apache Lucene PMC / Committer Bremen, Germany http://lucene.apache.o

Re: RFR: 8171373: Reduce copying during initialization of ModuleHashes

2016-12-16 Thread Claes Redestad
Chris, Mandy, thanks for reviewing! I've made nameToHash final and added a comment, updated in place. I'll push this tomorrow unless I hear any objections. /Claes On 2016-12-16 18:52, Mandy Chung wrote: On Dec 16, 2016, at 8:00 AM, Claes Redestad wrote: Hi, recent changes to split out M

Re: RFR: 8171373: Reduce copying during initialization of ModuleHashes

2016-12-16 Thread Mandy Chung
+1 Mandy > On Dec 16, 2016, at 4:45 PM, Claes Redestad wrote: > > Chris, Mandy, > > thanks for reviewing! > > I've made nameToHash final and added a comment, updated in place. > > I'll push this tomorrow unless I hear any objections. > > /Claes > > On 2016-12-16 18:52, Mandy Chung wrote: >