Re: RFR: 8177845: Need a mechanism to load Graal

2017-04-18 Thread Mandy Chung
> On Apr 18, 2017, at 3:13 PM, Doug Simon wrote: > > Please review these changes that make jdk.internal.vm.compiler an upgradable > compiler. > : > http://cr.openjdk.java.net/~dnsimon/8177845/ Thanks for making this change. This would simplify the way to replace JDK’s graal with the lab graa

RFR: 8177845: Need a mechanism to load Graal

2017-04-18 Thread Doug Simon
Please review these changes that make jdk.internal.vm.compiler an upgradable compiler. The primary requirement for this is to remove all usage of JDK internals from Graal. While this most involves changes in Graal, there remain a few capabilities that must be exposed via JVMCI. Namely: 1. Graal

Re: Review Request: 8178404: jlink --suggest-providers should list providers from observable modules

2017-04-18 Thread Alan Bateman
On 18/04/2017 17:32, Mandy Chung wrote: : How about this: diff --git a/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties b/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties --- a/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties +

Re: Review Request: 8178404: jlink --suggest-providers should list providers from observable modules

2017-04-18 Thread Mandy Chung
> On Apr 18, 2017, at 7:35 AM, Alan Bateman wrote: > > For the usage message then --suggest-providers might be simpler as "Suggest > service providers that implement the given service type from the module > path". The mention of `--add-modules` could confuse readers so I'd leave it > out. >

Re: Review Request: 8178404: jlink --suggest-providers should list providers from observable modules

2017-04-18 Thread Alan Bateman
On 13/04/2017 00:34, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8178404/webrev.00/index.html --suggest-providers should suggest providers from any observable modules rather than the resolved modules. This patch also improves the output and fixes JDK-8178405 a

hg: jigsaw/jake/jdk: tools/jlink/JLinkNegativeTest.java failing

2017-04-18 Thread alan . bateman
Changeset: b44379d23925 Author:alanb Date: 2017-04-18 12:15 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b44379d23925 tools/jlink/JLinkNegativeTest.java failing ! test/tools/jlink/JLinkNegativeTest.java