Re: IllegalAccessError with --patch-module

2021-01-07 Thread Johannes Kuhn
On 07-Jan-21 20:04, Alan Bateman wrote> [...] The bug in the patcher code results in a root module that does not require java.base and since they are no other root modules, it means the boot layer doesn't have java.base, oops! But, the java.base has been partly defined to the VM in very early

Re: IllegalAccessError with --patch-module

2021-01-07 Thread Alan Bateman
On 07/01/2021 13:06, Johannes Kuhn wrote: : To be honest - I don't quite understand the bug - but I was able to reproduce it. So I did manually retrace the code to see where the difference was happening, and found the lines above - which was "good enough" for an explanation. Resolution

Re: IllegalAccessError with --patch-module

2021-01-07 Thread Johannes Kuhn
On 07-Jan-21 11:01, Alan Bateman wrote: On 06/01/2021 23:49, Johannes Kuhn wrote: Indeed a bug. Happens under the following conditions: * Patched module is an automatic module * Patch adds one or more additional packages to the module. : Proposed fix: * Change requires to not check if it

Re: IllegalAccessError with --patch-module

2021-01-07 Thread Alan Bateman
On 06/01/2021 23:49, Johannes Kuhn wrote: Indeed a bug. Happens under the following conditions: * Patched module is an automatic module * Patch adds one or more additional packages to the module. : Proposed fix: * Change requires to not check if it is an automatic module if the builder is