Re: trySetAccessible​

2017-07-10 Thread Alan Bateman
On 10/07/2017 16:31, Uwe Schindler wrote: Hi Alan, we understand all this. But what you say is also not true. I started a second approach to fix the issue by using canAccess() and also checking the module stuff. For that I executed the following code on the Groovy unnamed module: import org.c

Re: trySetAccessible​

2017-07-10 Thread Alan Bateman
On 10/07/2017 10:44, Jochen Theodorou wrote: : Example: module A: class Foo { protected void foo(){} } Groovy program: class X extends Foo { def bar() {return {foo()}} } if Foo is in an exported package, then it is legal for X to call foo, even though it is protected. But bar() does no

Re: trySetAccessible​

2017-07-10 Thread Alan Bateman
On 10/07/2017 10:59, Cédric Champeau wrote: This is not really practical. Basically it means that for every Gradle build script on earth, we would either choose to make them fail on JDK 9, or be bloated with warnings, that are actually handled. My mail was just explaining why it returns `true`.

Re: trySetAccessible​

2017-07-10 Thread Alan Bateman
On 10/07/2017 09:43, Uwe Schindler wrote: Hi Alan, I was trying to fix Groovy to use trySetAccessible() instead of setAccessible() and this did not change any warnings at all: The code can be found here: https://github.com/apache/groovy/compare/master...uschindler:java9/trySetAccessible It di

Re: trySetAccessible​

2017-07-10 Thread Alan Bateman
On 10/07/2017 09:49, Cédric Champeau wrote: I second Uwe's comment here: I was surprised as well, I expected the semantics of `trySetAccessible` to be: "let me know if I can do this, respecting the semantics of modules, and if not, return false" For the example, trySetAccessible succeeds (returns

Re: trySetAccessible​

2017-07-10 Thread Alan Bateman
On 10/07/2017 03:28, Stephen Felts wrote: : com.sun.xml.bind.v2.runtime.reflect.opt.Injector com.sun.xml.ws.model.Injector From what I can tell, these two aren't using tryAccessible. Instead they seem to use setAccessible to attempt to get at a non-public ClassLoader.defineClass method. It s

Re: trySetAccessible​

2017-07-10 Thread Alan Bateman
On 10/07/2017 00:16, Jochen Theodorou wrote: Hi all, since the JVM now prints warnings if you call setAccssible there was the advise to move to trySetAccessible​ to prvent these warnings. The motivation for trySetAccessible is to avoid using exceptions for control flow. I don't recall any sug

Re: Module in JDK image as platform module or loaded by application class loader?

2017-07-06 Thread Alan Bateman
On 06/07/2017 13:03, Langer, Christoph wrote: Hi there, for our JDK 9 image the jtreg test jdk/modules/etc/VerifyModuleDelegation has unveiled a problem. The issue is that we introduced a few modules that are defined as a platform module. One of these modules requires jdk.attach which is ne

Re: Use classes in unnamed module that are also contained in a JDK platform/runtime module

2017-07-04 Thread Alan Bateman
On 04/07/2017 08:02, Langer, Christoph wrote: Hi experts, probably this was already asked or discussed here but I don't find an exact answer for my type of issue, so I'm asking again. I have some piece of software that we ship as a jar file and which will hence run on a JDK 9 in the unnamed m

Re: RFR 8182776/8183161/8183251: Miscellaneous API doc fixes

2017-07-03 Thread Alan Bateman
On 03/07/2017 19:27, Jonathan Gibbons wrote: Looks good to me. -- Jon Thumbs up from me too. -Alan

Re: Exporting a package with no Java sources

2017-07-03 Thread Alan Bateman
On 03/07/2017 12:57, Alexander Udalov wrote: : Thanks, a dummy class certainly workarounds the problem of javac reporting a compilation error here. However, I hope there's a better way because it'd be a bit strange to force users to create a dummy Java class in every exported package in pure X mo

Re: Spec confusion about open modules

2017-07-02 Thread Alan Bateman
On 02/07/2017 11:16, Cay Horstmann wrote: In §7.7, the JLS draft from 2017-06-26 states: An open module, with the open modifier ... grants access at run time to types in all its packages, as if all packages had been exported. ... Distinct from access at compile time and access at run time, the J

Re: Cleanly starting apps on Java 9 and earlier

2017-07-01 Thread Alan Bateman
On 01/07/2017 13:15, Enrico Olivelli wrote: : Alan, Can you give some poonters to this page? Thank you There isn't a page to point at yet, mostly we are waiting for javaee.github.io to be updated to list stable Maven coordinates or download links for each of the standalone technologies. -Al

Re: javap cannot read module-info.class

2017-07-01 Thread Alan Bateman
On 01/07/2017 16:08, Stephan Herrmann wrote: compile an arbitrary module-info.java and then: $ javap module-info.class Error: error while reading constant pool for /tmp/bin/module-info.class: unexpected tag at #5: 19 From tweaking the Eclipse compiler it seems that javap is expecting a CO

Re: Exporting a package with no Java sources

2017-07-01 Thread Alan Bateman
On 01/07/2017 10:09, Peter Levart wrote: Hi Alexander, Have you tried to put a package-info.java into the exported package? It might work. I don't think so, but a dummy class/interface will do (it doesn't have to be public). There is a lengthy discussion on this topic in JIRA from 2016 that w

Re: Cleanly starting apps on Java 9 and earlier

2017-07-01 Thread Alan Bateman
On 01/07/2017 10:18, Mark Thomas wrote: Hi, Apache Tomcat needs to add the following options when running on Java 9: --add-modules=java.se.ee --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED The first is because it depends on javax.xml.ws.WebServic

hg: jigsaw/jake/nashorn: 2 new changesets

2017-07-01 Thread alan . bateman
Changeset: b25986e36b28 Author:lana Date: 2017-06-29 17:26 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/b25986e36b28 Added tag jdk-9+176 for changeset 3c6fbdf6e785 ! .hgtags Changeset: e93bc38cf3f3 Author:alanb Date: 2017-07-01 07:58 +0100 URL: http

hg: jigsaw/jake: 4 new changesets

2017-07-01 Thread alan . bateman
Changeset: 99918cff846d Author:ihse Date: 2017-06-21 12:51 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/99918cff846d 8179892: Update build documentation for JDK 9 Reviewed-by: erikj ! common/doc/building.html ! common/doc/building.md ! common/doc/testing.html ! make/Init.g

hg: jigsaw/jake/jaxp: 2 new changesets

2017-07-01 Thread alan . bateman
Changeset: 332ad9f92632 Author:lana Date: 2017-06-29 17:26 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/332ad9f92632 Added tag jdk-9+176 for changeset 38cf34e23280 ! .hgtags Changeset: 712c8f06dd80 Author:alanb Date: 2017-07-01 07:58 +0100 URL: http://

hg: jigsaw/jake/hotspot: 3 new changesets

2017-07-01 Thread alan . bateman
Changeset: 2ab74e5dbdc2 Author:roland Date: 2017-06-23 09:33 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/2ab74e5dbdc2 8181742: Load that bypasses arraycopy has wrong memory state Summary: Set load memory edge to the memory state right before the arraycopy. Reviewed

hg: jigsaw/jake/corba: 2 new changesets

2017-07-01 Thread alan . bateman
Changeset: 76cebcdca958 Author:lana Date: 2017-06-29 17:26 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/76cebcdca958 Added tag jdk-9+176 for changeset 40fb9f229471 ! .hgtags Changeset: ace27af8942f Author:alanb Date: 2017-07-01 07:58 +0100 URL: http:/

hg: jigsaw/jake/jdk: 4 new changesets

2017-07-01 Thread alan . bateman
Changeset: 2425838cfb5e Author:mullan Date: 2017-06-23 14:32 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/2425838cfb5e 8182652: RuntimePermission("usePolicy") is not a Java SE permission Reviewed-by: mchung ! src/java.base/share/classes/java/lang/RuntimePermission.java

hg: jigsaw/jake/jaxws: 2 new changesets

2017-07-01 Thread alan . bateman
Changeset: 880541212285 Author:lana Date: 2017-06-29 17:26 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/880541212285 Added tag jdk-9+176 for changeset ea819b6009d3 ! .hgtags Changeset: 7c7fed544711 Author:alanb Date: 2017-07-01 07:58 +0100 URL: http:/

hg: jigsaw/jake/langtools: 3 new changesets

2017-07-01 Thread alan . bateman
Changeset: 0d0ac75b0f6c Author:jjg Date: 2017-06-26 18:48 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/0d0ac75b0f6c 8182736: javadoc generates bad names and broken module graph links Reviewed-by: jjg, bpatel, darcy, ksrini Contributed-by: bhavesh.pa...@oracle.com,

Re: Non Standadrd Module Attribute

2017-06-29 Thread Alan Bateman
On 29/06/2017 03:04, fo...@univ-mlv.fr wrote: : yes, it's what i'm believing too. To take an example, currently, the module-info of java.sql as n attribute ModuleTarget which is empty, IMO only java.base should have a module attribute ModuleTarget. Okay, I understand what you are saying now. Wh

Re: Proposal (revised): Allow illegal access to internal APIs by default in JDK 9

2017-06-28 Thread Alan Bateman
On 28/06/2017 14:46, Robert Gibson wrote: Sure. (It actually doesn't make any difference how the app is started, browser or javaws, results are the same in either case.) Can you confirm that this is Windows only? Andy tells me that javaws.exe is the equivalent of javaw.exe rather than java.

Re: Non Standadrd Module Attribute

2017-06-28 Thread Alan Bateman
On 28/06/2017 12:12, Remi Forax wrote: Hi Alan, hi all, i've implemented the non standard attributes ModuleTarget, ModuleHashes and ModuleResolution in ASM. First, given that i was not able to find a document that describe them, i've used the javadoc of the classes inside jdk.internal.module.C

Re: Proposal (revised): Allow illegal access to internal APIs by default in JDK 9

2017-06-28 Thread Alan Bateman
On 28/06/2017 08:54, Robert Gibson wrote: : Thanks for the follow-up: the debug option doesn't seem to work, bug report filed as 9049772 - hope it doesn't get targeted to 10 ;) If the illegal access is succeeding then it means Java Web Start has picked up the option that you added via Control

Re: Proposal (revised): Allow illegal access to internal APIs by default in JDK 9

2017-06-27 Thread Alan Bateman
On 27/06/2017 08:46, Robert Gibson wrote: : Hi Alan, Thanks for your quick response. No debug option? Not in the JNLP but you should be able to use the Java Control Panel to add `--illegal-access=debug`. -Alan.

Re: Proposal (revised): Allow illegal access to internal APIs by default in JDK 9

2017-06-27 Thread Alan Bateman
On 27/06/2017 08:24, Robert Gibson wrote: Hi Mark, What is the intended interaction between this proposal and Java Web Start? I'm testing with JDK EA build 175 and it looks like a VM launched through Web Start is running with --illegal-access=deny, with no possibility of changing it - is this

Re: Missing translation for "--illegal-access"; Hadoop problems with build 175

2017-06-26 Thread Alan Bateman
On 26/06/2017 08:35, Uwe Schindler wrote: : So I just wanted to give you some feedback that translations are obviously missing. FYI, the Linux version in English returns the correct text. The last translation drop went into jdk-9+172 so it's out of sync with the CLI/usage messages in builds si

hg: jigsaw/jake/hotspot: 6 new changesets

2017-06-26 Thread alan . bateman
Changeset: 8346c00b2ba6 Author:mchung Date: 2017-06-17 11:50 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/8346c00b2ba6 8182416: Clean up module-info.java like move requires transitive adjacent to exports Reviewed-by: alanb ! src/jdk.aot/share/classes/module-info.j

hg: jigsaw/jake/jaxp: 4 new changesets

2017-06-26 Thread alan . bateman
Changeset: bc9aafd4cee2 Author:mchung Date: 2017-06-17 11:50 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/bc9aafd4cee2 8182416: Clean up module-info.java like move requires transitive adjacent to exports Reviewed-by: alanb ! src/java.xml/share/classes/module-info.jav

hg: jigsaw/jake: 5 new changesets

2017-06-26 Thread alan . bateman
Changeset: 7df4f16bfa8f Author:mr Date: 2017-06-19 18:20 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/7df4f16bfa8f 8182408: Simplify the API-specification overview page Reviewed-by: erikj, mchung, jrose, alanb ! make/Docs.gmk Changeset: 985eae459953 Author:mchung Date

hg: jigsaw/jake/nashorn: 3 new changesets

2017-06-26 Thread alan . bateman
Changeset: 734b3209b6ed Author:mchung Date: 2017-06-17 11:50 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/734b3209b6ed 8182416: Clean up module-info.java like move requires transitive adjacent to exports Reviewed-by: alanb ! src/jdk.scripting.nashorn.shell/share/c

hg: jigsaw/jake/jdk: 14 new changesets

2017-06-26 Thread alan . bateman
Changeset: a59b6b3fc4dd Author:mchung Date: 2017-06-17 11:50 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a59b6b3fc4dd 8182416: Clean up module-info.java like move requires transitive adjacent to exports Reviewed-by: alanb ! src/java.base/share/classes/module-info.jav

hg: jigsaw/jake/corba: 3 new changesets

2017-06-26 Thread alan . bateman
Changeset: dc78a3dd6b3a Author:mchung Date: 2017-06-17 11:50 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/dc78a3dd6b3a 8182416: Clean up module-info.java like move requires transitive adjacent to exports Reviewed-by: alanb ! src/java.corba/share/classes/module-info.

hg: jigsaw/jake/langtools: 7 new changesets

2017-06-26 Thread alan . bateman
Changeset: bd10ad9aefb3 Author:mchung Date: 2017-06-17 11:50 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/bd10ad9aefb3 8182416: Clean up module-info.java like move requires transitive adjacent to exports Reviewed-by: alanb ! src/java.compiler/share/classes/modul

hg: jigsaw/jake/jaxws: 4 new changesets

2017-06-26 Thread alan . bateman
Changeset: 083973007bef Author:mchung Date: 2017-06-17 11:51 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/083973007bef 8182416: Clean up module-info.java like move requires transitive adjacent to exports Reviewed-by: alanb ! src/java.activation/share/classes/module-

Re: 8182482: Module System spec updates

2017-06-21 Thread Alan Bateman
On 20/06/2017 20:51, Rony G. Flatscher wrote: Maybe a few little things: : * in the "stream" (method-detail) description, second paragraph, second sentence, there is a "the" too many: If a service provider cannot be loaded for any of *the* *the* reasons... Thanks.

Re: 8182482: Module System spec updates

2017-06-21 Thread Alan Bateman
On 21/06/2017 09:27, Hamlin Li wrote: : Besides of it, I have some minor comments about the doc: In section "Timing of provider discovery", it says as below: Each invocation of the|iterator|method returns an|Iterator|that first yields all of the elements cached from previous iteration, in

Re: 8182482: Module System spec updates

2017-06-21 Thread Alan Bateman
On 21/06/2017 07:10, Hamlin Li wrote: : It's possible to have 2 public static no-args method "provider" in a service provider *class file*, JVM spec allows it, Right, you can't do this in the Java Language but the JVMS allows it. The most obvious usage of this "feature" is covariant return typ

Re: 8182482: Module System spec updates

2017-06-20 Thread Alan Bateman
On 20/06/2017 14:02, Rony G. Flatscher wrote: Just a side-note: when printing with the latest Firefox the headers cover part of the text, which makes printing of such Javadocs somewhat useless. Not sure where to report this, so posting it here. The printout of the generated javadoc is enclosed

Re: 8182482: Module System spec updates

2017-06-20 Thread Alan Bateman
On 20/06/2017 11:39, Remi Forax wrote: Hi Alan, the doc is clearly better. Can you change A service is a single type, usually an interface or abstract class. A concrete class can be used, but this is not recommended. to A service is a single type, usually an interface. An abstract class o

8182482: Module System spec updates

2017-06-20 Thread Alan Bateman
We have two javadoc/spec updates that I'd like to get into the JDK 9 Initial Release Candidate that is scheduled for this week. The spec updates are for two issues: 1. ServiceLoader: The API spec has been updated significantly to support modules but it needs another round of update to do clean

Re: Review Request JDK-8182416: Clean up module-info.java like move requires transitive adjacent to exports

2017-06-17 Thread Alan Bateman
On 17/06/2017 16:19, Mandy Chung wrote: On Jun 17, 2017, at 7:26 AM, Alan Bateman wrote: On 17/06/2017 07:27, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.00/ This patch cleans up module-info.java mainly moving requires transitive before exports, group

hg: jigsaw/jake/jaxp: 2 new changesets

2017-06-17 Thread alan . bateman
Changeset: f0eb5431121e Author:joehw Date: 2017-06-15 12:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/f0eb5431121e 8182111: Package summary is missing in jdk.xml.dom module Reviewed-by: mchung + src/jdk.xml.dom/share/classes/org/w3c/dom/css/package-info.java + src/

hg: jigsaw/jake/langtools: 5 new changesets

2017-06-17 Thread alan . bateman
Changeset: bbb3a10fce39 Author:jjg Date: 2017-06-15 14:45 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/bbb3a10fce39 8181825: Add tool and services information to module summary Reviewed-by: mchung, rfield ! src/jdk.compiler/share/classes/com/sun/tools/javac/Main.

hg: jigsaw/jake/hotspot: 11 new changesets

2017-06-17 Thread alan . bateman
Changeset: 79b6a9bd5c3b Author:fyang Date: 2017-06-10 16:01 +0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/79b6a9bd5c3b 8181906: AArch64: port bugfix for 7009641 to AArch64 Summary: Allocation in the code cache returns NULL instead of failing the entire VM Reviewed-b

hg: jigsaw/jake/jdk: 20 new changesets

2017-06-17 Thread alan . bateman
Changeset: e8f3a872e69a Author:psandoz Date: 2017-06-12 14:30 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e8f3a872e69a 8181442: Deprecate sun.misc.Unsafe.defineClass Reviewed-by: shade, mchung ! src/jdk.unsupported/share/classes/sun/misc/Unsafe.java Changeset: 573efb

hg: jigsaw/jake/corba: 2 new changesets

2017-06-17 Thread alan . bateman
Changeset: e68b042f7130 Author:msheppar Date: 2017-06-16 20:37 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/e68b042f7130 8181836: BadKindHelper.html and BoundsHelper.html contains broken link in the javadoc Reviewed-by: chegar ! src/java.corba/share/classes/org/omg/

hg: jigsaw/jake: 7 new changesets

2017-06-17 Thread alan . bateman
Changeset: 35f50e9952e4 Author:mchung Date: 2017-06-13 10:44 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/35f50e9952e4 8182029: Make the top-level docs index.html to a HTML-level redirect to the API overview page Reviewed-by: alanb, erikj, ihse ! make/Docs.gmk Changeset:

hg: jigsaw/jake/jaxws: 2 new changesets

2017-06-17 Thread alan . bateman
Changeset: c9b85ef1567e Author:lancea Date: 2017-06-16 19:12 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/c9b85ef1567e 8182405: add legal file for freebxml Reviewed-by: mchung + src/jdk.xml.bind/share/legal/freebxml.md Changeset: e8582f469c79 Author:alanb Date:

Re: Review Request JDK-8182416: Clean up module-info.java like move requires transitive adjacent to exports

2017-06-17 Thread Alan Bateman
On 17/06/2017 07:27, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.00/ This patch cleans up module-info.java mainly moving requires transitive before exports, group exports/opens (packages) together and uses/provides (services) next. Document if a module is u

Re: Incompatible change to java.lang.instrument.Instrumentation

2017-06-16 Thread Alan Bateman
On 16/06/2017 10:08, Sven Reimers wrote: Hi Peter, nice idea. The only drawback is this requires JDK 9 for a build. What I wanted to check is if I can compile the same unchanged source tree with JDK 8 and 9... Since there is not yet a hard requirement for JDK 9 compilation, i.e. this is just an

hg: jigsaw/jake/jdk: 2 new changesets

2017-06-16 Thread alan . bateman
Changeset: cb616bb8b8d0 Author:alanb Date: 2017-06-16 07:55 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cb616bb8b8d0 com/sun/tools/attach/StartManagementAgent.java failing ! test/ProblemList.txt Changeset: c7c2a3e12341 Author:alanb Date: 2017-06-16 13:34 +01

Re: 8181087: Module system implementation refresh (6/2017 update)

2017-06-16 Thread Alan Bateman
On 14/06/2017 22:44, Peter Levart wrote: : In j.l.Module: There are two places in the same method that contain exactly the same fragment of code: 566 if (targets.contains(EVERYONE_MODULE) || targets.contains(other)) 567 return true; 568

Re: 8181087: Module system implementation refresh (6/2017 update)

2017-06-16 Thread Alan Bateman
On 15/06/2017 15:28, Mandy Chung wrote: On Jun 15, 2017, at 12:34 AM, Alan Bateman wrote: java/lang/Module.java 901 void implAddOpensToAllUnnamed(Iterator iterator) { 902 if (jdk.internal.misc.VM.isModuleSystemInited()) { 903 iterator.forEachRemaining(pn

Re: Accessing module internals from bytecode rewriting agent

2017-06-16 Thread Alan Bateman
On 16/06/2017 10:26, Michael Rasmussen wrote: : If going that route, then there are 3 capabilities added with JVMTI 9 that you should look into, in order to be able to intercept the loading of the very early classes as well (Object, String, Class etc): can_generate_early_vmstart can_generate_all_

Re: Incompatible change to java.lang.instrument.Instrumentation

2017-06-16 Thread Alan Bateman
On 16/06/2017 08:40, Jaroslav Tulach wrote: : So can you say what NetBeans is doing? Is this mocking, maybe forwarding/intercepting? See https://netbeans.org/bugzilla/show_bug.cgi?id=237919 If I read this correctly then NBInstrumentation is only interested in the addTransformer methods. If no

Re: Explicitly empty sourcepath regression

2017-06-15 Thread Alan Bateman
On 16/06/2017 05:07, Pepper Lebeck-Jobe wrote: I'll start with a question, and then give an opinion. *Question* Why must the source files which make up a module be on the source path for the module to be compiled? *Opinion* Build tools, especially Gradle, attempt to make reproducible builds a r

Re: Incompatible change to java.lang.instrument.Instrumentation

2017-06-15 Thread Alan Bateman
On 16/06/2017 06:54, Sven Reimers wrote: Hi all, as part of the process of the code donation from Oracle to Apache for NetBeans I tried a compilation of the source code using idk 9-ea+173. The compilation fails due to an added method boolean isModifiableModule(Module) in java.lang.instrument.Ins

hg: jigsaw/jake/corba: 2 new changesets

2017-06-15 Thread alan . bateman
Changeset: 6a33ed672191 Author:lana Date: 2017-06-15 17:24 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/6a33ed672191 Added tag jdk-9+174 for changeset 3615768c1290 ! .hgtags Changeset: 2b5fa3512f1f Author:alanb Date: 2017-06-15 20:18 +0100 URL: http:/

hg: jigsaw/jake/hotspot: 7 new changesets

2017-06-15 Thread alan . bateman
Changeset: bb5c32e2d31a Author:eosterlund Date: 2017-06-06 13:31 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/bb5c32e2d31a 8161145: The min/max macros make hotspot tests fail to build with GCC 6 Summary: Change min/max macros to expand (once) to self. Reviewed-by: s

hg: jigsaw/jake/langtools: 5 new changesets

2017-06-15 Thread alan . bateman
Changeset: 733fb11b37d4 Author:jjg Date: 2017-06-08 15:50 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/733fb11b37d4 8180296: Move Javadoc: doclet, taglet specs to specs directory Reviewed-by: ksrini ! src/jdk.compiler/share/classes/com/sun/source/doctree/package-

hg: jigsaw/jake/nashorn: 4 new changesets

2017-06-15 Thread alan . bateman
Changeset: 7b12e7ae Author:mchung Date: 2017-06-07 18:57 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/7b12e7ae 8181639: Add tool and services information to module summary Reviewed-by: alanb, psandoz, lancea ! src/jdk.dynalink/share/classes/module-info.java

hg: jigsaw/jake: 5 new changesets

2017-06-15 Thread alan . bateman
Changeset: 577896ffb41a Author:mchung Date: 2017-06-07 21:15 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/577896ffb41a 8181639: Add tool and services information to module summary Reviewed-by: alanb, psandoz, lancea ! make/common/Modules.gmk Changeset: abe884590f03 Author

hg: jigsaw/jake/jaxp: 4 new changesets

2017-06-15 Thread alan . bateman
Changeset: 0ca686e3e26b Author:mchung Date: 2017-06-07 21:08 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/0ca686e3e26b 8181639: Add tool and services information to module summary Reviewed-by: alanb, psandoz, lancea ! src/java.xml/share/classes/module-info.java Chang

hg: jigsaw/jake/jaxws: 5 new changesets

2017-06-15 Thread alan . bateman
Changeset: 0d797e800441 Author:lancea Date: 2017-06-07 18:47 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/0d797e800441 8181702: Mark jdk.xml.bind and jdk.xml.ws modules deprecated and for removal Reviewed-by: alanb, mchung ! src/jdk.xml.bind/share/classes/module-info

hg: jigsaw/jake/jdk: 22 new changesets

2017-06-15 Thread alan . bateman
Changeset: ffa11326afd5 Author:psandoz Date: 2017-06-05 16:05 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ffa11326afd5 8181292: Backport Rename internal Unsafe.compare methods from 10 to 9 Reviewed-by: psandoz, dholmes, mchung Contributed-by: ron.press...@oracle.com !

hg: jigsaw/jake/jdk: 3 new changesets

2017-06-15 Thread alan . bateman
Changeset: b9f3633bf293 Author:alanb Date: 2017-06-15 13:15 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b9f3633bf293 Review comments ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/util/ServiceLoader.java ! src/java.base/share/cla

hg: jigsaw/jake/hotspot: Remove --permit-illegal-access

2017-06-15 Thread alan . bateman
Changeset: 6b59d482c269 Author:alanb Date: 2017-06-15 13:23 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/6b59d482c269 Remove --permit-illegal-access ! src/share/vm/runtime/arguments.cpp

Re: Accessing module internals from bytecode rewriting agent

2017-06-15 Thread Alan Bateman
On 15/06/2017 01:00, Jeremy Manson wrote: : The upshot is that, in the same way as we would have turned on the big kill switch by default to ease the transition, we are also likely to implement -Xbootclasspath/p to ease the transition. You might find it easier to add --patch-module to your JDK

Re: 8181087: Module system implementation refresh (6/2017 update)

2017-06-15 Thread Alan Bateman
On 15/06/2017 06:37, Mandy Chung wrote: : java/lang/Class.java 2453 reflectionFactory.getExecutableSharedParameterTypes(method), reflectionFactory should be accessed via getReflectionFactory(). I see Peter already comments on this. Thanks, it should be getReflectionFacto

Re: 8181087: Module system implementation refresh (6/2017 update)

2017-06-15 Thread Alan Bateman
Thanks for looking through this. On 14/06/2017 22:44, Peter Levart wrote: : ...where you use the 'reflectionFactory' field one time and 'getReflectionFactory()' method another time. The field might not already be initialized... Well spotted, it should be using getReflectionFactory(), not ref

8181087: Module system implementation refresh (6/2017 update)

2017-06-14 Thread Alan Bateman
It's time to bring the changes accumulated in the jake forest into jdk9/dev. I'm hoping we are near the end of these updates and that we can close the jake forest soon. A summary of the changes that have accumulated for this update are listed in this issue: https://bugs.openjdk.java.net/b

hg: jigsaw/jake/jdk: Restore paragraph on SM, removed in error

2017-06-14 Thread alan . bateman
Changeset: c488bbb509d9 Author:alanb Date: 2017-06-14 16:58 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c488bbb509d9 Restore paragraph on SM, removed in error ! src/java.base/share/classes/java/lang/ModuleLayer.java

hg: jigsaw/jake/jdk: 4 new changesets

2017-06-14 Thread alan . bateman
Changeset: 4d68e26297db Author:alanb Date: 2017-06-14 09:31 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4d68e26297db More clean-up/clarification to jl.instrument spec ! src/java.instrument/share/classes/java/lang/instrument/package-info.java Changeset: 4c1a6e0ad708 A

Re: Accessing module internals from bytecode rewriting agent

2017-06-14 Thread Alan Bateman
On 14/06/2017 00:57, Jeremy Manson wrote: Hey folks, As a followup to this, given everything else that has happened in the mean time: I wonder if the same logic Mark put in his proposal to allow illegal access to internal APIs ( http://mail.openjdk.java.net/pipermail/jigsaw-dev/2017-June/012841.

hg: jigsaw/jake/jdk: More clean-up of SL javadoc

2017-06-13 Thread alan . bateman
Changeset: 7ec1b2a769fe Author:alanb Date: 2017-06-13 21:01 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/7ec1b2a769fe More clean-up of SL javadoc ! src/java.base/share/classes/java/util/ServiceLoader.java

hg: jigsaw/jake/jdk: Migrate jl.instrument package.html to package-info.java, misc. cleanup

2017-06-13 Thread alan . bateman
Changeset: 9269173b154d Author:alanb Date: 2017-06-13 13:56 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9269173b154d Migrate jl.instrument package.html to package-info.java, misc. cleanup + src/java.instrument/share/classes/java/lang/instrument/package-info.java - src

Re: Review Request JDK-8182032: Make java.compiler upgradeable

2017-06-13 Thread Alan Bateman
On 13/06/2017 08:42, Remi Forax wrote: Hi Mandy, why only java.compiler is upgradable and not all modules defined in langtools ? java.compiler needs to be upgradeable because JSR 199 and JSR 269 are standalone technologies. The other modules in the langtools repository are JDK-specific. They

hg: jigsaw/jake/jdk: Move locating/ordering sections from SL spec to SL.load methods

2017-06-12 Thread alan . bateman
Changeset: 01a5ea9fa211 Author:alanb Date: 2017-06-12 19:30 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/01a5ea9fa211 Move locating/ordering sections from SL spec to SL.load methods ! src/java.base/share/classes/java/util/ServiceLoader.java

hg: jigsaw/jake/jdk: Cleanup of CL spec, move text for default implementation to @implSpec

2017-06-12 Thread alan . bateman
Changeset: 741bd322be3e Author:alanb Date: 2017-06-12 12:01 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/741bd322be3e Cleanup of CL spec, move text for default implementation to @implSpec ! src/java.base/share/classes/java/lang/ClassLoader.java

Re: Why is -XD-Xmodule hidden?

2017-06-12 Thread Alan Bateman
On 11/06/2017 16:26, Jonathan Gibbons wrote: There are some tests which still need to be changed to use --patch-module. Once all uses of -Xmodule have been removed from tests, we will remove the (hidden/undocumented) option. I thought this was done already but I see now that there are small

Re: Why is -XD-Xmodule hidden?

2017-06-11 Thread Alan Bateman
On 11/06/2017 08:57, Nicolai Parlog wrote: : With --patch-module I get the same errors as without: javac --module-path mods -d classes \ --patch-module monitor.rest=mods/monitor.rest.jar \ monitor.rest/src/main/java/monitor/rest/MonitorServer.java I agree the documentation needs

Re: Why is -XD-Xmodule hidden?

2017-06-11 Thread Alan Bateman
On 11/06/2017 08:13, Nicolai Parlog wrote: Hi! When incrementally compiling some of a module's sources it is necessary to make the compiler aware that the sources actually belong to that module. One way to do this was the non-standard option -Xmodule, which was recently demoted to the hidden -

Re: Fwd: Using java.sql.Time in an Agent?

2017-06-09 Thread Alan Bateman
On 09/06/2017 16:01, Todd West wrote: I am currently running into an issue where a usage of java.sql.Time in an Agent prevents the agent from starting correctly when running on JDK 9. Here is the example I am testing with: https://github.com/AdoptOpenJDK/jdk9-jigsaw/tree/ master/session-1-jigsaw

hg: jigsaw/jake/jdk: More ServiceLoader tests

2017-06-09 Thread alan . bateman
Changeset: 208848417e5e Author:alanb Date: 2017-06-09 15:42 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/208848417e5e More ServiceLoader tests ! test/java/util/ServiceLoader/ModulesTest.java

hg: jigsaw/jake/jdk: Add additional tests to exercise addExports/addOpens with --illegal-access

2017-06-09 Thread alan . bateman
Changeset: 5a5c798c2ef9 Author:alanb Date: 2017-06-09 14:08 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/5a5c798c2ef9 Add additional tests to exercise addExports/addOpens with --illegal-access ! test/tools/launcher/modules/illegalaccess/IllegalAccessTest.java ! test/to

hg: jigsaw/jake/jdk: Update JCP technology summary page

2017-06-09 Thread alan . bateman
Changeset: ba87fa8f1282 Author:alanb Date: 2017-06-09 08:18 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ba87fa8f1282 Update JCP technology summary page Contributed-by: alex.buck...@oracle.com ! make/src/classes/build/tools/jigsaw/technology-summary.html

hg: jigsaw/jake/jaxp: 2 new changesets

2017-06-08 Thread alan . bateman
Changeset: 67ce05675aaf Author:lana Date: 2017-06-08 16:32 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/67ce05675aaf Added tag jdk-9+173 for changeset 9788347e0629 ! .hgtags Changeset: 21950dd23de4 Author:alanb Date: 2017-06-08 18:38 +0100 URL: http://

hg: jigsaw/jake/jaxws: 2 new changesets

2017-06-08 Thread alan . bateman
Changeset: 40b9dc95ccbb Author:lana Date: 2017-06-08 16:32 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/40b9dc95ccbb Added tag jdk-9+173 for changeset 2bd967aa452c ! .hgtags Changeset: e59303e8d946 Author:alanb Date: 2017-06-08 18:38 +0100 URL: http:/

hg: jigsaw/jake/hotspot: 8 new changesets

2017-06-08 Thread alan . bateman
Changeset: e939acda146e Author:vlivanov Date: 2017-05-30 21:35 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e939acda146e 8179882: C2: Stale control info after cast node elimination during loop optimization pass Reviewed-by: kvn, roland ! src/share/vm/opto/loopnode

hg: jigsaw/jake/corba: 5 new changesets

2017-06-08 Thread alan . bateman
Changeset: d5fd6bd57a56 Author:jjg Date: 2017-05-30 15:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/d5fd6bd57a56 8181290: Invalid HTML 5 in core-libs docs Reviewed-by: mchung, lancea ! src/java.corba/share/classes/org/omg/CORBA/doc-files/generatedfiles.html Chang

hg: jigsaw/jake/nashorn: 2 new changesets

2017-06-08 Thread alan . bateman
Changeset: df6109f734e8 Author:lana Date: 2017-06-08 16:32 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/df6109f734e8 Added tag jdk-9+173 for changeset fa8e4de50e82 ! .hgtags Changeset: 53da60749b59 Author:alanb Date: 2017-06-08 18:38 +0100 URL: http

hg: jigsaw/jake: 4 new changesets

2017-06-08 Thread alan . bateman
Changeset: 3ad8b22b022c Author:rriggs Date: 2017-06-01 10:21 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/3ad8b22b022c 8181156: html5 issues in java.base javadoc Reviewed-by: ihse, erikj ! make/CompileJavaModules.gmk Changeset: 88d7fd969e7d Author:lana Date: 2017

hg: jigsaw/jake/jdk: 13 new changesets

2017-06-08 Thread alan . bateman
Changeset: 54551ea84184 Author:mchung Date: 2017-05-30 14:12 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/54551ea84184 8181148: Update the jdeps tool to list exported packages instead of just internal APIs Reviewed-by: psandoz + make/src/classes/build/tools/jigsaw/Lis

hg: jigsaw/jake/langtools: 5 new changesets

2017-06-08 Thread alan . bateman
Changeset: 5be57bc01147 Author:mchung Date: 2017-05-30 14:11 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5be57bc01147 8181148: Update the jdeps tool to list exported packages instead of just internal APIs Reviewed-by: psandoz - make/src/classes/build/tools/list

Re: Request Review: JDK-8181639 Add tool and services information to module summary

2017-06-07 Thread Alan Bateman
On 07/06/2017 18:58, Mandy Chung wrote: I updated the javadoc per your comment/suggestion. My reply to some of your comments are inlined below. Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8181639/webrev.01/ Module summary pages: http://cr.openjdk.java.net/~mchung/jdk9/webrevs

<    1   2   3   4   5   6   7   8   9   10   >