Re: RFR 8178323: Add negative tests for bind services Jlink feature

Apr 2017, at 12:46, Andrey Nazarov <andrey.x.naza...@oracle.com> wrote: > > Hi Mandy, > > Here is updated patch > http://cr.openjdk.java.net/~anazarov/8178323/webrev.02/webrev/ > <http://cr.openjdk.java.net/~anazarov/8178323/webrev.02/webrev/> > > — Thanks, >

Re: RFR 8178323: Add negative tests for bind services Jlink feature

Hi Mandy, Here is updated patch http://cr.openjdk.java.net/~anazarov/8178323/webrev.02/webrev/ <http://cr.openjdk.java.net/~anazarov/8178323/webrev.02/webrev/> — Thanks, Andrey > On 10 Apr 2017, at 23:50, Mandy Chung <mandy.ch...@oracle.com> wrote: > > >> On Apr 10

Re: RFR 8178323: Add negative tests for bind services Jlink feature

oracle.com>> wrote: > > >> On Apr 10, 2017, at 12:30 PM, Andrey Nazarov <andrey.x.naza...@oracle.com >> <mailto:andrey.x.naza...@oracle.com>> wrote: >> >> Mandy, thanks for review. I’ve updated patch >> http://cr.openjdk.java.net/~anazarov/8178323/webre

Re: RFR 8178323: Add negative tests for bind services Jlink feature

t;> On Apr 7, 2017, at 8:40 AM, Andrey Nazarov <andrey.x.naza...@oracle.com> >> wrote: >> >> Hi, >> >> Please review 3 negative tests for Jlink which tests new >> bind-services/suggest-providers feature. >> >> JBS: https://bugs.openjd

RFR 8178323: Add negative tests for bind services Jlink feature

Hi, Please review 3 negative tests for Jlink which tests new bind-services/suggest-providers feature. JBS: https://bugs.openjdk.java.net/browse/JDK-8178323 webrev: http://cr.openjdk.java.net/~anazarov/8178323/webrev.00/webrev/

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

Hi Mandy > On 23 Mar 2017, at 21:07, Mandy Chung <mandy.ch...@oracle.com> wrote: > > >> On Mar 23, 2017, at 10:47 AM, Andrey Nazarov <andrey.x.naza...@oracle.com> >> wrote: >> >> Hi Mandy, >> >> TaskHelper.java, JLinkTest and Integratio

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

Hi Mandy, TaskHelper.java, JLinkTest and IntegrationTest need new copyright year. It’s unclear why do you need concept of “terminal” option Instead of "copy-paste" code to run Jlink in tests ProcessTools and OutputAnalyzer can be used from standard test library

Re: [9] RFR 8170113: jimage extract to readonly directory causes MissingResourceException

Hi, looks ok for me. Simple and safe fix. —Andrey > On 9 Feb 2017, at 13:03, Denis Kononenko wrote: > > > Hi, > >> >> On 06/02/2017 10:27, Denis Kononenko wrote: >>> Hi, >>> >>> Could someone please review this very small fix. >>> >>> The class JImageTask >>

Re: 8170987: Module system implementation refresh (12/2016)

Langtools changes look good. —Andrey > On 15 Dec 2016, at 00:46, Alan Bateman wrote: > > Folks on jigsaw-dev will be aware that we are on yet another mission to bring > the changes accumulated in the jake forest to jdk9/dev. The plan this time is > to bring the

Re: RFR [9] 8166568 & 8169492 jmod extract and bug fix

Looks good, thanks —Andrey > On 8 Dec 2016, at 19:16, Alan Bateman wrote: > > > > On 08/12/2016 13:09, Chris Hegarty wrote: >> : >>> >>> Looks good. I agree with Alan and it’d be good to take the destination >>> directory to which the contents are written. FYI.

Re: RFR [9] 8166568 & 8169492 jmod extract and bug fix

Hi Chris, Changes looks good. I think tests should be added for case when there are extracted files in directory. —Andrey > On 6 Dec 2016, at 14:44, Chris Hegarty wrote: > > [ forwarding to a more appropriate list to review this change ] > >> Begin forwarded

Re: Code review for jigsaw/jake -> jdk9/dev sync up

Hi, I’ve reviewed Langtools code. There are various comment “//TODO”, “//FIXME”, “//XXX”. I think they should be revised. May be issues should be filed to track them. Unused import at 37 import java.io.IOException; in langtools/test/tools/javac/modules/ModuleInfoTest.java ASCII graphics issue

Re: [9] RFR: 8170120: Several new jimage testcases should be excluded due to their failures

Hi, Looks OK to me. —Andrey > On 22 Nov 2016, at 15:51, Denis Kononenko wrote: > > > Hi, > > Could someone please review this small fix. > > Recently several failing test cases were delivered into jdk9-dev by my > mistake

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

Hi, Looks OK. Is it 100% pass rate? —Andrey > On 9 Nov 2016, at 20:36, Denis Kononenko wrote: > > > > Hi, > > After discussion with Andrey we decided to add more tests for corner cases. > The new changes are available by the link below. > > WEBREV:

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

Hi, Looks OK to me. I can suggest two more cases. A directory and file symlink can be passed in options where tool requires a file path. —Andrey > On 8 Nov 2016, at 16:17, Denis Kononenko wrote: > > > Hi, > > The new version of changes. > > - Switched back to

RFR 8149683: Eliminate jdk.zipfs dependency.

Hi. Could you please take a look on eliminating jdk.zipfs module dependency which was added by http://cr.openjdk.java.net/~shurailine/8149391/webrev.jake.00/ Tested locally on Windows. All tests which depend on CompileUtils are passed. https://bugs.openjdk.java.net/browse/JDK-8149683 Jake