Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-12 Thread Erik Joelsson
Hello, On 2019-02-12 09:05, Severin Gehwolf wrote: Hi Erik, On Tue, 2019-02-12 at 08:44 -0800, Erik Joelsson wrote: On 2019-02-12 01:35, Severin Gehwolf wrote: Hi Erik, On Mon, 2019-02-11 at 11:12 -0800, Erik Joelsson wrote: Hello Severin, I think you also need a $(wildcard ) around it

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-12 Thread Erik Joelsson
On 2019-02-12 01:35, Severin Gehwolf wrote: Hi Erik, On Mon, 2019-02-11 at 11:12 -0800, Erik Joelsson wrote: Hello Severin, I think you also need a $(wildcard ) around it, but I may be wrong. Did you try this version? Yes, this version works for me without $(wildcard). Why is it needed

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-11 Thread Erik Joelsson
-conventions.html On 2019-02-11 10:03, Severin Gehwolf wrote: Hi Erik, On Thu, 2019-02-07 at 17:01 -0800, Erik Joelsson wrote: On 2019-02-07 11:09, Severin Gehwolf wrote: Hi Erik, On Thu, 2019-02-07 at 09:39 -0800, Erik Joelsson wrote: Hello Severin, There is a macro for automatically finding all

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-07 Thread Erik Joelsson
On 2019-02-07 11:09, Severin Gehwolf wrote: Hi Erik, On Thu, 2019-02-07 at 09:39 -0800, Erik Joelsson wrote: Hello Severin, There is a macro for automatically finding all source dirs for a module. So in Gensrc-jdk.jlink.gmk, I think it would be better expressed using that macro, like this

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-07 Thread Erik Joelsson
Hello Severin, There is a macro for automatically finding all source dirs for a module. So in Gensrc-jdk.jlink.gmk, I think it would be better expressed using that macro, like this: JLINK_RESOURCE_DIRS := $(wildcard $(addsuffix /jdk/tools/jlink/resources, $(call FindModuleSrcSdirs, jdk.jlink

Re: [12] RFR JDK-8202941: GenModuleInfoSource build tool does not detect missing semicolons

2018-07-27 Thread Erik Joelsson
Build change looks good. /Erik On 2018-07-27 13:12, mandy chung wrote: GenModuleInfoSource build tool augments module-info.java to include platform-specific qualified exports/opens and uses/provides services. This fixes the build tool to catch syntax errors as closely as javac does. The build

Re: RFR: JDK-8194141: Remove JDK9Wrappers

2018-01-04 Thread Erik Joelsson
Looks good to me. /Erik On 2018-01-03 23:42, Jonathan Gibbons wrote: Updated webrev, reverting unnecessary change to generated-configure.sh http://cr.openjdk.java.net/~jjg/8194141/webrev.01/ -- Jon On 01/03/2018 01:44 PM, Jonathan Gibbons wrote: Please review this code to remove a "temporar

Re: Review Request JDK-8182032: Make java.compiler upgradeable

2017-06-13 Thread Erik Joelsson
Hello Mandy, Looks good to me. /Erik On 2017-06-13 07:35, Mandy Chung wrote: Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182032/webrev.00/ java.compiler is a standalone technology that allows to be running on older JDK, in particular for IDE to support new language featu

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-11 Thread Erik Joelsson
On 2017-04-11 09:40, Magnus Ihse Bursie wrote: On 2017-04-07 22:04, Mandy Chung wrote: On Apr 6, 2017, at 1:09 AM, Magnus Ihse Bursie > wrote: Having though this over real hard, I'd realized I need to make a plea for sanity and consistency. I thoug

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-04 Thread Erik Joelsson
Oh, I missed the further discussion before I posted this and the webrev was apparently updated in place to reflect that discussion. Please ignore my comment below. /Erik On 2017-04-04 11:57, Erik Joelsson wrote: Hello, I don't quite understand this. In the proposition below it say

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-04 Thread Erik Joelsson
Hello, I don't quite understand this. In the proposition below it says osx, and x64, but in platform.m4 you generate macos and amd64. Does this then get translated again and why are we introducing yet another name for the operating system on Apple computers? /Erik On 2017-04-03 20:41, Mand

Re: Review Request: JDK-8173303: Add module-subgraph images to main platform documentation

2017-03-27 Thread Erik Joelsson
Looks ok to me. Not sure about adding a make variable as a parameter, but I assume Magnus will fix that as part of JDK-8176785? /Erik On 2017-03-25 22:33, Mandy Chung wrote: I edited the module descriptions per your feedback. I also revised GenGraphs tool to take a properties file to customi

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-22 Thread Erik Joelsson
(adding build-dev) Build changes look good to me. /Erik On 2017-03-21 22:42, Alan Bateman wrote: We have been accumulating changes in the jake forest for the last few weeks to align with the proposals in JSR 376 and also to pick up API changes and bug fixes. It's time to bring these changes

Re: RFR 8171316: Add IMPLEMENTOR property to the release file

2016-12-15 Thread Erik Joelsson
Looks good to me. /Erik On 2016-12-15 16:32, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8171316 top level webrev: http://cr.openjdk.java.net/~sundar/8171316/top/webrev.00/ jdk webrev: http://cr.openjdk.java.net/~sundar/8171316/jdk/webrev

Re: Review Request: JDK-8171201 & JDK-8171202: Drop java.compact$N aggregator modules

2016-12-14 Thread Erik Joelsson
Build changes look good to me. /Erik On 2016-12-14 07:49, Mandy Chung wrote: JDK-8171201: Drop java.compact$N aggregator modules JDK-8171202: Rename jdk.crypto.pkcs11 and jdk.pack200 to end with Java letters http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8171201%2b8171202/webrev.00/ Compact

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

2016-12-10 Thread Erik Joelsson
Looks good, thanks! /Erik On 2016-12-10 08:54, Mandy Chung wrote: On Dec 9, 2016, at 11:51 PM, Erik Joelsson wrote: Hello Mandy, In Copy-java.base.gmk. Modules.gmk is no longer needed. JMOD_* varaibles are no longer used. Good catch. In Main.gmk, it would be good with a comment

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

2016-12-09 Thread Erik Joelsson
Hello Mandy, In Copy-java.base.gmk. Modules.gmk is no longer needed. JMOD_* varaibles are no longer used. In Main.gmk, it would be good with a comment explaining why the jmods need java.base-copy. Something like: # All modules include the main license files from java.base. Otherwise I'm ok

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

2016-12-08 Thread Erik Joelsson
Hello Mandy, In autoconf you are also adding a "man" dir, is this intended with this change? In make/InterimImage.gmk, -J-Djlink.debug=true looks like left over debug code. make/CreateJmods.gmk: 83-84, please indent 4 spaces for continuation. make/Main.gmk: You should not add the dependenc

hg: jigsaw/jake: Adjusted workaround for javafx import with new module-info format

2016-11-29 Thread erik . joelsson
Changeset: 891ed56bc4da Author:erikj Date: 2016-11-29 17:52 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/891ed56bc4da Adjusted workaround for javafx import with new module-info format ! make/common/Modules.gmk

hg: jigsaw/jake: Regenerated configure after merge

2016-11-24 Thread erik . joelsson
Changeset: 13e19d185301 Author:erikj Date: 2016-11-24 11:37 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/13e19d185301 Regenerated configure after merge ! common/autoconf/generated-configure.sh

Re: Review Request: JDK-8169816 Move src.zip and jrt-fs.jar under the lib directory

2016-11-23 Thread Erik Joelsson
Build changes look good. /Erik On 2016-11-22 22:07, Mandy Chung wrote: This patch moves src.zip and jrt-fs.jar from the top-level into the `lib` directory in the run-time image as we proposed [1]. Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169816/webrev.00/ thanks Mandy [1] h

hg: jigsaw/jake/jdk: Parse module-info.java.extra in java build tool instead of makefile

2016-11-08 Thread erik . joelsson
Changeset: 65473330550b Author:erikj Date: 2016-11-08 17:01 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/65473330550b Parse module-info.java.extra in java build tool instead of makefile ! make/src/classes/build/tools/module/GenModuleInfoSource.java

hg: jigsaw/jake: Parse module-info.java.extra in java build tool instead of makefile

2016-11-08 Thread erik . joelsson
Changeset: 9795bd5076ec Author:erikj Date: 2016-11-08 17:01 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/9795bd5076ec Parse module-info.java.extra in java build tool instead of makefile ! make/GensrcModuleInfo.gmk

hg: jigsaw/jake: When importing modules, look in modules_src_jake for jake specific module-info.java files

2016-11-08 Thread erik . joelsson
Changeset: 07c57a17121e Author:erikj Date: 2016-11-08 14:40 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/07c57a17121e When importing modules, look in modules_src_jake for jake specific module-info.java files ! common/autoconf/generated-configure.sh ! common/autoconf/sourc

Re: RFR: 8165804: Revisit the way of loading BreakIterator rules/dictionaries

2016-10-24 Thread Erik Joelsson
Build change looks good. /Erik On 2016-10-20 10:33, Masayoshi Okutsu wrote: Hi, Please review the changes for JDK-8165804 which is a follow-up of JDK-8076757. Some notes on the changes. - Removed INCLUDES := $(TEXT_PKG_LD) from make/gendata/GendataBreakIterator.gmk in order to avoid compi

Re: RFR: 8154399, 8159096, export packages containing standard javadoc doclet

2016-06-21 Thread Erik Joelsson
Looks fine. /Erik On 2016-06-16 19:28, Jonathan Gibbons wrote: Please review this simple fix for two related aspects of the same problem: Export the "standard doclet" used by javadoc, such that it is possible to derive alternative doclets, either by delegation or subtyping. In JDK 9, javad

hg: jigsaw/jake/nashorn: Fixed -Xpatch usage bootcycle build

2016-04-12 Thread erik . joelsson
Changeset: 8e76d81a938e Author:erikj Date: 2016-04-12 14:18 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/8e76d81a938e Fixed -Xpatch usage bootcycle build ! make/BuildNashorn.gmk

hg: jigsaw/jake/jdk: Fixed -Xpatch usage bootcycle build

2016-04-12 Thread erik . joelsson
Changeset: d8729c2bd09c Author:erikj Date: 2016-04-12 14:18 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d8729c2bd09c Fixed -Xpatch usage bootcycle build ! make/gendata/GendataBreakIterator.gmk

hg: jigsaw/jake: Fixed -Xpatch usage bootcycle build

2016-04-12 Thread erik . joelsson
Changeset: fb05bc686bb6 Author:erikj Date: 2016-04-12 14:18 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/fb05bc686bb6 Fixed -Xpatch usage bootcycle build ! common/autoconf/boot-jdk.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in

hg: jigsaw/jake: Fixed cross compile build

2016-04-08 Thread erik . joelsson
Changeset: cb835147c8af Author:erikj Date: 2016-04-08 18:00 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/cb835147c8af Fixed cross compile build ! make/CreateBuildJdkCopy.gmk

Re: Review Request 8152197: Single place to specify module-specific information for images build

2016-03-22 Thread Erik Joelsson
Hello, I like the consolidation of all module information. I don't like that every time Modules.gmk is included, it calculates the IMPORTED_MODULES. It also looks like that can't work in the current patch since the call is before the definition of FindImportedModules. I can see if I can modi

hg: jigsaw/jake: Changing Jib dependency for jtreg to 4.2 b01

2016-03-15 Thread erik . joelsson
Changeset: 65b3f0d0bc2c Author:erikj Date: 2016-03-15 16:45 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/65b3f0d0bc2c Changing Jib dependency for jtreg to 4.2 b01 ! common/conf/jib-profiles.js

hg: jigsaw/jake: Fixing JDK-8149775: Exploded image has _the. files on system module path

2016-03-10 Thread erik . joelsson
Changeset: 6b9bb0953873 Author:erikj Date: 2016-03-10 15:39 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/6b9bb0953873 Fixing JDK-8149775: Exploded image has _the. files on system module path ! make/CreateJmods.gmk ! make/common/JavaCompilation.gmk

hg: jigsaw/jake/jdk: Build cleanup

2016-03-07 Thread erik . joelsson
Changeset: a0071ded705e Author:erikj Date: 2016-03-07 11:25 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a0071ded705e Build cleanup ! make/launcher/LauncherCommon.gmk

hg: jigsaw/jake: Build cleanup

2016-03-07 Thread erik . joelsson
Changeset: deba19bdeddf Author:erikj Date: 2016-03-07 11:25 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/deba19bdeddf Build cleanup ! common/autoconf/boot-jdk.m4 ! common/autoconf/generated-configure.sh ! make/CompileJavaModules.gmk ! make/Main.gmk ! make/common/JavaCompil

hg: jigsaw/jake/nashorn: Relaxed build dependencies slightly

2016-03-04 Thread erik . joelsson
Changeset: 3aafb5e2bc1d Author:erikj Date: 2016-03-04 16:34 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/3aafb5e2bc1d Relaxed build dependencies slightly ! make/BuildNashorn.gmk

hg: jigsaw/jake/jdk: Fixed bootcycle builds by correcting merge mistake

2016-03-04 Thread erik . joelsson
Changeset: 2db2becfab6e Author:erikj Date: 2016-03-04 16:34 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/2db2becfab6e Fixed bootcycle builds by correcting merge mistake ! make/Tools.gmk

hg: jigsaw/jake: Fixing JDK-8150293: open+closed jake fails on JPRT when deploy repo is not present

2016-02-22 Thread erik . joelsson
Changeset: eb5ef0636943 Author:erikj Date: 2016-02-22 22:45 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/eb5ef0636943 Fixing JDK-8150293: open+closed jake fails on JPRT when deploy repo is not present ! common/autoconf/generated-configure.sh ! common/autoconf/source-dirs.

hg: jigsaw/jake: Fix jprt config

2016-02-19 Thread erik . joelsson
Changeset: 947386030f5a Author:erikj Date: 2016-02-19 12:21 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/947386030f5a Fix jprt config ! make/jprt.properties

hg: jigsaw/jake: Fixed merge mistake in jprt config

2016-02-16 Thread erik . joelsson
Changeset: b3736d835f24 Author:erikj Date: 2016-02-16 11:02 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/b3736d835f24 Fixed merge mistake in jprt config ! make/jprt.properties

hg: jigsaw/jake: Fixed non cross builds

2016-02-04 Thread erik . joelsson
Changeset: 1906df3b76d6 Author:erikj Date: 2016-02-04 11:49 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/1906df3b76d6 Fixed non cross builds ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4

hg: jigsaw/jake: Fixed cross builds

2016-02-04 Thread erik . joelsson
Changeset: 8243d47b666a Author:erikj Date: 2016-02-04 10:24 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/8243d47b666a Fixed cross builds ! common/autoconf/buildjdk-spec.gmk.in ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchai

hg: jigsaw/jake/langtools: 17 new changesets

2016-01-30 Thread erik . joelsson
Changeset: 1203d1d370e2 Author:jjg Date: 2016-01-15 15:40 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/1203d1d370e2 8146208: Add a public DocTreeFactory to the Compiler Tree API Reviewed-by: ksrini + src/jdk.compiler/share/classes/com/sun/source/util/DocTreeFacto

hg: jigsaw/jake/nashorn: 11 new changesets

2016-01-30 Thread erik . joelsson
Changeset: ca4d50be062e Author:hannesw Date: 2016-01-18 10:25 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/ca4d50be062e 8146274: Thread spinning on WeakHashMap.getEntry() with concurrent use of nashorn Reviewed-by: mhaupt, attila ! src/jdk.scripting.nashorn/share

hg: jigsaw/jake/jdk: 79 new changesets

2016-01-30 Thread erik . joelsson
Changeset: c20bc888feea Author:xuelei Date: 2016-01-16 00:18 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c20bc888feea 8146669: Test SessionTimeOutTests fails intermittently Reviewed-by: mullan ! test/javax/net/ssl/SSLSession/SSLCtxAccessToSessCtx.java ! test/javax/net

hg: jigsaw/jake/jaxws: 5 new changesets

2016-01-30 Thread erik . joelsson
Changeset: daffd583eb35 Author:mkos Date: 2016-01-18 15:28 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/daffd583eb35 8146086: Publishing two webservices on same port fails with "java.net.BindException: Address already in use" Reviewed-by: chegar Contributed-by: kubot

hg: jigsaw/jake/jaxp: 8 new changesets

2016-01-30 Thread erik . joelsson
Changeset: 6aa4b1090a7c Author:joehw Date: 2016-01-15 20:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/6aa4b1090a7c 8147051: StaxEntityResolverWrapper should create StaxXMLInputSource with a resolver indicator Reviewed-by: lancea ! src/java.xml/share/classes/com/s

hg: jigsaw/jake: 34 new changesets

2016-01-30 Thread erik . joelsson
Changeset: 5f3d162d11fc Author:erikj Date: 2016-01-16 13:01 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/5f3d162d11fc 8146403: Windows build can be faster Reviewed-by: ihse ! common/autoconf/generated-configure.sh ! make/BuildStatic.gmk + make/GenerateModuleDeps.gmk ! make

hg: jigsaw/jake/corba: 4 new changesets

2016-01-30 Thread erik . joelsson
Changeset: 7cf41aa89a2b Author:erikj Date: 2016-01-16 13:01 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/7cf41aa89a2b 8146403: Windows build can be faster Reviewed-by: ihse ! make/gensrc/Gensrc-java.corba.gmk Changeset: 0680fb7dae4d Author:lana Date: 2016-0

hg: jigsaw/jake/nashorn: /-systemmodulepath/-system/

2016-01-21 Thread erik . joelsson
Changeset: f6a942282894 Author:erikj Date: 2016-01-21 13:38 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/f6a942282894 /-systemmodulepath/-system/ ! make/BuildNashorn.gmk

hg: jigsaw/jake: /-systemmodulepath/-system/

2016-01-21 Thread erik . joelsson
Changeset: 8235e92cec13 Author:erikj Date: 2016-01-21 13:38 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/8235e92cec13 /-systemmodulepath/-system/ ! make/CompileJavaModules.gmk ! make/Javadoc.gmk ! make/common/SetupJavaCompilers.gmk

hg: jigsaw/jake: Fixed JDK-8146698: make images always creates the jdk/jre images

2016-01-12 Thread erik . joelsson
Changeset: 91af65298753 Author:erikj Date: 2016-01-12 11:14 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/91af65298753 Fixed JDK-8146698: make images always creates the jdk/jre images Summary: Made source_tips only be recreated if they actually changed since last run ! mak

hg: jigsaw/jake: Changed Jib configuration to use jtreg nightly

2016-01-11 Thread erik . joelsson
Changeset: 4cac93878184 Author:erikj Date: 2016-01-11 16:26 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/4cac93878184 Changed Jib configuration to use jtreg nightly ! common/conf/jib-profiles.js

hg: jigsaw/jake/jdk: Reverting mistakenly submitted patch for sjavac

2015-12-17 Thread erik . joelsson
Changeset: b20c9733ab0b Author:erikj Date: 2015-12-17 11:02 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b20c9733ab0b Reverting mistakenly submitted patch for sjavac ! make/gendata/GendataBreakIterator.gmk

hg: jigsaw/jake: Reverting mistakenly submitted patch for sjavac

2015-12-17 Thread erik . joelsson
Changeset: 89666c1768e8 Author:erikj Date: 2015-12-17 11:02 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/89666c1768e8 Reverting mistakenly submitted patch for sjavac ! make/common/JavaCompilation.gmk ! test/make/TestJavaCompilation.gmk

hg: jigsaw/jake/jdk: JavaCompilation include/exclude cleanup needed for sjavac work

2015-12-16 Thread erik . joelsson
Changeset: c170ca3344f7 Author:erikj Date: 2015-12-16 15:55 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c170ca3344f7 JavaCompilation include/exclude cleanup needed for sjavac work ! make/gendata/GendataBreakIterator.gmk

hg: jigsaw/jake: JavaCompilation include/exclude cleanup needed for sjavac work

2015-12-16 Thread erik . joelsson
Changeset: f4bd56daae5d Author:erikj Date: 2015-12-16 15:55 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/f4bd56daae5d JavaCompilation include/exclude cleanup needed for sjavac work ! make/common/JavaCompilation.gmk ! test/make/TestJavaCompilation.gmk

hg: jigsaw/jake: Fixed JDK-8137157 by generating a base release file into exploded image

2015-12-16 Thread erik . joelsson
Changeset: 7334fc443fa5 Author:erikj Date: 2015-12-16 12:03 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/7334fc443fa5 Fixed JDK-8137157 by generating a base release file into exploded image ! make/Images.gmk

hg: jigsaw/jake/jdk: Restore workaround for JDK-8134409

2015-12-14 Thread erik . joelsson
Changeset: 50a178588a76 Author:erikj Date: 2015-12-14 12:00 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/50a178588a76 Restore workaround for JDK-8134409 ! make/lib/CoreLibraries.gmk

hg: jigsaw/jake: Made error message for --with-import-modules a little bit better

2015-12-04 Thread erik . joelsson
Changeset: f204b6d539cb Author:erikj Date: 2015-12-04 12:25 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/f204b6d539cb Made error message for --with-import-modules a little bit better ! common/autoconf/generated-configure.sh ! common/autoconf/source-dirs.m4

hg: jigsaw/jake: Use VERSION_SHORT as module-version

2015-12-03 Thread erik . joelsson
Changeset: 1c47a576a05a Author:erikj Date: 2015-12-03 14:07 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/1c47a576a05a Use VERSION_SHORT as module-version ! make/CreateJmods.gmk

hg: jigsaw/jake/langtools: 29 new changesets

2015-12-03 Thread erik . joelsson
Changeset: 404f1956145b Author:ihse Date: 2015-06-11 00:23 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/404f1956145b 8085822: JEP 223: New Version-String Scheme (initial integration) Reviewed-by: erikj, dcubed, dholmes, alanb Contributed-by: Kumar Srinivasan , Mag

hg: jigsaw/jake/nashorn: 26 new changesets

2015-12-03 Thread erik . joelsson
Changeset: aad920be350a Author:ihse Date: 2015-06-11 00:23 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/aad920be350a 8085822: JEP 223: New Version-String Scheme (initial integration) Reviewed-by: erikj, dcubed, dholmes, alanb, sundar Contributed-by: Magnus Ihse Burs

hg: jigsaw/jake/jaxws: 2 new changesets

2015-12-03 Thread erik . joelsson
Changeset: e625f295b89e Author:lana Date: 2015-12-02 15:55 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/e625f295b89e Added tag jdk-9+95 for changeset 3e03ddaaac65 ! .hgtags Changeset: 895fd3aeee77 Author:erikj Date: 2015-12-03 11:35 +0100 URL: http://

hg: jigsaw/jake/jdk: 36 new changesets

2015-12-03 Thread erik . joelsson
Changeset: 474db9ef5ee7 Author:ihse Date: 2015-06-11 00:23 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/474db9ef5ee7 8085822: JEP 223: New Version-String Scheme (initial integration) Reviewed-by: erikj, dcubed, dholmes, alanb Contributed-by: Magnus Ihse Bursie , Alejand

hg: jigsaw/jake/jaxp: 25 new changesets

2015-12-03 Thread erik . joelsson
Changeset: 1ba7abcb360a Author:amurillo Date: 2015-06-22 13:04 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/1ba7abcb360a 8098588: Allow for parsing jdk9 new version string Reviewed-by: alanb, joehw, dtitov ! src/java.xml/share/classes/com/sun/org/apache/xalan/interna

hg: jigsaw/jake/hotspot: 29 new changesets

2015-12-03 Thread erik . joelsson
Changeset: 5b88604f11a1 Author:ihse Date: 2015-06-12 08:31 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/5b88604f11a1 8085822: JEP 223: New Version-String Scheme (initial integration) Reviewed-by: erikj, dcubed, dholmes, alanb Contributed-by: Magnus Ihse Bursie , Ale

hg: jigsaw/jake: 34 new changesets

2015-12-03 Thread erik . joelsson
Changeset: 4999895b3a44 Author:ihse Date: 2015-06-11 00:21 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/4999895b3a44 8085822: JEP 223: New Version-String Scheme (initial integration) Reviewed-by: erikj, dcubed, dholmes Contributed-by: Magnus Ihse Bursie ! common/autoconf/

hg: jigsaw/jake/corba: 2 new changesets

2015-12-03 Thread erik . joelsson
Changeset: feb1bd85d799 Author:lana Date: 2015-12-02 15:55 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/feb1bd85d799 Added tag jdk-9+95 for changeset fd038e8a16ee ! .hgtags Changeset: ee360f55e364 Author:erikj Date: 2015-12-03 11:35 +0100 URL: http://

hg: jigsaw/jake: Generate modulesourcepath for jdk.vm.ci

2015-12-02 Thread erik . joelsson
Changeset: f00cc7909d28 Author:erikj Date: 2015-12-02 12:08 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/f00cc7909d28 Generate modulesourcepath for jdk.vm.ci ! make/CompileJavaModules.gmk

hg: jigsaw/jake/jdk: More build unification with jdk9

2015-11-24 Thread erik . joelsson
Changeset: 33d87582d833 Author:erikj Date: 2015-11-24 14:01 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/33d87582d833 More build unification with jdk9 ! make/launcher/Launcher-jdk.jcmd.gmk ! make/launcher/LauncherCommon.gmk

hg: jigsaw/jake: More build unification with jdk9

2015-11-24 Thread erik . joelsson
Changeset: 5165085d2c54 Author:erikj Date: 2015-11-24 14:01 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/5165085d2c54 More build unification with jdk9 ! make/CompileJavaModules.gmk

hg: jigsaw/jake: Fixed images target to properly also build the exploded-image target

2015-11-24 Thread erik . joelsson
Changeset: d18e85f68fe3 Author:erikj Date: 2015-11-24 11:03 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/d18e85f68fe3 Fixed images target to properly also build the exploded-image target ! common/autoconf/generated-configure.sh ! make/Main.gmk

hg: jigsaw/jake: Refixed cross compilation

2015-11-18 Thread erik . joelsson
Changeset: a95a37aa12bf Author:erikj Date: 2015-11-18 17:15 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/a95a37aa12bf Refixed cross compilation ! common/autoconf/flags.m4 ! common/autoconf/generated-configure.sh ! make/HotspotWrapper.gmk

hg: jigsaw/jake/corba: Reverting unneeded jigsaw specific changes

2015-11-18 Thread erik . joelsson
Changeset: 2cc9f6df4e50 Author:erikj Date: 2015-11-18 12:52 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/2cc9f6df4e50 Reverting unneeded jigsaw specific changes ! make/copy/Copy-java.corba.gmk ! make/gensrc/Gensrc-java.corba.gmk

hg: jigsaw/jake: Fixed compilation error when importing modules

2015-11-18 Thread erik . joelsson
Changeset: 677465fa89aa Author:erikj Date: 2015-11-18 12:21 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/677465fa89aa Fixed compilation error when importing modules ! make/CompileJavaModules.gmk

hg: jigsaw/jake: Removed some more outdated jigsaw specifics parts from build files

2015-11-18 Thread erik . joelsson
Changeset: 7cf69b6b3538 Author:erikj Date: 2015-11-18 13:56 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/7cf69b6b3538 Removed some more outdated jigsaw specifics parts from build files ! common/autoconf/configure.ac ! common/autoconf/flags.m4 ! common/autoconf/generated-co

hg: jigsaw/jake/hotspot: Reverting unneeded jigsaw specific changes

2015-11-18 Thread erik . joelsson
Changeset: 222c2519e1cb Author:erikj Date: 2015-11-18 12:52 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/222c2519e1cb Reverting unneeded jigsaw specific changes ! make/gensrc/Gensrc-jdk.vm.ci.gmk

hg: jigsaw/jake/langtools: Reverting unneeded jigsaw specific changes

2015-11-18 Thread erik . joelsson
Changeset: 70ad7a14ed9b Author:erikj Date: 2015-11-18 12:52 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/70ad7a14ed9b Reverting unneeded jigsaw specific changes ! make/CompileInterim.gmk ! make/gendata/Gendata-jdk.compiler.gmk ! make/gensrc/GensrcCommon.gmk

hg: jigsaw/jake/jdk: Reverting unneeded jigsaw specific changes

2015-11-18 Thread erik . joelsson
Changeset: fa885780a428 Author:erikj Date: 2015-11-18 12:52 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/fa885780a428 Reverting unneeded jigsaw specific changes ! make/Import.gmk ! make/copy/CopyCommon.gmk ! make/gendata/Gendata-java.base.gmk ! make/gendata/GendataBlac

hg: jigsaw/jake: Reverting unneeded jigsaw specific changes

2015-11-18 Thread erik . joelsson
Changeset: 903bd87f9402 Author:erikj Date: 2015-11-18 12:52 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/903bd87f9402 Reverting unneeded jigsaw specific changes ! common/autoconf/buildjdk-spec.gmk.in ! common/autoconf/flags.m4 ! common/autoconf/generated-configure.sh ! com

hg: jigsaw/jake/corba: Jake part of JDK-8143141, makefile cleanup between jake and jdk9

2015-11-17 Thread erik . joelsson
Changeset: 355803ae4e8a Author:erikj Date: 2015-11-17 16:38 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/355803ae4e8a Jake part of JDK-8143141, makefile cleanup between jake and jdk9 ! make/copy/Copy-java.corba.gmk

hg: jigsaw/jake/jdk: Jake part of JDK-8143141, makefile cleanup between jake and jdk9

2015-11-17 Thread erik . joelsson
Changeset: 2376cb553336 Author:erikj Date: 2015-11-17 16:38 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/2376cb553336 Jake part of JDK-8143141, makefile cleanup between jake and jdk9 ! make/copy/Copy-java.base.gmk ! make/copy/CopyCommon.gmk ! make/gensrc/Gensrc-java.ma

hg: jigsaw/jake/corba: Preparing makefiles for sjavac

2015-11-17 Thread erik . joelsson
Changeset: 341389d6ae08 Author:erikj Date: 2015-11-17 16:26 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/341389d6ae08 Preparing makefiles for sjavac ! make/gensrc/Gensrc-java.corba.gmk

hg: jigsaw/jake/hotspot: Jake part of JDK-8143141, makefile cleanup between jake and jdk9

2015-11-17 Thread erik . joelsson
Changeset: 3cd01614795b Author:erikj Date: 2015-11-17 16:38 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/3cd01614795b Jake part of JDK-8143141, makefile cleanup between jake and jdk9 ! make/gensrc/Gensrc-jdk.vm.ci.gmk

hg: jigsaw/jake/langtools: Jake part of JDK-8143141, makefile cleanup between jake and jdk9

2015-11-17 Thread erik . joelsson
Changeset: d63276f7f746 Author:erikj Date: 2015-11-17 16:38 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d63276f7f746 Jake part of JDK-8143141, makefile cleanup between jake and jdk9 ! make/gendata/Gendata-jdk.compiler.gmk

hg: jigsaw/jake: Jake part of JDK-8143141, makefile cleanup between jake and jdk9

2015-11-17 Thread erik . joelsson
Changeset: 48e940c6eece Author:erikj Date: 2015-11-17 16:38 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/48e940c6eece Jake part of JDK-8143141, makefile cleanup between jake and jdk9 ! common/autoconf/boot-jdk.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/s

hg: jigsaw/jake/jdk: Preparing makefiles for sjavac

2015-11-17 Thread erik . joelsson
Changeset: c40287b843b3 Author:erikj Date: 2015-11-17 16:26 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c40287b843b3 Preparing makefiles for sjavac ! make/CompileInterimRmic.gmk

hg: jigsaw/jake: Preparing makefiles for sjavac

2015-11-17 Thread erik . joelsson
Changeset: 2cffaee2b44e Author:erikj Date: 2015-11-17 16:26 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/2cffaee2b44e Preparing makefiles for sjavac ! make/JrtfsJar.gmk ! make/common/JavaCompilation.gmk

Re: jrt file system now has /package and /modules directories

2015-11-16 Thread Erik Joelsson
The "install" target should most definitely depend on "images". I see that it currently doesn't, which is certainly a bug. The workaround is to do "make images && make install". Filing a bug. /Erik On 2015-11-16 08:42, Alan Bateman wrote: On 16/11/2015 00:44, Michael Hall wrote: Not a bad

hg: jigsaw/jake: 2 new changesets

2015-11-11 Thread erik . joelsson
Changeset: 471d26171bcf Author:erikj Date: 2015-11-11 10:24 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/471d26171bcf Removing dead code - make/CompileModuleInfos.gmk Changeset: 887db7246c21 Author:erikj Date: 2015-11-11 10:24 +0100 URL: http://hg.openjdk.j

hg: jigsaw/jake: Temp workaround for JPRT until JDK-8140593 is fixed

2015-10-27 Thread erik . joelsson
Changeset: d0c45db4bcf3 Author:erikj Date: 2015-10-27 17:29 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/d0c45db4bcf3 Temp workaround for JPRT until JDK-8140593 is fixed ! make/jprt.properties

hg: jigsaw/jake: Remove stray ')'

2015-10-21 Thread erik . joelsson
Changeset: 975324e7b306 Author:erikj Date: 2015-10-21 16:03 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/975324e7b306 Remove stray ')' ! make/common/JavaCompilation.gmk

Re: CFV: New Committer: Christian Tornqvist

2015-09-17 Thread Erik Joelsson
Vote: yes /Erik

Re: CFV: New jigsaw Committer: Jean-Francois Denise

2015-09-17 Thread Erik Joelsson
Vote: yes /Erik

Re: CFV: New Jigsaw Committer: Lois Foltan

2015-09-17 Thread Erik Joelsson
Vote: yes /Erik

Re: CFV: New Jigsaw Committer: Harold Seigel

2015-09-17 Thread Erik Joelsson
Vote: yes /Erik

hg: jigsaw/jake/nashorn: Aligning jake build changes with jdk9 PathList make macro

2015-09-11 Thread erik . joelsson
Changeset: dbb145cb2c85 Author:erikj Date: 2015-09-09 18:38 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/dbb145cb2c85 Aligning jake build changes with jdk9 PathList make macro ! make/BuildNashorn.gmk

hg: jigsaw/jake/langtools: Aligning jake build changes with jdk9 PathList make macro

2015-09-11 Thread erik . joelsson
Changeset: 2ca32a0790e4 Author:erikj Date: 2015-09-09 18:38 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2ca32a0790e4 Aligning jake build changes with jdk9 PathList make macro ! make/CompileInterim.gmk

hg: jigsaw/jake/jdk: 2 new changesets

2015-09-11 Thread erik . joelsson
Changeset: c35f2ffc77f8 Author:erikj Date: 2015-09-09 18:38 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c35f2ffc77f8 Aligning jake build changes with jdk9 PathList make macro ! make/Tools.gmk ! make/gendata/GendataBreakIterator.gmk ! make/gensrc/GensrcSwing.gmk ! make

  1   2   3   >