Re: RFR: JDK-8241602 jlink does not produce reproducible jimage filesJ

2020-05-06 Thread Jim Laskey
http://cr.openjdk.java.net/~jlaskey/8241602/webrev-02 <http://cr.openjdk.java.net/~jlaskey/8241602/webrev-02> > On May 6, 2020, at 11:05 AM, Alan Bateman wrote: > > On 06/05/2020 14:42, Jim Laskey wrote: >> : >> >> Aside: The order in the file is still som

Re: RFR: JDK-8241602 jlink does not produce reproducible jimage files

2020-05-06 Thread Jim Laskey
Thank you. Notes below. updated webrev: http://cr.openjdk.java.net/~jlaskey/8241602/webrev-00 <http://cr.openjdk.java.net/~jlaskey/8241602/webrev-00> > On May 6, 2020, at 4:14 AM, Alan Bateman wrote: > > On 05/05/2020 20:56, Jim Laskey wrote: >> This fix addresses the

RFR: JDK-8241602 jlink does not produce reproducible jimage files

2020-05-05 Thread Jim Laskey
This fix addresses the inconsistent ordering by jimage content by jlink from run to run. Bottom line, the implementer was using HashSet without defining hashcode/equals for the Set entry classes. webrev: http://cr.openjdk.java.net/~jlaskey/8241602/webrev-00

Re: RFR 8242859: test/jdk/tools/jlink/JLinkTest.java uses nashorn module

2020-04-17 Thread Jim Laskey
+1 > On Apr 17, 2020, at 7:06 AM, sundararajan.athijegannat...@oracle.com wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8242859 > > Webrev: http://cr.openjdk.java.net/~sundar/8242859/webrev.00/ > > Relevant JLinkTest.java section deleted as part of nashorn removal

Re: RFR 8222098: tools/jlink/plugins/IncludeLocalesPluginTest.java time out

2020-01-10 Thread Jim Laskey
+1 > On Jan 10, 2020, at 2:03 AM, sundararajan.athijegannat...@oracle.com wrote: > > Please review. > > Not really a fix - but increasing the default timeout for the test. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8222098 > > Webrev: http://cr.openjdk.java.net/~sundar/8222098/webrev.00

Re: RFR 8216535: tools/jimage/JImageExtractTest.java timed out

2019-05-30 Thread Jim Laskey
+1 > On May 30, 2019, at 2:12 PM, Sundararajan Athijegannathan > wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8216535 > Webrev: https://cr.openjdk.java.net/~sundar/8216535/webrev.00/ > > I'm creating a small jre image with just java.base and jdk.zipfs modules i

Re: RFR 8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path

2019-05-28 Thread Jim Laskey
+1 > On May 28, 2019, at 6:48 AM, Sundararajan Athijegannathan > wrote: > > Updated for java test failures: > > https://cr.openjdk.java.net/~sundar/8216553/webrev.01/ > > PS. Test framework used wrong jrt: URI pattern. Fixed it. > > -Sundar > > On 27/05/19, 5:37 PM, Alan Bateman wrote: >> O

Re: RFR 8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path

2019-05-27 Thread Jim Laskey
+1 > On May 27, 2019, at 6:18 AM, Sundararajan Athijegannathan > wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8216553 > Webrev: https://cr.openjdk.java.net/~sundar/8216553/webrev.00/ > > Thanks, > -Sundar > >

Re: RFR: JDK-8215026: Incorrect amount of memory unmapped with ImageFileReader::close()

2018-12-10 Thread Jim Laskey
+1 > On Dec 10, 2018, at 1:40 AM, Jini George wrote: > > Hello, > > This is a request to review the proposed change to fix: > > https://bugs.openjdk.java.net/browse/JDK-8215026 > > The webrev is at: > > http://cr.openjdk.java.net/~jgeorge/8215026/webrev.00/index.html > > The background mai

Re: Clarification needed for the amount of memory unmapped during imagefile closure.

2018-12-05 Thread Jim Laskey
An oversight, please file a bug. — Jim > On Dec 5, 2018, at 8:37 AM, Alan Bateman wrote: > > On 05/12/2018 12:26, Jini George wrote: >> Hello! >> >> I needed a clarification regarding the amount of memory unmapped during >> imagefile closure in src/java.base/share/native/libjimage/imageFile.

Re: RFR: 8202583: Remove experimental ClassForNamePlugin

2018-05-07 Thread Jim Laskey
+1 > On May 7, 2018, at 10:23 AM, Claes Redestad wrote: > > Hi, > > the --class-for-name jlink plugin was added as an experiment to test and > evolve the jlink plugin infrastructure. The actual effect of enabling this > plugin on standard images is very limited (only a handful of Class.forNa

Re: RFR 8192986: Inconsistent handling of exploded modules in jlink

2017-12-08 Thread Jim Laskey (Oracle)
+1 > On Dec 7, 2017, at 11:27 PM, Sundararajan Athijegannathan > wrote: > > Hi, > > * On stricter check for missing module-info.class in a directory: There is a > similar check for non-modular jars. > > jlink --add-modules java.base --module-path t.jar --output foo > Error: Unable to deriv

Re: RFR: 8175891, 8192892: JrtPath improvements

2017-12-01 Thread Jim Laskey (Oracle)
+1 > On Dec 1, 2017, at 9:34 AM, Claes Redestad wrote: > > Hi, > > please review this patch that resolves two small but sometimes significant > inefficiencies in jdk.internal.jrtfs.JrtPath: > > Improve JrtPath::getResolved fast-path test: > https://bugs.openjdk.java.net/browse/JDK-8192892 >

Re: RFR: 8175561: Memory churn in jimage code affects startup after resource encapsulation changes

2017-03-01 Thread Jim Laskey (Oracle)
My only concern at this point is if Claes and I get hit by a bus, no one will be able to figure this out. I recommend that next release that we switch to character based hash. This means some minor complexity in the C code but I think the java code will be much simpler (and the C not so bad.)

Re: RFR: 8169713: jimage fails with StringIndexOutOfBoundsException when path to the inspected image is an empty string

2017-02-23 Thread Jim Laskey (Oracle)
+1 > On Feb 23, 2017, at 1:34 PM, Claes Redestad wrote: > > Hi, > > please review this fix to make the jimage tool work correctly > for empty string: > > diff -r b2661d26e556 > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java > --- a/src/jdk.jlink/share/classes/jdk/tools/

Re: RFR: 8175010: ImageReader is not thread-safe

2017-02-15 Thread Jim Laskey (Oracle)
+1 > On Feb 15, 2017, at 9:22 AM, Claes Redestad wrote: > > Hi, > > a few intermittent but rare test failures[1] that has appeared > since the latest jake integration, and since one of the changes > in there was to make initialization of the system ImageReader > lazy there appears to be cases w

Re: RFR 8174718: "Module 's descriptor returns inconsistent package set" confusing

2017-02-14 Thread Jim Laskey (Oracle)
+1 > On Feb 14, 2017, at 9:52 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8174718/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8174718 > > Thanks, > -Sundar

Re: RFR 8174209: Renumber the compress levels

2017-02-13 Thread Jim Laskey (Oracle)
+1 > On Feb 13, 2017, at 1:03 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8174209/webrev/ for > https://bugs.openjdk.java.net/browse/JDK-8174209 > > Thanks, > -Sundar

Re: [9] RFR: 8169715: jimage fails with IAE when attempts to inspect an empty file

2017-02-13 Thread Jim Laskey (Oracle)
+1 > On Feb 13, 2017, at 1:58 PM, Denis Kononenko > wrote: > > > Hi, > > Optimized buffer's capacity checks. > > WEBREV: http://cr.openjdk.java.net/~dkononenko/8169715/webrev.02 > > >> >> Could please someone review the fix for

Re: RFR 8172864: Remove custom plugin module path

2017-01-27 Thread Jim Laskey (Oracle)
+1 > On Jan 27, 2017, at 2:45 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8172864/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8172864 > > Thanks, > -Sundar

Re: RFR 8172659: PluginException("TargetPlatform attribute is missing ...") - should be ModuleTarget

2017-01-20 Thread Jim Laskey (Oracle)
+1 > On Jan 20, 2017, at 5:06 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8172659/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8172659 > > Thanks, > -Sundar

Re: RFR 8168254: Detect duplicated resources in packaged modules

2017-01-18 Thread Jim Laskey (Oracle)
+1 > On Jan 18, 2017, at 2:03 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8168254/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8168254 > > Thanks, > -Sundar

Re: RFR 8170618: jmod should validate if any exported or open package is missing

2016-12-21 Thread Jim Laskey (Oracle)
+1 > On Dec 21, 2016, at 8:08 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8170618/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8170618 > > Thanks, > -Sundar

Re: RFR 8171316: Add IMPLEMENTOR property to the release file

2016-12-15 Thread Jim Laskey (Oracle)
+1 > On Dec 15, 2016, at 11:32 AM, Sundararajan Athijegannathan > wrote: > > Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8171316 > > top level webrev: http://cr.openjdk.java.net/~sundar/8171316/top/webrev.00/ > jdk webrev: http://cr.openjdk.java.net/~sundar/8171316/jdk/webrev.

Re: RFR 8171138: Remove FileCopierPlugin

2016-12-14 Thread Jim Laskey (Oracle)
+1 > On Dec 14, 2016, at 1:02 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8171138/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8171138 > > Piggybacking cleanup: release file generation ("TOP" entry type handling) > moved to acce

Re: RFR 8171070: Test ModuleNamesOrderTest.java fails

2016-12-14 Thread Jim Laskey (Oracle)
+1 > On Dec 14, 2016, at 9:37 AM, Alan Bateman wrote: > > On 14/12/2016 13:44, Sundararajan Athijegannathan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8171070/webrev.00/ for >> https://bugs.openjdk.java.net/browse/JDK-8171070 > Looks okay. > > -Alan

Re: RFR 8168925: MODULES property should be topologically ordered and space-separated list

2016-12-09 Thread Jim Laskey (Oracle)
+1 > On Dec 9, 2016, at 4:49 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8168925/webrev.01/index.html > for https://bugs.openjdk.java.net/browse/JDK-8168925 > > PS. Mandy Chung wrote ModuleSorter for another fix (yet to be pushed). I'm > us

Re: RFR 8160359: Improve jlink logging for cases when a plugin throws exception

2016-11-30 Thread Jim Laskey (Oracle)
+1 > On Nov 30, 2016, at 7:05 AM, Sundararajan Athijegannathan > wrote: > > Please review fix for https://bugs.openjdk.java.net/browse/JDK-8160359 > > jdk webrev: http://cr.openjdk.java.net/~sundar/8160359/webrev.01/ > > top webrev: http://cr.openjdk.java.net/~sundar/8160359/top/webrev.01/ >

Re: Review Request: JDK-8169816 Move src.zip and jrt-fs.jar under the lib directory

2016-11-22 Thread Jim Laskey (Oracle)
+1 > On Nov 22, 2016, at 5:07 PM, Mandy Chung wrote: > > This patch moves src.zip and jrt-fs.jar from the top-level into > the `lib` directory in the run-time image as we proposed [1]. > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169816/webrev.00/ > > thanks > Mandy > [1] >

Re: [9] RFR: 8170120: Several new jimage testcases should be excluded due to their failures

2016-11-22 Thread Jim Laskey (Oracle)
+1 > On Nov 22, 2016, at 8:51 AM, Denis Kononenko > wrote: > > > Hi, > > Could someone please review this small fix. > > Recently several failing test cases were delivered into jdk9-dev by my > mistake (https://bugs.openjdk.java.net/browse/JDK-8167240). I've just renamed > these test case

Re: RFR 8170099: Nashorn test failures with stricter reflection access checks in jake forest

2016-11-21 Thread Jim Laskey (Oracle)
+1 > On Nov 21, 2016, at 10:14 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8170099/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8170099 > > Thanks, > -Sundar

RFR: JDK-8168256 - Plugin alias options in jlink --help output seems to be in an arbitrary order

2016-11-16 Thread Jim Laskey (Oracle)
Sorts options by full name http://cr.openjdk.java.net/~jlaskey/8168256/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8168256

Re: RFR 8153038: The set of jlink plugins enabled by default should be the same via CLI or jlink API

2016-11-16 Thread Jim Laskey (Oracle)
+1 > On Nov 16, 2016, at 4:30 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8153038/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8153038 > > PS. Pre-existing IntegrationTest.java test already checks the Jlink API code > path [so,

RFR: JDK-8169505 - Update changes by JDK-8159393 to reflect CCC review

2016-11-15 Thread Jim Laskey (Oracle)
http://cr.openjdk.java.net/~jlaskey/8169505/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8169505

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

2016-11-15 Thread Jim Laskey (Oracle)
+1 Really nice, thank you. > On Nov 15, 2016, at 11:16 AM, Denis Kononenko > wrote: > > > Hi, > > Please do re-review for these changes. > > 1) tests for list --include were rewritten accordingly to > https://bugs.openjdk.java.net/browse/JDK-8167384; > 2) removed tests for '@filename', see

RFR: JDK-8169720 - jimage help message for --include option should be corrected

2016-11-15 Thread Jim Laskey (Oracle)
http://cr.openjdk.java.net/~jlaskey/8169720/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8169720

RFR: JDK-8155756 - Better context for some jlink exceptions

2016-11-07 Thread Jim Laskey (Oracle)
Only 2 of 3 examples still present. http://cr.openjdk.java.net/~jlaskey/8155756/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8155756

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

2016-11-07 Thread Jim Laskey (Oracle)
Suits me. > On Nov 7, 2016, at 12:06 PM, Sean Mullan wrote: > > On 11/7/16 9:13 AM, Jim Laskey (Oracle) wrote: >> The bug https://bugs.openjdk.java.net/browse/JDK-8159393 >> <https://bugs.openjdk.java.net/browse/JDK-8159393> is really about >> warning dev

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

2016-11-07 Thread Jim Laskey (Oracle)
If it's already done somewhere else please make sure it is > the same. > > Thanks > Max > >> 在 2016年11月7日,22:11,Jim Laskey (Oracle) 写道: >> >> The security entries are (have been) ignored when building the image. At >> some future date (po

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

2016-11-07 Thread Jim Laskey (Oracle)
On Nov 7, 2016, at 10:11 AM, Jim Laskey (Oracle) > wrote: > > The security entries are (have been) ignored when building the image. At > some future date (post-9), we need to decide how to sign an image. > > — Jim > > >> On Nov 7, 2016, at 10:06 AM, Wang Wei

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

2016-11-07 Thread Jim Laskey (Oracle)
re is one thing I don't understand, the --strip-signing-information > option. It looks like you will remove the signature-related files if this > option is set. But, where are they stripped? > > Thanks > Max > > On 11/7/2016 9:48 PM, Jim Laskey (Oracle) wrote

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

2016-11-07 Thread Jim Laskey (Oracle)
Apologies for the poor links earlier. http://cr.openjdk.java.net/~jlaskey/8159393/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8159393 > On Nov 7, 2016, at 9:26 AM, Jim Laskey (Oracle) > wrote: > > Revising to > >String name = entry.

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

2016-11-07 Thread Jim Laskey (Oracle)
name.endsWith(".DSA") || name.endsWith(".RSA") || name.endsWith(".EC") || name.startsWith("META-INF/SIG-")

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

2016-11-07 Thread Jim Laskey (Oracle)
if ((cc < 'A' || cc > 'Z') && (cc < '0' || cc > '9')) { return false; } } } return true; // no extension is OK } return false; } &

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

2016-11-07 Thread Jim Laskey (Oracle)
But I need to be more careful with "Note that if such files are located in META-INF subdirectories, they are not considered signature-related.” > On Nov 7, 2016, at 9:09 AM, Jim Laskey (Oracle) > wrote: > > Thank you. Regarding SIG- I was just followed the spec. >

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

2016-11-07 Thread Jim Laskey (Oracle)
Bateman wrote: > > > n 07/11/2016 12:29, Jim Laskey (Oracle) wrote: >> http://cr.openjdk.java.net/~jlaskey/8159393/webrev/test/tools/jlink/JLinkSigningTest.java.html >> >> <http://cr.openjdk.java.net/~jlaskey/8159393/webrev/test/tools/jlink/JLinkSigningTest.java.

RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

2016-11-07 Thread Jim Laskey (Oracle)
http://cr.openjdk.java.net/~jlaskey/8159393/webrev/test/tools/jlink/JLinkSigningTest.java.html https://bugs.openjdk.java.net/browse/JDK-8159393

Re: RFR 8166286: jmod fails on symlink to directory

2016-11-04 Thread Jim Laskey (Oracle)
+1 > On Nov 4, 2016, at 7:36 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8166286/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8166286 > > Thanks, > -Sundar

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

2016-11-03 Thread Jim Laskey (Oracle)
Nice work. +1 > On Nov 3, 2016, at 10:29 AM, Denis Kononenko > wrote: > > Hi, > > I've done some rework accordingly to Alan's and Shura's comments: > > 1) removed overlapped tests from JImageToolTest.java; > > 2) added new tests JImageVerifyTest.java for jimage verify; > > 3) reorganized

Re: RFR 8160063: Provide a means to disable a plugin via the command line

2016-10-31 Thread Jim Laskey (Oracle)
+1 > On Oct 31, 2016, at 12:11 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8160063/webrev.02/ for > https://bugs.openjdk.java.net/browse/JDK-8160063 > > PS. Earlier review thread on slightly different fix: > http://mail.openjdk.java.net/pipe

Re: RFR 8166810: jlink should fail on extra arguments

2016-10-25 Thread Jim Laskey (Oracle)
+1 > On Oct 25, 2016, at 2:37 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8166810/webrev.00/index.html > for https://bugs.openjdk.java.net/browse/JDK-8166810 > > Thanks, > -Sundar

Re: RFR 8168091: jlink should check security permission early when programmatic access is used

2016-10-17 Thread Jim Laskey (Oracle)
+1 > On Oct 17, 2016, at 2:23 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8168091/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8168091 > > Thanks, > > -Sundar >

Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

2016-10-12 Thread Jim Laskey (Oracle)
+1 > On Oct 12, 2016, at 12:11 PM, Sundararajan Athijegannathan > wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8167614 > > jdk webrev: http://cr.openjdk.java.net/~sundar/8167614/jdk/webrev.00/ > > nashorn webrev: > http://cr.openjdk.java.net/~sundar/8167614/nashorn/webrev.00/ > >

Re: RFR 8165735: jlink incorrectly accepts multiple --module-path and --limit-modules options

2016-09-28 Thread Jim Laskey (Oracle)
+1 > On Sep 28, 2016, at 7:36 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8165735/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8165735 > > Thanks, > -Sundar

Re: RFR 8160063: Provide a means to disable a plugin via the command line

2016-09-15 Thread Jim Laskey (Oracle)
+1 > On Sep 15, 2016, at 11:31 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8160063/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8160063 > > * Adding --disable- option for any plugin that is auto-enabled. > * Removed ad-hoc "none"

Re: RFR 8165772: fix for 8165595 results in failure of jdk/test/tools/launcher/VersionCheck.java

2016-09-12 Thread Jim Laskey (Oracle)
+1 > On Sep 12, 2016, at 9:32 AM, Sundararajan Athijegannathan > wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8165772 > > This VersionCheck.java test failed after main class was added to nashorn > modules. VersionCheck expects all jdk/bin tools to be derived from the > standard lau

Re: RFR 8165772: fix for 8165595 results in failure of jdk/test/tools/launcher/VersionCheck.java

2016-09-09 Thread Jim Laskey (Oracle)
+1 > On Sep 9, 2016, at 10:58 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8165772/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8165772 > > Thanks, > > -Sundar >

Re: RFR 8165697: jlink running on Mac with Windows jmods produces non-runnable image

2016-09-08 Thread Jim Laskey (Oracle)
+1 > On Sep 8, 2016, at 11:32 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8165697/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8165697 > > Thanks > > -Sundar >

Re: RFR 8165503: jlink exclude VM plugin's handling of jvmlibs is wrong

2016-09-07 Thread Jim Laskey (Oracle)
+1 > On Sep 7, 2016, at 8:43 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8165503/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8165503 > > Thanks, > > -Sundar >

Re: RFR 8163952: jlink exclude VM plugin does not support static libraries

2016-09-06 Thread Jim Laskey (Oracle)
I missed that as well. Good catch. > On Sep 6, 2016, at 11:50 AM, Anthony Vanelverdinghe > wrote: > > Hi Sundar > > I'm not familiar with the code, but the for-loop at lines 105-107 looks like > a bug, since only the first element is considered: > > 105 for (String jvmlib : jvm

Re: RFR 8163952: jlink exclude VM plugin does not support static libraries

2016-09-06 Thread Jim Laskey (Oracle)
+1 > On Sep 6, 2016, at 7:12 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8163952/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8163952 > > Thanks, > > -Sundar >

Re: RFR 8157992: Improve jlink help message on optimization-related options

2016-09-02 Thread Jim Laskey (Oracle)
+1 > On Sep 2, 2016, at 6:10 AM, Sundararajan Athijegannathan > wrote: > > Cleas, Alan: > > Thanks for the reviews. Uploaded updated webrev for the record: > http://cr.openjdk.java.net/~sundar/8157992/webrev.02/ > > And going ahead with push.. > > Thanks. > > -Sundar > > > On 9/2/2016 1:4

Re: RFR 8159004: jlink attempts to create launcher scripts when root/bin dir does not exist

2016-08-29 Thread Jim Laskey (Oracle)
+1 > On Aug 29, 2016, at 9:00 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8159004/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8159004 > > Piggybacking couple of cleanups suggested (but missed) in this thread -> > http://mail.op

Re: RFR 8164800: Cross targeting Windows

2016-08-26 Thread Jim Laskey (Oracle)
+1 > On Aug 26, 2016, at 11:54 AM, Sundararajan Athijegannathan > wrote: > > Hi, > > Fixed as suggested: http://cr.openjdk.java.net/~sundar/8164800/webrev.02/ > > * Field name changed to targetOsName > > * Throwing RuntimeException if os name can't be determined from java.base > > -Sundar >

Re: RFR 8164800: Cross targeting Windows

2016-08-26 Thread Jim Laskey (Oracle)
+1 > On Aug 26, 2016, at 10:51 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8164800/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8164800 > > Thanks, > > -Sundar >

Re: RFR 8147491: module graph consistency checks after jlink plugins operate on module pool

2016-08-25 Thread Jim Laskey (Oracle)
+1 > On Aug 25, 2016, at 11:18 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8147491/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8147491 > > Thanks, > > -Sundar > >

Re: RFR 8163382: ResourcePoolManager.findEntry has a bug in startsWith call

2016-08-08 Thread Jim Laskey (Oracle)
+1 > On Aug 8, 2016, at 12:10 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8163382/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8163382 > > Thanks, > > -Sundar >

Re: RFR 8163116: jlink exclude VM plugin does not fully support cross platform image creation

2016-08-05 Thread Jim Laskey (Oracle)
+1 > On Aug 4, 2016, at 10:36 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8163116/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8163116 > > No cross platform test added. Existing test fixed to use > java.base/module-info.class. Als

Re: RFR 8146721: FileCopierPlugin should not create fake module

2016-08-04 Thread Jim Laskey (Oracle)
Fix grammar on FileCopierPluginTest.java: "We didn't add any .class resources of java.base module!” +1 > On Aug 4, 2016, at 6:10 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8146721/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR 8159487: Add JAVA_VERSION, OS_NAME, OS_ARCH properties in release file

2016-08-02 Thread Jim Laskey (Oracle)
+1 > On Aug 2, 2016, at 8:39 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8159487/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8159487 > > OS_NAME, OS_ARCH, OS_VERSION properties are already added due to another > fix. Just adding

Re: RFR 8162782: jlink ResourcePool.releaseProperties should be removed

2016-07-29 Thread Jim Laskey (Oracle)
+1 > On Jul 29, 2016, at 11:42 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8162782/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8162782 > > Thanks, > > -Sundar >

Re: RFR 8162538: plugin API should avoid read only pool, have module view separated from resource view and have pool builder to modify

2016-07-26 Thread Jim Laskey (Oracle)
+1 > On Jul 26, 2016, at 11:38 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8162538/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8162538 > > Thanks, > > -Sundar >

RFR: JDK-8158407 - jimage: verify should do more extensive test

2016-07-20 Thread Jim Laskey (Oracle)
http://cr.openjdk.java.net/~jlaskey/8158407/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8158407

Re: [9] RFR: 8159214: jlink --include-locales problems

2016-07-18 Thread Jim Laskey (Oracle)
+1 > On Jul 18, 2016, at 12:54 PM, Naoto Sato wrote: > > Ping. > > On 7/14/16 5:42 AM, Naoto Sato wrote: >> Hello, >> >> Please review the fix to the following issue: >> >> https://bugs.openjdk.java.net/browse/JDK-8159214 >> >> The fix is located at: >> >> http://cr.openjdk.java.net/~naoto/

Re: RFR: JDK-8161067 - jlink: Enable plugins to use the module pool for class lookup

2016-07-11 Thread Jim Laskey (Oracle)
rote: >> >> >>> On 11 Jul 2016, at 14:17, Jim Laskey (Oracle) >>> wrote: >>> >>> I’m not sure if we can determine supplied classes vs others unless we >>> provide a flag or the set of supplied modules. At any rate, the rules for >&

Re: RFR: JDK-8161067 - jlink: Enable plugins to use the module pool for class lookup

2016-07-11 Thread Jim Laskey (Oracle)
h functionality is much clearer regarding > the scope of resolution. > > Paul. > > >> On 8 Jul 2016, at 17:53, Jim Laskey (Oracle) wrote: >> >> http://cr.openjdk.java.net/~jlaskey/8161067/webrev/index.html >> https://bugs.openjdk.java.net/browse/JDK-8161067 >> >

RFR: JDK-8161067 - jlink: Enable plugins to use the module pool for class lookup

2016-07-08 Thread Jim Laskey (Oracle)
http://cr.openjdk.java.net/~jlaskey/8161067/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8161067

Re: RFR 8161055: Remove plugin ordering by isAfter, isBefore.

2016-07-08 Thread Jim Laskey (Oracle)
+1 > On Jul 8, 2016, at 8:19 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8161055/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8161055 > > Thanks > > -Sundar >

RFR: JDK-8160829 - Remove ASMPool support from jlink

2016-07-05 Thread Jim Laskey (Oracle)
Much of the removed code seems unnecessary since the same functionality can be accomplished with much simpler code. An example is provided with ClassForNamePlugin.java (temporary.) A shipping byte code optimizer plugin will be supplied later. Additional changes to the plugin API will supply a

Re: RFR 8160641: PostProcessingPlugin and ExecutableImage should not be part of plugin API

2016-06-30 Thread Jim Laskey (Oracle)
+1 > On Jun 30, 2016, at 8:08 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8160641/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8160641 > > Thanks, > > -Sundar >

RFR: JDK-8160459 - jlink minor code clean up

2016-06-28 Thread Jim Laskey (Oracle)
http://cr.openjdk.java.net/~jlaskey/8160459/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8160459

Re: RFR: JDK-8160348 - jlink should use System.out for usage messages

2016-06-27 Thread Jim Laskey (Oracle)
Thank you > On Jun 27, 2016, at 9:23 AM, Sundararajan Athijegannathan > wrote: > > +1 > > -Sundar > > > On 6/27/2016 5:46 PM, Jim Laskey (Oracle) wrote: >> Trivial patch >> >> http://cr.openjdk.java.net/~jlaskey/8160348/webrev/index.html &g

RFR: JDK-8160348 - jlink should use System.out for usage messages

2016-06-27 Thread Jim Laskey (Oracle)
Trivial patch http://cr.openjdk.java.net/~jlaskey/8160348/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8160348

Re: RFR 8157936: Files.size(Path p) returns 0 if path is from JrtFileSystem with exploded build

2016-06-27 Thread Jim Laskey (Oracle)
+1 > On Jun 27, 2016, at 5:16 AM, Sundararajan Athijegannathan > wrote: > > Thanks for the review. I'll include a space in test and push. > > -Sundar > > > On 6/27/2016 1:42 PM, Paul Sandoz wrote: >>> On 27 Jun 2016, at 09:03, Sundararajan Athijegannathan >>> wrote: >>> >>> Please review

Re: RFR 8160346: JLinkTest.java should compute exact number of plugins from jdk.jlink module [ was Re: RFR 8153238: Improve test/tools/jlink/JLinkTest.java not to hard code the number of plugins]

2016-06-27 Thread Jim Laskey (Oracle)
+1 > On Jun 27, 2016, at 8:19 AM, Sundararajan Athijegannathan > wrote: > > Sorry I had that test change already. I've filed another bug to track > your suggestions. > > Please review http://cr.openjdk.java.net/~sundar/8160346/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8160346 >

Re: RFR 8153238: Improve test/tools/jlink/JLinkTest.java not to hard code the number of plugins

2016-06-24 Thread Jim Laskey (Oracle)
+1 > On Jun 24, 2016, at 1:54 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8153238/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8153238 > > Thanks, > > -Sundar >

Re: RFR 8147794: Jlink's ModuleEntry.stream can't be consumed more than once and ModuleEntry content should be read only if needed

2016-06-24 Thread Jim Laskey (Oracle)
+1 nice to get this done > On Jun 24, 2016, at 10:12 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8147794/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8147794 > > Thanks, > > -Sundar >

Re: RFR: JDK-8159172 - Update usage of jlink/jimage/jmod to show option patterns

2016-06-23 Thread Jim Laskey (Oracle)
Thank you > On Jun 23, 2016, at 4:33 PM, Alan Bateman wrote: > > On 23/06/2016 19:40, Jim Laskey (Oracle) wrote: > >> http://cr.openjdk.java.net/~jlaskey/8159172/webrev/index.html >> <http://cr.openjdk.java.net/~jlaskey/8159172/webrev/index.html> >> http

Re: RFR: JDK-8159172 - Update usage of jlink/jimage/jmod to show option patterns

2016-06-23 Thread Jim Laskey (Oracle)
New spellings >>> --- > >>> -modulepath | -mp | --modulepath--module-path | -p > > Chris > > >> On Jun 23, 2016, at 11:40 AM, Jim Laskey (Oracle) >> wrote: >> >> >> http://cr.openjdk.java.net/~jlaskey/8159172/webrev/

RFR: JDK-8159172 - Update usage of jlink/jimage/jmod to show option patterns

2016-06-23 Thread Jim Laskey (Oracle)
http://cr.openjdk.java.net/~jlaskey/8159172/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8159172 This is an initial clean up of help for jlink/jimage/jmod. More work

Re: RFR 8159593: Plugin Set getType() should return a Category

2016-06-21 Thread Jim Laskey (Oracle)
+1 Thanks > On Jun 21, 2016, at 10:30 AM, Sundararajan Athijegannathan > wrote: > > Thanks for the review. > > Please review the updated webrev : > http://cr.openjdk.java.net/~sundar/8159593/webrev.01/ > > Thanks > > -Sundar > > On 6/21/2016 5:

Re: RFR 8159593: Plugin Set getType() should return a Category

2016-06-21 Thread Jim Laskey (Oracle)
59 public static boolean isPostProcessor(Category category) { 60 return category.equals(Category.VERIFIER) 61 || category.equals(Category.PROCESSOR) 62 || category.equals(Category.PACKAGER); 63 } 64 65 public static boolean isPreProce

Re: RFR JDK-8159206 - All jlink tests failing

2016-06-15 Thread Jim Laskey (Oracle)
Webrev updated in place. > On Jun 15, 2016, at 9:50 AM, Jim Laskey (Oracle) > wrote: > > >> On Jun 14, 2016, at 11:51 PM, Mandy Chung wrote: >> >> I reviewed http://cr.openjdk.java.net/~jlaskey/8159206/webrev >> >> Looks much

Re: RFR JDK-8159206 - All jlink tests failing

2016-06-15 Thread Jim Laskey (Oracle)
> On Jun 14, 2016, at 11:51 PM, Mandy Chung wrote: > > I reviewed http://cr.openjdk.java.net/~jlaskey/8159206/webrev > > Looks much cleaner. Thanks for the update > > 342 StringSharingPlugin(String[] patterns) throws IOException { > 343 this(ResourceFilter.includeFilter(Arrays.asL

Re: RFR JDK-8159206 - All jlink tests failing

2016-06-14 Thread Jim Laskey (Oracle)
> On Jun 11, 2016, at 9:03 PM, Mandy Chung wrote: > > >> On Jun 10, 2016, at 12:20 PM, Jim Laskey (Oracle) >> wrote: >> >> http://cr.openjdk.java.net/~jlaskey/8159206/webrev/index.html >> <http://cr.openjdk.java.net/~jlaskey/8159206/webrev/index

RFR JDK-8159206 - All jlink tests failing

2016-06-10 Thread Jim Laskey (Oracle)
http://cr.openjdk.java.net/~jlaskey/8159206/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8159206

Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

2016-06-09 Thread Jim Laskey (Oracle)
I’ll followup shortly. > On Jun 9, 2016, at 11:51 AM, Alan Bateman wrote: > > > On 09/06/2016 12:00, Jim Laskey (Oracle) wrote: >> : >> I have changes for the make files as well. >> >> diff -r 6a78ef1d1e58 make/Images.gmk >> --- a/make/Images

Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

2016-06-09 Thread Jim Laskey (Oracle)
> On Jun 9, 2016, at 8:52 AM, Chris Hegarty wrote: > >> >> On 9 Jun 2016, at 11:16, Alan Bateman wrote: >> >> On 08/06/2016 20:45, Jim Laskey (Oracle) wrote: >> >>> Consistent use of PathPatterns for jlink, jimage and jmod options. >>>

Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

2016-06-09 Thread Jim Laskey (Oracle)
> On Jun 9, 2016, at 7:16 AM, Alan Bateman wrote: > > On 08/06/2016 20:45, Jim Laskey (Oracle) wrote: > >> Consistent use of PathPatterns for jlink, jimage and jmod options. >> >> —optionName=(regex:|glob:|) ?? where => >> glob: >> >>

RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

2016-06-08 Thread Jim Laskey (Oracle)
Consistent use of PathPatterns for jlink, jimage and jmod options. —optionName=(regex:|glob:|) ?? where => glob: http://cr.openjdk.java.net/~jlaskey/8158402/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8158402

  1   2   >