hg: jigsaw/jake/langtools: Another test fixed

2016-02-12 Thread jonathan . gibbons
Changeset: f8e4851cc07b Author:jjg Date: 2016-02-12 15:26 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f8e4851cc07b Another test fixed ! test/ProblemList.jake.txt ! test/tools/javac/diags/Example.java ! test/tools/javac/diags/examples/InvalidDefaultInterface/Inv

hg: jigsaw/jake/langtools: fixing tests on the ProblemList

2016-02-11 Thread jonathan . gibbons
Changeset: a2e310fa72c6 Author:jjg Date: 2016-02-11 19:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/a2e310fa72c6 fixing tests on the ProblemList ! src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/jdk.javadoc/share

hg: jigsaw/jake/langtools: Fix test on ProblemList; add missing method impl in file manager

2016-02-11 Thread jonathan . gibbons
Changeset: c84763b6fe42 Author:jjg Date: 2016-02-11 14:58 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/c84763b6fe42 Fix test on ProblemList; add missing method impl in file manager ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java !

hg: jigsaw/jake/langtools: 8149033: ClassCastException in case of service implementation is nested static class

2016-02-10 Thread jonathan . gibbons
Changeset: 18a98f8f09a4 Author:vromero Date: 2016-02-10 17:30 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/18a98f8f09a4 8149033: ClassCastException in case of service implementation is nested static class ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp

hg: jigsaw/jake/langtools: Start adding bug IDs into ProblemList

2016-02-10 Thread jonathan . gibbons
Changeset: 37f388c03568 Author:jjg Date: 2016-02-10 13:59 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/37f388c03568 Start adding bug IDs into ProblemList ! test/ProblemList.jake.txt

hg: jigsaw/jake/langtools: minor update to test

2016-02-09 Thread jonathan . gibbons
Changeset: 0d994d57bf64 Author:jjg Date: 2016-02-09 19:05 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/0d994d57bf64 minor update to test ! test/tools/javac/processing/model/testgetallmembers/Main.java

hg: jigsaw/jake/langtools: minor update for test

2016-02-09 Thread jonathan . gibbons
Changeset: dd9f148a231c Author:jjg Date: 2016-02-09 18:46 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/dd9f148a231c minor update for test ! test/tools/javac/T8003967/DetectMutableStaticFields.java

hg: jigsaw/jake/langtools: fix test on problem list

2016-02-09 Thread jonathan . gibbons
Changeset: faf4f70ddd6a Author:jjg Date: 2016-02-09 18:18 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/faf4f70ddd6a fix test on problem list ! test/ProblemList.jake.txt - test/tools/javac/synthesize/Boolean.java - test/tools/javac/synthesize/Byte.java - test/tool

hg: jigsaw/jake/langtools: delete obsolete tests and remove from problem list

2016-02-09 Thread jonathan . gibbons
Changeset: 7cce0e7f4fb5 Author:jjg Date: 2016-02-09 17:52 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7cce0e7f4fb5 delete obsolete tests and remove from problem list ! test/ProblemList.jake.txt - test/com/sun/javadoc/testProfiles/TestProfiles.java - test/com/sun

hg: jigsaw/jake/langtools: basic support for modules in javah

2016-02-09 Thread jonathan . gibbons
Changeset: bfa8469c0ff2 Author:jjg Date: 2016-02-09 17:41 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/bfa8469c0ff2 basic support for modules in javah ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/jdk.compiler/share/classes/com/sun

hg: jigsaw/jake/langtools: improve handling of synthetic compilation units for package.html

2016-02-08 Thread jonathan . gibbons
Changeset: 6b6ea9e2fe99 Author:jjg Date: 2016-02-08 18:01 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/6b6ea9e2fe99 improve handling of synthetic compilation units for package.html ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTrees.java

hg: jigsaw/jake/langtools: Start using module element

2016-02-08 Thread jonathan . gibbons
Changeset: ab2073af5b29 Author:ksrini Date: 2016-02-08 16:45 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ab2073af5b29 Start using module element ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractModuleIndexWriter.java ! src/jdk.

hg: jigsaw/jake/langtools: 8148648: javac, neither a service definition or its implementation can be inner classes

2016-02-08 Thread jonathan . gibbons
Changeset: 46c903152cfe Author:vromero Date: 2016-02-08 15:55 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/46c903152cfe 8148648: javac, neither a service definition or its implementation can be inner classes ! src/jdk.compiler/share/classes/com/sun/tools/javac/c

hg: jigsaw/jake/langtools: update javadoc to support -addmods -limitmods

2016-02-08 Thread jonathan . gibbons
Changeset: afbf27e227d7 Author:jjg Date: 2016-02-08 15:36 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/afbf27e227d7 update javadoc to support -addmods -limitmods ! src/jdk.javadoc/share/classes/com/sun/tools/javadoc/JavadocTool.java ! src/jdk.javadoc/share/classe

hg: jigsaw/jake: update javadoc to support -addmods -limitmods

2016-02-08 Thread jonathan . gibbons
Changeset: 9b60f19f818d Author:jjg Date: 2016-02-08 15:36 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/9b60f19f818d update javadoc to support -addmods -limitmods ! make/Javadoc.gmk

hg: jigsaw/jake/langtools: 8130868: error msg can be more accurate while compiling file in default package with -modulesourcepath option

2016-02-08 Thread jonathan . gibbons
Changeset: 257fc848711e Author:vromero Date: 2016-02-08 13:15 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/257fc848711e 8130868: error msg can be more accurate while compiling file in default package with -modulesourcepath option ! src/jdk.compiler/share/classes

hg: jigsaw/jake/langtools: fix and enable indy string concat tests

2016-02-08 Thread jonathan . gibbons
Changeset: 80ac7bd55719 Author:jjg Date: 2016-02-08 12:48 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/80ac7bd55719 fix and enable indy string concat tests ! test/ProblemList.jake.txt ! test/tools/javac/TestIndyStringConcat.java

Re: hg: jigsaw/jake/langtools: support module files directly on file manager module paths

2016-02-08 Thread Jonathan Gibbons
2.46 +} Op Mon, 08 Feb 2016 03:58:37 +0100 schreef Jonathan Gibbons : Hi Robert, Thanks for the report. This should now have been addressed by http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/719a1da641c7 -- Jon On 02/03/2016 09:38 AM, Robert Scholte wrote: Hi Jonatha

hg: jigsaw/jake/langtools: fix tests on langtools ProblemList.jake.txt

2016-02-08 Thread jonathan . gibbons
Changeset: 05ea8a0ca1c6 Author:vromero Date: 2016-02-08 11:14 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/05ea8a0ca1c6 fix tests on langtools ProblemList.jake.txt ! test/ProblemList.jake.txt ! test/tools/javac/T6406771.java ! test/tools/javac/T8003967/DetectMuta

Re: [Jigsaw] Getting "Bad service configuration file" error with annotation processor

2016-02-08 Thread Jonathan Gibbons
Gunnar, cross-posting to jigsaw-dev. Can you describe more about the setup of this example? Is the processor in a module with a module declaration with a provides clause for the processor, or is it a "pre-Jigsaw"/"JDK8-style" processor with a service configuration file in a jar file's META-I

Re: hg: jigsaw/jake/langtools: support module files directly on file manager module paths

2016-02-07 Thread Jonathan Gibbons
Hi Robert, Thanks for the report. This should now have been addressed by http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/719a1da641c7 -- Jon On 02/03/2016 09:38 AM, Robert Scholte wrote: Hi Jonathan, it seems like this change is not enough, see: Locations.ModulePathLocationHandler::s

hg: jigsaw/jake/langtools: updates for javac -m option

2016-02-07 Thread jonathan . gibbons
Changeset: 18fc1fe05891 Author:vromero Date: 2016-02-07 15:22 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/18fc1fe05891 updates for javac -m option ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java ! src/jdk.compiler/share/classes/com/sun/

hg: jigsaw/jake/langtools: extra checks on output directory

2016-02-06 Thread jonathan . gibbons
Changeset: 67b88c9e7b4d Author:jjg Date: 2016-02-06 22:36 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/67b88c9e7b4d extra checks on output directory ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java ! src/jdk.compiler/share/classes/com/sun

hg: jigsaw/jake/langtools: javac accepts exploded modules on module path

2016-02-06 Thread jonathan . gibbons
Changeset: 3618aab41cd0 Author:jjg Date: 2016-02-06 19:26 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/3618aab41cd0 javac accepts exploded modules on module path ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java ! test/tools/javac/modules/M

hg: jigsaw/jake/langtools: update javac handling of .jar and .jmod on module path

2016-02-06 Thread jonathan . gibbons
Changeset: 719a1da641c7 Author:jjg Date: 2016-02-06 16:32 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/719a1da641c7 update javac handling of .jar and .jmod on module path ! make/tools/propertiesparser/parser/MessageType.java ! src/jdk.compiler/share/classes/com/s

hg: jigsaw/jake/langtools: 2 new changesets

2016-02-05 Thread jonathan . gibbons
Changeset: e6dee894037f Author:jjg Date: 2016-02-05 15:22 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/e6dee894037f Add missing test + test/tools/javac/main/MOptionTest.java Changeset: d6ae30697fc2 Author:jjg Date: 2016-02-05 15:31 -0800 URL: http

hg: jigsaw/jake/langtools: fix typo in comment

2016-02-05 Thread jonathan . gibbons
Changeset: 5e7e9d89d7ea Author:jjg Date: 2016-02-05 15:21 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5e7e9d89d7ea fix typo in comment ! src/java.compiler/share/classes/javax/lang/model/element/ModuleElement.java

hg: jigsaw/jake/langtools: undo bad commit

2016-02-05 Thread jonathan . gibbons
Changeset: f4f66c2744ec Author:jjg Date: 2016-02-05 14:51 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f4f66c2744ec undo bad commit ! src/java.compiler/share/classes/javax/lang/model/element/ModuleElement.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/

hg: jigsaw/jake/langtools: fix typo in comment

2016-02-05 Thread jonathan . gibbons
Changeset: ae8f31d8db90 Author:jjg Date: 2016-02-05 14:47 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ae8f31d8db90 fix typo in comment ! src/java.compiler/share/classes/javax/lang/model/element/ModuleElement.java ! src/jdk.compiler/share/classes/com/sun/tools/ja

hg: jigsaw/jake/langtools: javac -m option

2016-02-04 Thread jonathan . gibbons
Changeset: cc8de1bf3af7 Author:vromero Date: 2016-02-04 18:07 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/cc8de1bf3af7 javac -m option ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/m

hg: jigsaw/jake/langtools: 12 new changesets

2016-02-04 Thread jonathan . gibbons
Changeset: 4a4f58f3b344 Author:mcimadamore Date: 2016-01-26 12:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4a4f58f3b344 8148128: Regression: array constructor references marked as inexact Summary: Missing check in constructor reference stuckness check Reviewed

hg: jigsaw/jake/jdk: 2 new changesets

2016-02-04 Thread jonathan . gibbons
Changeset: be500855d6fa Author:ksrini Date: 2016-02-04 14:18 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/be500855d6fa Enable old doclet temporarily ! make/launcher/Launcher-jdk.javadoc.gmk Changeset: a7ef8d672b70 Author:jjg Date: 2016-02-04 16:02 -0800 URL:

hg: jigsaw/jake: Enable building of new doclet api docs

2016-02-04 Thread jonathan . gibbons
Changeset: ca23aeeb366e Author:ksrini Date: 2016-02-04 14:13 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/ca23aeeb366e Enable building of new doclet api docs ! make/Javadoc.gmk

hg: jigsaw/jake: fix merge problems for "make docs"

2016-02-04 Thread jonathan . gibbons
Changeset: ee7c28c82b0d Author:jjg Date: 2016-02-04 13:16 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/ee7c28c82b0d fix merge problems for "make docs" ! make/Javadoc.gmk

hg: jigsaw/jake: partially re-enable docs

2016-02-04 Thread jonathan . gibbons
Changeset: 8858b53b1be8 Author:jjg Date: 2016-02-04 11:06 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/8858b53b1be8 partially re-enable docs ! make/Javadoc.gmk ! make/Main.gmk

Re: hg: jigsaw/jake/langtools: support module files directly on file manager module paths

2016-02-03 Thread Jonathan Gibbons
Robert, Noted. Thanks for the report. That should be easy enough to fix. -- Jon On 02/03/2016 09:38 AM, Robert Scholte wrote: Hi Jonathan, it seems like this change is not enough, see: Locations.ModulePathLocationHandler::setPaths 910 @Override 911 void setPaths(Iterable

hg: jigsaw/jake/langtools: 8147801: java.nio.file.ClosedFileSystemException when using Javadoc API's in JDK9

2016-02-01 Thread jonathan . gibbons
Changeset: 74b0706bf77e Author:jjg Date: 2016-02-01 19:34 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/74b0706bf77e 8147801: java.nio.file.ClosedFileSystemException when using Javadoc API's in JDK9 ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/BaseFi

hg: jigsaw/jake/langtools: fix rogue reference to JRT_MARKER_FILE in jshell

2016-01-29 Thread jonathan . gibbons
Changeset: 81c3b83300a8 Author:jjg Date: 2016-01-29 18:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/81c3b83300a8 fix rogue reference to JRT_MARKER_FILE in jshell ! src/jdk.jshell/share/classes/jdk/jshell/SourceCodeAnalysisImpl.java

hg: jigsaw/jake/langtools: 2 new changesets

2016-01-29 Thread jonathan . gibbons
Changeset: d3be51644469 Author:jjg Date: 2016-01-29 17:44 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d3be51644469 minor cleanup of diagnostic messages ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java ! src/jdk.compiler/share/classes/com/s

hg: jigsaw/jake/langtools: 2 new changesets

2016-01-29 Thread jonathan . gibbons
Changeset: f7df0e138394 Author:vromero Date: 2016-01-29 16:24 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f7df0e138394 8145013: Javac doesn't report warnings/errors if module provides unexported service and doesn't use it itself Reviewed-by: jjg ! src/jdk.compi

hg: jigsaw/jake/langtools: fix/remove JRT_MARKER_FILE mechanism

2016-01-29 Thread jonathan . gibbons
Changeset: 7cfabbeaddaa Author:jjg Date: 2016-01-29 12:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7cfabbeaddaa fix/remove JRT_MARKER_FILE mechanism ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/jdk.compiler/share/class

hg: jigsaw/jake/langtools: 8145839: javac report error if service doesn't have a no-args constructor

2016-01-28 Thread jonathan . gibbons
Changeset: 650b3ea0c0c6 Author:vromero Date: 2016-01-28 16:31 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/650b3ea0c0c6 8145839: javac report error if service doesn't have a no-args constructor Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac

hg: jigsaw/jake/langtools: 2 new changesets

2016-01-24 Thread jonathan . gibbons
Changeset: e2ff06eb2d30 Author:jjg Date: 2016-01-24 15:43 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/e2ff06eb2d30 Fix typo in comment ! src/java.compiler/share/classes/javax/lang/model/type/TypeKind.java Changeset: de056c8b3d09 Author:jjg Date: 2016-0

hg: jigsaw/jake/langtools: add missing @modules

2016-01-21 Thread jonathan . gibbons
Changeset: 9584cbedf24f Author:jjg Date: 2016-01-21 14:53 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/9584cbedf24f add missing @modules ! test/jdk/jshell/T8146368/JShellToolTest8146368.java ! test/jdk/jshell/ToolReloadTest.java

hg: jigsaw/jake/langtools: change javac -systemmodulepath option to -system (with temp alias)

2016-01-20 Thread jonathan . gibbons
Changeset: 7859480f373f Author:jjg Date: 2016-01-20 19:37 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7859480f373f change javac -systemmodulepath option to -system (with temp alias) ! src/java.compiler/share/classes/javax/tools/StandardLocation.java ! src/jdk.co

hg: jigsaw/jake/langtools: support module files directly on file manager module paths

2016-01-20 Thread jonathan . gibbons
Changeset: 546b5fa35f9a Author:jjg Date: 2016-01-20 17:58 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/546b5fa35f9a support module files directly on file manager module paths ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java

Re: Specifying module paths

2016-01-15 Thread Jonathan Gibbons
be placed directly on the module path; they must continue to be placed in a directory on the module path. This will apply to all JDK tools that support options whose value is a module path. -- Jon On 01/07/2016 03:39 PM, Jonathan Gibbons wrote: This is a follow-up to some of the recent email d

Re: Specifying module paths

2016-01-14 Thread Jonathan Gibbons
On 01/14/2016 12:25 PM, e...@zusammenkunft.net wrote: Hello, If I understood it correctly the modules on the MP must be unique and are not merged, thats why the order inside the directory does not matter for the named modules. Bernd Let me refine that for you ... The modules in each dir

Re: Specifying module paths

2016-01-14 Thread Jonathan Gibbons
On 01/14/2016 12:30 PM, Jonathan Gibbons wrote: On 01/14/2016 12:14 PM, Robert Scholte wrote: Igor Fedorenko says: "This is a very good proposal. My only suggestion is to extend javax.tools CompilationTask API to take modulepath map as in-memory parameter. Not a big deal, but it&

Re: Specifying module paths

2016-01-14 Thread Jonathan Gibbons
On 01/14/2016 12:14 PM, Robert Scholte wrote: Igor Fedorenko says: "This is a very good proposal. My only suggestion is to extend javax.tools CompilationTask API to take modulepath map as in-memory parameter. Not a big deal, but it'll be silly to write properties file to disk for it to be imm

Re: Specifying module paths

2016-01-09 Thread Jonathan Gibbons
On 01/09/2016 08:16 AM, Alan Bateman wrote: On 07/01/2016 23:39, Jonathan Gibbons wrote: : This note suggests a similar-but-different approach. The proposal is that it should be possible to represent an entry on the module path as a text file in Java properties file format, such that it

hg: jigsaw/jake/langtools: 27 new changesets

2016-01-08 Thread jonathan . gibbons
Changeset: 30e288cb2d22 Author:jjg Date: 2015-12-07 14:02 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/30e288cb2d22 8059976: Convert JavacFileManager to use java.nio.file internally Reviewed-by: jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Cl

Specifying module paths

2016-01-07 Thread Jonathan Gibbons
This is a follow-up to some of the recent email discussions regarding the use of the module path. The "State of the Module System" [1] defines a _module path_ as follows: A module path is a sequence of directories containing module artifacts which are searched, in order, for the first artifact

hg: jigsaw/jake/langtools: sjavac support for module-info.java

2016-01-05 Thread jonathan . gibbons
Changeset: b4c8fc3cfad7 Author:alundblad Date: 2016-01-05 18:46 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b4c8fc3cfad7 sjavac support for module-info.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/Source.java ! src/jdk.compiler/share/classes/com/su

hg: jigsaw/jake/langtools: 8144342: javac doesn't report errors if module exports non-existent package

2015-12-22 Thread jonathan . gibbons
Changeset: 44535f5efc07 Author:vromero Date: 2015-12-22 16:25 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/44535f5efc07 8144342: javac doesn't report errors if module exports non-existent package ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.j

hg: jigsaw/jake/langtools: 2 new changesets

2015-12-22 Thread jonathan . gibbons
Changeset: d9ce7a3e1672 Author:jjg Date: 2015-12-22 12:54 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d9ce7a3e1672 unignore test case in UsesTest.java ! test/tools/javac/modules/UsesTest.java Changeset: 8a2b2c2caa15 Author:jjg Date: 2015-12-22 13:03 -0

hg: jigsaw/jake/langtools: 8145957: langtools tests failing on exploded image

2015-12-21 Thread jonathan . gibbons
Changeset: 37fefa14f3a7 Author:jjg Date: 2015-12-21 19:03 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/37fefa14f3a7 8145957: langtools tests failing on exploded image ! test/tools/javac/6589361/T6589361.java ! test/tools/lib/ToolBox.java

hg: jigsaw/jake/langtools: Remove support for obsolete -Xoverride option

2015-12-21 Thread jonathan . gibbons
Changeset: 8c8e4774ff86 Author:jjg Date: 2015-12-21 15:21 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8c8e4774ff86 Remove support for obsolete -Xoverride option ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java ! src/jdk.compiler/share/cla

hg: jigsaw/jake/jaxws: 8144342: javac doesn't report errors if module exports non-existent package

2015-12-18 Thread jonathan . gibbons
Changeset: ab43de1d28fd Author:vromero Date: 2015-12-17 14:38 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/ab43de1d28fd 8144342: javac doesn't report errors if module exports non-existent package ! src/jdk.xml.bind/share/classes/module-info.java

hg: jigsaw/jake/langtools: 8145016: Javac doesn't report errors on service implementation which cannot be initialized

2015-12-18 Thread jonathan . gibbons
Changeset: 4a70ae037273 Author:vromero Date: 2015-12-17 13:41 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4a70ae037273 8145016: Javac doesn't report errors on service implementation which cannot be initialized ! src/jdk.compiler/share/classes/com/sun/tools/java

hg: jigsaw/jake/langtools: 8145012: Javac doesn't report errors on duplicate uses or provides

2015-12-18 Thread jonathan . gibbons
Changeset: f22706341c4d Author:vromero Date: 2015-12-16 17:29 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f22706341c4d 8145012: Javac doesn't report errors on duplicate uses or provides ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Directive.java ! s

Result: New Jigsaw Committer: Jan Lahoda

2015-12-17 Thread Jonathan Gibbons
Voting for Jan Lahoda [1] is now closed. Yes: 6 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Jonathan Gibbons [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2015-December/005534.html

hg: jigsaw/jake/langtools: 8145102: new module graph tests

2015-12-15 Thread jonathan . gibbons
Changeset: cf44ed878521 Author:anazarov Date: 2015-12-15 13:50 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/cf44ed878521 8145102: new module graph tests Reviewed-By: jjg + test/tools/javac/modules/GraphsTest.java ! test/tools/javac/modules/ModuleInfoTest.java ! t

hg: jigsaw/jake/langtools: 8134514: javac -X should provide updated syntax for -XaddExports

2015-12-15 Thread jonathan . gibbons
Changeset: 088c841e9b42 Author:vromero Date: 2015-12-15 13:34 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/088c841e9b42 8134514: javac -X should provide updated syntax for -XaddExports Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/resource

hg: jigsaw/jake/langtools: Fix bug entering duplicate cass symbols

2015-12-15 Thread jonathan . gibbons
Changeset: b4ca7d930f0f Author:jlahoda Date: 2015-12-15 13:00 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b4ca7d930f0f Fix bug entering duplicate cass symbols Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java ! test/tools/jav

hg: jigsaw/jake/langtools: 8133058: NPE while compiling empty javafile with -modulesourcepath option

2015-12-08 Thread jonathan . gibbons
Changeset: 8e4070f9a7ae Author:vromero Date: 2015-12-08 18:39 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8e4070f9a7ae 8133058: NPE while compiling empty javafile with -modulesourcepath option Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac

Re: modulepath spec

2015-12-07 Thread Jonathan Gibbons
On 12/07/2015 11:46 AM, Alan Bateman wrote: On 07/12/2015 17:18, Stephane Epardaud wrote: Hi, When there is a -modulepath argument, is it a path in the Unix sense? With a list of File.pathSeparator-separated folders? Ceylon produces `.car` files instead of `.jar` files, but they're really zi

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

2015-12-04 Thread Jonathan Gibbons
On 12/04/2015 06:33 AM, Stephane Epardaud wrote: On 04/12/2015 15:21, David M. Lloyd wrote: IIRC there is *already* within Java 9 an option to compile against previous JDK ABIs (which are bundled with JDK 9), isn't there? Ah that's interesting, I got hit by calls to byteBuffer(int) which c

Re: IllegalAccessError even when -XaddExports adds ALL-UNNAMED to the reported module/package

2015-12-03 Thread Jonathan Gibbons
Roel, To understand the problem, you need to understand something of how javac works. javac is a Java program, and as such it is composed of a set of modules that run in a JVM. The primary module is jdk.compiler, and if you follow the dependencies, you'll see it references java.compiler, and

hg: jigsaw/jake: Use VERSION_SHORT again, now that jtreg has been updated

2015-12-03 Thread jonathan . gibbons
Changeset: 1c8c3c9e2494 Author:jjg Date: 2015-12-03 14:01 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/1c8c3c9e2494 Use VERSION_SHORT again, now that jtreg has been updated ! make/CreateJmods.gmk

hg: jigsaw/jake/langtools: javap should generate useful output for module-info in absence of -v

2015-12-02 Thread jonathan . gibbons
Changeset: 55927a560def Author:jjg Date: 2015-12-02 16:09 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/55927a560def javap should generate useful output for module-info in absence of -v ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/Module_attribute.java !

Re: no error when module exports non-existing package

2015-12-02 Thread Jonathan Gibbons
On 12/02/2015 02:20 PM, Victor Rudometov wrote: On 02.12.2015 21:09, Jonathan Gibbons wrote: Adding Victor back into the recipients. -- Jon On 12/02/2015 10:08 AM, Jonathan Gibbons wrote: On 12/02/2015 09:41 AM, Victor Rudometov wrote: Hi, Javac does not complain if user exports a

CFV: New Jigsaw Committer: Jan Lahoda

2015-12-02 Thread Jonathan Gibbons
, 2015. Only current Jigsaw Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Jonathan Gibbons [1] http://openjdk.java.net/census#jigsaw [2] http://openjdk.java.net/projects

Re: no error when module exports non-existing package

2015-12-02 Thread Jonathan Gibbons
Adding Victor back into the recipients. -- Jon On 12/02/2015 10:08 AM, Jonathan Gibbons wrote: On 12/02/2015 09:41 AM, Victor Rudometov wrote: Hi, Javac does not complain if user exports a package that does not exist. If it was not done intentionally, it would be good to report an error

Re: no error when module exports non-existing package

2015-12-02 Thread Jonathan Gibbons
On 12/02/2015 09:41 AM, Victor Rudometov wrote: Hi, Javac does not complain if user exports a package that does not exist. If it was not done intentionally, it would be good to report an error, or at least a warning. Today was the third time I saw the code with a typo or just incorrect packa

hg: jigsaw/jake/langtools: read target of symbolic links in JRT file system

2015-11-20 Thread jonathan . gibbons
Changeset: 2eea71812f91 Author:jjg Date: 2015-11-20 16:52 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2eea71812f91 read target of symbolic links in JRT file system ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/JRTIndex.java

hg: jigsaw/jake/langtools: fix whitespace and merge error in ProblemList.jake.txt

2015-11-16 Thread jonathan . gibbons
Changeset: 2e97a1c3478f Author:jjg Date: 2015-11-13 16:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2e97a1c3478f fix whitespace and merge error in ProblemList.jake.txt ! test/ProblemList.jake.txt

Re: Proposal to enhance jdeps tool to search split packages/add some kind of general API

2015-11-15 Thread Jonathan Gibbons
On 11/12/2015 06:49 PM, Mandy Chung wrote: On Nov 12, 2015, at 2:39 AM, Patrick Reinhart wrote: Hi there, I like to do some early adoption tests with software using the new module system. Now we got an unknown amount of split packages in our system, the we will need to fix in order to migr

hg: jigsaw/jake/langtools: Fix tests on langtools ProblemList.jake.txt

2015-11-13 Thread jonathan . gibbons
Changeset: 8630a1e8260d Author:jjg Date: 2015-11-13 18:02 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8630a1e8260d Fix tests on langtools ProblemList.jake.txt ! test/ProblemList.jake.txt - test/tools/javac/Object1.java - test/tools/javac/Object1.out - test/tools

hg: jigsaw/jake/langtools: Setting UsesProviderCompleter to ModuleSymbol.usesProvidersCompleter, to avoid running it too soon.

2015-11-11 Thread jonathan . gibbons
Changeset: 7c66438d4d8a Author:jlahoda Date: 2015-11-11 15:27 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7c66438d4d8a Setting UsesProviderCompleter to ModuleSymbol.usesProvidersCompleter, to avoid running it too soon. ! src/jdk.compiler/share/classes/com/sun/t

hg: jigsaw/jake/langtools: 8140767: adding -XaddReads option to javac

2015-11-10 Thread jonathan . gibbons
Changeset: 2c1838c6e03c Author:jlahoda Date: 2015-11-10 14:19 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2c1838c6e03c 8140767: adding -XaddReads option to javac ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Directive.java ! src/jdk.compiler/share/cl

Re: Unable to compile modules with references to automatic modules - "cannot find module: jdk.management.resource"

2015-11-09 Thread Jonathan Gibbons
On 11/09/2015 12:55 AM, Alan Bateman wrote: On 08/11/2015 17:51, Jan Lahoda wrote: Automatic modules depend on all other named modules, and javac currently uses all modules it knows about, which includes those it found while analyzing other module-infos. I think it could be changed to onl

hg: jigsaw/jake/langtools: 2 new changesets

2015-11-05 Thread jonathan . gibbons
Changeset: 755579d808dc Author:alundblad Date: 2015-11-05 10:49 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/755579d808dc add missing methods in ForwardingFileManager ! src/java.compiler/share/classes/javax/tools/ForwardingJavaFileManager.java Changeset: 76aeac0

Re: Compilation feedback and version question

2015-10-28 Thread Jonathan Gibbons
On 10/28/2015 01:50 PM, Stephen Colebourne wrote: Finally, I had my module-info.java in the wrong folder initially (at the org.joda.convert package level, rather than the root). However, it got picked up and compiled into the root of the output classes folder. I guess this is expected, but I fo

hg: jigsaw/jake/langtools: move ModuleTestBase for reuse by additional tests

2015-10-23 Thread jonathan . gibbons
Changeset: 5ce41c5e35a8 Author:vromero Date: 2015-10-23 18:02 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5ce41c5e35a8 move ModuleTestBase for reuse by additional tests - test/tools/javac/modules/ModuleTestBase.java + test/tools/lib/ModuleTestBase.java

hg: jigsaw/jake/langtools: 8136505: properly enforcing module boundaries for expression types.

2015-10-23 Thread jonathan . gibbons
Changeset: 7bfad2b9fda7 Author:jlahoda Date: 2015-10-23 15:11 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7bfad2b9fda7 8136505: properly enforcing module boundaries for expression types. ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java ! te

hg: jigsaw/jake/langtools: 8136709: fixing visible package computation for automatic modules which are used as a dependency of a named module.

2015-10-23 Thread jonathan . gibbons
Changeset: df52fb21fa9f Author:jlahoda Date: 2015-10-23 15:00 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/df52fb21fa9f 8136709: fixing visible package computation for automatic modules which are used as a dependency of a named module. ! src/jdk.compiler/share/c

hg: jigsaw/jake/langtools: Fixing package-info.class and module-info.class genereation when an internal JavacTaskImpl API is used.

2015-10-23 Thread jonathan . gibbons
Changeset: f5aa149f5bd0 Author:jlahoda Date: 2015-10-23 14:31 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f5aa149f5bd0 Fixing package-info.class and module-info.class genereation when an internal JavacTaskImpl API is used. ! src/jdk.compiler/share/classes/com/s

hg: jigsaw/jake/langtools: Fixing a few Java model API bugs.

2015-10-23 Thread jonathan . gibbons
Changeset: f34f96b386fc Author:jlahoda Date: 2015-10-23 14:22 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f34f96b386fc Fixing a few Java model API bugs. ! src/java.compiler/share/classes/javax/lang/model/type/TypeKind.java ! src/jdk.compiler/share/classes/com/su

hg: jigsaw/jake/langtools: message.txt

2015-10-23 Thread jonathan . gibbons
Changeset: 7907e684cef1 Author:jlahoda Date: 2015-10-23 13:54 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7907e684cef1 message.txt ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Sym

Re: non-API classes displayed by jrt filesystem

2015-10-19 Thread Jonathan Gibbons
On 10/19/2015 06:57 AM, Alan Bateman wrote: On 19/10/2015 13:12, Philippe Marschall wrote: Hi I'm toying around with the jrt filesystem [1]. I noted that non-API classes are shown for java modules (see attachment). I assume this is because jrt currently reports all classes in a module, not

Re: The -release option is not compatible with JavaFileManagers

2015-10-14 Thread Jonathan Gibbons
On 10/13/2015 03:50 PM, Keimpe Bronkhorst wrote: I have a custom JavaFileManager used for JSR199 compilations, but when I use the -release option I see: Error: -release option specified, but the provided JavaFileManager is not a StandardJavaFileManager.. This basically forces everybody to im

Re: JavaFileManager UnsupportedOperationException

2015-10-08 Thread Jonathan Gibbons
JavaFileManager has some new methods whose default implementation is to throw UOE. Are you providing your own full custom file manager? If you are, and you are using it in a module-oriented compilation (i.e. -target 9) then you need to provide the new methods. -- Jon On 10/08/2015 02:16 PM

Re: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-08 Thread Jonathan Gibbons
Keimpe, While your use-case is about accessing alternate versions of javac, the underlying mechanism you are looking for is more general and not specific to javac. The ability that you need, and which you're currently missing, is the ability to load code (modules) from an alternate JDK image

Re: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-07 Thread Jonathan Gibbons
On 10/07/2015 06:01 PM, Keimpe Bronkhorst wrote: The underlying exception I get is: "Class oracle.jdevimpl.javacompiler.JDevJavaCompiler can not access a member of class com.sun.tools.javac.api.JavacTool (module jdk.compiler) with modifiers "public static", module jdk.compiler does not expor

Re: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-07 Thread Jonathan Gibbons
Yes, the message says that "JDevJavaCompiler ... cannot access ... com.sun.tools.javac.api.JavacTool" and indeed, com.sun.tools.javac.api is not a supported public API. Here's the standard comment from the head of the file: * This is NOT part of any supported API. * If you write code that d

hg: jigsaw/jake/langtools: 8049819: specify annotation processors in modules

2015-10-02 Thread jonathan . gibbons
Changeset: 3571fc58f820 Author:vromero Date: 2015-10-02 11:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/3571fc58f820 8049819: specify annotation processors in modules ! src/java.compiler/share/classes/javax/tools/JavaFileManager.java ! src/java.compiler/share/

Re: hg: jigsaw/jake/langtools: 8062324: Remove workaround copy of ServiceLoader from javac

2015-09-25 Thread Jonathan Gibbons
This should have been attributed to jan.lah...@oracle.com. My apologies for not catching this in time. -- Jon On 09/25/2015 04:07 PM, jonathan.gibb...@oracle.com wrote: Changeset: 4dfde5dc00fc Author:jjg Date: 2015-09-25 15:53 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/lan

hg: jigsaw/jake/langtools: 8062324: Remove workaround copy of ServiceLoader from javac

2015-09-25 Thread jonathan . gibbons
Changeset: 4dfde5dc00fc Author:jjg Date: 2015-09-25 15:53 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4dfde5dc00fc 8062324: Remove workaround copy of ServiceLoader from javac ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/jdk

hg: jigsaw/jake/langtools: add support for javac -Xpatch option with -Xoverride as a temporary alias

2015-09-24 Thread jonathan . gibbons
Changeset: 5684716bd129 Author:jjg Date: 2015-09-24 18:33 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5684716bd129 add support for javac -Xpatch option with -Xoverride as a temporary alias ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java

<    1   2   3   4   >