Re: Review Request: JDK-8173303: Add module-subgraph images to main platform documentation

2017-03-26 Thread Philip Race
123 "fontname", "DejaVuSans bold", Even if this gets consumed only during the build environment by some tool it supposes that string means something to either the tool or the OS. Unless one of those parses "bold" out of the string and interprets it as a style request then I don't see

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

2016-12-11 Thread Philip Race
The parts of this which I know about (the client licenses) look fine to me. Some day we should look at whether we still have vestiges of X11 in the Mac code from the BSD port but for now its safer to assume there are .. By this I mean "unix" includes Mac. as a core OS, but not as a desktop techn

Re: Testing

2016-07-24 Thread Philip Race
The odds that this is jigsaw related are zero. The odds that this is a bug in JDK 9 are only slightly above that. LWJGL apps crash all the time due to driver issues completely outside the JDK. And the entire Vulkan stack and APIs are drivers are all EA so far as I know. Hmm .. the internet t

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

2016-06-13 Thread Philip Race
Alan, See the comment here : http://mail.openjdk.java.net/pipermail/awt-dev/2016-June/011478.html Probably you should chime in directly on that discussion with such input .. -phil. On 6/13/16, 12:47 PM, Alan Bateman wrote: On 13/06/2016 20:26, Philip Race wrote: PS .. also you probably

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

2016-06-13 Thread Philip Race
PS .. also you probably should just suppress lint on the jdk.jsobject module The change you propose to JSObject is going to cause a potential conflict with the ongoing review discussion about this here :- http://mail.openjdk.java.net/pipermail/awt-dev/2016-June/011472.html -phil. On 6/13/16,

Re: build error on windows

2015-11-17 Thread Philip Race
This is a known issue and the fix should go into jdk9/dev in about 24 hours. --disable-warnings-as-errors will work around it. -phil. On 11/16/15, 8:25 AM, Ali Ebrahimi wrote: Hi, . . Creating jsoundds.dll from 4 file(s) f:/openjdk/jake/jdk/src/java.desktop/share/native/libfontmanager/freetype