Hi,
Attaching the patch as a .patch or .txt file should be sufficient for
small contributions and example code.
Roger
On 1/22/2018 10:39 AM, Rony G. Flatscher wrote:
Hi,
On 22.01.2018 16:24, Roger Riggs wrote:
Contributions need to be submitted using the OpenJDK infrastructure to adhere
Hi,
Contributions need to be submitted using the OpenJDK infrastructure to
adhere to the IP requirements.
The mail lists shold pass attachments that are text and patches though
you may need to be
sure your mailer attaches them with the correct mime-types and/or
extensions.
Roger
p.s.
The cu
Hi Frank,
The test library components seem to duplicate those already in the
JDK/test/lib/testlibrary
There needs to be a good reason to duplicate the test library.
Roger
On 4/14/2016 3:43 AM, Frank Yuan wrote:
-Original Message-
From: huizhe wang [mailto:huizhe.w...@oracle.com]
Su
.
Roger
On 3/10/2016 6:22 PM, Jim Laskey (Oracle) wrote:
Thank you Roger. Comments inline. In general, I will hold off changes until
after merge so as not to destabilize. Note that ImageBufferCache and
Decompression are not currently used.
On Mar 8, 2016, at 2:07 PM, Roger Riggs wrote
Hi,
Review comments for the jimage code in java.base, mostly cleanup but
perhaps a bug or two.
General: inconsistent style and not following guidelines, copyright
dates may need an update.
Use of assert for error checking is not going to catch or help isolate
errors in production builds.
di
Hi Daniel,
fyi, there is a new TEST.properties file for the java/lang/management
tests that includes
the needed @modules = jdk.management.
Roger
On 3/2/2016 1:06 PM, Daniel Fuchs wrote:
On 02/03/16 18:48, Alexandre (Shura) Iline wrote:
Hi.
Could you please take a look on a fix to add miss
Hi Alan,
I just pushed it to jdk9, it should merge easily; can you or Jim take
care of getting it into Jake.
Thanks, Roger
On 12/02/2015 10:15 AM, Alan Bateman wrote:
On 01/12/2015 23:18, Roger Riggs wrote:
Please review a fix for jimage native code to correctly maintain the
list of
Please review a fix for jimage native code to correctly maintain the
list of ImageFileReaders.
Issue:
https://bugs.openjdk.java.net/browse/JDK-8143879
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-jimage-read-8143879/
(It appears Jake has the same bugs but that's a separate issue/fix
replaced with an error
in order to handle OOM's that occur in production code?
Thanks, Harold
On 11/12/2015 10:20 AM, Roger Riggs wrote:
Please review additions to jimageFile to diagnose an intermittent
failure.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-jimage-segv-8141571/
Issue:
Please review additions to jimageFile to diagnose an intermittent failure.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-jimage-segv-8141571/
Issue:
https://bugs.openjdk.java.net/browse/JDK-8141571
Thanks, Roger
Hi Mandy,
Collapsing the emails.
As for asserting that module name is never null;
it appears that the module name is not being supplied by the VM. (in
hs-comp or jdk9).
On 10/29/15 12:59 PM, Mandy Chung wrote:
On Oct 27, 2015, at 11:40 PM, Roger Riggs wrote:
Please review an update to the
Hi Alan,
Yes, it uses the JNU_CHECK_EXCEPTION_RETURN macros.
If it would be cleaner to remove the jni_util.h include, the macros can
be replaced.
They don't add much value in this case.
Thanks, Roger
On 10/28/15 8:15 AM, Alan Bateman wrote:
On 28/10/2015 06:40, Roger Riggs wrote:
P
Please review an update to the jimage reader implementation to correct the
case where a class name is very long causing a SEGV due to buffer overruns.
The fix will be pushed to the hs-comp repo; the bug was first spotted there.
Webrev:
http://cr.openjdk.java.net/~rriggs//webrev-jimage-segv-81
My mistake, Withdrawn, I am not a jigsaw comitter.
On 9/11/2015 12:44 PM, Roger Riggs wrote:
Vote: yes
On 9/11/2015 12:31 PM, Karen Kinnear wrote:
I hereby nominate Harold Seigel to Jigsaw Committer.
Vote: yes
On 9/11/2015 12:31 PM, Karen Kinnear wrote:
I hereby nominate Harold Seigel to Jigsaw Committer.
15 matches
Mail list logo
