Re: 8159248: ModuleFinder.of spec + 8158456: ModuleDescriptor.read does not verify dependence on java.base

2016-06-16 Thread Alan Bateman
On 16/06/2016 19:11, Mandy Chung wrote: On Jun 16, 2016, at 9:44 AM, Alan Bateman wrote: On 16/06/2016 17:31, Mandy Chung wrote: : ModuleFinder.of spec describes the possible cases where FindException may be thrown by a module finder’s find or findAll methods. It

Re: 8159248: ModuleFinder.of spec + 8158456: ModuleDescriptor.read does not verify dependence on java.base

2016-06-16 Thread Alan Bateman
On 16/06/2016 17:47, Paul Benedict wrote: Please definitely list all such possible exceptions. The knowledge outweighs concern for clutter, IMO. I'd rather know the full number of ways an API can fail rather than receive a failure that wasn't documented. There is one exception and all the

Re: 8159248: ModuleFinder.of spec + 8158456: ModuleDescriptor.read does not verify dependence on java.base

2016-06-16 Thread Paul Benedict
Please definitely list all such possible exceptions. The knowledge outweighs concern for clutter, IMO. I'd rather know the full number of ways an API can fail rather than receive a failure that wasn't documented. Cheers, Paul On Thu, Jun 16, 2016 at 11:44 AM, Alan Bateman

Re: 8159248: ModuleFinder.of spec + 8158456: ModuleDescriptor.read does not verify dependence on java.base

2016-06-16 Thread Alan Bateman
On 16/06/2016 17:31, Mandy Chung wrote: : ModuleFinder.of spec describes the possible cases where FindException may be thrown by a module finder’s find or findAll methods. It would be useful to have the @throws FindException if an error occurs finding all modules in find and findAll methods

Re: 8159248: ModuleFinder.of spec + 8158456: ModuleDescriptor.read does not verify dependence on java.base

2016-06-16 Thread Mandy Chung
> On Jun 16, 2016, at 8:33 AM, Alan Bateman wrote: > > I need a Reviewer for a patch is to address two conformance issues. > > One is that the ModuleFinder.of(Path...) javadoc doesn't make it clear that > an exception is thrown when a module descriptor cannot be

Re: 8159248: ModuleFinder.of spec + 8158456: ModuleDescriptor.read does not verify dependence on java.base

2016-06-16 Thread Chris Hegarty
> On 16 Jun 2016, at 16:33, Alan Bateman wrote: > > I need a Reviewer for a patch is to address two conformance issues. > > One is that the ModuleFinder.of(Path...) javadoc doesn't make it clear that > an exception is thrown when a module descriptor cannot be created