8174823: Module system implementation refresh (3/2017)

2017-03-21 Thread Alan Bateman
We have been accumulating changes in the jake forest for the last few weeks to align with the proposals in JSR 376 and also to pick up API changes and bug fixes. It's time to bring these changes into jdk9/dev. The issue to bring these changes into jdk9/dev in bulk has been approved via the FC e

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-21 Thread serguei.spit...@oracle.com
Alan, The hotspot part looks good. Thanks, Serguei On 3/21/17 14:42, Alan Bateman wrote: We have been accumulating changes in the jake forest for the last few weeks to align with the proposals in JSR 376 and also to pick up API changes and bug fixes. It's time to bring these changes into jdk

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-21 Thread Jonathan Gibbons
Alan, langtools changes are OK. -- Jon On 03/21/2017 02:42 PM, Alan Bateman wrote: We have been accumulating changes in the jake forest for the last few weeks to align with the proposals in JSR 376 and also to pick up API changes and bug fixes. It's time to bring these changes into jdk9/dev.

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-21 Thread David Holmes
On 22/03/2017 8:09 AM, serguei.spit...@oracle.com wrote: Alan, The hotspot part looks good. I second that - but a few copyright years need updating. It was unfortunate that yet another version of vm_exit_during_initialization had to be added. Thanks, David Thanks, Serguei On 3/21/17 14

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-22 Thread Chris Hegarty
> On 21 Mar 2017, at 21:42, Alan Bateman wrote: > > We have been accumulating changes in the jake forest for the last few weeks > to align with the proposals in JSR 376 and also to pick up API changes and > bug fixes. It's time to bring these changes into jdk9/dev. The issue to bring > these

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-22 Thread Lois Foltan
Alan, Hotspot changes look good. Lois On 3/21/2017 5:42 PM, Alan Bateman wrote: We have been accumulating changes in the jake forest for the last few weeks to align with the proposals in JSR 376 and also to pick up API changes and bug fixes. It's time to bring these changes into jdk9/dev. Th

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-22 Thread Erik Joelsson
(adding build-dev) Build changes look good to me. /Erik On 2017-03-21 22:42, Alan Bateman wrote: We have been accumulating changes in the jake forest for the last few weeks to align with the proposals in JSR 376 and also to pick up API changes and bug fixes. It's time to bring these changes

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-22 Thread Mandy Chung
> On Mar 21, 2017, at 2:42 PM, Alan Bateman wrote: > > We have been accumulating changes in the jake forest for the last few weeks > to align with the proposals in JSR 376 and also to pick up API changes and > bug fixes. It's time to bring these changes into jdk9/dev. The issue to bring > the

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-22 Thread Remi Forax
njdk.java.net runtime" > > Envoyé: Mardi 21 Mars 2017 22:42:02 > Objet: 8174823: Module system implementation refresh (3/2017) > We have been accumulating changes in the jake forest for the last few > weeks to align with the proposals in JSR 376 and also to pick up API > cha

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-22 Thread Alan Bateman
On 22/03/2017 17:20, Remi Forax wrote: So ModuleTarget.osVersion is removed, i will have to update ASM accordingly. ModuleTarget is JDK-specific now, I think JEP 261 will be the place to document it. In jdk/internal/module/ModuleBootstrap.java, addExtraExportsOrOpens(bootLayer, extraOpen

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-22 Thread Alan Bateman
On 22/03/2017 10:03, Chris Hegarty wrote: : Should the @return for ModuleDescriptor.Requires::rawCompiledVersion contain the same caveat as was added to compiledVersion? * @return The string containing the version of the module if recorded *at compile-time, OR AN EMPTY OP

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-22 Thread Alan Bateman
On 22/03/2017 04:50, David Holmes wrote: On 22/03/2017 8:09 AM, serguei.spit...@oracle.com wrote: Alan, The hotspot part looks good. I second that - but a few copyright years need updating. Yeah, it's probably time to run the bulk update and catch all the files that haven't had their copyri