Re: Issue with an automatic module

2016-08-03 Thread Alan Bateman
On 03/08/2016 08:49, Paul Benedict wrote: Given that "automatic modules" are meant to be a migration path, I think refusing any legacy jar adds an unfortunate surprise to migrating. I understand the intent to throw FindException with regard to real modules (has module-info.class), but why appl

Re: Issue with an automatic module

2016-08-03 Thread Paul Benedict
Given that "automatic modules" are meant to be a migration path, I think refusing any legacy jar adds an unfortunate surprise to migrating. I understand the intent to throw FindException with regard to real modules (has module-info.class), but why apply the same restriction to *automatic* modules?

Re: Issue with an automatic module

2016-08-02 Thread Jochen Theodorou
On 02.08.2016 15:19, Peter Levart wrote: Hi, Top-package (unnamed package) classes can not be referenced from classes in named packages anyway, so they usually represent just reflective entry points (such as Main class with main() method). In Java that is you mean. The JVM does not care about

Re: Issue with an automatic module

2016-08-02 Thread Remi Forax
Seems to be a reasonable idea :) Rem On August 2, 2016 6:19:45 AM PDT, Peter Levart wrote: >Hi, > >Top-package (unnamed package) classes can not be referenced from >classes >in named packages anyway, so they usually represent just reflective >entry points (such as Main class with main() metho

Re: Issue with an automatic module

2016-08-02 Thread Alan Bateman
On 02/08/2016 06:19, Peter Levart wrote: Hi, Top-package (unnamed package) classes can not be referenced from classes in named packages anyway, so they usually represent just reflective entry points (such as Main class with main() method). If a jar is used as an automatic module, it would pr

RE: Issue with an automatic module

2016-08-02 Thread charbel yazbeck
hi, i would vote for that... thank u De : Peter Levart Envoyé : mardi 2 août 2016 13:19 À : Andrew Dinn; Alan Bateman; charbel yazbeck; jigsaw-dev@openjdk.java.net Objet : Re: Issue with an automatic module Hi, Top-package (unnamed package) classes can not

Re: Issue with an automatic module

2016-08-02 Thread Peter Levart
Hi, Top-package (unnamed package) classes can not be referenced from classes in named packages anyway, so they usually represent just reflective entry points (such as Main class with main() method). If a jar is used as an automatic module, it would probably be safe to just ignore any classes

Re: Issue with an automatic module

2016-08-02 Thread Andrew Dinn
On 02/08/16 13:01, Alan Bateman wrote: > HelpMojo seems to be something to do with Maven Plugin Plugin. It > doesn't seem to be present in nar-maven-plugin 3.3.0 or 3.5.0 HelpMojo is indeed something to do with the Maven Plugin Plugin. The latter will generate a class called HelpMojo on demand to

Re: Issue with an automatic module

2016-08-02 Thread Alan Bateman
On 02/08/2016 00:21, charbel yazbeck wrote: hi, most of the open sources jars have classes with unnamed package, like nar-maven-plugin. Any idea how can i solve this? Do i have to implement my own version of ModuleFinder? Some examples: D:\.m2\jdom\jdom\1.0\jdom-1.0.jar, D:\.m2\net\ja

Re: Issue with an automatic module

2016-08-02 Thread Andrew Dinn
On 02/08/16 08:21, charbel yazbeck wrote: > most of the open sources jars have classes with unnamed package, like > nar-maven-plugin. Hmm, citation needed for that I think. In my experience it is extremely rare for production code to place classes in the unnamed module. It is extremely bad prac

Re: Issue with an automatic module

2016-08-02 Thread Paul Benedict
db\1.8.0.7\hsqldb-1.8.0.7.jar > > > thank you > > > > > > De : Alan Bateman > Envoyé : lundi 1 août 2016 22:00 > À : charbel yazbeck; jigsaw-dev@openjdk.java.net > Objet : Re: Issue with an automatic module > > > On 01/08/

RE: Issue with an automatic module

2016-08-02 Thread charbel yazbeck
\hsqldb\hsqldb\1.8.0.7\hsqldb-1.8.0.7.jar thank you De : Alan Bateman Envoyé : lundi 1 août 2016 22:00 À : charbel yazbeck; jigsaw-dev@openjdk.java.net Objet : Re: Issue with an automatic module On 01/08/2016 12:01, charbel yazbeck wrote: hi I was just

Re: Issue with an automatic module

2016-08-01 Thread Alan Bateman
On 01/08/2016 12:01, charbel yazbeck wrote: hi I was just trying the following sample: ModuleFinder finder = ModuleFinder.of(path); //path points to the location of a jar with an unnamed module finder.findAll().forEach(System.out::println); I see nar-maven-plugin-3.0.0.ja

RE: Issue with an automatic module

2016-08-01 Thread charbel yazbeck
De : Alan Bateman Envoyé : lundi 1 août 2016 16:32 À : charbel yazbeck; jigsaw-dev@openjdk.java.net Objet : Re: Issue with an automatic module On 01/08/2016 08:37, charbel yazbeck wrote: > Hi > > > i was trying to play around latest jigsaw version in order to a

Re: Issue with an automatic module

2016-08-01 Thread Alan Bateman
On 01/08/2016 08:37, charbel yazbeck wrote: Hi i was trying to play around latest jigsaw version in order to adapt an open source projet that i developed and i found the following issue. When using a jar containing a class with no package, the modulefinder is failing to create its module de

Issue with an automatic module

2016-08-01 Thread charbel yazbeck
Hi i was trying to play around latest jigsaw version in order to adapt an open source projet that i developed and i found the following issue. When using a jar containing a class with no package, the modulefinder is failing to create its module descriptor. It guesses that it is an automatic m