Re: Concealed packages (was Re: Module API usage questions)

2016-07-20 Thread Alan Bateman
On 20/07/2016 20:13, Paul Benedict wrote: Yes, that's my concern, but it's really only secondary to something else. I am more concerned that specifying both seems redundant. The JVM should be able to infer at resolution time that what's not exported is concealed. There may be a grander design

Re: Concealed packages (was Re: Module API usage questions)

2016-07-20 Thread Chris Hegarty
> On 20 Jul 2016, at 20:13, Paul Benedict wrote: > > Yes, that's my concern, but it's really only secondary to something else. I > am more concerned that specifying both seems redundant. The JVM should be > able to infer at resolution time that what's not exported is concealed. > There may be a

Re: Concealed packages (was Re: Module API usage questions)

2016-07-20 Thread Paul Benedict
Yes, that's my concern, but it's really only secondary to something else. I am more concerned that specifying both seems redundant. The JVM should be able to infer at resolution time that what's not exported is concealed. There may be a grander design at play which I yet to understand, but I don't

Re: Concealed packages (was Re: Module API usage questions)

2016-07-20 Thread Alan Bateman
On 20/07/2016 19:34, Paul Benedict wrote: Alan, is the JVM going to verify that what's listed in ConcealedPackages structure actually exists as packages in the module? If you asking if it scans the contents of the JAR file to check if the ConcealedPackages attribute is correct then "no". Are

Concealed packages (was Re: Module API usage questions)

2016-07-20 Thread Paul Benedict
Alan, is the JVM going to verify that what's listed in ConcealedPackages structure actually exists as packages in the module? Cheers, Paul On Tue, Jul 19, 2016 at 4:56 PM, Alan Bateman wrote: > On 19/07/2016 21:16, Paul Benedict wrote: > > > Can you into more about packages "not be package of y

Re: Module API usage questions

2016-07-19 Thread Alan Bateman
On 19/07/2016 22:34, Paul Benedict wrote: On Tue, Jul 19, 2016 at 3:00 PM, Alan Bateman > wrote: On 19/07/2016 19:38, Paul Benedict wrote: 2) Must all modules that could ever be loaded be specified on the module path? I was hoping to

Re: Module API usage questions

2016-07-19 Thread Alan Bateman
On 19/07/2016 21:16, Paul Benedict wrote: Can you into more about packages "not be package of your module"? I apologize for not understanding. If I assemble myself a jar file and my jar file has 10 packages and I have an "empty" module-info.java file (i.e., just a name and curly braces), don

Re: Module API usage questions

2016-07-19 Thread Paul Benedict
On Tue, Jul 19, 2016 at 3:00 PM, Alan Bateman wrote: > On 19/07/2016 19:38, Paul Benedict wrote: > >> 2) Must all modules that could ever be loaded be specified on the module >> path? I was hoping to find a hook where I could provide by own >> implementation of ModuleFinder that has all that know

Re: Module API usage questions

2016-07-19 Thread Paul Benedict
On Tue, Jul 19, 2016 at 3:00 PM, Alan Bateman wrote: > On 19/07/2016 19:38, Paul Benedict wrote: > > 3) What is the difference between adding a concealed package and not adding >> the package at all? If no difference, I don't know why you would ever call >> ModuleDescriptor.Builder.conceals() >>

Re: Module API usage questions

2016-07-19 Thread Alan Bateman
On 19/07/2016 19:38, Paul Benedict wrote: I have a few questions regarding how to use the module API. Thanks for reading. 1) Is Configuration.empty() meant to be an immutable singleton or a mutable empty configuration? Is it supposed to be analogous to Collections::emptyList/Map where it's a st

Module API usage questions

2016-07-19 Thread Paul Benedict
I have a few questions regarding how to use the module API. Thanks for reading. 1) Is Configuration.empty() meant to be an immutable singleton or a mutable empty configuration? Is it supposed to be analogous to Collections::emptyList/Map where it's a stand-in? I am asking based on the javadoc alon