Re: 8078820 -> Re: RFR: 8068938: Test deploying a XML parser as a module

2016-03-21 Thread Alan Bateman
On 21/03/2016 17:30, huizhe wang wrote: As Peter mentioned in the other thread (8068938...), references to jaxp changes in JIRA would point to wrong links, that would be disruptive. Plus, we (people who have jaxp workplace configured using the JAXP standalone structure) would have to spend

Re: 8078820 -> Re: RFR: 8068938: Test deploying a XML parser as a module

2016-03-21 Thread huizhe wang
On 3/21/2016 10:12 AM, Daniel Fuchs wrote: On 21/03/16 18:02, huizhe wang wrote: On 3/21/2016 9:56 AM, Alan Bateman wrote: On 21/03/2016 16:49, huizhe wang wrote: Then the module-info.java needs to be fixed. XMLReaderFactory is supported along with SAX. Are you sure this API is using Ser

Re: 8078820 -> Re: RFR: 8068938: Test deploying a XML parser as a module

2016-03-21 Thread huizhe wang
On 3/21/2016 2:09 AM, Alan Bateman wrote: On 19/03/2016 23:14, huizhe wang wrote: Saw Alan's update for JDK-8078820. 8078820 is the right id for this, isn't it? :-) 8068938 was a different issue that Sundar has already resolved. By the way, I just realized that the previous webrevs didn't

Re: 8078820 -> Re: RFR: 8068938: Test deploying a XML parser as a module

2016-03-21 Thread Daniel Fuchs
On 21/03/16 18:02, huizhe wang wrote: On 3/21/2016 9:56 AM, Alan Bateman wrote: On 21/03/2016 16:49, huizhe wang wrote: Then the module-info.java needs to be fixed. XMLReaderFactory is supported along with SAX. Are you sure this API is using ServiceLoader? I have a vague memory that we'd n

Re: 8078820 -> Re: RFR: 8068938: Test deploying a XML parser as a module

2016-03-21 Thread huizhe wang
On 3/21/2016 9:56 AM, Alan Bateman wrote: On 21/03/2016 16:49, huizhe wang wrote: Then the module-info.java needs to be fixed. XMLReaderFactory is supported along with SAX. Are you sure this API is using ServiceLoader? I have a vague memory that we'd need the to update the endorsed SAX API

Re: 8078820 -> Re: RFR: 8068938: Test deploying a XML parser as a module

2016-03-21 Thread Alan Bateman
On 21/03/2016 16:49, huizhe wang wrote: Then the module-info.java needs to be fixed. XMLReaderFactory is supported along with SAX. Are you sure this API is using ServiceLoader? I have a vague memory that we'd need the to update the endorsed SAX API for this. -Alan

Re: 8078820 -> Re: RFR: 8068938: Test deploying a XML parser as a module

2016-03-21 Thread huizhe wang
On 3/21/2016 2:44 AM, Frank Yuan wrote: By the way, I just realized that the previous webrevs didn't include org.xml.sax.helpers.XMLReaderFactory. Would you want to add that too? But module-info.java in module java.xml doesn't declare "uses org.xml.sax.helpers.XMLReaderFactory". Btw, I was

RE: 8078820 -> Re: RFR: 8068938: Test deploying a XML parser as a module

2016-03-21 Thread Frank Yuan
From: huizhe wang [mailto:huizhe.w...@oracle.com] Sent: Sunday, March 20, 2016 7:15 AM To: Frank Yuan Cc: Alan Bateman ; Felix Yang ; jigsaw-dev@openjdk.java.net Subject: 8078820 -> Re: RFR: 8068938: Test deploying a XML parser as a module Saw Alan's update for JDK-8078820. 80

Re: RFR: 8068938: Test deploying a XML parser as a module

2016-03-21 Thread Peter Levart
On 01/27/2016 12:10 PM, Alan Bateman wrote: On 26/01/2016 17:30, huizhe wang wrote: Hi Felix, I would feel sorry for Frank since at the time we wanted all tests to be hosted in the JAXP repo. I understand the intention to consolidate repos as Alan suggested. However, if the JAXP repo is no

Re: 8078820 -> Re: RFR: 8068938: Test deploying a XML parser as a module

2016-03-21 Thread Alan Bateman
On 19/03/2016 23:14, huizhe wang wrote: Saw Alan's update for JDK-8078820. 8078820 is the right id for this, isn't it? :-) 8068938 was a different issue that Sundar has already resolved. By the way, I just realized that the previous webrevs didn't include org.xml.sax.helpers.XMLReaderFactor

8078820 -> Re: RFR: 8068938: Test deploying a XML parser as a module

2016-03-19 Thread huizhe wang
Saw Alan's update for JDK-8078820. 8078820 is the right id for this, isn't it? :-) 8068938 was a different issue that Sundar has already resolved. By the way, I just realized that the previous webrevs didn't include org.xml.sax.helpers.XMLReaderFactory. Would you want to add that too? Best,

Re: RFR: 8068938: Test deploying a XML parser as a module

2016-01-27 Thread Alan Bateman
On 26/01/2016 17:30, huizhe wang wrote: Hi Felix, I would feel sorry for Frank since at the time we wanted all tests to be hosted in the JAXP repo. I understand the intention to consolidate repos as Alan suggested. However, if the JAXP repo is not hampering JDK development, I'd prefer an ind

Re: RFR: 8068938: Test deploying a XML parser as a module

2016-01-26 Thread huizhe wang
Hi Felix, I would feel sorry for Frank since at the time we wanted all tests to be hosted in the JAXP repo. I understand the intention to consolidate repos as Alan suggested. However, if the JAXP repo is not hampering JDK development, I'd prefer an independent JAXP repo as is since it made JA

Re: RFR: 8068938: Test deploying a XML parser as a module

2016-01-22 Thread Felix Yang
Hi Alan and Joe, I agree with your opinion to move jaxp tests to idk repo. Do you think it is OK to file an enhancement to initiate it? Or at least, plan for future. Thanks, Felix > On Jan 12, 2016, at 12:10 AM, Alan Bateman wrote: > > Joe - where are XML tests going these days? I see Frank

Re: RFR: 8068938: Test deploying a XML parser as a module

2016-01-15 Thread huizhe wang
Sorry for the late response! Looks like I need to pay attention to the jigsaw alias from now on :-) On 1/12/2016 12:10 AM, Alan Bateman wrote: On 11/01/2016 03:02, Frank Yuan wrote: Hi Alan and Joe Would you like to have a review for test task https://bugs.openjdk.java.net/browse/JDK-807882

Re: RFR: 8068938: Test deploying a XML parser as a module

2016-01-15 Thread huizhe wang
Sorry for the late response! Looks like I need to pay attention to the jigsaw alias from now on :-) On 1/12/2016 12:10 AM, Alan Bateman wrote: On 11/01/2016 03:02, Frank Yuan wrote: Hi Alan and Joe Would you like to have a review for test task https://bugs.openjdk.java.net/browse/JDK-807882

Re: RFR: 8068938: Test deploying a XML parser as a module

2016-01-12 Thread Alan Bateman
On 11/01/2016 03:02, Frank Yuan wrote: Hi Alan and Joe Would you like to have a review for test task https://bugs.openjdk.java.net/browse/JDK-8078820? The webrev is at: http://cr.openjdk.java.net/~fyuan/8078820/webrev.00/ . JAXP has