> On May 5, 2016, at 12:12 PM, Jonathan Gibbons
> wrote:
>
> There is potentially a separate discussion here, as to whether javac should
> "force" the provision of a jar-fs provider.
>
> Strictly speaking, javac does not inherently require it. You can use javac
On 05/05/16 19:42, Alexandre (Shura) Iline wrote:
Chris, could you please take another look:
http://cr.openjdk.java.net/~shurailine/8151914/webrev.02/
This looks ok to me Shura, maybe just 'mrjar' for the directory
name?
Since there are file moves can you please prepare the changeset,
and I
There is potentially a separate discussion here, as to whether javac
should "force" the provision of a jar-fs provider.
Strictly speaking, javac does not inherently require it. You can use
javac just fine, with files in the system image, and source and class
files in the default file system.
> On May 5, 2016, at 11:42 AM, Alexandre (Shura) Iline
> wrote:
> Whether the java.tools API behavior is correct is a separate matter. I am
> planning to create a standalone test case and take it with javac ppl.
I take this ^^ back, as the error was there all
Chris, could you please take another look:
http://cr.openjdk.java.net/~shurailine/8151914/webrev.02/
What I have discovered is that jdk.zipfs was used to access jars on the
classpath, which were JTreg jars: jtreg.jar, testing.jar, etc. Cleaning the
class path through the environment removed
This makes sense - I will move the tests into a subduer, put the dependencies
into a TEST.properties file.
jdk.zipfs has the code needed for access jars - the tests are failing without
that dependency.
Shura
> On May 4, 2016, at 8:30 AM, Chris Hegarty wrote:
>
> On
On 04/05/2016 11:24, Chris Hegarty wrote:
:
The tests cause compilation of test library classes, but only some tests
actually use the methods that provoke compilation. Similar to above, tests
that don’t actually compile anything could depend on just java.compiler.
This is all to fragile and
On 04/05/2016 09:40, Chris Hegarty wrote:
On 3 May 2016, at 16:10, Chris Hegarty wrote:
Can you please take a look on:
http://cr.openjdk.java.net/~shurailine/8151914/webrev.01/
Taking another look over this before sponsoring….
The test library dependency seems to
On 3 May 2016, at 16:10, Chris Hegarty wrote:
>>>
>>> Can you please take a look on:
>>> http://cr.openjdk.java.net/~shurailine/8151914/webrev.01/
Taking another look over this before sponsoring….
The test library dependency seems to be on java.compiler, and not
On 2 May 2016, at 22:48, Steve Drach wrote:
> Looks fine to me,
+1.
-Chris.
> although I am not an official reviewer. Thanks for doing this.
>
>> On May 2, 2016, at 1:03 PM, Alexandre (Shura) Iline
>> wrote:
>>
>> Hi,
>>
>> Can you
Looks fine to me, although I am not an official reviewer. Thanks for doing
this.
> On May 2, 2016, at 1:03 PM, Alexandre (Shura) Iline
> wrote:
>
> Hi,
>
> Can you please take a look on:
> http://cr.openjdk.java.net/~shurailine/8151914/webrev.01/
> ?
>
> Thank
> On May 2, 2016, at 1:03 PM, Alexandre (Shura) Iline
> wrote:
>
> Hi,
>
> Can you please take a look on:
> http://cr.openjdk.java.net/~shurailine/8151914/webrev.01/
> ?
Looks okay to me.
Mandy
12 matches
Mail list logo