Re: RFR (T): 8242846: Bring back test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java (was: Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

2020-04-27 Thread Ao Qi
Thanks, Sundar! I updated a new webrev (patch is the same, only hg commit info was added): http://cr.openjdk.java.net/~aoqi/8242846/webrev.02/ Could someone help to sponsor this? Thanks, Ao Qi On Mon, Apr 27, 2020 at 4:52 PM wrote: > > Looks good > > -Sundar > > On 27/04/20 12:24 pm, Ao Qi

Re: RFR (T): 8242846: Bring back test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java (was: Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

2020-04-27 Thread sundararajan . athijegannathan
Looks good -Sundar On 27/04/20 12:24 pm, Ao Qi wrote: On Sun, Apr 26, 2020 at 12:00 AM Alan Bateman wrote: On 21/04/2020 04:58, Ao Qi wrote: On 2020/4/20 下午9:27, Alan Bateman wrote: On 20/04/2020 11:32, sundararajan.athijegannat...@oracle.com wrote: Hi Alan, I don't remember it now.

RFR (T): 8242846: Bring back test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java (was: Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java)

2020-04-27 Thread Ao Qi
On Sun, Apr 26, 2020 at 12:00 AM Alan Bateman wrote: > > On 21/04/2020 04:58, Ao Qi wrote: > > > > On 2020/4/20 下午9:27, Alan Bateman wrote: > >> On 20/04/2020 11:32, sundararajan.athijegannat...@oracle.com wrote: > >>> Hi Alan, > >>> > >>> I don't remember it now. Likely a mistake. The changeset

Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

2020-04-25 Thread Alan Bateman
On 21/04/2020 04:58, Ao Qi wrote: On 2020/4/20 下午9:27, Alan Bateman wrote: On 20/04/2020 11:32, sundararajan.athijegannat...@oracle.com wrote: Hi Alan, I don't remember it now. Likely a mistake. The changeset http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/a066fe7b1b42 has that file. Perhaps

Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

2020-04-20 Thread Ao Qi
On 2020/4/20 下午9:27, Alan Bateman wrote: On 20/04/2020 11:32, sundararajan.athijegannat...@oracle.com wrote: Hi Alan, I don't remember it now. Likely a mistake. The changeset http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/a066fe7b1b42 has that file. Perhaps it may be useful to restore &

Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

2020-04-20 Thread Ao Qi
Hi Alan and Sundar, Thanks for the advice. I will take a look at if the test should be brought back. Cheers, Ao Qi On 2020/4/20 下午6:32, sundararajan.athijegannat...@oracle.com wrote: Hi Alan, I don't remember it now. Likely a mistake. The changeset

Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

2020-04-20 Thread Alan Bateman
On 20/04/2020 11:32, sundararajan.athijegannat...@oracle.com wrote: Hi Alan, I don't remember it now. Likely a mistake. The changeset http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/a066fe7b1b42 has that file. Perhaps it may be useful to restore & check if the test passes. Yes. I think it was

Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

2020-04-20 Thread sundararajan . athijegannathan
Hi Alan, I don't remember it now. Likely a mistake. The changeset http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/a066fe7b1b42 has that file. Perhaps it may be useful to restore & check if the test passes. Thanks, -Sundar On 18/04/20 3:32 pm, Alan Bateman wrote: Sundar - do you recognize

Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

2020-04-18 Thread Alan Bateman
Sundar - do you recognize this? I assume truncating this test to 0 bytes was a mistake but I can't tell if the test should be brought back or not (to ensure that`jlink --order-resources` is tested). -Alan On 17/04/2020 11:34, Ao Qi wrote: Hi, The original email is waiting for moderator

Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

2020-04-17 Thread Ao Qi
Hi, The original email is waiting for moderator approval. Subscribed to jigsaw-dev and resent the RFR (cc'ed core-libs-dev). Thanks, Ao Qi On Wed, Apr 15, 2020 at 10:11 PM Ao Qi wrote: > > Hi all, > > test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java was changed > to an empty file by