> On Jun 15, 2016, at 1:32 PM, Mandy Chung wrote:
>
>
>> On Jun 14, 2016, at 4:00 PM, Mandy Chung wrote:
>>
>>
>>> On Jun 14, 2016, at 3:53 PM, Alexandre (Shura) Iline
>>> wrote:
>>>
>>> Hi.
>>>
>>> After some offline conversations it was decided to leave the tests which
>>> depend on a
> On Jun 14, 2016, at 4:00 PM, Mandy Chung wrote:
>
>
>> On Jun 14, 2016, at 3:53 PM, Alexandre (Shura) Iline
>> wrote:
>>
>> Hi.
>>
>> After some offline conversations it was decided to leave the tests which
>> depend on absence of “-limitmods” in VM options for later. I have created a
>
> On Jun 14, 2016, at 3:53 PM, Alexandre (Shura) Iline
> wrote:
>
> Hi.
>
> After some offline conversations it was decided to leave the tests which
> depend on absence of “-limitmods” in VM options for later. I have created a
> separate bug ti track that:
> https://bugs.openjdk.java.net/bro
Hi.
After some offline conversations it was decided to leave the tests which depend
on absence of “-limitmods” in VM options for later. I have created a separate
bug ti track that:
https://bugs.openjdk.java.net/browse/JDK-8159523
What left for this review is this, then:
http://cr.openjdk.java.n
Hi Shura,
test/java/lang/Class/GetModuleTest.java
This can use java.base/jdk.internal.misc.Unsafe instead.
Other @modules looks okay.
Regarding the executeTestJava change, if you drop the VM options, this test
will only exercise the default launcher setting. The hotspot nightlies depend
on
On 07/06/2016 06:04, Alexandre (Shura) Iline wrote:
On Jun 6, 2016, at 8:59 PM, Amy Lu wrote:
I'm not an official reviewer but just a minor comment ...
I noticed that "executeTestJava" changed to "executeProcess" in ProxyTest.java,
ProxyClassAccessTest.java and ModuleAccessControlTest.java,
> On Jun 6, 2016, at 8:59 PM, Amy Lu wrote:
>
> I'm not an official reviewer but just a minor comment ...
>
> I noticed that "executeTestJava" changed to "executeProcess" in
> ProxyTest.java, ProxyClassAccessTest.java and ModuleAccessControlTest.java,
> are these changes expected in this patc
I'm not an official reviewer but just a minor comment ...
I noticed that "executeTestJava" changed to "executeProcess" in
ProxyTest.java, ProxyClassAccessTest.java and
ModuleAccessControlTest.java, are these changes expected in this patch?
If yes, should test/java/lang/reflect/Module/access/Ac
Hi,
Please review the change with fixes the remaining @module declaration in
java/lang tests:
http://cr.openjdk.java.net/~shurailine/8158855/webrev.00
This addresses everything in the java.lang, except next few tests which either
require more work or blocked by other issues:
java/lang/SecurityM
