Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

2017-03-24 Thread Andrey Nazarov
Hi Mandy > On 23 Mar 2017, at 21:07, Mandy Chung wrote: > > >> On Mar 23, 2017, at 10:47 AM, Andrey Nazarov >> wrote: >> >> Hi Mandy, >> >> TaskHelper.java, JLinkTest and IntegrationTest need new copyright year. >> It’s unclear why do you need concept of “terminal” option >> > > It’s a low

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

2017-03-24 Thread Mandy Chung
> On Mar 24, 2017, at 7:53 AM, Alan Bateman wrote: > > On 23/03/2017 17:04, Mandy Chung wrote: > >> : >> Good catch. Fixed. >> >> Revised webrev: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8174826/webrev.01/ >> > The updated webrev looks okay. On the --verbose output then what you ha

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

2017-03-24 Thread Alan Bateman
On 23/03/2017 17:04, Mandy Chung wrote: : Good catch. Fixed. Revised webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8174826/webrev.01/ The updated webrev looks okay. On the --verbose output then what you have is okay (although it does end up listing the the service provider modules

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

2017-03-23 Thread Mandy Chung
> On Mar 23, 2017, at 11:40 AM, Alan Bateman wrote: > > On 23/03/2017 17:04, Mandy Chung wrote: > >> : >> When linking with explicit providers via —-add-modules, would you think it >> may be useful to see the list of providers? > For the most part then this will just print out the providers sp

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

2017-03-23 Thread Alan Bateman
On 23/03/2017 17:04, Mandy Chung wrote: : When linking with explicit providers via —-add-modules, would you think it may be useful to see the list of providers? For the most part then this will just print out the providers specified to --add-modules, unless you are thinking about the less comm

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

2017-03-23 Thread Mandy Chung
> On Mar 23, 2017, at 11:07 AM, Mandy Chung wrote: > >> Instead of "copy-paste" code to run Jlink in tests ProcessTools and >> OutputAnalyzer can be used from standard test library >> test/lib/share/classes/jdk/test/lib/process >> > > I agree that it’d be good to move it to a test library bu

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

2017-03-23 Thread Mandy Chung
> On Mar 23, 2017, at 10:47 AM, Andrey Nazarov > wrote: > > Hi Mandy, > > TaskHelper.java, JLinkTest and IntegrationTest need new copyright year. > It’s unclear why do you need concept of “terminal” option > It’s a low risk and expedient way to support options with optional argument (-—sugg

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

2017-03-23 Thread Andrey Nazarov
Hi Mandy, TaskHelper.java, JLinkTest and IntegrationTest need new copyright year. It’s unclear why do you need concept of “terminal” option Instead of "copy-paste" code to run Jlink in tests ProcessTools and OutputAnalyzer can be used from standard test library test/lib/share/classes/jdk/test/l

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

2017-03-23 Thread Mandy Chung
> On Mar 23, 2017, at 7:58 AM, Alan Bateman wrote: > > On 22/03/2017 19:11, Mandy Chung wrote: > >> Webrev: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8174826/webrev.00/ >> >> This is a proposal to resolve the open issue listed in JEP 282 >> about jlink and service binding. > The out

Re: Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

2017-03-23 Thread Alan Bateman
On 22/03/2017 19:11, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8174826/webrev.00/ This is a proposal to resolve the open issue listed in JEP 282 about jlink and service binding. The output for --suggest-providers looks good. For --verbose then the "Provider

Review Request: JDK-8174826 jlink does not provide support for linking in service provider modules

2017-03-22 Thread Mandy Chung
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8174826/webrev.00/ This is a proposal to resolve the open issue listed in JEP 282 about jlink and service binding. jlink does not do service binding by default as it may be confusing to the users. To link in service providers, users have t