Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

2015-09-16 Thread Attila Szegedi
> On Sep 16, 2015, at 2:51 PM, Alan Bateman wrote: > > > > On 16/09/2015 13:28, Magnus Ihse Bursie wrote: >> On 2015-09-11 18:00, Attila Szegedi wrote: >>> Please review the revised changes for JDK-8135251 "Use >>> Unsafe.defineAnonymousClass for loading Nashorn script code” >>>

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

2015-09-16 Thread Sundararajan Athijegannathan
+1 Nashorn changes and modules.xml changes look good to me. -Sundar On 9/16/2015 7:35 PM, Attila Szegedi wrote: On Sep 16, 2015, at 2:51 PM, Alan Bateman wrote: On 16/09/2015 13:28, Magnus Ihse Bursie wrote: On 2015-09-11 18:00, Attila Szegedi wrote: Please review the revised changes for

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

2015-09-16 Thread Alan Bateman
On 16/09/2015 14:06, David M. Lloyd wrote: Also I could be wrong but it looks to me like the jigsaw/jake forest's equivalent module graph has evolved somewhat, and thus doesn't quite match this file anyway. jigsaw/jake is currently at jdk9-b81. There may be changes backed up in jdk9/dev that

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

2015-09-16 Thread Alan Bateman
On 16/09/2015 14:04, Magnus Ihse Bursie wrote: Does this mean that updates to modules.xml between now and the integration-to-come of jigsaw/jake do not anymore need specific approval? I think we should keep the status quo and CC jigsaw-dev when there are changes to modules.xml. If nothing els

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

2015-09-16 Thread David M. Lloyd
On 09/16/2015 07:51 AM, Alan Bateman wrote: On 16/09/2015 13:28, Magnus Ihse Bursie wrote: On 2015-09-11 18:00, Attila Szegedi wrote: Please review the revised changes for JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code”

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

2015-09-16 Thread Magnus Ihse Bursie
On 2015-09-16 14:51, Alan Bateman wrote: On 16/09/2015 13:28, Magnus Ihse Bursie wrote: On 2015-09-11 18:00, Attila Szegedi wrote: Please review the revised changes for JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code”

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

2015-09-16 Thread Alan Bateman
On 16/09/2015 13:28, Magnus Ihse Bursie wrote: On 2015-09-11 18:00, Attila Szegedi wrote: Please review the revised changes for JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code” The revision incorporates the foll

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

2015-09-16 Thread Magnus Ihse Bursie
On 2015-09-11 18:00, Attila Szegedi wrote: Please review the revised changes for JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code” The revision incorporates the following changes: - the feature can be disabled by set