Re: RFR: JDK-8058118: Generate modules.list during the build

2014-09-12 Thread Mandy Chung
On 9/12/14 7:03 AM, Erik Joelsson wrote: Hello, The checked in modules.list file defines the dependencies between modules for the build. The dependency information in this file is already captured in the modules.xml. Rather than keeping two copies of this information, with this change, module

Re: RFR: JDK-8058118: Generate modules.list during the build

2014-09-14 Thread Mandy Chung
On 9/13/2014 1:30 AM, Chris Hegarty wrote: Update jdk part as per Mandy’s comments: http://cr.openjdk.java.net/~chegar/8058118/webrev_jdk.01/webrev/ Looks good. Thanks for the update. As Alan pointed out, it'd be good to add a private no-arg constructor to ModulesXmlReader and ModulesXml

hg: jigsaw/m2/jdk: 2 new changesets

2014-09-18 Thread mandy . chung
Changeset: 8fba547a2bc7 Author:mchung Date: 2014-09-18 20:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/8fba547a2bc7 jimage build tool should not exclude classes starts with _ ! make/src/classes/build/tools/module/ModuleArchive.java Changeset: f5b029a53bfd Author:

hg: jigsaw/m2/jdk: Merge localedata and cldrdata service config file

2014-09-18 Thread mandy . chung
Changeset: 52ee19a24415 Author:mchung Date: 2014-09-18 22:15 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/52ee19a24415 Merge localedata and cldrdata service config file ! make/CreateJars.gmk - src/jdk.localedata/META-INF/cldrdata-services/sun.util.locale.provider.Locale

hg: jigsaw/m2/langtools: Update jdeps to work with modular image

2014-09-24 Thread mandy . chung
Changeset: 11a11f331a42 Author:mchung Date: 2014-09-24 12:16 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/11a11f331a42 Update jdeps to work with modular image ! src/jdk.dev/share/classes/com/sun/tools/jdeps/ClassFileReader.java ! src/jdk.dev/share/classes/com/sun/t

hg: jigsaw/m2: 20 new changesets

2014-09-27 Thread mandy . chung
Changeset: 34df46455488 Author:lancea Date: 2014-09-12 17:46 -0400 URL: http://hg.openjdk.java.net/jigsaw/m2/rev/34df46455488 8058366: Export sun.misc to java.sql Reviewed-by: mchung ! modules.xml Changeset: a3ee36412163 Author:ehelin Date: 2014-09-15 16:30 +0200 URL:

hg: jigsaw/m2/corba: 4 new changesets

2014-09-27 Thread mandy . chung
Changeset: cfdac5887952 Author:katleman Date: 2014-09-25 12:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/corba/rev/cfdac5887952 Added tag jdk9-b32 for changeset b5b139354630 ! .hgtags Changeset: 1683040fc3fa Author:mchung Date: 2014-09-27 00:40 -0700 URL: http

hg: jigsaw/m2/jaxws: 6 new changesets

2014-09-27 Thread mandy . chung
Changeset: d35ad0854f68 Author:mkos Date: 2014-09-12 17:20 +0200 URL: http://hg.openjdk.java.net/jigsaw/m2/jaxws/rev/d35ad0854f68 8054548: JAX-WS tools need to updated to work with modular image Summary: Removing java reflection API to get JavaCompiler; using standard javax.tools A

hg: jigsaw/m2/hotspot: 70 new changesets

2014-09-27 Thread mandy . chung
Changeset: 6818c5298fab Author:dholmes Date: 2014-09-02 21:27 -0400 URL: http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/6818c5298fab 8046210: Missing memory barrier when reading init_lock Reviewed-by: fparain, dcubed, mdoerr Contributed-by: Bill Pittore ! src/share/vm/oops/insta

hg: jigsaw/m2/jaxp: 2 new changesets

2014-09-27 Thread mandy . chung
Changeset: 46b360454dad Author:katleman Date: 2014-09-25 12:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/jaxp/rev/46b360454dad Added tag jdk9-b32 for changeset b940ca3d2c7e ! .hgtags Changeset: bf5a6fa4e8c2 Author:mchung Date: 2014-09-27 00:40 -0700 URL: http:

hg: jigsaw/m2/langtools: 15 new changesets

2014-09-27 Thread mandy . chung
Changeset: 3eb8614e39b3 Author:sogoel Date: 2014-09-12 17:05 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/3eb8614e39b3 8055080: Group 9d: golden files for tests in tools/javac dir Reviewed-by: jjg, mcimadamore, jlahoda ! test/tools/javac/Parens1.java + test/tools/j

hg: jigsaw/m2/nashorn: 19 new changesets

2014-09-27 Thread mandy . chung
Changeset: a20309596c42 Author:hannesw Date: 2014-09-12 11:00 +0200 URL: http://hg.openjdk.java.net/jigsaw/m2/nashorn/rev/a20309596c42 8057743: Single quotes must be escaped in message resource file Reviewed-by: attila, lagergren, sundar ! src/jdk.scripting.nashorn/share/classes/j

Re: RFR 8058657: Add @jdk.Exported to com.sun.jarsigner APIs

2014-09-29 Thread Mandy Chung
On 9/29/2014 8:14 PM, Wang Weijun wrote: Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8058657/webrev.00/ It includes both the dev repo and dev/jdk repo. While the change in dev/jdk is useless with today's modules environment, it is included here and will be

Review Request: JDK-8059083: Remove jdk.compact3 from modules.xml

2014-10-02 Thread Mandy Chung
jdk.compact3 was meant to be removed when we integrated JEP 201: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8059083/webrev.00/ Mandy

hg: jigsaw/m2/jdk: Update java.policy and test policy with module URL

2014-10-15 Thread mandy . chung
Changeset: 3150fbd1dbde Author:wetmore Date: 2014-10-15 16:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/3150fbd1dbde Update java.policy and test policy with module URL ! src/java.base/share/conf/security/java.policy ! src/java.base/windows/conf/security/java.policy !

Re: RFR 8046002: Move Ucrypto to the open jdk repo

2014-10-16 Thread Mandy Chung
On 10/15/14 3:20 PM, Valerie Peng wrote: Hi, experts, Please review the update for module.xml for 8046002: Move Ucrypto to the open jdk repo http://cr.openjdk.java.net/~valeriep/8046002_top/webrev.00/ Looks okay to me too. Mandy

hg: jigsaw/m2/jdk: 8059315: KeyStore and keytool tests failing with KeyStoreException; ...

2014-10-17 Thread mandy . chung
Changeset: d359a9bb2d3a Author:mchung Date: 2014-10-17 12:16 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/d359a9bb2d3a 8059315: KeyStore and keytool tests failing with KeyStoreException 8059316: closed/com/sun/crypto/provider/KeyStore/BackwardCompatibility.java failing i

hg: jigsaw/m2/langtools: Remove jdeps legacy image support

2014-10-20 Thread mandy . chung
Changeset: 604f4be5fcea Author:mchung Date: 2014-10-20 19:24 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/604f4be5fcea Remove jdeps legacy image support ! src/jdk.dev/share/classes/com/sun/tools/jdeps/Archive.java ! src/jdk.dev/share/classes/com/sun/tools/jdeps/Jde

hg: jigsaw/m2/jdk: jfxrt.jar moved from lib/ext to lib in the modular image

2014-10-21 Thread mandy . chung
Changeset: ca389ce52206 Author:mchung Date: 2014-10-21 11:53 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/ca389ce52206 jfxrt.jar moved from lib/ext to lib in the modular image ! src/java.base/share/classes/sun/misc/Launcher.java

hg: jigsaw/m2/langtools: jfxrt.jar moved from lib/ext to lib in the modular image

2014-10-21 Thread mandy . chung
Changeset: 8dd333dfc21c Author:mchung Date: 2014-10-21 11:53 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/8dd333dfc21c jfxrt.jar moved from lib/ext to lib in the modular image ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java

Re: [9] RFR: 8061382: Separate CLDR locale data from JRE locale data

2014-10-22 Thread Mandy Chung
On 10/20/2014 5:25 PM, Naoto Sato wrote: My motive for the question is the naming because the changes mean we have jdk.localedata and jdk.localedata.cldr, an arrangement that suggests that the CLDR locale data augments the jdk.localedata module. It may be that we need to choose more suitable

hg: jigsaw/m2/jdk: Temporarily exclude com/sun/tracing/BasicWithSecurityMgr.java

2014-10-28 Thread mandy . chung
Changeset: 261a146261a7 Author:mchung Date: 2014-10-28 08:33 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/261a146261a7 Temporarily exclude com/sun/tracing/BasicWithSecurityMgr.java ! test/ProblemList.txt

hg: jigsaw/m2/jdk: Remove endorsed standards and override mechanism

2014-10-28 Thread mandy . chung
Changeset: ecb6b907fac5 Author:mchung Date: 2014-10-28 15:50 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/ecb6b907fac5 Remove endorsed standards and override mechanism + test/java/lang/ClassLoader/EndorsedDirs.java

hg: jigsaw/m2/langtools: Exclude tests setting -Djava.endorsed.dirs

2014-10-28 Thread mandy . chung
Changeset: d165efd0c47a Author:mchung Date: 2014-10-28 15:50 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/d165efd0c47a Exclude tests setting -Djava.endorsed.dirs ! test/tools/javac/Paths/Class-Path.sh ! test/tools/javac/Paths/Diagnostics.sh ! test/tools/javac/Paths

hg: jigsaw/m2/hotspot: Remove endorsed standards and override mechanism

2014-10-28 Thread mandy . chung
Changeset: 03c2fc15b0c9 Author:mchung Date: 2014-10-28 15:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/03c2fc15b0c9 Remove endorsed standards and override mechanism ! src/os/aix/vm/os_aix.cpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solar

Re: CFV: New Jigsaw Committer: Sundar Athijegannathan

2014-11-03 Thread Mandy Chung
Vote: yes On 11/3/14 6:02 AM, Alan Bateman wrote: I hereby nominate Sundar Athijegannathan to Jigsaw Committer. Sundar is currently a Reviewer on the jdk9, jdk8u and Nashorn projects. Sundar has been contributing to Project Jigsaw by way of the compression support in jimage container format

Re: CFV: New Jigsaw Committer: Jim Laskey

2014-11-03 Thread Mandy Chung
Vote: yes On 11/3/14 6:02 AM, Alan Bateman wrote: I hereby nominate Jim Laskey to Jigsaw Committer. Jim is lead for Project Nashorn and a Reviewer on the jdk9 and jdk8u projects. Jim has been contributing to Project Jigsaw by way of the jimage container format that is currently prototyped in

hg: jigsaw/m2/hotspot: Remove the extension mechanism

2014-11-03 Thread mandy . chung
Changeset: cfb878035fe3 Author:mchung Date: 2014-11-03 14:09 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/cfb878035fe3 Remove the extension mechanism ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/globals.hpp

hg: jigsaw/m2/jaxp: Remove the extension mechanism

2014-11-03 Thread mandy . chung
Changeset: c39696d0fabb Author:mchung Date: 2014-11-03 14:12 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/jaxp/rev/c39696d0fabb Remove the extension mechanism ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/util/ClassPath.java ! src/java.xml/share/classes/com/sun

hg: jigsaw/m2/jdk: Remove the extension mechanism

2014-11-03 Thread mandy . chung
Changeset: 2214c889c9a5 Author:mchung Date: 2014-11-03 14:11 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/2214c889c9a5 Remove the extension mechanism ! src/demo/share/java2d/J2DBench/src/j2dbench/ResultSet.java ! src/java.base/share/classes/java/lang/System.java ! src/ja

hg: jigsaw/m2/langtools: Temporarily exclude test cases setting -Djava.ext.dirs

2014-11-03 Thread mandy . chung
Changeset: 3cd26d48ea17 Author:mchung Date: 2014-11-03 14:10 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/3cd26d48ea17 Temporarily exclude test cases setting -Djava.ext.dirs ! test/tools/javac/Paths/Class-Path2.sh ! test/tools/javac/api/TestSearchPaths.java

hg: jigsaw/m2/nashorn: Remove the extension mechanism

2014-11-03 Thread mandy . chung
Changeset: 23d881bb7a79 Author:sundar Date: 2014-11-03 14:07 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/nashorn/rev/23d881bb7a79 Remove the extension mechanism ! make/build.xml ! test/script/nosecurity/JDK-8050964.js ! test/script/nosecurity/JDK-8055034.js ! test/src/jdk/nasho

hg: jigsaw/m2/hotspot: Remove java.ext.dirs from perfcounter list

2014-11-04 Thread mandy . chung
Changeset: 85265c0ba36c Author:mchung Date: 2014-11-04 14:44 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/85265c0ba36c Remove java.ext.dirs from perfcounter list ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/statSampler.cpp

hg: jigsaw/m2/jdk: Update test/javax/naming/spi/providers/InitialContextTest.java not to use java.ext.dirs

2014-11-04 Thread mandy . chung
Changeset: 86c0f929d70f Author:prappo Date: 2014-11-04 14:46 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/86c0f929d70f Update test/javax/naming/spi/providers/InitialContextTest.java not to use java.ext.dirs ! test/ProblemList.txt ! test/javax/naming/spi/providers/Initia

hg: jigsaw/m2/hotspot: Fix fastdebug hotspot build failure

2014-11-07 Thread mandy . chung
Changeset: 524e324ecb43 Author:mchung Date: 2014-11-07 13:20 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/524e324ecb43 Fix fastdebug hotspot build failure ! src/share/vm/classfile/classLoader.cpp

hg: jigsaw/m2/hotspot: Replace PrintExtDirsWarning with -XX:+CheckEndorsedAndExtDirs flag

2014-11-10 Thread mandy . chung
Changeset: 9531206c79a6 Author:mchung Date: 2014-11-10 12:05 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/9531206c79a6 Replace PrintExtDirsWarning with -XX:+CheckEndorsedAndExtDirs flag ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp

hg: jigsaw/m2/hotspot: Missing closedir when returning error

2014-11-17 Thread mandy . chung
Changeset: 88e46ff30a76 Author:mchung Date: 2014-11-17 14:14 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/88e46ff30a76 Missing closedir when returning error ! src/share/vm/runtime/arguments.cpp

hg: jigsaw/m2/langtools: 8064782: Change jdeps to use jrt:/ instead of jimagefs

2014-11-17 Thread mandy . chung
Changeset: 08d53f676247 Author:mchung Date: 2014-11-17 19:18 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/08d53f676247 8064782: Change jdeps to use jrt:/ instead of jimagefs ! src/jdk.dev/share/classes/com/sun/tools/jdeps/ClassFileReader.java ! src/jdk.dev/share/cl

hg: jigsaw/m2/jdk: 8064782: Change jdeps to use jrt:/ instead of jimagefs

2014-11-17 Thread mandy . chung
Changeset: 8cb493f1bb25 Author:mchung Date: 2014-11-17 19:18 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/8cb493f1bb25 8064782: Change jdeps to use jrt:/ instead of jimagefs ! make/src/classes/build/tools/module/ModulesXmlReader.java ! make/src/classes/build/tools/module

hg: jigsaw/m2: ucrypto moved to the open

2014-11-17 Thread mandy . chung
Changeset: 7ec2be25e81e Author:mchung Date: 2014-11-17 19:52 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/rev/7ec2be25e81e ucrypto moved to the open ! make/Images.gmk

hg: jigsaw/m2/jdk: Deprecate IMPLEMENTATION_VENDOR_ID, part of the extension mechanism

2014-11-25 Thread mandy . chung
Changeset: 822817a5a844 Author:mchung Date: 2014-11-24 13:05 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/822817a5a844 Deprecate IMPLEMENTATION_VENDOR_ID, part of the extension mechanism ! src/java.base/share/classes/java/util/jar/Attributes.java

hg: jigsaw/m2/jdk: Remove @Deprecated from EXTENSION_NAME and EXTENSION_LIST

2014-11-26 Thread mandy . chung
Changeset: 3e198fd8bac3 Author:mchung Date: 2014-11-26 08:32 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/3e198fd8bac3 Remove @Deprecated from EXTENSION_NAME and EXTENSION_LIST ! src/java.base/share/classes/java/util/jar/Attributes.java

hg: jigsaw/m2/langtools: Fix typo

2014-12-01 Thread mandy . chung
Changeset: 2b199ffb3f98 Author:mchung Date: 2014-12-01 17:41 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/2b199ffb3f98 Fix typo ! src/jdk.dev/share/classes/com/sun/tools/jdeps/Profile.java

Re: 8067867: Subsume module java.xml.soap into module java.xml.ws

2015-01-05 Thread Mandy Chung
On 1/3/15 1:24 AM, Alan Bateman wrote: There are a number of proposed updates to the module graph that we need reflected in the source code layout (and the module graph in JEP 200 [1] will need to be refreshed too). JDK-8067867 tracks dropping the module java.xml.soap and subsuming the API i

Re: 8047776: Add module java.transaction to export API javax.transaction

2015-01-05 Thread Mandy Chung
On 1/3/15 2:01 AM, Alan Bateman wrote: This is another update to the module graph, this time it's the quagmire of the Java Transaction API, a subset of which is defined for Java SE for mapping of CORBA exceptions to RMI exceptions and for the XA support in the JDBC API. The proposal is to c

Review request: JDK-8069414: Rename oracle.accessbridge to jdk.accessbridge

2015-01-22 Thread Mandy Chung
diff --git a/modules.xml b/modules.xml --- a/modules.xml +++ b/modules.xml @@ -737,7 +737,7 @@ sun.awt - oracle.accessbridge + jdk.accessbridge Mandy

Review request 8069551: Move java.security.acl from compact3 to java.base

2015-01-29 Thread Mandy Chung
Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8069551/webrev.00 java.security.acl is superceded by java.security package since 1.2. This patch proposes to move java.security.acl package to java.base module rather than complicating the module graph with a close-to-useless dedicated

Re: Review request 8069551: Move java.security.acl from compact3 to java.base

2015-01-30 Thread Mandy Chung
On 1/30/15 12:50 AM, Alan Bateman wrote: On 29/01/2015 20:58, Mandy Chung wrote: Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8069551/webrev.00 java.security.acl is superceded by java.security package since 1.2. This patch proposes to move java.security.acl package to java.base

Re: RFR JDK-8071338: Move policytool from JRE to JDK

2015-02-05 Thread Mandy Chung
On 2/5/2015 6:18 PM, Weijun Wang wrote: Hi All Please review this change at root: http://cr.openjdk.java.net/~weijun/8071338/root/webrev.00/ jdk: http://cr.openjdk.java.net/~weijun/8071338/jdk/webrev.00/ No actual java code change, just move everything inside the s.s.t.policytool into anoth

Re: Apache Maven JDeps Plugin

2015-02-17 Thread Mandy Chung
Hi Robert, Indeed this looks very useful. On 2/16/2015 10:45 AM, Alan Bateman wrote: On 16/02/2015 18:28, Robert Scholte wrote: Hi Alan, if you are referring to the -R / -recursive option of the jdeps tool, then yes you can. See http://maven.apache.org/plugins-archives/maven-jdeps-plugin-LA

Re: [9] Review Request: 8072663: Remove the sun.security.acl package which is not used in the JDK

2015-02-18 Thread Mandy Chung
On 2/17/15 12:59 PM, Jason Uh wrote: Please review this fix, which removes the sun.security.acl package. webrev: http://cr.openjdk.java.net/~juh/8072663/00/ jbs: http://bugs.openjdk.java.net/browse/JDK-8072663 Looks fine. While the java.security.acl package is small, it'd be nice if this pac

Re: Apache Maven JDeps Plugin

2015-02-19 Thread Mandy Chung
Wed, 18 Feb 2015 05:46:37 +0100 schreef Mandy Chung : Hi Robert, Indeed this looks very useful. On 2/16/2015 10:45 AM, Alan Bateman wrote: On 16/02/2015 18:28, Robert Scholte wrote: Hi Alan, if you are referring to the -R / -recursive option of the jdeps tool, then yes you can. See http:/

Re: RFR 8073596 : Add jdk.management.cmm in boot.modules that needs sun.management.spi be exported to it

2015-02-27 Thread Mandy Chung
On 2/27/15 12:55 PM, Brent Christian wrote: Hi, Please review a small update to the module config files for a new jdk.management.cmm module. Webrev: http://cr.openjdk.java.net/~bchristi/8073596/webrev/ Bug: https://bugs.openjdk.java.net/browse/JDK-8073596 The change looks fine. Mandy

Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

2015-03-04 Thread Mandy Chung
As listed in an open issue in JEP 200: The jdk.dev and jdk.runtime modules contain miscellaneous tools that do not obviously belong to any other module; these modules will eventually be either renamed or refactored. Currently there are jdk.javadoc, jdk.jconsole, jdk.jcmd modules in the JDK that

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

2015-03-04 Thread Mandy Chung
into jdk.security.tools and jdk.security.util. Put the executables into tools and APIs into util. --Max On Mar 5, 2015, at 09:13, Mandy Chung wrote: As listed in an open issue in JEP 200: The jdk.dev and jdk.runtime modules contain miscellaneous tools that do not obviously belong to any other m

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

2015-03-05 Thread Mandy Chung
On 3/5/2015 12:31 AM, Alan Bateman wrote: On 05/03/2015 01:13, Mandy Chung wrote: : Separate webrevs for each issue: 1. pack200, unpack200 to jdk.pack200 http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074428%2b8074429%2b8074430/8074428/webrev.00/ I think this looks okay. In the

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

2015-03-05 Thread Mandy Chung
Max, Since the new APIs you're working on are still in design phase, I think it's a bit early to discuss where these new APIs should be in. Just one thing to say about the new JarSigner API from your webrev. com.sun.jarsigner is an existing exported package that you should consider whether

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

2015-03-13 Thread Mandy Chung
be called jdk.unpack200 and not jdk.pack200 ? since it contains only the unpacker, and the bin utilities are pack200 and unpack200. Kumar On 3/4/2015 5:13 PM, Mandy Chung wrote: As listed in an open issue in JEP 200: The jdk.dev and jdk.runtime modules contain miscellaneous tools that do not obviously bel

Re: RFR 8047789: auth.login.LoginContext needs to be updated to work with modules

2015-03-20 Thread Mandy Chung
On 3/20/15 7:39 AM, Wang Weijun wrote: Please review the code changes at http://cr.openjdk.java.net/~weijun/8047789/webrev.03/ It looks okay to me. Removing some use of reflection seems a good thing. One observation: invoke(String methodName) now calls the method statically and the imple

Re: Policy providers in Java 9

2015-03-21 Thread Mandy Chung
On 3/21/2015 5:12 AM, Peter Firmstone wrote: Just wondering, with the removal of the extensions directory, what's the correct way of specifying a policy provider? We currently have a number of nested policy providers that are loaded by the extension classloader. Do you set the custom polic

Re: RFR 8042901: Allow com.sun.management to be in a different module to java.lang.management

2015-04-01 Thread Mandy Chung
On 3/31/2015 9:39 AM, shanliang wrote: Please review this fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8042901 Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8042901/00/ Thank you for doing this big change to separate com.sun.management API from java.management module. Looking really g

Re: JDK 9 build with application class loader changes available?

2015-04-27 Thread Mandy Chung
On 04/26/2015 11:47 PM, Alan Bateman wrote: On 27/04/2015 01:52, Luke Daley wrote: This is a follow on from: http://mail.openjdk.java.net/pipermail/jigsaw-dev/2015-April/004291.html @Mandy: is there a build of 9 available that has the application class loader changes that we can use to test w

Re: OS X 1.9 ea jdeps

2015-04-29 Thread Mandy Chung
On 4/13/15 1:32 AM, Michael Hall wrote: On Apr 13, 2015, at 2:32 AM, Alan Bateman wrote: On 12/04/2015 17:57, Michael Hall wrote: : Not exactly sure what you mean. But, which java /usr/bin/java ... I think the issue is that the installation creates sym links in /usr/bin for most, but no

Re: jdeps command

2015-04-30 Thread Mandy Chung
On 04/30/2015 03:02 PM, Michael Hall wrote: Please file a bug at asking for this command to be added to /usr/bin, and send me the bug ID. We can ensure that these stubs are in the base OS without any Apple Java being installed. Thanks, Mike Swingler Apple Inc.

Re: jdeps command

2015-04-30 Thread Mandy Chung
On 04/30/2015 04:17 PM, Michael Hall wrote: On Apr 30, 2015, at 5:39 PM, Mandy Chung <mailto:mandy.ch...@oracle.com>> wrote: and existing tool may be removed (e.g. jhat [1]). Not through Java 9 ea? jhat -version jhat version 2.0 (java version 1.9.0-ea) So I would think it m

Re: internal API usage: sun.awt.CausedFocusEvent

2015-05-13 Thread Mandy Chung
> On May 13, 2015, at 10:51 AM, Alan Snyder wrote: > > I will do that, but a larger question remains: > > Are any of the AWT classes currently reported by jdeps as “JDK internal API” > going to be accessible in JDK 9? > No - there is no known RFE that I know of may provide a replacement for

Re: Review Request 8074432: Move jdeps to jdk.compiler module

2015-05-25 Thread Mandy Chung
Meant to include jigsaw-dev in the initial post. > On May 25, 2015, at 12:16 AM, Alan Bateman wrote: > > On 24/05/2015 05:00, Mandy Chung wrote: >> This will move jdeps to the same module as other langtools javac and javap. >> >> Webrev at: >> http://cr.open

Re: Review Request 8074432: Move jdeps to jdk.compiler module

2015-05-26 Thread Mandy Chung
We discussed this offline and revised the proposal to group javap and classfile library together with jdeps in jdk.jdeps module for static analysis tools to live. The jdk.compiler module will contain the compiler and a couple of small tools. Moving out javap and classfile library save about 1.

Re: Review Request 8074432: Move jdeps to jdk.compiler module

2015-05-27 Thread Mandy Chung
+-DNEVER_ACT_AS_SERVER_CLASS_MACHINE \ +-DJAVA_ARGS='{ "-J-ms8m"$(COMMA) "com.sun.tools.jdeps.Main"$(COMMA) }')) > On May 27, 2015, at 12:48 AM, Erik Joelsson wrote: > > Hello Mandy, > > I don't see a Launcher-jdk.jdeps.gmk. Should there be one? > >

Re: RFR: JDK-8080511 - Refresh of jimage support

2015-06-18 Thread Mandy Chung
http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-top modules.xml looks fine. test/lib/sun/hotspot/WhiteBox.java This adds the native entry points. Where are they implemented? It’s not obvious to me. http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-langtools

Re: RFR: JDK-8080511 - Refresh of jimage support

2015-06-19 Thread Mandy Chung
> On Jun 19, 2015, at 6:27 AM, Alan Bateman wrote: > > > > On 18/06/2015 19:48, Mandy Chung wrote: >> : >> >> test/java/nio/Buffer/LimitDirectMemory.sh >> test/java/nio/file/spi/SetDefaultProvider.java >>Why this test is ignored? >> &g

Re: Jigsaw Hackday in London - Anything in particular you want us to look at?

2015-06-29 Thread Mandy Chung
FYI. The RFE concerning sun.misc.SignalHandler is: https://bugs.openjdk.java.net/browse/JDK-8087286 Mandy > On Jun 29, 2015, at 5:43 AM, Richard Warburton > wrote: > > Hi, > > This is a good point actually. I have also used that class before as it > seems to be the only way to hook those

Re: Review for JDK-8132527

2015-08-18 Thread Mandy Chung
On 08/18/2015 01:34 AM, Jean-Francois Denise wrote: Hi, asking for review to fix jvm crashing when replacing jimage file with recreated one. The name of the module metadata resource was wrongly associated to the name of the recreated jimage file. The original name must be reused in the recreat

Re: jdeps and annotations parameters

2015-08-27 Thread Mandy Chung
It looks like a bug. I have filed an issue to look into further: https://bugs.openjdk.java.net/browse/JDK-8134625 Mandy On 08/27/2015 01:15 PM, Jeff Hain wrote: Hello. (adding surnumerary new lines because sometimes some disapear for some reason). It seems that jdeps ignores dependencies of

Re: jdeps and annotations parameters

2015-09-01 Thread Mandy Chung
d be possible.) 2) It does not consider public and protected nested classes as dependencies (even though they are in the API of the class). 3) Should annotations of APIs be considered APIs? (at least for some trivial cases they are) -Jeff ---

Re: jdeps and annotations parameters

2015-09-03 Thread Mandy Chung
Hi Jeff, Thanks for the feedback that is helpful. jdeps is static analysis tool reporting class dependencies to help existing code for modularization. So jdeps should report the list of class names matching the list that are needed during compilation as closely as possible. It looks at Sig

Re: Project Jigsaw: Early-Access Builds available on jdk9.java.net/jigsaw

2015-09-10 Thread Mandy Chung
On 09/10/2015 01:55 PM, Jim Connors wrote: When you run the com.greetings.Main class via: $ java -mp mods -m com.greetings/com.greetings.Main The Quick Start guide shows the output as: class org.fastsocket.FastNetworkSocket The Main.java file referenced above prints nothing (at lea

Re: CFV: New Jigsaw Committer: Harold Seigel

2015-09-11 Thread Mandy Chung
Vote: yes Mandy

hg: jigsaw/jake/jaxp: 2 new changesets

2015-09-11 Thread mandy . chung
Changeset: 53fe3c103b6f Author:lana Date: 2015-09-11 10:26 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/53fe3c103b6f Added tag jdk9-b81 for changeset 6a418934997f ! .hgtags Changeset: faade39222ae Author:mchung Date: 2015-09-11 17:09 -0700 URL: http://

hg: jigsaw/jake: 5 new changesets

2015-09-11 Thread mandy . chung
Changeset: c356ee0434a0 Author:ihse Date: 2015-09-03 11:05 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/c356ee0434a0 8062618: Create a build failure summary at end of build log Reviewed-by: erikj ! make/Init.gmk ! make/InitSupport.gmk ! make/common/JavaCompilation.gmk ! ma

hg: jigsaw/jake/corba: 2 new changesets

2015-09-11 Thread mandy . chung
Changeset: c20d8ebddaa6 Author:lana Date: 2015-09-11 10:26 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/c20d8ebddaa6 Added tag jdk9-b81 for changeset 45c35b7f5b40 ! .hgtags Changeset: 5ac2a88513aa Author:mchung Date: 2015-09-11 17:09 -0700 URL: http:/

hg: jigsaw/jake/jaxws: 2 new changesets

2015-09-11 Thread mandy . chung
Changeset: 52d9ad2536ba Author:lana Date: 2015-09-11 10:26 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/52d9ad2536ba Added tag jdk9-b81 for changeset 139338618c77 ! .hgtags Changeset: 0f7ed2f66596 Author:mchung Date: 2015-09-11 17:09 -0700 URL: http:/

hg: jigsaw/jake/hotspot: 60 new changesets

2015-09-11 Thread mandy . chung
Changeset: 3c76d8048a58 Author:david Date: 2015-08-12 16:32 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/3c76d8048a58 8133193: Memory leak in G1 because G1RootProcessor doesn't have desctructor Reviewed-by: mgerdin, tschatzl ! src/share/vm/gc/g1/g1RootProcessor.cpp

hg: jigsaw/jake/jdk: 24 new changesets

2015-09-11 Thread mandy . chung
Changeset: 2b3b9aa80615 Author:erikj Date: 2015-08-28 10:13 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/2b3b9aa80615 8134408: Disable warnings for jdk libraries triggered by SS12u4 Reviewed-by: tbell, ihse ! make/lib/Awt2dLibraries.gmk ! make/lib/CoreLibraries.gmk ! m

hg: jigsaw/jake/langtools: 5 new changesets

2015-09-11 Thread mandy . chung
Changeset: 891db670a8cb Author:mcimadamore Date: 2015-08-31 15:50 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/891db670a8cb 8134007: Improve string folding Summary: Generalize string folding algorithm to detect mulitple groups of foldable constants within an conc

hg: jigsaw/jake/nashorn: 15 new changesets

2015-09-11 Thread mandy . chung
Changeset: cffb8ad5ad94 Author:sundar Date: 2015-08-31 17:51 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/cffb8ad5ad94 8134731: Function.prototype.apply interacts incorrectly with arguments Reviewed-by: attila, hannesw ! src/jdk.scripting.nashorn/share/classes/jdk

hg: jigsaw/jake/langtools: Adds tests to ProblemList.jake.txt for further investigation

2015-09-11 Thread mandy . chung
Changeset: 2e667d1f8d67 Author:mchung Date: 2015-09-11 22:58 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2e667d1f8d67 Adds tests to ProblemList.jake.txt for further investigation ! test/ProblemList.jake.txt

hg: jigsaw/jake/langtools: 2 new changesets

2015-09-12 Thread mandy . chung
Changeset: 144597c5a68b Author:jlahoda Date: 2015-09-12 10:20 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/144597c5a68b Fixing langtools tests broken by recent merge. ! test/ProblemList.jake.txt ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/ja

Re: CFV: New jigsaw Committer: Jean-Francois Denise

2015-09-14 Thread Mandy Chung
Vote: yes

Re: JavaxToolsCompiler

2015-09-14 Thread Mandy Chung
On 09/14/2015 12:44 PM, Alan Bateman wrote: On 14/09/2015 20:21, Stuart McCulloch wrote: Yes, the issue is that ToolProvider.getSystemJavaCompiler() is returning null when using the Jigsaw EA with Maven. AFAICT this is because it’s now using the service loader mechanism which is influenced

hg: jigsaw/jake/hotspot: 8134288: compiler/runtime/6859338/Test6859338.java crashes in PhaseIdealLoop::try_move_store_after_loop

2015-09-16 Thread mandy . chung
Changeset: f40ee07d9099 Author:roland Date: 2015-08-26 12:43 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/f40ee07d9099 8134288: compiler/runtime/6859338/Test6859338.java crashes in PhaseIdealLoop::try_move_store_after_loop Summary: Store nodes may not have a contro

hg: jigsaw/jake/jdk: Fix typos in Proxy.getProxyClass javadoc

2015-09-16 Thread mandy . chung
Changeset: acfccb988108 Author:mchung Date: 2015-09-16 09:51 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/acfccb988108 Fix typos in Proxy.getProxyClass javadoc ! src/java.base/share/classes/java/lang/reflect/Proxy.java

Re: CFV: New Jigsaw Committer: Lois Foltan

2015-09-16 Thread Mandy Chung
Vote: yes

Re: CFV: New Committer: Christian Tornqvist

2015-09-16 Thread Mandy Chung
Vote: yes

hg: jigsaw/jake/jdk: 8135172: complication error "package exists in another module: jdk.xml.dom"

2015-09-16 Thread mandy . chung
Changeset: 090e9350479b Author:mchung Date: 2015-09-16 14:34 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/090e9350479b 8135172: complication error "package exists in another module: jdk.xml.dom" Reviewed-by: mchung Contributed-by: Hamlin Li ! test/ProblemList.jake.txt

hg: jigsaw/jake/hotspot: additional dump time checks

2015-09-16 Thread mandy . chung
Changeset: cafd001e4c37 Author:ccheung Date: 2015-09-16 17:58 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/cafd001e4c37 additional dump time checks Summary: we currently don't support -modulepath, etc. module related options during archive dumping Reviewed-by: ikla

hg: jigsaw/jake/hotspot: fixing XoverrideCCDS.java test failure

2015-09-17 Thread mandy . chung
Changeset: e6b7e9cc28c0 Author:ccheung Date: 2015-09-17 14:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e6b7e9cc28c0 fixing XoverrideCCDS.java test failure Summary: adjusted the expected error message during dump time Reviewed-by: iklam, jiangli ! test/runtime/m

hg: jigsaw/jake/jdk: Exception typo in Proxy class javadoc

2015-09-17 Thread mandy . chung
Changeset: 3f905b5efebf Author:mchung Date: 2015-09-17 15:14 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3f905b5efebf Exception typo in Proxy class javadoc ! src/java.base/share/classes/java/lang/reflect/Proxy.java

hg: jigsaw/jake/jdk: 8136790: @argfile does not work after -addmods or -modulepath

2015-09-18 Thread mandy . chung
Changeset: cc51fbfc6390 Author:mchung Date: 2015-09-18 17:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cc51fbfc6390 8136790: @argfile does not work after -addmods or -modulepath Reviewed-by: henryjen ! src/java.base/share/native/libjli/args.c

hg: jigsaw/jake/jdk: 8136802: Creation of a logger with a resource bundle contained in the same named module fails

2015-09-21 Thread mandy . chung
Changeset: 3862c75182ad Author:mchung Date: 2015-09-21 13:27 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3862c75182ad 8136802: Creation of a logger with a resource bundle contained in the same named module fails Contributed-by: daniel.fu...@oracle.com ! src/java.logg

<    2   3   4   5   6   7   8   9   10   11   >