Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

2016-07-02 Thread Mandy Chung
> On Jul 1, 2016, at 6:20 PM, Alexandre (Shura) Iline > wrote: > > Please review the new version of the fix. > http://cr.openjdk.java.net/~shurailine/8158670/webrev.01/ This looks much better. Small comment: you can use Layer::findModule and also

hg: jigsaw/jake/jdk: Add @spec tag on additional APIs for JPMS spec

2017-02-03 Thread mandy . chung
Changeset: 5135bbdae96f Author:mchung Date: 2017-02-03 13:50 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/5135bbdae96f Add @spec tag on additional APIs for JPMS spec ! src/java.base/share/classes/java/lang/StackTraceElement.java !

Re: RFR 8173717: jlink --help fails with missing "plugin.opt.plugin-module-path" key in resource bundle

2017-01-31 Thread Mandy Chung
> On Jan 31, 2017, at 9:06 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8173717/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8173717 +1 Thanks for fixing this quickly. Mandy

hg: jigsaw/jake/jdk: 2 new changesets

2017-02-04 Thread mandy . chung
Changeset: cd7842eb7d8d Author:mchung Date: 2017-02-04 17:24 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cd7842eb7d8d Minor cleanup ! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java Changeset: c741bb5b6652 Author:mchung Date: 2017-02-04

hg: jigsaw/jake/nashorn: Module created dynamically should have synthetic modifier

2017-02-07 Thread mandy . chung
Changeset: 22eecb4b45d7 Author:mchung Date: 2017-02-07 12:51 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/22eecb4b45d7 Module created dynamically should have synthetic modifier !

hg: jigsaw/jake/jdk: Module created dynamically should have synthetic modifier

2017-02-07 Thread mandy . chung
Changeset: 5c4843cc0b4b Author:mchung Date: 2017-02-07 12:50 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/5c4843cc0b4b Module created dynamically should have synthetic modifier ! src/java.base/share/classes/java/lang/reflect/Proxy.java !

Re: [9] Review request: JDK-8170200: Packager Redistributable Module List Unit Test

2017-02-07 Thread Mandy Chung
Should this test be in the FX repo where jdk.packager resides? I would think so. This test should only run with the build with FX modules. Mandy > On Feb 7, 2017, at 10:32 AM, Victor Drozdov wrote: > > Kevin, Mandy, > > Please review my new unit test for

hg: jigsaw/jake/jdk: Add AccessibleObject::canAccess and trySetAccessible

2017-02-04 Thread mandy . chung
Changeset: 335657c73d0b Author:mchung Date: 2017-02-04 15:41 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/335657c73d0b Add AccessibleObject::canAccess and trySetAccessible ! src/java.base/share/classes/java/lang/SecurityManager.java !

Re: hg: jigsaw/jake/jdk: Add AccessibleObject::canAccess and trySetAccessible

2017-02-07 Thread Mandy Chung
This is included in the module system refresh discussion [1] to avoid the merge conflict if it were separated from it. Your feedback is welcome and appreciated. Mandy [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2017-February/011231.html > On Feb 7, 2017, at 6:05 AM, David M. Lloyd

Re: Review Request: JDK-8173096 jmod files are not world-readable

2017-01-21 Thread Mandy Chung
> On Jan 21, 2017, at 5:08 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 21/01/2017 02:32, Mandy Chung wrote: > >> Updated webrev to put the temporary file in the same containing directory of >> the target file: >> http://cr.openjdk.java.net/~m

Re: Review Request: JDK-8173096 jmod files are not world-readable

2017-01-24 Thread Mandy Chung
> On Jan 22, 2017, at 3:17 AM, Peter Levart <peter.lev...@gmail.com> wrote: > > Hi Mandy, > > On 01/21/2017 03:32 AM, Mandy Chung wrote: >> Updated webrev to put the temporary file in the same containing directory of >> the target file: >> http://c

Re: RFR: 8145337: [JVMCI] JVMCI initialization with SecurityManager installed fails: java.security.AccessControlException: access denied

2017-01-30 Thread Mandy Chung
> On Jan 30, 2017, at 1:36 PM, Doug Simon <doug.si...@oracle.com> wrote: > > >> On 30 Jan 2017, at 21:55, Mandy Chung <mandy.ch...@oracle.com> wrote: >> >> >>> On Jan 30, 2017, at 10:38 AM, Doug Simon <doug.si...@oracle.com> wrote: >&

Re: Review Request: 8173381: osName/osArch/osVersion is missing in ModuleDescriptor created by SystemModules

2017-01-28 Thread Mandy Chung
Updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173381/webrev.02 > On Jan 28, 2017, at 10:01 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 27/01/2017 06:21, Mandy Chung wrote: > >> : >> Updated webrev: >> http://cr.openjdk.j

Re: Review Request: 8173381: osName/osArch/osVersion is missing in ModuleDescriptor created by SystemModules

2017-01-29 Thread Mandy Chung
> On Jan 29, 2017, at 1:56 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 28/01/2017 20:50, Mandy Chung wrote: > >> : >> I agree that would be cleaner and made the change. That’s what I started >> with but that’d leave ModuleTarget attribute in th

Re: jlink / legal folder and LICENSE

2017-01-25 Thread Mandy Chung
> On Jan 25, 2017, at 3:08 AM, Alan Bateman wrote: > > On 25/01/2017 10:53, fo...@univ-mlv.fr wrote: > >> : >> I mean legal/java.base/LICENSE in jdk9. > > The EA builds that Oracle publishes on jdk9.java.net have a LICENSE file that > links to the BCL on oracle.com.

Review Request: 8173381: osName/osArch/osVersion is missing in ModuleDescriptor created by SystemModules

2017-01-25 Thread Mandy Chung
The ModuleTarget attribute is added to java.base and other JDK modules when JMOD file is created but it gets dropped when the system modules plugin reconstitutes the ModuleDescriptor for fast loading. The fix is straight-forward to add osName/osArch/osVersion if present. Webrev at:

Re: RFR 8172527: Rename jdk.crypto.token to jdk.crypto.cryptoki

2017-01-20 Thread Mandy Chung
> On Jan 20, 2017, at 10:22 AM, Anthony Scarpino > wrote: > > Good catch.. that'll teach me for trusting the graphical tool to rename a > directory when I used 'Rename'. > > Also I found Brad's issue as it was a new changeset that just showed up in > that file.

Re: Review Request: JDK-8173096 jmod files are not world-readable

2017-01-20 Thread Mandy Chung
t 8:55 AM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.00/index.html > > A recent change in jmod tool [1] creates the JMOD file with no group > and other readable permission as that’s the default

hg: jigsaw/jake/jdk: Minor clean up on StackWalker::getCallerClass spec

2017-01-20 Thread mandy . chung
Changeset: cbf1e85f7c11 Author:mchung Date: 2017-01-20 19:58 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cbf1e85f7c11 Minor clean up on StackWalker::getCallerClass spec ! src/java.base/share/classes/java/lang/StackWalker.java

Re: Review Request: JDK-8173096 jmod files are not world-readable

2017-01-20 Thread Mandy Chung
> On Jan 20, 2017, at 12:37 PM, Peter Levart wrote: > > I guess the JmodTask is creating a temp file because it wants the file to not > be observed by other processes while it is being written to, right? At the > end when the tempTarget is fully written, it is renamed

Re: Review Request: JDK-8173096 jmod files are not world-readable

2017-01-20 Thread Mandy Chung
> On Jan 20, 2017, at 1:22 PM, Alan Bateman wrote: > > Mandy - a while back then Erik changed the build so that JMOD files are > created in JMODS_TEMPDIR rather than JMODS_DIR. I think this was to reduce > interference with concurrent execution of the `jmod` tool.

Re: Review Request: 8173381: osName/osArch/osVersion is missing in ModuleDescriptor created by SystemModules

2017-01-26 Thread Mandy Chung
> On Jan 26, 2017, at 12:33 AM, Alan Bateman wrote: > > The set of modules has to include java.base so if it has all three properties > then there is no need to call the builder methods for the other modules. That > will save a few bytecodes at startup. It's not

Review Request: JDK-8175193: jlink and `requires static`

2017-02-23 Thread Mandy Chung
This patch fixes jlink to link modules that has `requires static M`. jlink does not modify module-info.class. Hence, at runtime if module M is on the module path and added in the resolved graph. `requires static` dependency will be satisfied. Webrev:

Re: Review Request: JDK-8175193: jlink and `requires static`

2017-02-23 Thread Mandy Chung
> On Feb 23, 2017, at 4:32 PM, Remi Forax <fo...@univ-mlv.fr> wrote: > > Hi Mandy, > I prefer that semantics. > > In the code, you can remove the ".stream()”. Good catch. I will remove it before I push. Mandy > regards, > Rémi > > - Mail orig

Re: RFR: 8175561: Memory churn in jimage code affects startup after resource encapsulation changes

2017-02-24 Thread Mandy Chung
> On Feb 23, 2017, at 2:57 PM, Claes Redestad wrote: > > Hi, > > various resource encapsulation changes in 9+148 meant an uptick in > footprint and startup times for certain applications. > > While some of this regression is hard to avoid[1] (opening readers, >

Review Request: JDK-8174739: Rename JMOD section name for native libraries from native to lib

2017-02-10 Thread Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8174739/webrev.00/ This renames the JMOD section name from `native` to `lib` that would map closely to the directory in the run-time image (with the exception on windows DLLs that go to image/bin directory). jlink defines a scheme to name a

Re: RFR 8174718: "Module 's descriptor returns inconsistent package set" confusing

2017-02-14 Thread Mandy Chung
> On Feb 14, 2017, at 5:52 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8174718/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8174718 JLinkNegativeTest.java - line 352 is not really needed.

Review Request: JDK-8173374: Update GenGraphs tool to generate dot graph with requires transitive edges

2017-02-14 Thread Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173374/webrev.00/ This is the first step to enable generating dot graph to be included in module summary javadoc, if desired. jdeps already supports generating the dot graph for modules. This patch converts GenGraphs build tool to use jdeps

Re: RFR 8174209: Renumber the compress levels

2017-02-13 Thread Mandy Chung
> On Feb 13, 2017, at 9:03 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8174209/webrev/ for > https://bugs.openjdk.java.net/browse/JDK-8174209 Looks okay. Mandy

Re: Running jaotc with an external Graal

2017-02-16 Thread Mandy Chung
r, the --patch-module + --upgrade-module-path trick[1] we’re using to > replace the version of Graal in the JDK apparently only works due to a bug > that will be fixed at some point. From Mandy Chung: > > "-—patch-module is to patch a module to replace or add content of that

Re: RFR: 8175026: Capture build-time parameters to --generate-jli-classes

2017-02-16 Thread Mandy Chung
> On Feb 16, 2017, at 5:20 AM, Claes Redestad wrote: > >> >> In addition, if the main argument is specified but the version does not >> match, it will ignore the given argument. Should it be an error instead? >> We are the one who will generate a trace file and

Re: RFR: 8175026: Capture build-time parameters to --generate-jli-classes

2017-02-16 Thread Mandy Chung
One more thing: the warning message should be in plugin.properties to be localized. Mandy > On Feb 16, 2017, at 12:04 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > >> On Feb 16, 2017, at 5:20 AM, Claes Redestad <claes.redes...@oracle.com> >> wrote: >

Re: RFR: 8175010: ImageReader is not thread-safe

2017-02-15 Thread Mandy Chung
> On Feb 15, 2017, at 5:22 AM, Claes Redestad wrote: > > Hi, > > a few intermittent but rare test failures[1] that has appeared > since the latest jake integration, and since one of the changes > in there was to make initialization of the system ImageReader > lazy

Re: Review Request: JDK-8173374: Update GenGraphs tool to generate dot graph with requires transitive edges

2017-02-15 Thread Mandy Chung
> On Feb 15, 2017, at 12:27 PM, Daniel Fuchs wrote: > > Hi Mandy, > > > Updated webrev: > > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173374/webrev.01/ > > Looks good. I haven't reviewed the build changes. > I assume they're OK if you managed to build ;-)

Re: Review Request: JDK-8173374: Update GenGraphs tool to generate dot graph with requires transitive edges

2017-02-15 Thread Mandy Chung
> On Feb 15, 2017, at 1:08 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: >> >>> Updated webrev: >>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173374/webrev.01/ You may be interested in the module graphs generated from this change. http://cr.open

Re: Running jaotc with an external Graal

2017-02-15 Thread Mandy Chung
> On Feb 15, 2017, at 1:56 PM, Christian Thalinger > wrote: > > >> On Feb 14, 2017, at 4:38 AM, Andrew Haley wrote: >> >> On 14/02/17 14:37, Alan Bateman wrote: >>> --patch-module can be used to patch any module in the boot layer. So if >>> you are

Re: RFR: 8175026: Capture build-time parameters to --generate-jli-classes

2017-02-15 Thread Mandy Chung
> On Feb 15, 2017, at 9:12 AM, Claes Redestad wrote: > > Hi, > > currently the file we generate at build time as input to > --generate-jli-classes is lost when linking custom images, which means > user generate images may perform worse in certain ways, mostly >

Re: Review Request: JDK-8173374: Update GenGraphs tool to generate dot graph with requires transitive edges

2017-02-15 Thread Mandy Chung
> On Feb 15, 2017, at 10:29 AM, Daniel Fuchs wrote: > > Hi Mandy, > > Some early comments: > > GenGraphs.java > -- > > 58 dir = Paths.get(args[++i]); > > may produced ArrayOutOfBoundsException - should we have better > error reporting? >

Re: RFR 8168254: Detect duplicated resources in packaged modules

2017-01-17 Thread Mandy Chung
> On Jan 17, 2017, at 10:03 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8168254/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8168254 Looks good except the copyright end year. Mandy

Review request: JDK-8172870 test/tools/jmod/JmodTest.java fails on windows with AccessDeniedException

2017-01-17 Thread Mandy Chung
This test case attempts to verify that the temp file created by jmod is cleaned up and removed if jmod create command fails. It first cleans up any temp files matching the prefix and suffix created for this test case. The test fails because the fix for JDK-8160286 that creates the jmod temp

hg: jigsaw/jake/langtools: jdeps update per ModuleDescriptor/Builder cleanup

2017-01-17 Thread mandy . chung
Changeset: 2eac819e2faa Author:mchung Date: 2017-01-17 14:42 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2eac819e2faa jdeps update per ModuleDescriptor/Builder cleanup ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/Module.java !

Re: Compact profile modules

2017-01-16 Thread Mandy Chung
java.compact$N modules were removed in jdk-9+150 [1][2]. We revisited the need for java.compact$N aggregator. Compact Profiles were useful in SE 8 but are legacy in 9, as intended from the outset. Highlighting them in the standard SE 9 module graph gives them unnecessary importance going

Re: RFR [9] 8172982: tools/jlink/ResourceDuplicateCheckTest.java requires jdk.tools.jlink.plugin to be exported

2017-01-18 Thread Mandy Chung
+1 Mandy > On Jan 18, 2017, at 9:05 AM, Chris Hegarty wrote: > > Since the jlink plugin package is no longer exported this test should > add the appropriate @modules tag. > > diff -r 5b75946223fb test/tools/jlink/ResourceDuplicateCheckTest.java > ---

Re: Review request: JDK-8172870 test/tools/jmod/JmodTest.java fails on windows with AccessDeniedException

2017-01-18 Thread Mandy Chung
> On Jan 18, 2017, at 1:25 AM, Chris Hegarty <chris.hega...@oracle.com> wrote: > > >> On 18 Jan 2017, at 07:38, Alan Bateman <alan.bate...@oracle.com> wrote: >> >> On 17/01/2017 21:23, Mandy Chung wrote: >> >>> This test case

hg: jigsaw/jake/jdk: Minor update on Proxy spec to clarify open packages

2017-01-18 Thread mandy . chung
Changeset: c1569ce11b78 Author:mchung Date: 2017-01-18 13:20 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c1569ce11b78 Minor update on Proxy spec to clarify open packages ! src/java.base/share/classes/java/lang/reflect/Proxy.java

hg: jigsaw/jake/jdk: 2 new changesets

2017-01-19 Thread mandy . chung
Changeset: 25d0881b2c0c Author:mchung Date: 2017-01-19 10:10 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/25d0881b2c0c Fix typo ! src/java.base/share/classes/java/lang/reflect/Proxy.java Changeset: e5e09b0e750b Author:mchung Date: 2017-01-19 10:12 -0800 URL:

Re: RFR 8172527: Rename jdk.crypto.token to jdk.crypto.cryptoki

2017-01-19 Thread Mandy Chung
> On Jan 19, 2017, at 11:39 AM, Anthony Scarpino > wrote: > > Hi, > > I need a review to rename the jdk.crypto.token to jdk.crypto.cryptoki. This > is to change what 8171202 had done to the original jdk.crypto.pkcs11 module. > For those not familiar with

Re: RFR 8172659: PluginException("TargetPlatform attribute is missing ...") - should be ModuleTarget

2017-01-20 Thread Mandy Chung
+1 Mandy > On Jan 20, 2017, at 1:06 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8172659/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8172659 > > Thanks, > -Sundar

Review Request: JDK-8173096 jmod files are not world-readable

2017-01-20 Thread Mandy Chung
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.00/index.html A recent change in jmod tool [1] creates the JMOD file with no group and other readable permission as that’s the default permission when creating a temporary file with Files::createTempFile. This fixes the

hg: jigsaw/jake/langtools: Merge

2016-08-19 Thread mandy . chung
Changeset: 19130450ad62 Author:mchung Date: 2016-08-19 16:30 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/19130450ad62 Merge ! src/jdk.jdeps/share/classes/com/sun/tools/javap/JavapTask.java

hg: jigsaw/jake/jdk: 35 new changesets

2016-08-19 Thread mandy . chung
Changeset: ef0ba6e50464 Author:bpb Date: 2016-08-09 07:43 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ef0ba6e50464 8163431: probeContentType/Basic.java fails after changes for JDK-8146215 Summary: Allow multiple legal MIME type interpretations for certain extensions.

hg: jigsaw/jake/jaxws: 5 new changesets

2016-08-19 Thread mandy . chung
Changeset: b41e7cd5f414 Author:mchung Date: 2016-08-10 15:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/b41e7cd5f414 8136930: Simplify use of module-system options by custom launchers Reviewed-by: alanb, ksrini, henryjen, sundar !

Re: RFR: 8163126 Wrong @modules in some of jdk/* tests

2016-08-19 Thread Mandy Chung
> On Aug 16, 2016, at 10:17 AM, Alexandre (Shura) Iline > wrote: > > Hi. > > Please review fixes related to module dependencies in a few jdk tests: > http://cr.openjdk.java.net/~shurailine/8163126/webrev.00/index.html Looks okay. I will sponsor this patch for

hg: jigsaw/jake: 5 new changesets

2016-08-19 Thread mandy . chung
Changeset: 8b1d348ad6a2 Author:mchung Date: 2016-08-10 15:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/8b1d348ad6a2 8136930: Simplify use of module-system options by custom launchers Reviewed-by: alanb, ksrini, henryjen, sundar ! common/autoconf/boot-jdk.m4 !

hg: jigsaw/jake/corba: 2 new changesets

2016-08-19 Thread mandy . chung
Changeset: 8b243cd19bff Author:lana Date: 2016-08-18 21:01 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/8b243cd19bff Added tag jdk-9+132 for changeset 1ab4b9399c4c ! .hgtags Changeset: d4a7b03f7cd4 Author:mchung Date: 2016-08-19 16:30 -0700 URL:

hg: jigsaw/jake/hotspot: 6 new changesets

2016-08-19 Thread mandy . chung
Changeset: 3cfddcb268e3 Author:hseigel Date: 2016-08-10 15:48 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/3cfddcb268e3 8136930: Simplify use of module-system options by custom launchers Reviewed-by: coleenp, lfoltan, mchung !

hg: jigsaw/jake/jaxp: 8 new changesets

2016-08-19 Thread mandy . chung
Changeset: 55f2b1691a7b Author:lana Date: 2016-08-04 13:58 +0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/55f2b1691a7b 8163145: Remove two null line in the end of message.properties Reviewed-by: joehw, rriggs Contributed-by: li.ji...@oracle.com !

hg: jigsaw/jake/nashorn: 6 new changesets

2016-08-19 Thread mandy . chung
Changeset: 3487086f145a Author:sdama Date: 2016-08-10 09:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/3487086f145a 8134304: NPE in initialization of OptimisticTypesPersistence Reviewed-by: hannesw, jlaskey, mhaupt !

hg: jigsaw/jake/jdk: Fixup merge issue

2016-08-19 Thread mandy . chung
Changeset: a0f2a493ec38 Author:mchung Date: 2016-08-19 21:58 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a0f2a493ec38 Fixup merge issue ! test/com/sun/corba/transport/KeepAliveSockets.java ! test/javax/xml/bind/xjc/8145039/JaxbMarshallTest.java !

hg: jigsaw/jake/jdk: Minor test merge cleanup

2016-08-20 Thread mandy . chung
Changeset: 801659c39b01 Author:mchung Date: 2016-08-20 12:06 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/801659c39b01 Minor test merge cleanup ! test/ProblemList.txt ! test/sun/security/krb5/auto/TEST.properties ! test/sun/security/util/Resources/NewNamesFormat.java

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

2016-08-20 Thread Mandy Chung
> On Aug 12, 2016, at 5:33 PM, Steve Drach wrote: > > I didn’t have it right ;-) It turns out a JarFile stream of versioned > entries was more interesting than I initially thought. Here’s another > webrev. It’s not clear to me if I should include the change to

Re: RFR: 8175561: Memory churn in jimage code affects startup after resource encapsulation changes

2017-03-01 Thread Mandy Chung
> On Feb 27, 2017, at 6:55 PM, Claes Redestad wrote: > > Hi, > > thanks Mandy and Jim for reviewing! > > However, I've found enough evidence now that we should this > one step further and eliminating the allocation in > BasicImageReader::findLocation(String,

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

2016-08-22 Thread Mandy Chung
> On Aug 22, 2016, at 2:56 PM, Steve Drach wrote: > > Is a jar tool that takes a -d option lurking somewhere? The latest one I > have does not have that option. It’s in jdk-9+132 and has been in jdk9/dev for 1.5 weeks (see JDK-8136930). It was -p previously. $ jar

Re: Can jdeps resolve unnecessary dependencies?

2016-09-06 Thread Mandy Chung
> On Sep 6, 2016, at 6:07 PM, Waldek Kozaczuk wrote: > > So jdeps can recursively identify all dependencies given a list of the > jars that my application is made of. Assume my main application jar is > app.jar and it depends (per gradle or maven dependencies resolution)

hg: jigsaw/jake/langtools: 22 new changesets

2016-09-01 Thread mandy . chung
Changeset: 4b17f176d19c Author:jjg Date: 2016-08-22 16:32 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4b17f176d19c 8164130: Simplify doclet IOException handling Reviewed-by: bpatel, ksrini !

hg: jigsaw/jake/jdk: 46 new changesets

2016-09-01 Thread mandy . chung
Changeset: 8e5362b5a18d Author:igerasim Date: 2016-08-22 22:16 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/8e5362b5a18d 8164366: ZoneOffset.ofHoursMinutesSeconds() does not reject invalid input Reviewed-by: scolebourne, ntv, coffeys !

hg: jigsaw/jake/hotspot: 4 new changesets

2016-09-01 Thread mandy . chung
Changeset: 091445016861 Author:jwilhelm Date: 2016-08-19 17:19 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/091445016861 8164124: [BACKOUT] G1 does not implement millis_since_last_gc which is needed by RMI GC Reviewed-by: jprovino !

hg: jigsaw/jake/jaxp: 5 new changesets

2016-09-01 Thread mandy . chung
Changeset: 4414c22d531e Author:joehw Date: 2016-08-23 13:33 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/4414c22d531e 8157797: SAX Parser throws incorrect error on invalid xml Reviewed-by: lancea !

hg: jigsaw/jake: 2 new changesets

2016-09-01 Thread mandy . chung
Changeset: 7ef51cfe867e Author:lana Date: 2016-09-01 23:20 + URL: http://hg.openjdk.java.net/jigsaw/jake/rev/7ef51cfe867e Added tag jdk-9+134 for changeset 065724348690 ! .hgtags Changeset: 8fa615724c4f Author:mchung Date: 2016-09-01 21:39 -0700 URL:

hg: jigsaw/jake/corba: 2 new changesets

2016-09-01 Thread mandy . chung
Changeset: 094d0db606db Author:lana Date: 2016-09-01 23:20 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/094d0db606db Added tag jdk-9+134 for changeset 1a497f5ca0cf ! .hgtags Changeset: 11ceba666902 Author:mchung Date: 2016-09-01 21:39 -0700 URL:

hg: jigsaw/jake/jaxws: 2 new changesets

2016-09-01 Thread mandy . chung
Changeset: 22631824f551 Author:lana Date: 2016-09-01 23:20 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/22631824f551 Added tag jdk-9+134 for changeset ab1d78d395d4 ! .hgtags Changeset: 64b7e64f3dbe Author:mchung Date: 2016-09-01 21:39 -0700 URL:

Re: Can jdeps resolve unnecessary dependencies?

2016-09-07 Thread Mandy Chung
> On Sep 7, 2016, at 8:07 AM, Sander Mak wrote: > > >> On 07 Sep 2016, at 16:12, Waldek Kozaczuk wrote: >> >> Will I be able to take advantage of jlink's ability to produce subset-only >> image of the JRE even if I do not use new Java 9 modular

Re: Can jdeps resolve unnecessary dependencies?

2016-09-07 Thread Mandy Chung
quot; behavior of jdeps is intende and I would need to >> build a tool that would process its generated dependency graph starting from >> app.jar and that way find the real subset of JRE it depends on? I am still >> thinking that jdeps would not be able to show m

Re: RFR 8163320: JAVA_VERSION in release file should come from java.base module

2016-09-09 Thread Mandy Chung
Looks good. Is there an existing test to check the content of `release` file? It would be good to have a test to sanity test a few properties and its quoted value. Mandy > On Sep 9, 2016, at 6:02 AM, Sundararajan Athijegannathan > wrote: > > Please

Re: Using non-parallel custom class loaders for Layer configurations

2016-09-08 Thread Mandy Chung
> On Sep 8, 2016, at 3:29 PM, David M. Lloyd wrote: > > Would it be possible to include a method like this (pretty old patch I had > laying around): > > diff --git a/jdk/src/java.base/share/classes/java/lang/ClassLoader.java >

Re: Using non-parallel custom class loaders for Layer configurations

2016-09-09 Thread Mandy Chung
> On Sep 9, 2016, at 8:44 AM, David M. Lloyd <david.ll...@redhat.com> wrote: > > On 09/08/2016 06:48 PM, Mandy Chung wrote: >> >>> On Sep 8, 2016, at 3:29 PM, David M. Lloyd <david.ll...@redhat.com> wrote: >>> >>> Would it be possible

hg: jigsaw/jake/jaxws: 2 new changesets

2016-09-08 Thread mandy . chung
Changeset: 09ec13a99f50 Author:lana Date: 2016-09-08 21:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/09ec13a99f50 Added tag jdk-9+135 for changeset 22631824f551 ! .hgtags Changeset: 09dff41baed2 Author:mchung Date: 2016-09-08 17:40 -0700 URL:

hg: jigsaw/jake/hotspot: 52 new changesets

2016-09-08 Thread mandy . chung
Changeset: 65a32a1c9bf9 Author:mchung Date: 2016-08-30 17:48 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/65a32a1c9bf9 8160851: Remove old launcher module-related options Reviewed-by: alanb ! test/runtime/Unsafe/NestedUnsafe.java Changeset: e3a19a55f062 Author:

hg: jigsaw/jake/jdk: 73 new changesets

2016-09-08 Thread mandy . chung
Changeset: 5e0ff917eab1 Author:amlu Date: 2016-08-30 09:31 +0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/5e0ff917eab1 8163934: Remove intermittent key from java/lang/ProcessBuilder/Zombies.java Reviewed-by: darcy ! test/java/lang/ProcessBuilder/Zombies.java Changeset:

hg: jigsaw/jake/nashorn: 2 new changesets

2016-09-08 Thread mandy . chung
Changeset: 61a07a6d70e4 Author:lana Date: 2016-09-08 21:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/61a07a6d70e4 Added tag jdk-9+135 for changeset cb00d5ef023a ! .hgtags Changeset: ba56297704e6 Author:mchung Date: 2016-09-08 17:42 -0700 URL:

Re: RFR 8163320: JAVA_VERSION in release file should come from java.base module

2016-09-13 Thread Mandy Chung
openjdk.java.net/~sundar/8163320/jdk/webrev.02/ > > Top: > > http://cr.openjdk.java.net/~sundar/8163320/top/webrev.02/ > > Thanks > > -Sundar > > > On 9/9/2016 9:07 PM, Mandy Chung wrote: >> Looks good. >> >> Is there an existing test to check t

Re: RFR 8160063: Provide a means to disable a plugin via the command line

2016-09-15 Thread Mandy Chung
> On Sep 15, 2016, at 8:26 AM, Alan Bateman wrote: > > On 15/09/2016 07:31, Sundararajan Athijegannathan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8160063/webrev.01/ for >> https://bugs.openjdk.java.net/browse/JDK-8160063 >> >> * Adding --disable-

Re: RFR 8160063: Provide a means to disable a plugin via the command line

2016-09-15 Thread Mandy Chung
> On Sep 15, 2016, at 7:31 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8160063/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8160063 > > * Adding --disable- option for any plugin that is

Re: RFR 8160063: Provide a means to disable a plugin via the command line

2016-09-15 Thread Mandy Chung
- will automatically fail as > "unsupported option". > > -Sundar > > > On 9/15/2016 9:57 PM, Paul Sandoz wrote: >>> On 15 Sep 2016, at 09:06, Mandy Chung <mandy.ch...@oracle.com> wrote: >>> >>> >>>> On Sep 15, 2016, at 8:26

hg: jigsaw/jake/jdk: Add test for checking StackTraceElement format

2016-09-15 Thread mandy . chung
Changeset: e0864f0eb268 Author:mchung Date: 2016-09-15 15:17 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e0864f0eb268 Add test for checking StackTraceElement format + test/java/lang/StackTraceElement/SerialTest.java

hg: jigsaw/jake/jaxp: 7 new changesets

2016-09-08 Thread mandy . chung
Changeset: 2bb277192648 Author:mchung Date: 2016-08-30 17:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/2bb277192648 8160851: Remove old launcher module-related options Reviewed-by: jjg, alanb !

hg: jigsaw/jake/corba: 2 new changesets

2016-09-08 Thread mandy . chung
Changeset: aa053a3faf26 Author:lana Date: 2016-09-08 21:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/aa053a3faf26 Added tag jdk-9+135 for changeset 094d0db606db ! .hgtags Changeset: d9b3cf2dd4d2 Author:mchung Date: 2016-09-08 17:40 -0700 URL:

hg: jigsaw/jake: 13 new changesets

2016-09-08 Thread mandy . chung
Changeset: f60c6d0cc585 Author:mchung Date: 2016-08-30 17:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/f60c6d0cc585 8160851: Remove old launcher module-related options Reviewed-by: jjg, alanb ! make/CompileJavaModules.gmk ! make/common/SetupJavaCompilers.gmk

Re: Review Request: JDK-8166860 Add magic number to jmod file

2016-09-29 Thread Mandy Chung
> On Sep 29, 2016, at 7:07 AM, Alan Bateman wrote: > > I think I agree on keep out of the ZipFile internals. As you noted, this is > just packaging and link time so it's not a magic issue if the file is opened > twice (assuming the file system isn't changing under

Re: Static analyzer tool for split packages available?

2016-09-29 Thread Mandy Chung
> On Sep 29, 2016, at 2:44 AM, Patrick Reinhart wrote: > >>> >> JDK does not have such a tool. I do have a simple tool to list packages >> and detect split packages for analysis. I can post it somewhere if you >> want to use. > > It would be great to get access to that.

hg: jigsaw/jake: 4 new changesets

2016-10-06 Thread mandy . chung
Changeset: 13a8f3836051 Author:erikj Date: 2016-09-30 09:05 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/13a8f3836051 8160630: libjimage.so and others should link statically to libgcc Reviewed-by: ihse, tbell ! common/autoconf/buildjdk-spec.gmk.in !

hg: jigsaw/jake/hotspot: 21 new changesets

2016-10-06 Thread mandy . chung
Changeset: c8b3f8e5423b Author:dsamersoff Date: 2016-09-15 10:19 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/c8b3f8e5423b 8027920: SA: Add default methods to InstanceKlass Summary: Add default methods to InstanceKlass to enable SA to inspect default methods

Review Request: JDK-8162401 Support multiple --add-exports and --add-reads with the same module/package

2016-10-06 Thread Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8162401/webrev.00/ Currently, `--add-exports` and `--add-reads` options do not accept duplicated module/package and it is an error to attempt to export the same package more than once on the command-line. There are cases where allow augmenting

hg: jigsaw/jake/corba: 2 new changesets

2016-10-06 Thread mandy . chung
Changeset: 8c9da7fc5b07 Author:erikj Date: 2016-10-04 13:41 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/8c9da7fc5b07 8166965: Some small java build tools are still running with big JVM configuration Reviewed-by: ihse ! make/gensrc/Gensrc-java.corba.gmk Changeset:

hg: jigsaw/jake/jdk: Workaround jdk.jconsole to add exports private

2016-10-06 Thread mandy . chung
Changeset: f493db6e68cc Author:mchung Date: 2016-10-06 12:22 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f493db6e68cc Workaround jdk.jconsole to add exports private ! make/launcher/Launcher-jdk.jconsole.gmk

Re: RFR 8167181: Exported elements referring to inaccessible types in jdk.security.jgss

2016-10-06 Thread Mandy Chung
> On Oct 6, 2016, at 9:55 AM, Wang Weijun wrote: > > Please review the code change for jdk9/dev/jdk repo at > > http://cr.openjdk.java.net/~weijun/8167181/webrev.00 This looks good to me. Thanks Mandy

hg: jigsaw/jake/jdk: 2 new changesets

2016-10-06 Thread mandy . chung
Changeset: 2bf254421854 Author:lana Date: 2016-10-06 20:56 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/2bf254421854 Added tag jdk-9+139 for changeset 5518ac2f2ead ! .hgtags Changeset: d31ab14d938f Author:mchung Date: 2016-10-06 15:48 -0700 URL:

hg: jigsaw/jake/langtools: 2 new changesets

2016-10-06 Thread mandy . chung
Changeset: 8e9e1a2373a4 Author:lana Date: 2016-10-06 20:56 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8e9e1a2373a4 Added tag jdk-9+139 for changeset 17a82cb0e4b4 ! .hgtags Changeset: e886b0aaa09f Author:mchung Date: 2016-10-06 15:48 -0700 URL:

hg: jigsaw/jake/hotspot: 2 new changesets

2016-10-06 Thread mandy . chung
Changeset: 0384427f59fa Author:lana Date: 2016-10-06 20:56 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/0384427f59fa Added tag jdk-9+139 for changeset 08492e67bf32 ! .hgtags Changeset: ced1a5e167ae Author:mchung Date: 2016-10-06 15:48 -0700 URL:

hg: jigsaw/jake: 2 new changesets

2016-10-06 Thread mandy . chung
Changeset: f73344fddabe Author:lana Date: 2016-10-06 20:56 + URL: http://hg.openjdk.java.net/jigsaw/jake/rev/f73344fddabe Added tag jdk-9+139 for changeset 7dcf453eacae ! .hgtags Changeset: 2f8eb7df5d8b Author:mchung Date: 2016-10-06 15:48 -0700 URL:

<    1   2   3   4   5   6   7   8   9   10   >